- 18 Jun, 2020 40 commits
-
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ib5be18e72766eac66f627569186a2803f5db4cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249840 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779802}
-
Maxim Kolosovskiy authored
This reverts commit c3de1340. Reason for revert: IconLoaderBrowserTest.LoadGroup failures. Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests First failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24355?blamelist=1#blamelist-tab Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1987273 TBR=avi@chromium.org,robliao@chromium.org,wfh@chromium.org Change-Id: I90479f28ef4849c382b28cfdbd40db4b84ad3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250202Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779801}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I18629d5a41bfdb7e691592c73e9ddb6cc57b88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251740Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779800}
-
sauski authored
CL changes incorrect usage of IsUserControlled to IsUserModifiable for checking whether a preference could be changed by the user. Also updates test cases that set the user preference to establish a known test state, to instead set default preferences. Bug: 1096471 Change-Id: I5d7fb02e438331e92d91d9d50b36b69250468667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250185Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#779799}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592459911-64171aa0ec184a29370607ccffd98ff29f1f78e8.profdata to chrome-mac-master-1592481559-9b531f50abff54ae1c92c78422a2cf2d21554f30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I775e55aaa8a2abf22bb9ea4247359c6594768a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779798}
-
Victor Hugo Vianna Silva authored
This CL adds a histogram to record the number of account passwords that are unsynced by the time the user signs out. We also use the occasion to update the term "passwords account storage" to "account-scoped password storage" in the description of another b4p histogram, and also replace @chromium with @google in the owners emails. Bug: 1063852 Change-Id: Ide376f40664112ada7ee62a404e019d53a2833bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251826 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779797}
-
Nigel Tao authored
Prior to this commit, the code looked like: etc.Deserialize(&error_code, etc); ASSERT_EQ(foo, error_code); which could be misinterpreted as testing that a side-effect of calling Deserialize was setting error_code to foo. In fact, error_code was set to foo before the Deserialize call, and what was actually being tested was that Deserialize has no effect on error_code when there's no error. That should be clearer after this commit. Bug: 1069271 Change-Id: I20045c24c098f792a87622762d58fb085f6fbaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248395Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779796}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b2c5e463ebe..8514078e455e 2020-06-18 mathias@chromium.org Avoid pathlib dependency in CSS lint script 2020-06-18 sigurds@chromium.org Remember frameId for DevTools-initiated loads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51123517fd0b16e19319b998b256ebc5c28682ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251732Reviewed-by:
-
Clemens Arbesser authored
Before this CL, it was possible that an action ended before it was initialized. In particular, this could happen if view inflation failed. This is problematic, because any calls immediately after SetGenericUi assumed that the action still existed. With this CL, most of the action is only initialized after a successful view inflation. This CL also includes a small change to how EndAction works. Before, the action was allowed to send data to backend, as long as view inflation succeeded. Now, this is only possible if EndAction is called with an ok() status. Bug: b/145043394 Change-Id: I8d7dc3d143d37ca4220b9d8f9c40a02964609d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249766Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#779794}
-
Darren Shen authored
The shared library is no longer needed after: https://crrev.com/c/2206855 Bug: 1019541 Change-Id: Ia57e89c5e8fe2e1b05e040c05438daea91aa00e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224478 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#779793}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592467151-bf53acbeb3a2f5db843a60a3b97cc31d9344243a.profdata to chrome-win32-master-1592470587-41d382284b84615cf61150faa274f216b9eaf19d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5ae02119f090dda4aeb389143e88436a77d9b699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251730Reviewed-by:
-
Jazz Xu authored
Bug: 1093968 Change-Id: I4a9d9de174a3a48713f7333c45e2aee3c7f8f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240896 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779791}
-
Eleonora Rocchi authored
This CL adds the Check passwords preference button in the Passwords settings menu, the button will be only shown if the corresponding feature flag is enabled. It adds tests to check whether the button is correctly shown. Bug:1092444 Change-Id: I35221b8f4af66f3a4e3a3b5fbbbef42650c7324f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246590 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779790}
-
Rohit Rao authored
BUG=1096151 Change-Id: I2ad7e76edfdf8a0cf42baf04e45aa6a95bebc315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250498Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779789}
-
Rohit Rao authored
BUG=1096117 Change-Id: I8f02f2c9a5f3da8c3e4560d33a2f04287abd901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248730Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779788}
-
Jochen Eisinger authored
Don't assume that time doesn't proceed between two calls to updateNewUrlLoading. Bug: 1096237 Change-Id: Id6e4089b94f6c4dd3c89d321430faf54fc6c9272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250041Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779787}
-
François Beaufort authored
This CL makes sure we're testing the value of pan_tilt_zoom_supported() when checking VideoCaptureDeviceDescriptors on macOS. Bug: 1095718 Change-Id: I5d3502b571735dd5f1f305f9face2217235944aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247728 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#779786}
-
Philipp Hancke authored
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in https://github.com/fippo/simulcast-playground/pull/7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
-
Michele Mancina authored
[Autofill Assistant] Create label for profile if null, this only happens for those profiles that are created within the CollectUserData action. Bug: b/158464101 Change-Id: Ia5df15a8d5244d981f42ad08588710d30b5e9067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246155 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592452187-d8b5060216a94a83da3c0624280c3c37a480cfb4.profdata to chrome-win64-master-1592474334-e0477f022b6eb5a61c43375c0dcd8da0fde9e8a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I35cb025a19b74cef6be6ae72b75760a7edac91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251728Reviewed-by:
-
Nektarios Paisios authored
This enhances readability when debugging. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I4e0bcf1ccb7ded6b0204b9c06b9965bde76b05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249934Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#779782}
-
Oriol Brufau authored
Some functions check whether a LayoutObject is anonymous, and then they exclude it if it's a list marker. However, since r745012, list markers can never be anonymous, they are always generated by a ::marker pseudo- element. Therefore, the condition is useless and can be removed. BUG=457718 Change-Id: I5e2636f68fab483838e8a5227ccace34b6de22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250102Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779781}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d02a81b1877..1b2c5e463ebe 2020-06-18 mathias@chromium.org Enable stylelint on presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie70ebeab1963f01641a31af0c6b2ef0a436d89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251727Reviewed-by:
-
Sebastien Marchand authored
This will let us use the Finch dashboards to evaluate the performance gains of ThinLTO. Bug: 1057737 Change-Id: I9ddaeb869a8aed369a7b5ca7af5994344dddf525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249085Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#779779}
-
Marc-André (MAD) Decoste authored
Bug: 1088082 Change-Id: I3c8e3907d09ffd2f5f7c3f5652fafb1f0d47374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248606 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779778}
-
Victor Hugo Vianna Silva authored
This CL addresses a few design issues with PasswordListItem that predate the introduction of PasswordsListHandler. - PasswordListItem would refer to a "menu" even though it knows nothing about such menu, which is actually provided by the embedder. This CL replaces mentions to passwordMenu in the component with what it actually represents: the "more actions" button. - The event fired by clicking the button was not documented in the file overview. Moreover, the typedef for the event lived in the embedder. Now the file exports the typedef. - Tests that simulated clicks on the button would use the $$('#id') syntax instead of the $.id one. This is now fixed. Bug: None Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#779777}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa3d64bf72d6..57f137d71cdf 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 763957e6b4fc to 7a1d99d0be42 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I6cfffdc86d76f8b38bc9409763f88c1aeaac1e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251725Reviewed-by:
-
Rohit Rao authored
BUG=None Change-Id: I9d075a81676196ee885e0d7fa9be55b2c4e59bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248728Reviewed-by:
-
Ewann authored
This CL presents views related to page info using FormSheet. Bug: 1095644 Change-Id: I58f2f2d343a16912f9effb78ff4ad26a42b569a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249778Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#779774}
-
Ewann authored
This CL rephrases the cookies status "Block Third-Party in Incognito" in "Block in Incognito". Bug: 1063824 Change-Id: I550a63a1608c981bd2af30121f4ff5508f653c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251619Reviewed-by:
-
Colin Blundell authored
This CL sets up the infrastructure for private instrumentation tests of WebLayer's infobars and adds an initial test: that addition of an infobar impacts the visual state of the infobar container as expected. BUG=1093846 Change-Id: Id5cdc73f02a4eadb46b3733451541fbd1f796441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247836 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779772}
-
Friedrich Horschig authored
With larger (or smaller font) the absolute pixel sizes for the spinner change the relative center of the animation which leads to an uneven rotation. To prevent this, the spinner now has a size relative to the font size which is identical for the current size on normal scaling but scales with larger/smaller sizes to keep the animation intact. Since a large/small spinner looks wrong for a static status icon, the icons also scale with the font size to match the spinner (which is not a problem for the vector graphics). Bug: 1096397 Change-Id: Ice9300cafdd2ef4877f28dd08c0a5b432588ddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250203Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779771}
-
Saurabh Nijhara authored
As per product requirements of minimum chrome version policy, it is required to show notifications (for update required in case of network limitations and to return the device in case of end-of-life) on login if it is the last day to reach the deadline. Like other notifications of this policy, this notification on sign in is also only applicable to managed users to maintain consistency. This behaviour helps to curb the problem of notification being missed if policy is received when un-managed user is signed in and later a managed user signs in. Only the last day notification is shown on managed user sign in to avoid too much spamming. Bug: 1048607 Change-Id: I01a8d52bbc4a003d5e1323140885881887211176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248567Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#779770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6d6e06a5c45..2c9d76a4eb0f 2020-06-18 eshr@google.com Use DataRates in QualityRampUpExperimentHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I508024aa1d86877043bc2e6aa2714a0b582faab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251726Reviewed-by:
-
Austin Tankiang authored
PreferenceWatcher is private to DriveIntegrationService, so there's no point having it be passed in. Bug: 1096355 Change-Id: I753c1c452d6873768f89d25f6737732624cc8b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251268Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#779768}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592459911-c43358934a37f46ea56775cef711f664e7b25ffd.profdata to chrome-win32-master-1592467151-bf53acbeb3a2f5db843a60a3b97cc31d9344243a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I70e7206f3b2e61f72f3e27b116d48bc91b30dd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251723Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I2b34d25846b971723bacb00e495ed219faa02e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249761 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779766}
-
Anatoliy Potapchuk authored
Bug: 1015383 Change-Id: I271647c5c47b568805ee1623c24823f92574737d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246562 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
-
Ewann authored
This CL adds a footer to cookies settings, explaining to the user how to apply the new cookies setting. Bug: 1063824 Change-Id: Ib683b385115f30f6b46eceb7a30741ca0a0a99d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248563 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
After recent fixes to the underlying blocking bug crbug.com/968222, it's worth giving those test another shot. Bug: 1044038,1054629 Change-Id: Idd2317c028c1cc7bb2ebee0e312c19456be57482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249981Reviewed-by:
-
