- 04 Oct, 2019 40 commits
-
-
Liquan(Max) Gu authored
The PaymentHandler UI is opened as an ChromeCustomTab Activity. Going forwards, we will refactor the Payment Handler to make it based on bottom-sheet. For this purpose, this CL adds: * A blank bottom-sheet-based Payment Handler UI. * "ScrollToExpandPaymentHandler" to enable the incomplete feature while we are still developing the refactored solution. Here's the expected change after the patch: Flag: When this flag is disabled (default), Payment Handler is unchanged. When this flag is enabled (--enable-features=ScrollToExpandPaymentHandler), the Payment Handler UI is changed to blank widget. The Payment Handler bottom-sheet: The Payment Handler UI will be displayed as an empty bottom-sheet. The swipe-down can dismissing the UI; the swipe-up can maximize the UI. Bug: 999196 Change-Id: Id839dfe63a9473243c5864295c5ae435ee725e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832702 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702998}
-
Eric Karl authored
Produce a new un-skewed frame after any frame rendered with de-jelly skew. This ensures a skewed frame is never shown for a long period of time. Bug: 995965 Change-Id: I6a8839646bacd88a1dff8c859a49c7c58ee6ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819495 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#702997}
-
Andrew Grieve authored
Change-Id: Ifa38ede1cba1a49dff0845d32a18f7de884b6b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838929Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702996}
-
Sammie Quon authored
We are gonna add a flag to introduce a new type of blur animation on the wallpaper for overview usages. This is a start to make the logics more encapsulated. No functional changes. Test: ash_unittests Bug: none Change-Id: I98ef63f957f6ebbcc2315a0f9472fcc536128c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838683 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702995}
-
John Delaney authored
This CL adds up to 1303 KB of uniform random noise to the network threshold for the heavy ad intervention. This is to done to prevent frames from learning cross-origin resource sizes in the clear. We add a second computed type metric to measure the number of frames that we are missing due to the fuzzing. Bug: 1010619 Change-Id: Ia48a4253beafcfbfdbdc689f2ae381dfe5a34c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835166 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#702994}
-
Erik Chen authored
Previously, memory metrics were collected at fixed intervals. The new timing uses a poisson process to emit the same number of events, but at randomly chosen times. Bug: 895474 Change-Id: I3e9564372e7b0c71f58965e6b238efe1c1de2ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836005 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702993}
-
Koji Ishii authored
This is the initial patch to paint inline boxes from |NGFragmentItem|. Not complete yet, and can't paint line boxes yet, but supports simple cases. Bug: 982194, 988015 Change-Id: I14da083edf0a839f57d7de8b28810f8d31d8b994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788427 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702992}
-
Albert Chaulk authored
Bug: b/141992733 Test: None Change-Id: Ia190abf893cb6dad03f6a0a1e0206b650b7da68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841943 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#702991}
-
Nina Satragno authored
The spec says the protocol identifier is the string "ctap1/u2f" [1], but the devtools protocol definition does not support slashes on enums. [1] https://w3c.github.io/webauthn/#authenticator-configuration Bug: 922572 Change-Id: Ide12cac53eadbac4260924c86bf0ad1d612b4c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842172 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702990}
-
Samuel Huang authored
[Sheriff] Disable flaky test: http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html TBR=tommili@chromium.org Bug: 1010863 Change-Id: Ia3bccb6f13cd1892028494fa6f742f39cde8a4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841755Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702989}
-
Jeffrey Chen authored
This reverts commit 30d3999b. Reason for revert: crbug.com/1009285 Original change's description: > Use opacity of 0.54 for placeholder text in input fields > > Prior to this change, placeholder text in input fields was set to grey > (#757575), but this did not apply to emojis. Now, we use an opacity > value to control the placeholder appearance. 0.54 is used because in a > white input field, regular placeholder text still appears as #757575. > > Bug: 932026 > Change-Id: Iba02fe3eb31484255332f2f34a67f97b97f50cb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754086 > Commit-Queue: Jeffrey C <jeffreyca16@gmail.com> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691770} TBR=aboxhall@chromium.org,eae@chromium.org,tkent@chromium.org,jeffreyca16@gmail.com Bug: 932026, 1009285 Change-Id: I97b7114ceb670e09bfbd6461d761a6404fa5c5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839434 Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#702988}
-
Alfonso Garza authored
https://screenshot.googleplex.com/7iRASUwruB7.png https://screenshot.googleplex.com/vHdkSZJ5DG5.png https://screenshot.googleplex.com/rVqAk1hM6ES.png BUG=993849 Change-Id: I3efc298f5bd8481af5392e0e76a6dc3c5fb23c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757210Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#702987}
-
Robert Liao authored
This is unreferenced code. BUG= TBR=sadrul@chromium.org Change-Id: I50ab2081195a0dc8fd447c08d29e87b5b55086d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841775Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702986}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6f6e364665a..34ff91ec6f44 git log d6f6e364665a..34ff91ec6f44 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 saklein@chromium.org sysroot_unittest: Allow running outside chroot. Created with: gclient setdep -r src/third_party/chromite@34ff91ec6f44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0311d9d4e8968fb539ce66b6d50992bdca76f98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702985}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 149de65c. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If00ce62cf4567765f71c9dfb89e47523df9f8dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841227Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702984}
-
Abigail Klein authored
The feature flag is remaining in the code as future work on this page will be hidden behind the flag while in progress. Filters, however, are done and so can be removed from behind the flag. Bug: 785493,959368 Change-Id: I605f6a44948648720298a1f609a55235054bf8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829956 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702983}
-
Bettina authored
Add a string for the password reuse modal warning dialog for saved passwords. This is a placeholder for implementation and not the final UX-approved string. Bug: 1010764 Change-Id: I7e47e80b600a1df289988b4f996fee078c254c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838686Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#702982}
-
John Emau authored
Make all console message anchor source links keyboard accessible by adding the anchor element to the _selectableChildren array in the ConsoleViewMessage UI component which will use _selectableChildren to manage keyboard navigation and focus. This is required to meet WCAG 2.1.1 Keyboard success criteria. See: https://www.w3.org/WAI/WCAG21/quickref/#keyboard For the tests I added an additional ArrowUp or ArrowDown to move focus to the original desired target under test, occasionally I would include the content of the source link in the test's expected results for additional guards against regressions. on the previous message, then use the up and down arrow keys to navigate between visible links within the console messages. Screenshot: https://i.imgur.com/ZUDFsUV.png Gif: https://i.imgur.com/UlhVhwn.gifv Test: Put focus in the console input, then use Shift + Tab to set focus Bug: 963183 Change-Id: I8e094506adeed099a2b0c1b81c4b4394f83129a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638137 Commit-Queue: John Emau <John.Emau@microsoft.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702981}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23149ef7ce0b..40ba239931e2 Created with: gclient setdep -r src-internal@40ba239931e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I92b20b8a5b23f4655c958f95461f5b69e477a0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702980}
-
Christian Biesinger authored
R=thakis@chromium.org Bug: 941669 Change-Id: Ib54429dcbebf65b6274ec294e862deaf77c32194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842311 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702979}
-
gogerald authored
This is the second patch of splitting the bigger one https://chromium-review.googlesource.com/c/chromium/src/+/1797069 It depends on https://chromium-review.googlesource.com/c/chromium/src/+/1817106 Screenshots https://drive.google.com/file/d/1FBGZygqGDlFA2e1Mr_81HAVWpzn_1-yc/view?usp=sharing Additional design discussion context: https://docs.google.com/document/d/1Igy8tZll_WtZyg7c5lxWzOYuxb3OGzJ39YcBW_em37s/edit?usp=sharing Bug: 982018 Change-Id: Ib93ae336cd77eb89296ed5cb68b2b62f5b45b94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822820 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#702978}
-
danakj authored
This is a reland of 8f0dc968 Original change's description: > Don't PostTask the RenderWidget::Close() call. > > The post task in RenderWidget was in order to keep IPC receipt of > destruction of a frame-based RenderWidget (ie a RenderView in the past) > from happening while the RenderWidget was already closing due to the > renderer-side detaching, but running a nested message loop. > > The RenderView destruction now already does a PostTask hop in > RenderThreadImpl before starting destruction of the RenderViewImpl > and its frame tree and RenderWidgets. A RenderWidget for a frame closes > when the frame detaches, and that is built to be consistent even if > it occurs inside of unload. The RenderWidget does not need to be kept > around after the blink frame and RenderFrame and WebWidget associated > with it are all gone. > > Popups and pepper RenderWidgets can close during a frame unload without > a consistency problem. > > R=dcheng@chromium.org > > Bug: 419087 > Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702868} TBR=dcheng Bug: 419087 Change-Id: I0f68df454e2873d7e6f3eeb38ff41563c16f6a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841942Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#702977}
-
Maksim Ivanov authored
Fix a few errors in the KeyRotationDeviceCloudPolicyTest.Basic browser test - some of them were presumably causing the flakiness that led to the test being disabled, some of them were accidentally added during later refactorings: 1. Correctly pipe through LocalPolicyTestServerMixin the needed settings of policy_testserver: the usage of signing keys bundled into the Python server and the automatic rotation of the signing key with every policy request. 2. Fix misplaced calls in the test's SetUp() phase: everything needs to be done *before* calling the parent SetUp() in order to run before the test. 3. Make the test less fragile by doing two explicit fetches of policy inside the test body and checking that the key got rotated in between (instead of relying on the device policy stack making the first policy fetch during its initialization and on the right parity of the PolicyBuilder's policy key version). Bug: 900631 Test: run the test 10'000 times (browser_tests --gtest_filter="KeyRotationDeviceCloudPolicyTest.Basic") Change-Id: I5eaa4f6e03a54dcc26319d39323f5edf51904c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829383 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#702976}
-
Eric Stevenson authored
This CL is based on http://crrev.com/c/1014739. Locally tested that the SubresourceFilterTests run since they're currently disabled on master (3 failed, 2 passed). Bug: 1010218 Change-Id: I03f63e7b852d69d82db11feb4bae5278a0139316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838632Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702975}
-
Omer Katz authored
This reverts commit f4e68ca6. Reason for revert: applying asan to WTF::Vector still causes failures (e.g. https://crbug.com/993415) Original change's description: > Enable asan on WTF::Vector for x86 > > Bug: 461406 > Change-Id: I239725947a9fa39a9089af29a68a85c3b7c238df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803147 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696359} TBR=haraken@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 461406 Change-Id: Ia14e4d0f1cc75127c15d6188bbc7ac9d11181990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841555 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702974}
-
Yusuke Sato authored
BUG=b:139752657 TEST=try Change-Id: I296a6f056f1f6197c25b5fe5a8d2ce4a768975da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836993Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#702973}
-
Shakti Sahu authored
InfoBarContainerLayout is a FrameLayout, which seems to keep references to its children after onMeasure call, even if they might have been removed. This causes DownloadProgressInfoBar to leak memory, if we move to another tab and keep downloading, while in theory we close the infobar of the background tab. OptimizedFrameLayout actually clears the references after onMeasure, hence using that seems to fix this issue. Bug: 1008906 Change-Id: I292331d3315728005fe7e81d03a08b00c2bcfab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838912Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702972}
-
Maksim Sisov authored
This is a very X11 specific method. Thus, move it to X11 space. Bug: 990756 Change-Id: I69ee7b59f62c3bd3f2f4fd6af5a5a3183e04743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834090 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702971}
-
Brandon Wylie authored
Reverting crrev/c/1818604, which caused a crash. Replacing the logic introduced in that change here in a way that doesn't rely on the the ordering of the callback. Bug: 1004903, 1009832 Change-Id: Ie8e34325648704aa7068113e60aac74d8d685d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835177Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702970}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6fff5122a23e..a580e2d761c1 git log 6fff5122a23e..a580e2d761c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 capn@google.com Remove Vulkan project from Visual Studio solution 2019-10-04 pjackson@google.com Support LLVM 8+ with Reactor Created with: gclient setdep -r src/third_party/swiftshader@a580e2d761c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/139412871 Change-Id: I88112da1f92eaa123bdf08088117958e38245e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702969}
-
Manas Verma authored
On Android, ensuring that if user unchecks checkbox for WebAuthn offer, it remains unchecked. Bug: 949269 Change-Id: I7214abc01d40d916ba14b2b6d3bb55faa871608c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825796Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#702968}
-
Steven Bennetts authored
Bug: 996418 Change-Id: I3d0dc82c0bbd9f4e9891058afd7766e8eb6a4494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838052 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702967}
-
Andrew Grieve authored
Chrome's many GN args make this check more trouble than it's worth. Change-Id: Id2fac9e67398c6b4b788fb36b2404248a8ca8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838545Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702966}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I6e25edb1a996a65d4e77261e327cf865605f92f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841936Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702965}
-
Matt Wolenetz authored
Coverage and inspection revealed a method in SourceBufferStream and several test helpers in SourceBufferStreamTest to be obsolete and unused. Change-Id: I663c822d30811b882068b19c1335cee51d266cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838682Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702964}
-
Andrew Grieve authored
md5_check.py is useful only when not all inputs are generated. For the main dex list builder, all inputs are generated. Change-Id: Ied81917b719d55785bad89ef8d3e6e232274125a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838309Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702963}
-
Nate Fischer authored
No change to logic. std::function is banned by the style guide. This replaces its use in FileMetricsProviderTest with base::OnceCallback. This resolves a presubmit warning. Bug: 1010369 Test: out/Default/metrics_unittests --gtest_filter=*FileMetricsProviderTest.* Test: git cl presubmit --upload Change-Id: I681c9309940e29814c4369d3a16d09f6d00e1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838398 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702962}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5a42da564fbe..6b60dfd80e3d git log 5a42da564fbe..6b60dfd80e3d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 cnorthrop@google.com Vulkan: Remove image views forced to one mip level 2019-10-04 geofflang@chromium.org GL: Update RenderbufferGL to use ANGLE_GL_TRY. 2019-10-04 geofflang@chromium.org GL: Fix support for glCopyTextureCHROMIUM with source rectangle textures. Created with: gclient setdep -r src/third_party/angle@6b60dfd80e3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:990368 Change-Id: Icb5a13f09e5db77d285c5fd38776e766131b2b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702961}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/666d4144..35874570 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8191957d965c659258d5e398cd90fe2c1270d6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702960}
-
Ioana Pandele authored
This is a reland of 3dd37620/ The previous CL was reverted since it was thought to have broken http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html on Win10 Tests x64. Relanding since it's an iOS-only CL, which couldn't have broken windows layout tests. TBR=vasilii@chromium.org Original change's description: > Reland "[iOS] Make the leak detection backend available on iOS" > > This is a reland of 74640a89 > > TBR=vasilii@chromium.org > > Original change's description: > > [iOS] Make the leak detection backend available on iOS > > > > Bug: 986317 > > > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702059} > > Bug: 986317 > Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702835} Bug: 986317 Change-Id: I4d48f378e44677d02c4f316cc406209195dabc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841553Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702959}
-