- 08 Jul, 2020 40 commits
-
-
Steve Kobes authored
Also update comment in disk_cache::SimpleBackendImpl, and remove some things that are not used. Bug: 1007815 Change-Id: I5e239877a52a9906a8e42b62a00a40506e98f89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288273 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#786520}
-
Daniel Classon authored
Added helper function GetModifiedUrlWithSettingId that returns the modified url with settingId appended. Also added a testing file for that function. Change-Id: Ic140bc81c334b89b43a332b66251cfff199f5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283653 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786519}
-
Erik Staab authored
Change-Id: I806dab8cea22aa3cd429b3c54727a4c5cb66fc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288493Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786518}
-
Matt Reynolds authored
BindRepeating is correct because SetTracksWatcher expects a media::MediaTracksUpdatedCB which is a base::RepeatingCallback. The callback is called whenever the media track configuration has been updated, which is expected to occur more than once. BUG=1102651 Change-Id: Ibc60aec4cbd7692dfd94a74429d718d38171bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284226 Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786517}
-
Michael Thiessen authored
This change introduces test batching to ContextualSearchManagerTest. This means that the browser process (and Instrumentation instance) is not restarted between each of the tests in the suite. However, it is restarted before and after this suite, as the batching type is PER_CLASS. For ContextualSearchManagerTest, this means the tests run >5x faster. I had to modify a few tests to clean up persistent state changes, and I got rid of the 1 second delay added to each test, replacing it with retries when panel interactions fail. I also had to make the EmbeddedTestServerRule reusable so that the server can be restarted for each test. In the future this should be further improved to allow the test server to be reused across tests. Finally, I had to remove a maximizePanelThenPromoteToTab animation from ContextualSearchManager that wasn't visible anyways (as it is used when launching an external app), as when run in the test it wasn't being set up correctly and ended up being too invasive to tear down. Bug: 989569 Change-Id: I5aff1667c01ac3dceb33704c6853299cab1cd541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270713 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#786516}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a376518817f9..563d497e009f 2020-07-08 handellm@webrtc.org SimulatedTaskQueue: release lock before destroying tasks. 2020-07-08 mbonadei@webrtc.org Fix 'Perf Android32 (M Nexus5)' config in MB. 2020-07-08 mbonadei@webrtc.org Reland "Add possibility to expand strings in the autoroller." 2020-07-08 danilchap@webrtc.org Delete RtcpDemuxer as unused 2020-07-08 handellm@webrtc.org Partly migrate test/ to webrtc::Mutex. 2020-07-08 danilchap@webrtc.org Cleanup setting VideoQualityTestFixtureInterface::Param struct 2020-07-08 mbonadei@webrtc.org Revert "Add possibility to expand strings in the autoroller." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a93f5349dfa38d87b0bedac084be4ef0bfa5f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288550Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786515}
-
Zhongyi Shi authored
Data for Net.QuicStreamFactory.NumDegradingSessions is missing while Net.QuicSession.PlatformNotification contains effective data. This is to validate the hypothesis that there are no more than one session when network change is detected (which is a bit surprising). Bug: 1090532 Change-Id: I8abe74ce87c2fe63ce5fcaa0edb019f8e8bc8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284445 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786514}
-
Liquan (Max) Gu authored
Change-Id: I36ca73f222600f47b55298202354eb66279c00b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288830Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786513}
-
Ali Juma authored
This CL disables kRealTimeLookupEnabled on iOS so that real-time lookups on iOS can be guarded by this flag rather than being hard-coded to disabled. Bug: 1103218 Change-Id: Icbf4b48c1283786810c7437fa00f1418f44066f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288373 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#786512}
-
Matt Menke authored
This CL removes the Link Doctor click tracking network requests and UMA code. It also removes the code promote the Google cache suggestion and record when the cache suggestions are interacted with. This CL also renames the variable "src" to "source" in the Javascript files, as otherwise, removing the trackClick method in the JS file results in funky build failures on Android, likely due to a buggy regexp when trying to inline files. Bug: 1030281 Change-Id: Ia2a9f56397f1014baf65ac0374c446a062b2007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284973 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#786511}
-
Taylor Bergquist authored
Bug: 1093972 Change-Id: I1d952d79885eccd1a1a011231ea3e2daf038ed75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278650Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#786510}
-
Lei Zhang authored
Consistently write it the same way as most of the code base. Then include build/build_config.h as required to guarantee OS_FOO is properly defined. Change-Id: I30c9e5c96808469b8e6b6a92ecfaa9239e63568c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277742 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786509}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: If36164e2de06f7590e3c619b1d4a78bc55b3a366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284369 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786508}
-
Erik Chen authored
This CL creates a new mojo interface: ScreenManager. This interface has a single method TakeScreenSnapshot which returns a bitmap of the screen's contents. Lacros-chrome uses this interface to implement a rudimentary version of screen-sharing. This in turn allows meet.google.com screen sharing to function properly. This interface will eventually be supplemented with methods to allow window-sharing as well. The whole interface will likely be overhauled in the future to create a more performant and fully-featured version of screen/window sharing. Change-Id: I821c59464ea4d2ff57665381038837f29645750d Bug: 1094460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261430Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786507}
-
evliu authored
This CL resets the Cloud recognition stream if audio has been paused for more than 28 seconds. The Open Speech API will not return recognition events if more than 30 seconds has elapsed since the last audio upload. Bug: 1101566 Change-Id: I9a667358fc8d5b98faaee3922d1d9778ab7a40f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278533 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
-
Andrew Xu authored
This CL ensures that hotseat only has vertical movement during transition between home launcher and hidden state. Bug: 1088182 Change-Id: I680735ec68b60080eaa920a4341d5a59db7dc2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285358 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786505}
-
John Williams authored
This patch as a number of changes to streamline unit tests; the main on is that it names ActivityRecord::SetOrUpdateSession() a nonvirtual method and delegates subclass-specific functionality to the new OnSessionSet() and OnSessionUpdated() methods. Change-Id: I3ce0c0ced968d3e3945ecd215dfe9a25959a49a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278138 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#786504}
-
Himanshu Jaju authored
- Removes existing protos copied from securemessage and ukey2 libraries - Adds dependency on open sourced libraries for the above protos. Change-Id: If2bb26e5c2e02f741f203bc699ef98dbf5edf581 Bug: 1037793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214535 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#786503}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: If2c3352048cdfefa616667b2dbe53e0f853f036e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283652Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#786502}
-
Lukasz Anforowicz authored
This CL takes GetOriginForURLLoaderFactory (and supporing helpers) from an anonymous namespace inside render_frame_host_impl.cc and makes it an instance method of NavigationRequest. This should help with the following long-term tasks: 1. Calculating the origin to commit in the browser process (https://crbug.com/888079). 2. Always setting request_initiator_site_lock (https://crbug.com/1098938). (Being able to access GetOriginForURLLoaderFactory via NavigationRequest might help populate |request_initiator_site_lock| and provide a URLLoaderFactory when creating any RenderFrameImpl in a renderer process (including speculative/provisional frames.) This CL should have no functional or test impact (it is pure refactoring - it just moves code around). Bug: 888079, 1098938 Change-Id: If464a49990d77bbf68b8e70f2a253e44e8c26f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285396Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#786501}
-
Himanshu Jaju authored
in chromium. Design doc - go/nearby-chrome The overall import is split into 3 CLs for easier reviews: - Securemessage and ukey2 import - Nearby connections import - Platform implementation for nearby in chrome Bug: 1037793 Change-Id: I59a58c01c877dd5fb4c7e647c122b633b592fa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274625 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie583045dfa8f5b24eb43dbf1b7c71fc52ebf7778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288086Reviewed-by:
-
Charlene Yan authored
The bug that makes it not possible to drag a tab to the right of a collapsed group header is due to TabStrip::GetLastVisibleTab() clamping the insertion index. TabStrip::ShouldTabBeVisible is used for determining if a tab is visible in the tabstrip due to space constraints. Moving the logic for collapsed tabs into TabStrip::SetTabVisibility(). This should also make is slightly nicer and show less headers in the case where the tabstrip is full of group headers and not visible tabs. Bug: 1099367 Change-Id: If31bf23b9d2fc069481f092e38310635b89d3165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277381 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
-
Daniel Murphy authored
The 'dummy' app installed to flush the sync system was installed in the wrong direction, so changes from profile 1 might not have made it to profile 0. This change fixes that. R=loyso@chromium.org Bug: 1099595 Change-Id: I28b8816e20ac2020d9329342a10936ba09309830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285296 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#786497}
-
Andrey Kosyakov authored
Originally broken by https://chromium-review.googlesource.com/c/chromium/src/+/2274584 Bug: 1094090 Change-Id: Icfd8b9be9acc7406ef63d88302986e9ac2d262cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288387 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#786496}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/430a7423039682e4bbc7b522e3b57b2c8dca5e3b..eda849d2e6e6a15a5a4dc728568ec12f21ebfb6d The following commits have Chromium bugs associated: eda849d2e Opaquify PKCS8_PRIV_KEY_INFO. 5d7c2f8b1 Implement i2d_PUBKEY and friends without crypto/asn1. 5fa22ed85 Avoid relying on SSL_get_session's behavior during the handshake. The following commits have update notes: eda849d2e Opaquify PKCS8_PRIV_KEY_INFO. d0637e901 Remove TRUST_TOKEN_experiment_v0. 25638f06e Remove x509->name. 5fa22ed85 Avoid relying on SSL_get_session's behavior during the handshake. Bug: 1010748, 1102458 Change-Id: I0e377889f94676efd90f292a0dcdf9b0c5b446d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288451 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#786495}
-
Maxime Charland authored
In parallel with the current TableViewEmptyView, the new TableViewIllustratedEmptyView will be able to display an image, a title and a subtitle on empty states. This new class will be accessible from a new helper function in ChromeTableViewController. (Googlers only links) Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: Ia54b55d9f2de749879bc0f811bd2629688dd2bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254519 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#786494}
-
Daniel Classon authored
Change-Id: Ifd63251a67ae9fe31e3d46f5e80a4dd54f7bd0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288203 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/83fe1bc34d80..8a9919980f54 2020-07-08 cwallez@chromium.org Don't leak buffers if MapAtCreation fails. 2020-07-08 cwallez@chromium.org Fix MSVC compilation. 2020-07-08 tommek@google.com Adding Queue::WriteTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1103154 Tbr: cwallez@google.com Change-Id: I11ee7c9d876f7dc4d9e034602c8640628b8c3b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288572Reviewed-by:
-
Vikas Soni authored
This is a reland of 5f7b87c0 with some additional changes and refactor. Original change's description: > Refactor SharedImageVideo backing. > > 1. Refactor SharedImageVideo backing to use SharedImageBackingAndroid > and SharedImageRepresentationSkiaVkAndroid. > > 2. Move GetAhardwareBuffer and VkImage creation from Representation's > BeginRead to ProduceSkia. > > Bug: 1091945 > Change-Id: Ic08616f37754c864d0059c38b0a64f1f296b1ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281478 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785336} Bug: 1091945 Change-Id: Ic46dbcfda2bc3c7a9435c1b5001b1c1722ed09a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282729Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786491}
-
Yu Han authored
In this CL, fixes all the remaining tests for ParentNode.replaceChildren by following the steps outlined in the spec[1]. Also connected RuntimeEnabledFeature to blink::feature so it's finch controllable. [1] https://dom.spec.whatwg.org/#dom-parentnode-replacechildren Bug: 1067384 Change-Id: I246b96d8907c222d15bc80376d83a0bc5ff90e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270678Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786490}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f8597f282852..5d5af4ebd056 2020-07-08 rmhasan@google.com telemetry: Add getter and setter for _binary_manager global variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:960833 Tbr: rmhasan@google.com Change-Id: I5436471462c52a2498f9321f3f994999310ed567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288651Reviewed-by:
-
Marijn Kruisselbrink authored
Following changes in https://github.com/WICG/native-file-system/pull/196 Bug: 1103022 Change-Id: I4ba11f12cf2e47ec326a09efa7b06fd300402945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285670 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786488}
-
Lijin Shen authored
This reverts commit 5c5957c7. Reason for revert: testMergeOnMultiDisplay_OnDisplayChanged failing on test-n-phone https://ci.chromium.org/p/chrome/builders/ci/test-n-phone Original change's description: > Merge tabs of multi-instance when display is changed. > > On partner foldable phones, when the secondary display is off, there > is only one targetable displays and only #onDisplayChanged is called. > This CL tries to merge tabs #onDisplayChanged as well. > > Bug: 1088202 > Change-Id: Id21960b40bceb4b04fce7a2718c0e33bee0f4920 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272131 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Lijin Shen <lazzzis@google.com> > Cr-Commit-Position: refs/heads/master@{#786055} TBR=tedchoc@chromium.org,twellington@chromium.org,lazzzis@google.com Change-Id: I73c428b30eb6005f4e85171434dec16d54d4e419 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288809Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786487}
-
Alex Moshchuk authored
This reverts commit cf27abd2. We thought that an outdated process model shortcut to avoid unnecessary OOPIFs was no longer needed now that we have default SiteInstances, but issue 1101214 showed that it is actually needed on Android Webview in cases where default SiteInstances aren't yet used, in particular with file: URLs. Hence, this CL brings the shortcut removed in https://crrev.com/c/1876979 back along with better documentation on why it's still needed. Bug: 1101214, 1103352, 1015882 Change-Id: I444700ca37670f47c9b7730ace1c7743ee408d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288382Reviewed-by:
-
Oleh Lamzin authored
Use constants close to type limits in unit tests. Bug: b:158658869 Change-Id: I364c55ebd14b7d9fccba78bd3cfcac3abd8ae960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278053 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786485}
-
Qiaofei Ye authored
As mentioned in Bug 1030396, the containerName attribute was first added in https://codereview.chromium.org/2515993002/ and it was truncated to 100 chars. The spec does not mention this truncation anywhere, see https://w3c.github.io/longtasks/. In this PR, we removed undocumented containerName truncation, and changed member variables to use atomicString instead of String. Bug: 1030396 Change-Id: Ie1e7e6d7d1878ca16091a5f4db316d9c59368be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276680 Commit-Queue: Qiaofei Ye <qiaye@microsoft.com> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#786484}
-
Luis G Garcia authored
I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4kMGCyCUIao/5vjPk4tuAQAJ Change-Id: Ib30e5d2ec4d833d2cc44246bf95827f4e2083f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230280 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#786483}
-
John Abd-El-Malek authored
They're timing out now. This brings them to the same runtime as Linux ASan LSan Tests. Bug: 1103330 Change-Id: I2e5e38ae4d3321b238c31af87026e26d95928abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288199 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#786482}
-
Ben Pastene authored
With crrev.com/c/2277078, the tool we're using to deploy chrome to the device/VM expects some additional runtime libs. These libs are encapsulated in the chromiumos_preflight group. So this adds them to any telemetry-based test's isolate input data. Bug: 1099963 Change-Id: Ie8bdad2b0aeb4f9b0848ec54869b4fcd4d7ec34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288491Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#786481}
-
