- 17 Jul, 2020 40 commits
-
-
Viktor Semeniuk authored
This change is a foundation for refurbished version of Passwords Details screen. For now this screen shows only website, username and masked password. Also it allows to edit password although at the moment it has no effect. This screen is shown only for compromised credentials. Bug: 1075494 Change-Id: I36de403dba0c560aa305e13b029351366629c9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295141 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789499}
-
Jose Dapena Paz authored
Clang SSE intrinsics do not complain on implicit conversions among several of the types (i.e. from __m128i to __ m128). But GCC intrinsics do. So use reinterpret_cast to make them explicit. Bug: 819294 Change-Id: I7df583459ad17ecfcf161a808d86e949afd4fd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303716Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#789498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5334ef45. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" 6afc7d8c "Make sure all methods have a correct name." 2cbc3cc4 "Reland preservesPitch test deflake, fix timeouts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-ui yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I4e59f376321644f5e9aa6af78afce163c0b50654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304298Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789497}
-
Javier Ernesto Flores Robles authored
This is an attempt to reduce the flakiness of this test. Fixes: 1103501 Change-Id: Ib160dd4941493d82eb793b63a0339feaa21dd69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303440Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789496}
-
Ella Ge authored
When checking TWA location permission with the client app, if the TWAService did not returns the success message (returns failed), we treat it as "denied" and returns the result via the PermissionResponseCallback. However if the TWAService did handle the extraCommand and later invoked the TWACallback, the PermissionResponseCallback will be called again. This causes the OnceCallback in native been called twice, and crashed. This should happen with a correct TWAService, but it would be nice to prevent that a TWAService handling extraCommand wrongly crashes Chrome. This CL fix it by adding a boolean mCalled in PermissionCheckCallback to mark whether the callback been invoked. so the callback would not be run more than once. Bug: 1105867 Change-Id: Icb5a87b73a5e18a107fed7f83cff8d7e311087bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300367 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789495}
-
Charlie Hu authored
Previously, adding a new feature to feature policy needs to modify 3 files: - feature_policy_feature.mojom - feature_policy_features.json5 - feature_policy.cc This CL generates |FeaturePolicy::GetDefaultFeatureList| from json5 config, which eliminates the need to modify feature_policy.cc when adding a new feature. Change-Id: I368215bc66fa8b568e20203f7e9810ddd13f683f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212794Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#789494}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f3cb1896971f..ae08b5b74c23 2020-07-17 johnkslang@users.noreply.github.com Merge pull request #2350 from ben-clayton/update-license-checker-rules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I75a8253ab5000ec156ecd9dda0630923dccd3dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789493}
-
Pavol Marko authored
Previously some tests were looping over available tokens and performing tests per token in that way, which is bad for error messages. Bug: 1045895 Change-Id: I45e542d06d44ce08cc40031296c69bc7625c78bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159468 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#789492}
-
stkhapugin authored
Disables the following tests: FormsTestCase / testPostFormEntryWithKeyboard TabOrderTestCase / testChildTabOrdering Bug: 1106741, 1106739 Change-Id: I61f2f1ded92223d8ce25fcd5a7c08ba33ad68afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304583 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789491}
-
Leonard Grey authored
When a user command-clicks on a nested bookmark bar folder to open all, we pop up a dialog to ask if they're sure if the number of tabs that would be opened exceeds some minimum. Currently, we do this *before* we dismiss the menu, which (at least on the Mac) closes on a later run loop as the result of a focus change. This causes some issues on Mac, including a mouse capture induced crash and accessibility inconsistencies (see bug for both). This change disables the code that keeps the bookmark menu open on background open if the node is a folder. Bug: 1105587 Change-Id: Iba0ffb0746a9caab0484df22ab40f49ef554ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299530 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#789490}
-
Vasiliy Telezhnikov authored
This CL adds check for gr_context() during Initializate call to avoid crash if we failed to create context or context was lost before Initialize happen. Bug: 1095840 Change-Id: I7992a745020b8b8df75253aed2d8c0ad88be8996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302772Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789489}
-
Mohamed Amir Yosef authored
Screenshot in Arabic layout: https://screenshot.googleplex.com/e5b8YLfe7dV.png Bug: 1100814 Change-Id: I5096449c43e53caafef6a634cfd7850c9a67d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302150 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789488}
-
Clark DuVall authored
This removes all remaining uses of base::Callback and base::Closure. A follow up CL will convert base::Bind -> base::BindOnce. Bug: 1007660 Change-Id: I29a326f68b90bea67c429115f678a3ced1bcbdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290076Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789487}
-
Gavin Williams authored
Instead of stamping 'highlighted_' HTML attribute to determine which of one of the dropdown items should be highlighted, use an index instead. Allows for simpler tracking of which item to highlight. Bug: 1059607 Change-Id: I1c60419c8c38862e33434e0f2ed05523cfb74b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300668Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#789486}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/450b6f4f844d..7f4980e7d265 2020-07-17 tommek@google.com Optimizing WriteTexture offset on Vulkan 2020-07-17 tommek@google.com Changing validation order for linear texture data 2020-07-17 hao.x.li@intel.com Query API: ResolveQuerySet 2020-07-17 jiawei.shao@intel.com Implement buffer lazy initialization before mapping 2020-07-17 tommek@google.com Optimizing WriteTexture row pitch on Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib5ee56da74ca0e7f9ae7795f626bf74e1dd4e9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304374Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72a5712e..15a3a6c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54e389cd2108f17acf015f42986d78d3bba67afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304304Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9acf5844cae6..c97ebe06dc1d 2020-07-17 michaelludwig@google.com Sneak per-GrBlockAllocator user-controlled metadata into head block If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: If903715a36cea1a02cadc2e5ac58fea4c46ea49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304676Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6e04d0af5a7f7637d142ea338cc44919639692c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304651Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d74c0e600a7f..fc4668dae26e 2020-07-17 philipp.hancke@googlemail.com configure target bitrate in opus dtx tests 2020-07-17 sprang@webrtc.org Allows bitrate prober to discard delayed probes, unit type refactorings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic24f325d280b69349f826fb7c0bff7defde302f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304375Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib3090988ea506c1c1d87e81dfcdec7f0cfb7cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304652Reviewed-by:
-
Vladimir Levin authored
This patch adds AggregatedFrame as a return value of SurfaceAggregator::Aggregate. The reason for this is twofold: 1. It type checks the usage and ensures that we only forward the minimum set of things that we populate (one field for example was used although never initialized by anything except the ctor). 2. It allows us to separate CompositorFrame::render_pass_list from AggregatedFrame::render_pass_list with hopes of (in the future) type checking that RenderPassId post aggregation is remapped into a global space, whereas RenderPassId in CompositorFrame is local to the associated SurfaceId. R=kylechar@chromium.org, weiliangc@chromium.org Bug: 1106418 Change-Id: Ie6728d010c2f15171fc74616f064446df752f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302710Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789479}
-
Maria Kazinova authored
Bug: 918846 Change-Id: Ida4d623da78879d9f739243131ceffbc7f7c60c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302994 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#789478}
-
Gayane Petrosyan authored
Rename and add user action to xml. Initially introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2295779 Bug: 1102382 Change-Id: I4b45358e4dd89bf12a73260afa474ea956a68a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303549Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#789477}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f50a0fb8a663..c0f23a129f67 2020-07-17 lalitm@google.com docs: add clarification on how to choose where to add diff tests 2020-07-17 lalitm@google.com Merge "Revert "tp: move completition of dangling sched events from C++ to SQL"" 2020-07-17 rsavitski@google.com Merge "profilers: stop parsing extraneous libs for managed processes" 2020-07-17 lalitm@google.com Merge "shell: fix hiding real cause of failure with dcheck" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4981989dcd637dcdb897966b24562d83fb234a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304670Reviewed-by:
-
Chris Sharp authored
This text was incorrectly removed in https://chromium-review.googlesource.com/c/chromium/src/+/2217873 Bug: 1018157 Change-Id: Id78aa3cf5012076780bc678c5106aa2a112284e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302830Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789475}
-
Antonio Gomes authored
... into MediaStreamRendererFactory. The implementation will now reside in media_stream_renderer_factory.cc|h. BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I6d254aaca5b42ed170ca84218770f80843ef7e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302918 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789474}
-
Olivier Robin authored
New windows are created with an NSUserActivity to load a URL (that can be chrome://newtabpage) in a new tab. 1. Use openOrReuseTab function to open such activities to reuse the current tab if it is an NTP 2. avoid opening the default NTP if such an activity exists as the NTP would flash before the target URL is loaded. Bug: 1106738 Change-Id: Ib034d54dc596b9ca5a69046fd71234831f35bd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302616 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789473}
-
WangHui authored
Move the logic of frame token check into RWHVA since the RWHVA maybe reused with create a new compositor. Bug:1103530 Change-Id: I69c5bbb7713e6054309d8d9a50188f48c6cbd74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288714 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789472}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e810d53b527e..45fb1f2ebb99 2020-07-17 tvanderlippe@chromium.org Stop building formatter_worker-entrypoint with build_release_applications 2020-07-17 janscheffler@chromium.org [WebAuthn] Add owners file for webauthn 2020-07-17 tvanderlippe@chromium.org Move acorn entrypoint to front_end/third_party/acorn 2020-07-17 szuend@chromium.org Don't add sourceURL comments to HTML and Markdown files 2020-07-17 szuend@chromium.org Build 'marked' module with TypeScript infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099162 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia8535a7c13d0979068461199dd64951ef5778884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304672Reviewed-by:
-
Jose Dapena Paz authored
This breaks GCC (but it should break any platform, a destructor specification should never have a return value. Bug: 819294 Change-Id: I2741ce5c10526a8e11914882449d0b207e755201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304573Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#789470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1769f267f216..086c75fa39cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106715 Tbr: mkwst@google.com Change-Id: I865b6e4efc68b6d04a8e1b08860df97ea6634b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304405Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789469}
-
Robert Sesek authored
Bug: 1097376, 949535 Change-Id: I50caa1db4ff41bb8de5ebc98eb137ec80d410faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302811 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789468}
-
Steven Bingler authored
Determine which cookie context, schemeless vs schemeful, to use based on the LegacySameSiteCookieBehaviorEnabled and LegacySameSiteCookieBehaviorEnabledForDomainList enterprise policies. This functionality may also be triggered if SameSiteByDefaultCookies is disabled. This seems acceptable because it's odd to decrease SameSite protections by disabling SameSiteByDefaultCookies but also want to increase those protections by having Schemeful Same-Site. Also update the documentation for the policies. Bug: 1101037 Change-Id: I6f74f6448147b451bbf8ae5aa0157277dd00639c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283505Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#789467}
-
Nicholas Verne authored
UX review always required a preliminary, low impact prompt for upgrade rather than going straight to the large format Upgrade Dialog. This CL implements the prompt as a notification. It also removes logic for prompting on the first Crostini app launch attempt per session. Instead, the notification is shown at session start if appropriate. Because of this a large amount of complexity for the continuation of the app launch action can be removed (in a subsequent CL). Bug: 1103505 Change-Id: Icbfe744ef9c5264e2d2e022e91a90a2600339962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297072Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789466}
-
Nodir Turakulov authored
The correct OS is "LINUX" not "OS_LINUX" Proto: https://source.chromium.org/chromium/infra/infra/+/master:go/src/infra/tools/dirmd/proto/dir_metadata.proto;l=49?q=dir_metadata.proto Bug: 1106176 Change-Id: If66b4e4c0f12315c428ebb2c73268b6e92e1955a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303467 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789465}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a09faed62a4..d74c0e600a7f 2020-07-17 mbonadei@webrtc.org Add presubmit test to use RTC_OBJC_TYPE on RTC_OBJC_EXPORT types. 2020-07-17 handellm@webrtc.org Rename CriticalSection to RecursiveCriticalSection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I33e28e647a7ac5510be945e47118d7cec438bdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304408Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id2b7cbade3a4c0a95eb035bf55ad52567555e05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304406Reviewed-by:
-
Kevin Ellis authored
Adds documentation for the Animation interface. Change-Id: I64934a9adc4d2f63fac65bbb3977e7f5f10b8375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300259Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#789462}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594963977-810cedbe35bd1c6db444ce1374d5ffa7453d77c9.profdata to chrome-mac-master-1594987060-434c51fdab164717c1b94e12633f94a30a81dd52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia0cc306928fe4fe50822a58d2121bf81d6a0e7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304669Reviewed-by:
-
Dominic Mazzoni authored
Bug: 1102937 Change-Id: Ib4ac8700bf147ec6aeff696c47f39592503f0447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303455 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789460}
-
