GitLab

Make sure battery status works with proper default values
on Android. Add an exception for battery present check for
Galaxy Nexus because it wrongly reports that the battery
is not present (see http://crbug.com/384348).

BUG=122593, 384348, 360068
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/330333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278829 0039d316-1c4b-4281-b951-d872f2087c98

Adds extensions common API target and extensions templates.

Adds a number of new targets: widevine, flash, sync proto, metrics proto, device serial.

Minor enhancements to protobuf and mojo templates.

TBR=jamesr

Review URL: https://codereview.chromium.org/343233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/344863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278827 0039d316-1c4b-4281-b951-d872f2087c98

This CL depends on: https://codereview.chromium.org/334053003/

BUG=380421
R=oshima@chromium.org, jamescook@chromium.org
TBR=sheib@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/345773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278825 0039d316-1c4b-4281-b951-d872f2087c98

Adds a field trial flag to control whether to use an alternate Instant search base page URL for prefetching search results.

BUG=382694
TEST=Run chrome with the following field trial flag and observe the Instant search base page url.
     --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /"

Review URL: https://codereview.chromium.org/330653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278824 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/343243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369659
TBR=vapier@chromium.org

Review URL: https://codereview.chromium.org/345133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278821 0039d316-1c4b-4281-b951-d872f2087c98

This is a special component that only gets registered when the user reset the profile settings and has enabled UMA reporting.

Once installed (or if already installed), the component is executed and it's exit code is reported via UMA.

In case the component doesn't have time to be installed and executed before Chrome exits, a local state pref identifies that we have a pending registration or execution so that it can be continued on next Chrome startup.

BUG=377601
R=asvitkine@chromium.org, battre@chromium.org, jhawkins@chromium.org, robertshield@chromium.org, sorin@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/333193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375430
TBR=rsleevi

Review URL: https://codereview.chromium.org/345213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278818 0039d316-1c4b-4281-b951-d872f2087c98

    
ChromeOS on bare hardware will do display configuration and cursor
movement from the GPU process. This is the conduit for the messages
needed to make this work.
    
This plumbing also supports other platforms with similar requirements
(e.g. wayland's port). X11 does not need any specific messaging here,
since we just call the X server from the browser.
    
TBR=piman@chromium.org,rjkroege@chromium.org,alexst@chromium.org,chrishtr@chromium.org
NOTRY=true
BUG=377497

Review URL: https://codereview.chromium.org/341253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278817 0039d316-1c4b-4281-b951-d872f2087c98

When Reset() is called outside of a config change, we need to clear
the active splice flag.

BUG=386782
TEST=new unittest
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/347813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278816 0039d316-1c4b-4281-b951-d872f2087c98

Avatar bubble:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMT2xPMnp3dEJvUms/edit?usp=sharing
- the previous code was using a temporary warning icon (while we were waiting
on UI resources), so this CL updates both the avatar button and bubble to 
use the correct one
- only the warning icon was clickable for accounts with an auth error in the
avatar bubble; changed this to have the entire account name be clickable, after
chatting with Travis/Alan
- moved the icon to in front of the account name, after
conversations with UI
- fixed eliding for the account button (which wasn't missing
one of the horizontal edge margins). Screenshot:
https://drive.google.com/file/d/0B1B1Up4p2NRMczBVQ29IRlREcG8/edit?usp=sharing

Avatar button:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMZnJsV3hlZTFjcGM/edit?usp=sharing
- fixes a bug where the avatar button text for glass windows was
displayed incorrectly when the window was maximized.

BUG=311235, 381713

Review URL: https://codereview.chromium.org/297143008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278814 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/333173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278813 0039d316-1c4b-4281-b951-d872f2087c98

Normally a child process kills itself if it can't connect to the browser in 15 seconds. This is to prevent a child process from staying around if the browser crashed right after launching it but before connecting to it.

When browser tests are sharded, sometimes tests run slower because of resource starvation which is why we have longer timeouts. So increase the child process connection timeout to match this.

BUG=TODO
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/343543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278812 0039d316-1c4b-4281-b951-d872f2087c98

Currently when HistoryURL provider decides to promote a match
for inline autocompletion, it will then decline to offer a what-you-typed
match even if it's valid and reasonable.

This behavior can cause problems in DisableInling mode because
this means that sometimes HistoryURL provider will not create a UWYT
match. Consequently, the default match in this mode can become a
search-what-you-typed even when the input is a valid URL. This causes
all sorts of badness and irritation.

This changelist creates a new mechanism, controlled through a field
trial parameter, that forces creation of the UWYT match if it wasn't
added due to this reason (promoted URL for inline autocompletion).

This is one approach to implement this strategy. The other approach
is in https://codereview.chromium.org/321243003/

Did some basic tests using a local field trial server with the
proper params.

TBR=pkasting
(to get this in M-37)

BUG=380357

Review URL: https://codereview.chromium.org/347963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278811 0039d316-1c4b-4281-b951-d872f2087c98

As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623

Review URL: https://codereview.chromium.org/341023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278810 0039d316-1c4b-4281-b951-d872f2087c98

A CHECK here seems too intrusive to me, I've changed it
to send error response instead.
A compromised renderer should not take down the whole browser process.

BUG=364141
Test=None, internal clean up.

Review URL: https://codereview.chromium.org/345983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278809 0039d316-1c4b-4281-b951-d872f2087c98

The ChildFrameCompositingHelper is used for swapped out RenderFrames only, which I want to eliminate and replace with RenderFrameProxy. As such, it is the RFP object that should own the helper.

BUG=357747

Review URL: https://codereview.chromium.org/345823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278808 0039d316-1c4b-4281-b951-d872f2087c98

AudioManagerAndroid uses Log.wtf to signal error conditions. However,
the undefined behavior of this function depending on device
configuration makes debugging difficult. Throw exceptions instead.

Review URL: https://codereview.chromium.org/340083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278807 0039d316-1c4b-4281-b951-d872f2087c98

This adds the following to the shouldInterceptRequest params:
 - isMainFrame
 - hasUserGesture
 - method
 - headers
This adds the following to InterceptedRequestData:
 - status code
 - response phrase
 - headers

BUG=387086
android_webview-only CL, trybots are happy.
NOTRY=true

Review URL: https://codereview.chromium.org/284123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278806 0039d316-1c4b-4281-b951-d872f2087c98

base::Time::Now() doesn't guarantee that successive calls don't get the
same value, and this seems to be happening on some Windows systems when
two BookmarkNodes are created one after the other in a unit test.

R=mad@chromium.org
TBR=sky@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/348893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278805 0039d316-1c4b-4281-b951-d872f2087c98

This has the side effect of MOSTLY resolving the issue of panels always
getting focus when Chrome is activated via Alt+Tab irrespective of which
Chrome window was last activate.
- Docked "Hangouts" panels will no longer steal focus when the Chrome/browser
shelf item is activated via Alt+Tab
- Docked "Hangouts" panels will steal focus when the "Hangouts" shelf item is
activated via Alt+Tab. In particular, if there is a docked "Hangouts" panel,
the docked panel will be activated by Alt+Tab even if there is a
detached "Hangouts" panel which was more recently active.

BUG=371621
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/333593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278804 0039d316-1c4b-4281-b951-d872f2087c98

Prior to NSS 3.16.2 there wasn't any validation of the RSA key parameters.

This has several consequences:

* Importing an RSA private key with another key's public modulus can be used to gain access to that key.
* importKey() can succeed for invalid RSA keys (invalid n, e, d, p, q etc).

This only affects Linux, since other platforms of Chromium bundle NSS/OpenSSL.

BUG=380424,378315
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/334983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387012
R=msw@chromium.org

Review URL: https://codereview.chromium.org/341323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278801 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/340453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278800 0039d316-1c4b-4281-b951-d872f2087c98

[DevTools] [PowerProfiler] Fix for browser crash with active timeline recording for capturing power.

The PowerProfilerService is a singleton class. It stores the PowerProfilerObserver to notify
about the power events. With the active timeline recording, the DevToolsPowerHandler registers
itself as the observer. When the tab close event occurs, the DevToolsPowerHandler is killed.
But the PowerProfilerService still contains a dangling reference to the observer thereby
causing the crash.

With this CL, DevToolsPowerHandler will remove itself from the observer to avoid the dangling
reference with the PowerProfilerService.

BUG=383725

Review URL: https://codereview.chromium.org/332623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278798 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/345113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387159
NOTRY=true

Review URL: https://codereview.chromium.org/348533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278796 0039d316-1c4b-4281-b951-d872f2087c98

This test is crashing frequently.

BUG=387045
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/341193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278795 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables custom color to be specified for IME composition.
Its Blink counterpart is https://codereview.chromium.org/313233002/ . Details:

- Prerequesite: the Blink change, since we assume WebCore::CompositionUnderline and
blink::WebCompositionUnderline have been updated.
- Prerequesite CL: https://codereview.chromium.org/319553002/ to allow
structures to temporarily mismatch, without triggering compiler assert.
- Adding background_color to ui::CompositionUnderline.
- To pass data from Android to Native C++, using JNI generator with callback: In C++, ImeAdapterAndroid::SetComposingText() calls Java to iterate over spans, then dispatch BackgroundColorSpan and UnderlineSpan data to C++ code and populate list of blink::WebCompositionUnderline.

We'll need to split this CL when we commit.

BUG=135900

Review URL: https://codereview.chromium.org/313053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278794 0039d316-1c4b-4281-b951-d872f2087c98

Some tests in content_browsertests are broken if --enable-text-input-focus-manager is enabled.  Fix those tests.

Since not all unittests run wm::FocusController::SetFocusedWindow, it turned out that we need WMTestHelper (instead of FocusController) to clear the text input client.

BUG=290701
TEST=Run content_browsertests with --enable-text-input-focus-manager enabled.

Review URL: https://codereview.chromium.org/340413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381447

Review URL: https://codereview.chromium.org/331793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278792 0039d316-1c4b-4281-b951-d872f2087c98

WebMediaPlayerImpl::seeking_ essentially tracks the same state.

BUG=144683

Review URL: https://codereview.chromium.org/343053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334602

Review URL: https://codereview.chromium.org/336543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278789 0039d316-1c4b-4281-b951-d872f2087c98

experiment state correctly now that its a multi-valued option.

BUG=386680

Review URL: https://codereview.chromium.org/343023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278788 0039d316-1c4b-4281-b951-d872f2087c98

Designers asked for some final tweaks to polish the interstitials. Small changes to CSS and strings.

BUG=381260
passed all of the bots at least once but cq is dead dead dead:
NOTRY=true

Review URL: https://codereview.chromium.org/344943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278787 0039d316-1c4b-4281-b951-d872f2087c98

Xcode 6 moved the location of the frameworks that iossim depends on and
added a few new dependecies so new header files need to be generated by
the gyp target.

Note that this CL gets iossim to compile but iossim will not launch the
Xcode 6 simulator.

BUG=381213
NOTRY=true
TBR=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/336773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278786 0039d316-1c4b-4281-b951-d872f2087c98

R=sbc@chromium.org

Review URL: https://codereview.chromium.org/348823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278784 0039d316-1c4b-4281-b951-d872f2087c98

 gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.

BUG=381601
TEST=covered by test.
R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278589

Review URL: https://codereview.chromium.org/340613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278783 0039d316-1c4b-4281-b951-d872f2087c98