- 14 May, 2018 40 commits
-
-
Mike Wasserman authored
Make a shared helper for getting the window type from properties. Apply properties to the window like the old WindowTreeClient. Bug: 837695 Change-Id: Icfe1efcddb52b2c3ef9d3ed218e02c105885e230 Reviewed-on: https://chromium-review.googlesource.com/1056349 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558209}
-
Koji Ishii authored
Following bot results are included. 5407 5409 TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9a4b34b49b723b49b4f3153141153fd0205497b2 Reviewed-on: https://chromium-review.googlesource.com/1056907 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#558208}
-
Hitoshi Yoshida authored
Some bindings code generator code depend on the paths of output directories to generate their contents. This CL changes the directory to output temporary files to test, and makes it possible to remove test-only hacks in code generators. Bug: 830255 Change-Id: I67b80489fcb3752679770cb56fa5c442c657b181 Reviewed-on: https://chromium-review.googlesource.com/1056778Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#558207}
-
Ramin Halavati authored
A minor bug in processing safe list in traffic annotation auditor is fixed. Bug: 690323 Change-Id: I76f6d023f88106bf69b6c5546142afb52e8e37c5 Reviewed-on: https://chromium-review.googlesource.com/1054877 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#558206}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I516955bcf67b5c21b789efad2c90c046c70127ce Reviewed-on: https://chromium-review.googlesource.com/1056794 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558205}
-
Yutaka Hirano authored
Bug: 570946 Change-Id: Iba0dd0c5af2d44a8baff9c4e5764fb9a624f719c Reviewed-on: https://chromium-review.googlesource.com/1056929Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#558204}
-
Hajime Hoshi authored
kInternalAnimation was introduced by replacing kUnspecedTimer, which is now kInternalDefault [1]. As we defined the task type guideline [2], the default behavior task runners should use kInternalDefault. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1009448 [2] https://bit.ly/2vMAsQ4, BUG: 836410 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib5788929dce6331fc8deee8d93df9b351f6d83ca Reviewed-on: https://chromium-review.googlesource.com/1055353Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558203}
-
Xiaocheng Hu authored
This patch removes the general member functions in RenderedPosition that inspect properties of bidi runs, and replace them by functions providing the exact information needed by SelectionController, which is the only client of RenderedPosition. Details: - Introduced RenderedPosition::BidiBoundaryType, so that we can obtain whether an RP is at bidi boundary without re-comparing its offset. - Replaced almost all existing member functions by - AtBidiBoundary(), replacing AtL/RBoundaryOfBidiRun() - BidiRunContains(other_rp), replacing |other_rp == this->L/RBoundaryOfBidiRun(other_rp.BidiLevelOnR/L())| - IsPossiblyOtherBoundaryOf(other_rp), replacing |this->AtL/RBoundaryOfBidiRun(other_rp.BidiLevelOnL/R())| Bug: 811502 Change-Id: I0b59b76e8060a5953295e09c98fcf7127a636ecc Reviewed-on: https://chromium-review.googlesource.com/1056220Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558202}
-
Noel Gordon authored
Document these tests. Also change them to have a common prefix. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c8d37efe4d9f380c17491b30b38c90d31204098 Reviewed-on: https://chromium-review.googlesource.com/1056752Reviewed-by:
Luciano Pacheco (SYD) <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558201}
-
Hwanseung Lee authored
the button in toasts of Bookmarks should not have a border. Bug: 842013 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2d431ba60b598125730eaf56b618fe3e9b1d9ccd Reviewed-on: https://chromium-review.googlesource.com/1055132 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#558200}
-
Noel Gordon authored
122:47 error Missing semicolon 515:52 error Missing semicolon Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id30d0aa122c0a34ac75b921de484ee5d2f376403 Reviewed-on: https://chromium-review.googlesource.com/1056888Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558199}
-
Timothy Loh authored
This reverts commit d9bf5454. Reason for revert: Breaks ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy on Linux Debug https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=not_site_per_process_browser_tests&tests=ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8946590247605008336%2F%2B%2Fsteps%2Fnot_site_per_process_browser_tests%2F0%2Flogs%2FExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy%2F0 Original change's description: > [Extensions Click-to-Script] Change default to allowing host permissions > > Change the default behavior of the kRuntimeHostPermissions feature to > allow extensions to have origin access, rather than defaulting to > withholding permission. In the first stage of click-to-script, we don't > want to change any defaults. > > Bug: 841099 > Change-Id: Ibdcbfb0fd9ecc535af73a1bd9048e196eab135e1 > Reviewed-on: https://chromium-review.googlesource.com/1052684 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558079} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841099, 842466 Change-Id: Id37af8c43bbf30d8963852df9b29b58ff3ca5a53 Reviewed-on: https://chromium-review.googlesource.com/1056887 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558198}
-
Hitoshi Yoshida authored
The target object is already traced in Oilpan from a static persistent map, but this CL adds a trace to make TraceWrappers() a subset of Trace() for unification. Bug: 841830 Change-Id: I3bec0361aa34ac7a0dc82fcb0cf3d823ea58057a Reviewed-on: https://chromium-review.googlesource.com/1055013 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558197}
-
Noel Gordon authored
Consistency: other tests use "Folder" instead of "Directory". Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8870cc25a39a54c6c06d2d5a2560652e854b5e99 Reviewed-on: https://chromium-review.googlesource.com/1056769Reviewed-by:
-
Noel Gordon authored
Document these tests, and remove redundant "State" from then end of a the geometry maximized test. No-Presubmit: true Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I261dc8083e19eae5b6252916b6abecb64eef57e1 Reviewed-on: https://chromium-review.googlesource.com/1056749 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Nicholas Verne authored
CrostiniRestarterService and CrostiniRestarterServiceFactory are kept local to CrostiniManager (for now) as they don't need to be exposed to other code. There is one CrostiniRestarterService per profile, and it owns CrostiniRestarter objects for that profile. When multiple calls to CrostiniManager::RestartCrostini are made due to user action, only one actual restart flow will run, and when it completes, multiple completion callbacks will run in succession. Bug: 839207 Change-Id: Icbf1da00fd9c937cd51bb77f0ad57bd63476b27b Reviewed-on: https://chromium-review.googlesource.com/1051208 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Ben Wells authored
The comment was incorrect. Bug: None Change-Id: Ifbacb882482dd834198046293b798da27b7b4964 Reviewed-on: https://chromium-review.googlesource.com/1055247 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558193}
-
Donna Wu authored
With this CL, the singleton device::MediaTransferProtocolManager is owned by device::mojom::MtpManager, and usage of the former MTP manager has also been converted to Mojo MTP interfaces. Next, we will merge device/media_transfer_protocol/ into the implementation of device::mojom::MtpManager. BUG=769630 Change-Id: I6a2b5d0bf388152e953bb7af3d13e85c2272e570 Reviewed-on: https://chromium-review.googlesource.com/1032237 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558192}
-
Ryan Hamilton authored
QuicClock is already part of the QUIC platform API. It's an abstraction for a clock. We don't gain anything by creating another clock abstraction and wrapping that up in a QuicClock. QuicAlarms are currently implemented using a task runner interface. There's no reason to change the abstraction from alarms to a task runner. Eliminating the task runner interface and using the QUIC alarm abstraction directly makes it easier to use the Quartc QUIC wrappers in a setting with an existing alarm implementation (eg. chromium). This might be useful in implementing RTCQuicStream. Quartc itself would like to use at least one alarm (see b/78013844). Implementing QuicAlarms directly in Quartc makes this easy. Merge internal change: 195335187 Change-Id: I2a0a60044e03c1d1893714ebe13492932ed87baf Reviewed-on: https://chromium-review.googlesource.com/1055938 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558191}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/193c9144b170..b15c2c28232c $ git log 193c9144b..b15c2c282 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 achuith cros_run_vm_test: Fix remote directory creation. Created with: roll-dep src/third_party/chromite BUG=chromium:829612 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic04b37f26f6554a286a21836d2f1fb5fa913fedd Reviewed-on: https://chromium-review.googlesource.com/1056791 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558190}
-
Giovanni Ortuño Urquidi authored
Before, HostedAppBrowserController would set/unset the strict mixed content preference on the main RenderViewHost when a WebContents was attached/detached from a PWA Browser window. This worked when Site Isolation was not enabled because all frames in the WebContents shared the same RenderViewHost. Now that Site Isolation is enabled, cross-origin iframes no longer share the same RenderViewHost resulting in the strict mixed content preference to not be applied to them. With Site Isolation enabled we need to handle two cases: (1) Apply the new preference on existing iframes (2) Apply the new preference on new iframes To handle case (1), this patch switches from UpdateWebKitPreferences to NotifyPreferencesChanged which eventually triggers a preference update on all RenderViewHosts in the WebContents. NotifyPreferencesChanged doesn't take any arguments, it just recomputes the preferences, so this patch modifies ChromeContentBrowserClient to check if the WebContents is in a PWA Browser window and set the preference accordingly. The above changes also handle case (2). When a new iframe is created, OverrideWebkitPrefs is called for its RenderViewHost and if the WebContents is in a PWA Browser window then the preference is set. Bug: 829688 Change-Id: Idb11bf979ec76ae8e1dfc905bf68e3c7ad1dbd6f Reviewed-on: https://chromium-review.googlesource.com/1048885 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#558189}
-
Koji Ishii authored
Following bot results are included. 5346 5349 5356 5363 5367 5369 5377 5378 5380 5386 5389 5392 5393 5394 5395 5398 5402 5403 5404 5405 19 lines were removed and 10 lines were deflaked by consecutive results since 5346. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3235231b21da2bb205ba84be22fca6e1752ce658 Reviewed-on: https://chromium-review.googlesource.com/1053927 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Timothy Loh authored
Disables: - ScrollEventToOOPIF on TSAN - OverlapSurfaceHitTestTest on Linux (was: TSAN) - HitTestWatermark on Linux (was: TSAN) - HitTestLayerSquashing on Linux - CrossProcessMouseCapture on Linux TBR=kenrb@chromium.org Bug: 833380 Change-Id: Ia8539488479c19e0dbeacf6bc0c16667f325ebd9 Reviewed-on: https://chromium-review.googlesource.com/1056775Reviewed-by:
-
Kevin Marshall authored
The ability to propagate files affords the sandboxing policy logic more precision in propagating the exact capabilities needed by child processes. Also some minor cleanup which changes the LaunchOptions interface to use FilePaths instead of strings for representing paths. Bug: 750938 Change-Id: I38059c39f629bc9234e4f94c0b215a39828f3665 Reviewed-on: https://chromium-review.googlesource.com/1050494 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#558186}
-
Joel Hockey authored
Change-Id: I107242a7118b5eaa0300c5a04c3ac48edf60dc5f Reviewed-on: https://chromium-review.googlesource.com/1056650Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558185}
-
Kent Tamura authored
Change-Id: I7d22ee25a4b4b55e4de846db6ec79919e703ac3e Reviewed-on: https://chromium-review.googlesource.com/1051185Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558184}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I0950d5fe5966d56308402c65300e6466bb32f0eb Reviewed-on: https://chromium-review.googlesource.com/1056022Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558183}
-
Kunihiko Sakamoto authored
This adds a parser for the CBOR certificate chain format defined in [1]. SignedExchangeCertificateChain::Parse() takes a version enum and selects a parser to use. For now, the new parser is used only by tests. [1] https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#cert-chain-format Bug: 815024,815025 Change-Id: Ia554ad3d086dbecd20294bdb6db03f37b60d67d9 Reviewed-on: https://chromium-review.googlesource.com/1002412 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558182}
-
Sam McNally authored
The file manager app queries the team-drives flag asynchronously, but may use its value before the response arrives, causing team drives to be enabled non-deterministically. Wait for the flag value to arrive before using its value to avoid this race. Bug: 723977 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic21f0833082be2ae8d297245fc6849a33e0b4058 Reviewed-on: https://chromium-review.googlesource.com/1053929Reviewed-by:
-
Eric Robinson authored
The pop-up string has been replaced with pop-ups and redirects. I've removed the old string, which will no longer be referenced after crrev.com/c/1047687. Bug: 840356 Change-Id: Iaf65ce22e3296215f27d25dfa7b7a81b0c605758 Reviewed-on: https://chromium-review.googlesource.com/1053953Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558180}
-
Xiaocheng Hu authored
This patch refactors bidi adjustment code in SelectonController by introducing ShouldAdjustBase/ExtentAtBidiBoundary(), so that adjustment criteria and adjustment result computation are separated. Bug: 811502 Change-Id: I197322426f1f108c9aeae971c599b5bff5a7fc46 Reviewed-on: https://chromium-review.googlesource.com/1053122Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558179}
-
Eric Robinson authored
This CL is the first step in having NotifyResult select the check with the highest priority. In order to do that (and not store intermediate data), all of the checks must have finished prior to NotifyResult being called. This *may* regress performance, and we should track the potential regression in SubresourceFilter.PageLoad.SafeBrowsingDelay. Bug: 823414 Change-Id: I1339e3795e9178dd7dd789ac98fcd21a2b76d726 Reviewed-on: https://chromium-review.googlesource.com/984672 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558178}
-
Charlie Harrison authored
This information is no longer being used anywhere. TBR=avi@chromium.org Bug: 842337 Change-Id: Iacdffd68df415a90ffe1b2c63971bd2c327d5cb0 Reviewed-on: https://chromium-review.googlesource.com/1056167 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558177}
-
Noel Gordon authored
Allows use to group "tabindex*" tests together (and eventually get rid of the FileManagerBrowserTestWithLegacyEventDisapatch class). Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd4c81458e853799e8a59e1185f8745fb27f8da8 Reviewed-on: https://chromium-review.googlesource.com/1056768Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558176}
-
Timothy Loh authored
This CL adds a LauncherCrostiniAppUpdater that ensures the Shelf knows about app uninstallation so it can remove pinned Crostini apps. TEST=Manually uninstalled an app and saw the pin disappear. Manually uninstalled Crostini and saw pins disappear. Bug: 839699 Change-Id: I81e6b60414ad8766ef159a9ea3969809beb5112c Reviewed-on: https://chromium-review.googlesource.com/1046605Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558175}
-
Sergei Datsenko authored
Default parameters are determined by the CrosDisks, it's not up to the client to decide which ones are the "default" so it ignores those anyway. BUG=chromium:831491 Change-Id: Ibb8cc66b318282b15bfcb361a6428e37028dcf37 Reviewed-on: https://chromium-review.googlesource.com/1053343 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558174}
-
Bence Béky authored
Remove SpdyNetworkTransactionTest.ServerPushBeforeHeaders, because this case is covered by SpdyNetworkTransactionPushTest.*/0. Remove SpdyNetworkTransactionTest.ServerPushInvalidCrossOrigin, because this case is covered by SpdyNetworkTransactionTest.ServerPushCrossOriginCorrectness. Change ServerPushCrossOriginCorrectness into a parametrized subclass, just like SpdyNetworkTransactionPushTest. For clarity, rename SpdyNetworkTransactionPushTest to SpdyNetworkTransactionPushHeaderTest, ServerPushCrossOriginCorrectness to SpdyNetworkTransactionPushUrlTest, and use PushHeaderTestParams and PushHeaderUrlParams as test data struct name, respectively. This will make it much easier to add tests for an upcoming histogram. Bug: 831536 Change-Id: I298fbd9a2dd4b6567b8cb597fcb704b956819218 Reviewed-on: https://chromium-review.googlesource.com/1055751 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558173}
-
chaopeng authored
This issue is caused by: 1. Press on any mouse button will update the last_scrollbar_under_mouse_ in EventHandler. last_scrollbar_under_mouse_ will set to null and call Scrollbar::MouseExited() when mouse middle click out of scrollbar. 2. Release any mouse button will check last_scrollbar_under_mouse_ for cleanup the mouse press state on Scrollbar. Because mouse middle button press happens before any mouse button release, last_scrollbar_under_mouse_ is null then release mouse button will not clear the scrollbar press state. There is another related issue here. We can drag the scrollbar by pressing the middle button. The root cause of the bug is not checking for the left mouse button before updating last_scrollbar_under_mouse_ and calling Scrollbar::MouseDown. In this patch, we only handle mouse left button for Scrollbar. Bug: 721303 Change-Id: I714eca2bbdd9dd1628e596dc6b9119bb5de85cc3 Reviewed-on: https://chromium-review.googlesource.com/1048389 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558172}
-
Wez authored
Allowances were added in thread checks, but these are no longer required since the fake for this class now grabs the calling-thread's TaskRunner. Bug: 838386 Change-Id: I27bc5bc192067ac5fc6c1636108dad30e92190f0 Reviewed-on: https://chromium-review.googlesource.com/1056252 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#558171}
-
Owen Rodley authored
The include flow is: test_struct_sizes.c arch_dependent_sizes_(32|64).h test_struct_sizes.c again arch_dependent_sizes_(32|64).h again then we hit the include guard as we've included the header twice test_struct_sizes.c is the only file that includes either of these headers, so the #include of test_struct_sizes.c is redundant. Change-Id: I95a4efe45a46dfe26b9b0e60b15af702d5546717 Reviewed-on: https://chromium-review.googlesource.com/1055009Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#558170}
-
