- 21 Oct, 2020 40 commits
-
-
Tom Lukaszewicz authored
This CL uses Polymer's dom-repeat chunking mode for the Tab Search list items. This allows an initial small list of tabs to be rendered, allowing the bubble appear at the correct size without waiting for the entire list to render. Bug: 1099917 Change-Id: Ib30d69923383e37e8241f62ed546ddb9ad73bbfd Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3270637Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819600}
-
Roman Arora authored
Bug: 1099917 Change-Id: Icc72b9bde3157f2d603173340e5c000e0b33474c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272131Reviewed-by:
Tom Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819599}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I8668b0dadf87721aec2c0d1ef42ffa94f769ab28 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3271919Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819598}
-
Takashi Toyoshima authored
Change-Id: I380bc7ce1b8bf17d8fe95dbb6bb92e9222efd11d Bug: 1126827, 1099917, 1053866 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
-
Yuheng Huang authored
tab.faviconUrl is a base64 stream of image for each tab. It's slow to generate, heavy to transfer and not reusable. getFaviconForPageURL uses chrome://favicon2 to get fav url from history, which is much more efficient but can not work in incognito mode. Since tab search is not supported in incognito mode, using getFaviconForPageURL is a performance win. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2406932 Bug: 1099917 Change-Id: If8b711b2b566fef2b1334c17ac768008f50ca867 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3265887Reviewed-by:
-
Roman Arora authored
Enable focus navigation for tab items and their buttons. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2388711 Bug: 1113470 Change-Id: I32b1ed98f0f832ff4c7dba5747e3437a860ab0d0 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3209477Reviewed-by:
-
Yuheng Huang authored
Search for item.title and item.hostname using weighted search from fuse.js. Scores are calculated from matching item.title and item.hostname. Items are sorted by scores by desc so better matching items will show up first. Also extract item.hostname from item.url. Bug: 1099917 Change-Id: Ieaee008b778dda90ef08ed504da034080b71cc58 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3222931Reviewed-by:
-
Yuheng Huang authored
This CL needs to be checked in before the related CL to prevent a revert due to src-internal build test breakage. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2382655 Bug: 1099917 Change-Id: Id79e1fa21be1bf0bdea52aa902f6685d8c985a4a Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3261333Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#819593}
-
Yuheng Huang authored
This CL makes sure the related CL does not break the js code when it lands. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2382655 Bug: 1099917 Change-Id: I766285c8114d279e6d466fa4d39c0dc3d47d8755 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3261323Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2399499 Bug: 1099917 Change-Id: I7b4856080e0b4b3939c6eb55f3c456af2a83dfc6 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3259362Reviewed-by:
-
Roman Arora authored
Add a footer to the Tab Search web contents to request user feedback. Feedback svg icon source: https://github.com/PolymerElements/iron-icons/blob/master/iron-icons.js Updated UI screenshot: https://drive.google.com/file/d/1cjPo0ec9UmKfhYwiy33E1F1NMgAElkEp/view?usp=sharing Original screenshots: Light mode: https://drive.google.com/file/d/17cFUycqQp-YnslTRVQigKEu2_eJ5wITK/view?usp=sharing Dark mode: https://drive.google.com/file/d/1HGxd1h2Dj10iR40rNRE-3M8T6XdZHTx1/view?usp=sharing Bug: 1099917 Change-Id: If562dbe74114e93bd0da1c42e04477e69a477370 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3228548Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Iadbf0be900c229a47dcf83bff9298c0580d83e93 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3251545Reviewed-by:
-
Tom Lukaszewicz authored
This change updates the Tab Search UI code to call ShowUI() on its BrowserProxy object when the necessary DOM changes have occurred and have become visible. This allows us to show the UI only when ready, preventing the UI from stuttering as it resizes while the list items load in. Bug: 1099917 Change-Id: Ia60f5ce1e0e30abd0dc1857344d880eb083356b8 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3245003Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates Tab Search WebUI to use the common make work better WebUI styles in ui/webui/resources/cr_elements. This factoring has been done to enable sharing of styles with the upcomming Read Later feature. Sharing common vars and styles will allow both features to remain visually consistent and enable better co-ordination between the teams wrt style changes. Small formatting fixes to html. Related refactoring CL: https://crrev.com/c/2365335 Bug: 1099917 Change-Id: I4fdd0a2b0198ae026199526947e0933f90fb0df5 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3225026Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819587}
-
Roman Arora authored
A search text change should reset the selected index to the first element of the list, if such an item exists, while a open tabs change should retain the current selected index, if it exists. Bug: 1099917 Change-Id: I07997c15dff33e7b5e62ab752cd3007f49199dcd Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3209263Reviewed-by:
-
Yuheng Huang authored
When tabUpdated() API is called, replace tab with the same tabId and trigger rerender. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2357958 Bug: 1099917 Change-Id: I3255f4ae9d78cf6b547523291043fc2675841c5f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3217588Reviewed-by:
-
Roman Arora authored
Initial style changes for 'dark mode' support. Screenshots attached: before light: https://drive.google.com/file/d/10ndrZxezf38F-me9owm6OE1Xit1vnJSn/view?usp=sharing after light: https://drive.google.com/file/d/1R-ZvfWEW2yVHz0TfNDRMBLniFQmOApXx/view?usp=sharing before dark: https://drive.google.com/file/d/1SGodUSsj4cGuUu7oW5CBDEGnYUI2FLN5/view?usp=sharing after dark: https://drive.google.com/file/d/13_lg8IE-vyi-qWqsHSZgucoJSFvR5H2E/view?usp=sharing Bug: 1110109 Change-Id: I46d76a453f44ce9b5be698adb4e58ce353b3220c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3209366Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates the WebUI for Tab Search to log whether or not the user has initiated a tab switch action from a filtered search result list or an unfiltered list. The related histogram and enum CL is below: http://crrev.com/c/2348698 Bug: 1099917 Change-Id: Ie2900b7c058233e353748f0981375186947385ee Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3210171Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Tom Lukaszewicz authored
Related CL: http://crrev.com/c/2339211 Bug: 1099917 Change-Id: Ib209f74c93375f0bb672ec6b09b294589cd18c65 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3186821Reviewed-by:
-
Roman Arora authored
Close button focus and navigation aspects to be addressed in crbug 1113470. Bug: 1099917 Change-Id: I7f42dd62381a345eb0cf807c48d5f8eb3b79b70e Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3203733Reviewed-by:
-
Roman Arora authored
Check for key event modifires before triggering keyboard navigation. Fixed: 1111003 Change-Id: Icccfc2938d4812974b628273edc7d68fc825a559 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3202978Reviewed-by:
-
Tom Lukaszewicz authored
This CL temporarily hides the close tab icon given the close tab functionality has not yet been fully plumbed in. This change will help avoid confusion when enabling Tab Search for early users looking to give feedback. Bug: 1099917 Change-Id: Ieed4c7d4220bb2edd07c0056198ac7d8490cb15f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3204546Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I3684b450523e4ec79fcd4dfc6497625982e4b79f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3203117Reviewed-by:
-
Yuheng Huang authored
Localization strings will be addressed in a follow up CL. Bug: 1099917 Change-Id: I537d681272524b747bd7d35bbf903d812984363b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3202980Reviewed-by:
-
Roman Arora authored
Fix scroll bug on repeated quick press of up/down keys on first/last selector entries. Fixed: 1110505 Change-Id: I84c015cfd21c6b8c8dd477dcd327ef23e09012ae Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3201593Reviewed-by:
-
Tom Lukaszewicz authored
Updated CSS to better align with figma mocks. Aligned hover color values to those used in the new-tab-page. before: https://drive.google.com/file/d/14924TmDxdzhC6CepFJSn6BxT-hWc3OXc after: https://drive.google.com/file/d/1S7j2xX_nlUXOuSQkN8Sl0kaq67mrdel9 Bug: 1099917 Change-Id: Ia369ea168740309c2dff12ad384ed8c0090d584d Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3197970Reviewed-by:
-
Tom Lukaszewicz authored
Updated JSDoc information to support using the CrSearchFieldBehavior with with the non-legacy class based Polymer3 syntax. Related CL: https://crrev.com/c/2333208 Bug: 1099917 Change-Id: Id514a5b20e19700a3f7b2948f6a2c7f36caf8d58 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3194288Reviewed-by:
-
Tom Lukaszewicz authored
Added the SearchField component to the TabSearch WebUI. The search field adheres to current UX style specifications for Read Later and Tab Search features. Dependent CL (update to Polymer bundle): https://crrev.com/c/2324810 Before: https://drive.google.com/file/d/1A_ikRVaaqhYH1k9RXSnH1aWWknAwajZF After: https://drive.google.com/file/d/1rN_-548iNgbWDvlVH9l_CZQXgydRtgyc Bug: 1099917 Change-Id: Id92c573aee7463e626773ff514a1b50d3ee18648 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3177409Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2290996 Bug: 1099917 Change-Id: Ic96dd27394ab8495d00a3a723c19e80239c99404 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3158203Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I95480e8bef7de7197642997cebf1296b5c0a1563 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3187724Reviewed-by:
-
Roman Arora authored
Tab Search UI related changes: - Custom tab-search-item component that represents each tab item - Show only hostname of tab url on tab-search-item - Close tab icon for certain list-item states - Keyboard navigation for tab-search-items Bug: 1099917 Change-Id: Idae91276a66b5b8e2efd7914266ea73107c58d34 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3154044Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2298282 Bug: 1099917 Change-Id: I45fb78b7013b46b5ac3c00f905631fc63d871c87 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3164617Reviewed-by:
-
Yuheng Huang authored
Tab Search is served by TabSearchUI with chrome://tab-search. It's guarded by compile flag enable_tab_search and enabled by --enable-features=TabSearch Bug: 1099917 Change-Id: I6621bd9fc2e7489b94a46fa0997cdb8f5f193d93 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3137445Reviewed-by:
-
Theresa Wellington authored
Conslidating team mailing lists. Change-Id: If933ddcf81ccd5563c90e2adfb9eaf96714af5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#819567}
-
Jesse Doherty authored
Change-Id: Id2cbe3d9ee41b44b00d48bb9271682b4294d1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490023Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#819566}
-
Sebastien Marchand authored
See the internal counterpart for this CL at cl/338334637 Bug: 1121427 Change-Id: I0be4895755eb476e06b0e825e8bd03fa25281b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490943Reviewed-by:
-
Matt Wolenetz authored
Adds a readonly, boolean-valued, static attribute named `canConstructInDedicatedWorker` to the MediaSource interface. Currently, this attribute is only visible to web apps if the RunTimeEnabledFeature "MediaSourceInWorkers" is enabled. When visible, this attribute always returns true. The primary goal of having this attribute is to enable web app's main thread to proactively determine whether or not MSE is supported from a dedicated worker context *before* deciding whether or not to create or try using MSE from such a context. As an initial example of this use case, the existing MSE-in-Workers web_tests are updated to use this new attribute's existence and value to fail-fast rather than potentially flakily fail (e.g. previously, the ...worker-terminate test might flakily pass/fail some of its test cases on implementations lacking MSE-in-Workers support if the test completed before handling receipt of error message from worker.) A further test is added to ensure that, if the attribute is missing or exists but is not `true`, a dedicated worker does not have ability to construct a MediaSource instance. See also https://github.com/w3c/media-source/issues/175 for further discussion which led to this new attribute. BUG=878133 Change-Id: I697ca6adc5b5dc65d5c5084ff67a541430a9237b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487834 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#819564}
-
Nidhi Jaju authored
This is a reland of a2505c5b Original change's description: > Remove NotEnumerable from Writable Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from writable streams. > > Bug: 1093862 > Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Cr-Commit-Position: refs/heads/master@{#819181} Bug: 1093862 Change-Id: Iaf54f395cc649b85cbc834dc18baf94855d53613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489110 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819563}
-
Sophey Dong authored
This bug fix has been launched since M84. Bug: 1124205 Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819562}
-
Tim Song authored
Currently, the notification icon is styled based on an accent color in the standard notification system. However, for PhoneHub, our icons have color, so we need to add a new field to reflect this behaviour. BUG=1140893,1106937 Change-Id: I892ab724b17cc2b17d20555ce68631fab055a418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489165 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819561}
-
