GitLab

We do not handle mouse drag (drag-n-drop & selection) when mouse/pen
is not drag with drag button (left mouse button or pen drag button)
However we do not clear mouse_down_may_start_drag_ when returns here.
This causes following mouse moves still think dragging may happen
and does not pass mousemove events to iframe.

Bug: 974790
Change-Id: Id1b7e4d71cb9607f918f3dc1b9e014fbb891ce5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661712Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671819}

This CL moves the icon id, which is located in public API but only used
internally by the scheduler, to NotificationEntry.


Bug: 977255
Change-Id: Ib35c65300fac87bed9722d14cd73d9a7edde1e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670300Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671818}

And promote out of experiment.

R=jbudorick, dpranke

Bug: 978051, 932269
Change-Id: Ic9355ad8d95f9311b03bcd64992d89a41194fefc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673751Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671817}

Bug: 977452
Change-Id: I5ed7e10988f45e648d582914b173878e4ad19c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673649Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671816}

With this change, JavascriptModalDialog can construct a touchless-
friendly dialog property model.

Bug: 977633
Change-Id: I68ab94b80ac47beef46184167c2b011a63de90c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671048Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671815}

The build system will verify that the manifest packages match if you
specify it in both GN and the manifest.

Bug: 891996
Change-Id: I39c3f158d01908b971a3ef47cb90af73019284a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667687
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671814}

Bug: 977619
Change-Id: I9267e6ccab7d13a46b865f573e165f28062fe75e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671931
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671813}

ProfileSyncService.get() can return null depending on configuration (for
example when sync is disabled from command line). IdentityDiscController
should check PSS reference for null before calling
addSyncStateChangedListener().

BUG=977626,976089
R=twellington@chromium.org

Change-Id: Ic04fbcfbe36b6074118823d94aac960bdcb8ff9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672182
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671812}

Add UMA metric to record how long peer to peer connections last. This
is the amount of duration for which we would need to throttle the
browser traffic.

Bug: 913424
Change-Id: I209dd5720c9f3c0923a2616f198db8611a789d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674447Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671811}

We ended keeping a deleted LayoutObject as part of whitespace re-
attachement because the previous next_sibling was detached at the next
iteration. Reset the next_sibling for each iteration.

I have not been able to reproduce the issue locally with the clusterfuzz
cases, and not figured out how to construct a case which causes this to
happen, so this is a speculative fix.

Bug: 977616
Change-Id: I31c840096897b757aaeccb3d8085ad57cf6b3060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674019Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671810}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e92b5481..d32b1ad1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibeb38fc79c8fbcd9cd60927dd6b21709bb037529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673672Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671809}

This type will be used for WebXR mojo instead of using an array of floats.

Change-Id: I25cc78a51a22b4a01dde3602bbfabf8c5e211e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672406Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671808}

https://android.googlesource.com/platform/external/perfetto.git/+log/a7344dc0fbc7..79519d67783b


git log a7344dc0fbc7..79519d67783b --date=short --no-merges --format='%ad %ae %s'
2019-06-24 primiano@google.com Fix tools/install-build-deps
2019-06-24 treehugger-gerrit@google.com Merge "[processor] Add string names for async ref types"
2019-06-24 taylori@google.com Merge "perfetto-ui: Quantize thread states less agressively"
2019-06-24 fmayer@google.com Merge "Convert relpc to abspc for pprof."
2019-06-24 taylori@google.com Merge "perfetto-ui: Use sched_waking for scheduling latency"


Created with:
  gclient setdep -r src/third_party/perfetto@79519d67783b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia765d32dd159e3adda3be847de2d715271e79c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673521Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671807}

This is a reland of 07f70727 that has
the uses-sdk assert disabled. We will enable once all dependency repos
are updated.

Original change's description:
> [build] Cleanup for specifying [min|target|max]SdkVersion in GN
>
> crrev/c/1650265 enforced setting [min|target|max]SdkVersion in GN.
> However, this is to strict for some dependencies, e.g. WebRTC.
> Therefore, relax rules so that you can specify the SDK versions in both
> GN and the AndroidManifest.xml. And the build system will assert that
> these values match.
>
> + Update some SDK versions that had been changed inadvertently in
>   crrev/c/1650265.
>
> TBR=tedchoc@chromium.org,torne@chromium.org
>
> Bug: 891996
> Bug: 977417
> Bug: 977328
> Change-Id: I89b944c1f73a35ba8fcdafdf4bdf62508759811e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660361
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671446}

TBR=tedchoc@chromium.org,agrieve@chromium.org,estevenson@chromium.org,yusufo@chromium.org

Bug: 891996, 977417, 977328
Change-Id: I97fd301368108f754f89b59beaa733121751a46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674324Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671806}

A previous CL changed the order in which ToolbarPhone is notified about
overview mode showing and the find-in-page toolbar hiding. Prior to that
CL, the find-in-page toolbar hiding notification came in first, followed
by the overview mode show. After the CL, the order was swapped causing
the ToolbarPhone visibility to be incorrectly set after the find-in-page
toolbar was hidden.

This CL updates ToolbarPhone#handleFindLocationBarStateChange to take
into account the current mTabSwitcherState.

BUG=977529

Change-Id: Iec4d1a11e0a79b0ffad3fee707e739be2ed550b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674346Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671805}

This CL changes the current WorkerRefCount test to be one based on a
Service Worker background page extension.

Bug: 973540
Change-Id: I5661470f85d17fe14b8d782e14a29d09260c1c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671864
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671804}

The eager page load strategy considers a page loaded when the
document.readyState is 'interactive'. This changelist implements it as
an option for users to use. A test was added 'testEagerMode' to ensure
that it is working properly.

R=crouleau@chromium.org, johnchen@chromium.org

Bug: chromedriver:1902
Change-Id: Ic83af73e959df9043de359d593a79c6adbc36992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669658
Commit-Queue: Julian Kung <juliankung@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671803}

Also corrects obsolete tag, since it was added to the wrong histogram
originally in https://crrev.com/2653733002.

These histograms were useful to monitor and keep tabs on regressions
from new deferred startup tasks. As we haven't used them in over two
years, setting these to expire until they are needed to diagnose a known
regression again. They can be quickly reactivated with a finch trial.

See: go/histogram-expiry-gdoc

Bug: 975356
Change-Id: Id191be3c3bfb538d72a15d0cb2488add9818da0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674327
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671802}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5c745f6720f759f0fdd72242670d4d91e59ba302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673523Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671801}

native


Bug: 963287
Change-Id: I0e3363c3e5f45e032e30aa97fea658a4d4b0bc10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668576
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671800}

The value of secureConnectionStart should be non-zero for secure
context navigations. It wasn't. This CL makes sure that it is!

Bug: 977519
Change-Id: Ia12e2842bc061e687512f1ed94d02c07f4dd42ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672068Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671799}

With this change, `autocorrect=off` turns off all substitutions, and
`spellcheck=false` just turns off quote and dash substitution, leaving
custom substitutions on.

Bug: 42434
Change-Id: I9ddf49f765e0ce061c8431563768f02e802d919b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672539
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671798}

The about page is copied over to the OS Settings. The non-CrOS parts
are removed as well as checks for the platform for CrOS parts. The
detail subpage, browser procy and dialogs files were not copied over.
They will continue to be shared by both about pages until their content
needs to change or after the SplitSettings feature flag is removed.

Added a link to the side menu in OS Settings to the
chrome://os-settings/help page.

Changed the chrome://management link to be an external link that opens
in the browser.

The existing chrome://settings/help is not rendered differently on
CrOS for when the SplitSettings feature flag is enabled. This will be
done in a follow-up CL.

Bug: 974378
Change-Id: I34177a9717dc3e5d292b13e435971bbe093187fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669185
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671797}

Bug: 734095
Change-Id: Ib06241c0995bf1adf554ecd8c4eda06c7fd3952d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670893
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671796}

Refactor to |base::OnceCallback| where possible.
Leave as is if depends on API that should be updated.

Bug: 968109
Change-Id: I19edf06451ffb2aebd511c49785f0e322e08128f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648180Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671795}

The TranslateBubbleView jumps through several hoops to update the tab titles on the contained tabbed pane. This is because there is no way to just set the text of the titles once the tabs are added.

This also updates the AddTabXXXX() APIs to clearly indicate ownership via std::unique_ptr<T>.

TBR: ellyjones@chromium.org
Bug: 974811
Change-Id: Ia93bc94bd712ce14454c95f3612a2e25ee6a4286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666255
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671794}

This reverts commit 29b821a9.

Reason for revert: Actual CL that caused the compile breakage was
https://chromium-review.googlesource.com/c/chromium/src/+/1674250.

Original change's description:
> Revert "Mass refactoring: Change JNI #includes to use full paths (chromecast/)."
>
> This reverts commit 748bea29.
>
> Reason for revert: Causing compile failures on Android bots: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/1626
>
> Original change's description:
> > Mass refactoring: Change JNI #includes to use full paths (chromecast/).
> >
> > Using relative paths was causing build failures. To create this change:
> >   * find out/Debug -name *_jni.h -delete
> >   * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \;
> >   * ninja $CHROMECAST_JNI_HEADERS
> >   * refactor_jni_includes.py  --out-dir out/Debug --repl-dir chromecast
> >   * fix DEPs files manually
> >
> > See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI
> > for discussion on naming scheme.
> >
> > Bug: 964169
> > Change-Id: I8aa1c635183444363f6a485464c3953331036e13
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672195
> > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#671682}
>
> TBR=tedchoc@chromium.org,estevenson@chromium.org
>
> Change-Id: I64c2b10d857d9736c61f95526745234a05e51b03
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 964169
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674051
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671697}

TBR=tedchoc@chromium.org,estevenson@chromium.org,steimel@chromium.org

Change-Id: I6d88e72d63de11d2db36540890af84cf2733aef4
Bug: 964169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673860Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671793}

Bug: 956680
Change-Id: I1cee8ba11e6ce7481066b4602a78c6469580bf35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657356
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671792}

This change switches addDiscoveredPrinter to returning a promise.
Since adding a discovered printer can take a bit of time, we continue
to use the configuring dialog.

Change-Id: I22b8f052cb1786200044473cac5c60c5840483c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649193
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671791}

Bug: 977566
Change-Id: I84ec81f7fd20fe9dd122602a3884efe4f0e3e1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671408Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671790}

This reverts commit 5c5db646 and
re-lands f090d8b6
with a fix to correct the .dSYM path for plugins; this fix won't
work if the plugin doesn't end in .so, but currently, neither
will the rest of the mac_plugin_bundle template.

R=bpastene@chromium.org
BUG=961548

Change-Id: Iaf520829cfcb495985d1dfdb3788f58a41936597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674406
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671789}

Bug: 975205
Change-Id: I80d76faef6aff9e9403c526cbcadd924366d6632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671847
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671788}

No change to logic, only docs.

This expands on commandline docs for WebView, to clarify that all
WebView providers support commandline flags in the same way, and to
advise how to properly use tooling (since some tools treat Monochrome
more like Chrome than like WebView).

This has a minor modification to remove --log-net-log as an example
flag, because we prefer users follow
https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/net-debugging.md
instead of applying this flag themselves.

This is inspired by the comment raised in https://crbug.com/977784#c19.

Bug: 918221
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I090c27082d072b8ad434702e19efea8d525a6aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674445
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671787}

https://swiftshader.googlesource.com/SwiftShader.git/+log/900e1dac1b2d..e899321b0bf7


git log 900e1dac1b2d..e899321b0bf7 --date=short --no-merges --format='%ad %ae %s'
2019-06-24 capn@google.com Refactor remaining cases of memset(this, ...)
2019-06-24 capn@google.com Fix initialization of LRU cache keys
2019-06-24 headlessclayton@gmail.com LLVMReactor: Bind double variants of trig / exp functions
2019-06-24 headlessclayton@gmail.com LLVMReactor: Remove "stack-probe-size" fudge, bind _chkstk extern
2019-06-24 headlessclayton@gmail.com Reactor: Various build fixes for MSVC 2019
2019-06-24 headlessclayton@gmail.com LLVMReactor: Align the coroutine stack frame.
2019-06-24 bclayton@google.com Put LLVM IR verification behind a default-disabled flag


Created with:
  gclient setdep -r src/third_party/swiftshader@e899321b0bf7

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/134932616,chromium:b/134932616,chromium:b/126873455,chromium:b/135866359,chromium:b/135691587,chromium:b/135609394
TBR=swiftshader-team+autoroll@google.com

Change-Id: I2785bf27aaba4be9cb43d7f7db3ebf16058b9bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671786}

This CL removes the entry in fieldtrial_testing_config.json for the
modern media controls, since the legacy controls no longer exist.

Bug: 884215
Change-Id: Ibc21ac0c61288581e2625821ca730697c834981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673752Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671785}

Before this patch, multiple scenarios that caused abort of payment would
reject PaymentRequest promises with "AbortError: Request cancelled."
This is an opaque message that does not tell the web developer what
happens. Although more detailed errors are printed in the developer
console, web developers don't see the developer console messages when
users interact with their website in production.

This patch combines C++ and Java error strings and lets the browser
control the error message content.

After this patch, web developers will see more detailed AbortError
messages when users interact with their website in production. For
example, instead of "AbortError: Request cancelled," a web developer
might see "AbortError: Cannot show PaymentRequest UI in a background
tab."

Bug: 908976
Change-Id: Ifc2103c43c6ebb50dd143d5c1cc12433ab9b7593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666477Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671784}

Refer to the bug for details.

Bug: 957992
Change-Id: Iec6649046f16f662068601c1cbc9723efe706d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674505Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671783}

This change will be important once InfobarBadgeTabHelper manages multiple
badges. If an infobar doesn't have a badge, then InfobarBadgeTabHelper
will not create and manage a badge state for that infobar.

Bug: 976901
Change-Id: I60242a798bd032d50c7263acc4561bf26af74d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670273
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671782}

When users click the "Configure" button in settings, a network
configuration dialog pops up. If a user fills in a password and presses
Enter, the device would attempt to connect to the network rather than
simply configuring the network.

This issue was caused by the fact that the <network-config> intercepted
the "Enter" event and immediately tried to connect, even if the dialog
was in "configure" mode instead of "connect" mode.

This CL changes logic such that when the "Enter" key is pressed,
<network-config> fires an event which is handled by its parent element;
then, the parent element decides whether to connect or to configure.

Bug: 974737
Change-Id: Ib2b89636451809c436f3ef4e996affa0cd065bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671852
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671781}

The GlobalDiscardableReferencePool is accessed either before or after
the Application exists, and causes crashes. It can be made independent
of either event to prevent that, and let it live as a global forever.

R=dtrainor@chromium.org

Bug: 978091
Change-Id: I295a0328720a7d8b3d63bde6b5dfe9df2d19f29a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673760
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671780}