GitLab

Disable flaky test org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testPreventHandlingCurrentSelectionModification.

TBR=twellington@chromium.org

BUG=673684

Review-Url: https://codereview.chromium.org/2573793002
Cr-Commit-Position: refs/heads/master@{#438153}

This patch implements a runtime headless mode (i.e., a
--headless command line switch) that makes it possible to
use a regular Chrome binary as a headless. When the binary
is launched with this switch, the main entrypoint calls
into the Headless Shell entrypoint, effectively starting
that shell instead of Chrome.

To make this possible we must remove the dependency from
Headless to Ozone, because Ozone is a build-time feature
which is generally not enabled for regular Chrome builds.
In practice this means implementing a new headless-specific
WindowTreeHost and modifying various graphics and input
entrypoints to do something appropriate in headless mode.

Since many of the modifications are in platform-specific
code, this initial patch only adds headless support in Linux.
Other platforms will be added later.

Design doc: https://docs.google.com/document/d/1aIJUzQr3eougZQp90bp4mqGr5gY6hdUice8UPa-Ys90/edit#

BUG=612904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1991953002
Cr-Commit-Position: refs/heads/master@{#438152}

Semi-auto generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2568143002
Cr-Commit-Position: refs/heads/master@{#438151}

Revert of Do not generate a microdump if there are no webview pointers on the stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
>
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
>
> BUG=664460
>
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460

Review-Url: https://codereview.chromium.org/2565353004
Cr-Commit-Position: refs/heads/master@{#438150}

The decorator was applied to a base class which doesn't
actually cause anything to be disabled.

BUG=catapult#:3088

Review-Url: https://codereview.chromium.org/2575513002
Cr-Commit-Position: refs/heads/master@{#438149}

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2557533005
Cr-Commit-Position: refs/heads/master@{#438148}

Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19 id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.externalnav.UrlOverridingTest%23testOpenWindowFromUserGesture

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2557233002
Cr-Commit-Position: refs/heads/master@{#438147}

Implementations of WorkerLoaderProxyProvider::postTaskToLoader have used
ExecutionContext::postTask to post tasks to the main thread. However,
the posted tasks are unexpectedly throttled, and that delays the startup
time of service workers.
This CL replaces ExecutionContext::postTask there with ParentFrameTaskRunners
and WebTaskRunner::postTask, so that the posted task is routed to suitable
task runners.

BUG=667310, 671084

Review-Url: https://codereview.chromium.org/2574703002
Cr-Commit-Position: refs/heads/master@{#438146}

BUG=630728

Review-Url: https://codereview.chromium.org/2568283002
Cr-Commit-Position: refs/heads/master@{#438145}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/642e2c87..d654057e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2573443003
Cr-Commit-Position: refs/heads/master@{#438144}

This is suspected to cause flaky failure of telemetry_unitests

BUG=661434

Review-Url: https://codereview.chromium.org/2564413002
Cr-Commit-Position: refs/heads/master@{#438143}

BUG=668714
TBR=jochen
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2572453002
Cr-Commit-Position: refs/heads/master@{#438142}

Change "Read" header to a phrase in reading to be clearer in all languages.

BUG=673335

Review-Url: https://codereview.chromium.org/2568163002
Cr-Commit-Position: refs/heads/master@{#438141}

This CL updates the FlagExpectations file for layout tests for the flag
--enable-browser-side-navigation (aka PlzNavigate).

BUG=576261

Review-Url: https://codereview.chromium.org/2568873002
Cr-Commit-Position: refs/heads/master@{#438140}

http://chromium.googlesource.com/chromium/deps/icu.git/+log/73e24736..9cd28287

One change in the range: deprecation warning suppresion for non-clang.

BUG=21515,637001

Review-Url: https://codereview.chromium.org/2575433002
Cr-Commit-Position: refs/heads/master@{#438139}

This CL is partial revert of
https://codereview.chromium.org/1682173005

BUG=671380
TEST=translate.py resumes working as expected.
TBR=flackr

Review-Url: https://codereview.chromium.org/2570003002
Cr-Commit-Position: refs/heads/master@{#438138}

Per discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=615589#c113.

BUG=615589,663546

Review-Url: https://codereview.chromium.org/2569183002
Cr-Commit-Position: refs/heads/master@{#438137}

The registration of the finalization callback now happens under-the-hood
and automatically.

R=haraken
BUG=673645

Review-Url: https://codereview.chromium.org/2570463005
Cr-Commit-Position: refs/heads/master@{#438136}

Also, define how initialization of nodes works, by adding an init()
method that is called after creating a node.

Initialization now happens after the full tree structure has been
created, and recursively processes all nodes in the tree. Subtrees that
are added later use the same pattern; InnerNode now has helper methods
for this.

BUG=616090

Review-Url: https://codereview.chromium.org/2513453004
Cr-Commit-Position: refs/heads/master@{#438135}

The test is essentially flaky and we are unable to fix it.

BUG=518988, 143475
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2570503004
Cr-Commit-Position: refs/heads/master@{#438134}

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573733002
Cr-Commit-Position: refs/heads/master@{#438133}

This cl fixes calculations done with offset value.
Offset value must be added to a raw value and only then multiplied
by a scaling value.
The formula is the following:
processed value = (raw + offset) * scale

BUG=661478

Review-Url: https://codereview.chromium.org/2570693004
Cr-Commit-Position: refs/heads/master@{#438132}

This is going to show the metrics for the first 5 peer connections;
I hope that's enough since showing all 30 makes the test really
annoying to triage.

BUG=632299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2561603003
Cr-Commit-Position: refs/heads/master@{#438131}

TBR=dtrainor@chromium.org

BUG=673279

Review-Url: https://codereview.chromium.org/2569013004
Cr-Commit-Position: refs/heads/master@{#438130}

Previously, last_visit_date metadata has was removed by
BookmarkSuggestionProvider via ContentSuggestionService::ClearHistory()
which only works on Android. This CL makes the removal platform-
independent. It aims at simplicity to make is easier to merge to M56
(and does not fix the pre-existing TODO).

The data is collected outside of BookmarkSuggestionProvider (by a tab
helper). Previously, the tab helper was only instantiated on Android.
Since M56 the tab helper is created and we thus collect the data on all
desktop platforms as well. For this reason, we also need to fix the
browsing data removal.

BUG=673268

Review-Url: https://codereview.chromium.org/2566123002
Cr-Commit-Position: refs/heads/master@{#438129}

We display various visual tab indicators but there is no corresponding indicator for accessible labels. The updated accessible label is in the format of:

Page title - Tab status

For tabs in incognito this is a format:
Page title - Tab status (incognito)

BUG=635610

Review-Url: https://codereview.chromium.org/2497373003
Cr-Commit-Position: refs/heads/master@{#438128}

The proposed spec for BudgetAPI defines the return value for getBudget
to be a Promise that resolves with a sequence<BudgetState> while the
current interface used a FrozenArray.

This patch updates the code to match the proposed spec. The implementation
works with either version, and this is covered by existing LayoutTests.

BUG=672112

Review-Url: https://codereview.chromium.org/2571573002
Cr-Commit-Position: refs/heads/master@{#438127}

The tests in these cases can pass only if Quit is called before Run, or
if Run is never called at all. If this is guaranteed to hold true, then
RunLoop is not needed (such as in timer_unittest.cc). Other cases (where
it is not guaranteed) are tests that can crash occasionally.

BUG=668707

Review-Url: https://codereview.chromium.org/2571473002
Cr-Commit-Position: refs/heads/master@{#438126}

This implements heap compaction for the Blink GC infrastructure
(Oilpan), compacting the arenas of the BlinkGC heap which are most
susceptible to becoming fragmented during actual use.

Fragmentation is a real problem and a growing one while browsing anything
but static pages: the amount of unused, but allocated, memory is
fluctuating higher over time.

To avoid leaving increasing amounts of unused holes in our heaps,
heap compaction will periodically squeeze out the unused portions,
packing together the live objects. The heap pages that are then
left as unused, are subsequently released and returned to the OS.

Due to a fortunate property of Blink heap collection types, providing
such compaction is within relatively easy reach. Experiments show that
the arenas which hold such collection objects ("backing stores") are
the ones that develop fragmentation the most & persistently. While not
a complete heap compactor of all Blink GC arenas, it addresses the
fragmentation problem where it is most pressing. More can be done, later.

Explainer / design document:

 https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU

R=haraken
BUG=672030

Review-Url: https://codereview.chromium.org/2531973002
Cr-Commit-Position: refs/heads/master@{#438125}

https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/d0c70649064f..3166d8be97c9

$ git log d0c706490..3166d8be9 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 tobiasjs Fix unit tests expecting no output when a microdump is suppressed.
2016-12-10 mpercy Fix sign-compare compiler warning in MicrodumpWriterTest
2016-11-23 vapier crash_generation: fix bad call to close

R=primiano@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2568713004
Cr-Commit-Position: refs/heads/master@{#438124}

DOMWindowProperty::frameDestroyed is now equivalent to ContextLifecycleObserver::contextDestroyed.
This CL does the replacement for InstalledAppController.

BUG=610176

Review-Url: https://codereview.chromium.org/2571513003
Cr-Commit-Position: refs/heads/master@{#438123}

Resolved a TODO: The testing::variations::VariationParamsManager
replaces a mock.

In order to enable Feature-associated params, the tested RequestBuilder
needed to be mocked. Since CL 645447, Feature-association works now and
exposing implementation details and mocking is now unnecessary.

BUG=634892

Review-Url: https://codereview.chromium.org/2552813005
Cr-Commit-Position: refs/heads/master@{#438122}

BUG=460722
NOTRY=true

Review-Url: https://codereview.chromium.org/2569173002
Cr-Commit-Position: refs/heads/master@{#438121}

Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade.

TBR=miguelg@chromium.org

BUG=673385

Review-Url: https://codereview.chromium.org/2571773002
Cr-Commit-Position: refs/heads/master@{#438120}

R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=539572

Review-Url: https://codereview.chromium.org/2565383002
Cr-Commit-Position: refs/heads/master@{#438119}

BUG=666756
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2572683002
Cr-Commit-Position: refs/heads/master@{#438118}

Reland of strict transmission of external exp ids to signed in users. (patchset #1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users. (patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
>
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
>
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuilds=100
>
> e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/35779
>
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
>
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> > TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
>
> TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
>
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2575483002
Cr-Commit-Position: refs/heads/master@{#438117}

This allows significant cleanup of CSSCursorImageValue, so do that too.

Intent-thread:

 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/r0lnh5Rw23M

TBR=timvolodine@chromium.org
BUG=650598

Review-Url: https://codereview.chromium.org/2522443002
Cr-Commit-Position: refs/heads/master@{#438116}

TBR=changwan@chromium.org

BUG=673588

Review-Url: https://codereview.chromium.org/2574713002
Cr-Commit-Position: refs/heads/master@{#438115}

We're deprecating DOMWindowProperty, which is now equivalent to ContextLifecycleObserver.
This CL replaces DOMWindowProperty with ContextLifecycleObserver in PresentationController.

BUG=610176

Review-Url: https://codereview.chromium.org/2569963003
Cr-Commit-Position: refs/heads/master@{#438114}