GitLab

This change reverts adding Cmd+L clear console shortcut, as it conflicts
with Chrome's omnibox focus shortcut on Mac.

This change also allows the pause script shortcuts to be used while
inside the inspected page, allowing the user to perform a series of
mouse/focus actions before pausing script.

BUG=527220

Review URL: https://codereview.chromium.org/1312393004

git-svn-id: svn://svn.chromium.org/blink/trunk@201672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL puts the classname under GC_PROFILING flag since it increases
binary size in production builds.

BUG=527054

Review URL: https://codereview.chromium.org/1317563005

git-svn-id: svn://svn.chromium.org/blink/trunk@201671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1314773009

git-svn-id: svn://svn.chromium.org/blink/trunk@201670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504537
TEST=Open Network Panel, navigate to mixed.badssl.com, type
"mixed-content:true" in the filter

Review URL: https://codereview.chromium.org/1320343005

git-svn-id: svn://svn.chromium.org/blink/trunk@201669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Split ResourceFetcher::loadPriority() into 3 functions:
* typeToPriority(), which converts Resource::Type into its default ResourceLoadPriority
* modifyPriorityForExperiments(), which contains all of the currently-running experimental logic.
* loadPriority() remains the entry point, and contains permanent special cases (e.g., synchronous loads).

BUG=

Review URL: https://codereview.chromium.org/1319153004

git-svn-id: svn://svn.chromium.org/blink/trunk@201667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522739

Review URL: https://codereview.chromium.org/1324073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526239

Review URL: https://codereview.chromium.org/1315193014

git-svn-id: svn://svn.chromium.org/blink/trunk@201661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

blink-dev intent to remove thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/E9LKKtcKbv8/cB7QmTlACgAJ

BUG=470301

Review URL: https://codereview.chromium.org/1291723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1310533007

git-svn-id: svn://svn.chromium.org/blink/trunk@201658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes an old TODO where processNewItem took a pointer
to make the initial review easier. The pointer indirection is not
necessary and has been switched to a reference.

Review URL: https://codereview.chromium.org/1330453002

git-svn-id: svn://svn.chromium.org/blink/trunk@201657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201644

BUG=522797
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1322243004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This helps people who follow a link directly to the class without reading its
file top-down.

Review URL: https://codereview.chromium.org/1305933006

git-svn-id: svn://svn.chromium.org/blink/trunk@201655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

BUG=497761,510398

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563

Review URL: https://codereview.chromium.org/1312353004

git-svn-id: svn://svn.chromium.org/blink/trunk@201654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RemoteArray wrapper incapsulates at and length methods. RemoteFunction incapsulates targetFunction method. Wrappers have createFromObject methods which check type of object.
In utilities.js method storeResultTo is added to Promise.prototype. This method allow to save promise result value to object[propertyName] and return it for following processing.

BUG=61643
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1325783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We want to introduce a WebTaskRunner which maps to a chromium
SingleThreadTaskRunner and migrate WebScheduler and WebThread
over to it.  The motivation is:

* Brings the blink side closer to the underlying chrome code.
* For spatial scheduling we plan to have a loading and timer
  task queue per frame.
* We want to be able to post delayed tasks to the loading
  task queue and architecturally we feel the WebTaskRunner
  will be cleaner than adding a postDelayedLoadingTask to
  WebScheduler.

Patch 2: https://codereview.chromium.org/1308183005
Patch 3: https://codereview.chromium.org/1303153005
Patch 4: https://codereview.chromium.org/1309423004
Patch 5: https://codereview.chromium.org/1310253009

BUG=510398,497761

Review URL: https://codereview.chromium.org/1325073002

git-svn-id: svn://svn.chromium.org/blink/trunk@201652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524115

Review URL: https://codereview.chromium.org/1327693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should remove stray "TracingStartedInPage event not found" message
when using screenshot recorder in Network panel.

- extract processMetadataEvents() from TracingModel to TimelineModel
- ditto for session id
- nuked TracingModel.Loader

BUG=

Review URL: https://codereview.chromium.org/1305373004

git-svn-id: svn://svn.chromium.org/blink/trunk@201649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: fix build after r201639. (patchset #1 id:1 of https://codereview.chromium.org/1312073003/ )

Reason for revert:
Not complete, reverting to reland.

Original issue's description:
> Oilpan: fix build after r201639.
> 
> TBR=oilpan-reviews
> BUG=none
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201647

TBR=oilpan-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1319623006

git-svn-id: svn://svn.chromium.org/blink/trunk@201648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This file does not use RetainPtr; move the include to
FontPlatformDataMac.mm, which does need it.

Review URL: https://codereview.chromium.org/1314663002

git-svn-id: svn://svn.chromium.org/blink/trunk@201646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn this unit test helper into something more RAII-like to avoid
Resources not having their clients removed.

For the tests touched, addresses reported Resource leaks.

R=haraken
BUG=526423

Review URL: https://codereview.chromium.org/1327653004

git-svn-id: svn://svn.chromium.org/blink/trunk@201645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522797
TEST=fast/repaint/subpixel-shadow-included-in-invalidation.html

Review URL: https://codereview.chromium.org/1308033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Part of a 3-sided patch:
1. https://codereview.chromium.org/1309273007
2. https://codereview.chromium.org/1313363006
3. this patch

BUG=507751

Review URL: https://codereview.chromium.org/1313013006

git-svn-id: svn://svn.chromium.org/blink/trunk@201643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Link header wasn't handling well extensions parameters with no value
that were not followed by a white space.
This CL fixes that.

BUG=520698

Review URL: https://codereview.chromium.org/1322543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Make m_executeScriptsWaitingForResourcesTimer a loading task (patchset #2 id:20001 of https://codereview.chromium.org/1312353004/ )

Reason for revert:
Oilpan leaks.

Original issue's description:
> Make m_executeScriptsWaitingForResourcesTimer a loading task
> 
> We would like to be able to prioritize loading tasks, but in order to
> do that we need to make sure loading tasks are posted to the right queue
> to make sure tasks run in the expected order.  If this task is posted as
> a timer, and loading tasks are prioritzed, it's possible
> FrameHostMsg_DidStopLoading will be sent before the corresponding
> FrameHostMsg_DidStartLoading ipc which causes various browser tests to
> break.
> 
> BUG=497761,510398
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563

TBR=mkwst@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497761,510398

Review URL: https://codereview.chromium.org/1304943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1323943008

git-svn-id: svn://svn.chromium.org/blink/trunk@201640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes FIXME(OILPAN) that is out-dated or doesn't make much sense.

BUG=

Review URL: https://codereview.chromium.org/1327793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The functionMap is already a global static variable. The createFunction has a check
which makes the method createFunction being called only once. Hence there is no need
of this function table to be a static table.

This reduces the bss size on linux by 656 bytes

R=haraken

Review URL: https://codereview.chromium.org/1324133002

git-svn-id: svn://svn.chromium.org/blink/trunk@201638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=514651

Review URL: https://codereview.chromium.org/1309523008

git-svn-id: svn://svn.chromium.org/blink/trunk@201637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=523249
NOTRY=true

Review URL: https://codereview.chromium.org/1325983003

git-svn-id: svn://svn.chromium.org/blink/trunk@201636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Updated modules/accessiblity, app_banner, audio_output_device, bluetooth, 
  cachestorage, canvas2d, compositorworker, crypto, encryptedmedia, fetch, and filesystem.

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1315743003

git-svn-id: svn://svn.chromium.org/blink/trunk@201635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Evict resources from the memory cache upon shutdown.

R=haraken
BUG=526423

Review URL: https://codereview.chromium.org/1309843011

git-svn-id: svn://svn.chromium.org/blink/trunk@201634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL ships Oilpan for core/animations except for temporary animation objects.
We confirmed that this CL won't regress any animation benchmark in telemetry.

Look at the discussion in the following thread for more details
and performance results: https://groups.google.com/a/chromium.org/d/topic/oilpan-reviews/V7d-7o4AbeA/discussion

BUG=340522

Review URL: https://codereview.chromium.org/1318543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1308273007

git-svn-id: svn://svn.chromium.org/blink/trunk@201632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The API has evolved a bit, dropping the 'password' and 'formData'
accessors in favor of a 'toFormData(FormDataOptions)' method which
is intended to be used in conjunction with 'fetch()' to submit
credentials to a server-side endpoint.

Defined at [1] and [2].

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential
[2]: https://w3c.github.io/webappsec/specs/credentialmanagement/#generate-formdata

BUG=526995

Review URL: https://codereview.chromium.org/1317043003

git-svn-id: svn://svn.chromium.org/blink/trunk@201631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScopedPageLoadDeferrer is an RAII-like class that does some work when it is
constructed and destructed, just like other ScopedXXX classes.

It was oilpanized in the past, and a new method, dispose(), was added to
do clean-ups that had been done in the destructor. However, a few stack-
allocated usages were overlooked in that change.

Garbage-collected objects shouldn't be allocated on the stack. So, stack-
allocated usages should be converted to heap-allocated, with dispose() calls
added in every single place where the object can go out of scope.

However, I find this conversion too cumbersome and less C++-idiomatic.

Therefore, this patch instead de-oilpanizes ScopedPageLoadDeferrer. The only
reference to will-be-heap-managed class in ScopedPageLoadDeferrer is
RefPtr<LocalFrame>, so it is safe to convert it to RefPtrWillBePersistent.

I think this patch makes the code cleaner overall.

BUG=486590
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1316663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1310633005

git-svn-id: svn://svn.chromium.org/blink/trunk@201629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Root cause:
Our testharnessreport.js removes unnecessary text nodes in a callback registered
by add_completion_callback() [1]. The html5lib tests add other completion
callbacks to show failure reasons, and they run after the callback of
testharnessreport.js.  So, the failure reasons remain in *-expected.txt.

Resolution:
testharness.js doesn't provide a way to specify that "This callback must run at
the end of callbacks." So we delay the text nodes cleanup by setTimeout(done, 0).

[1] https://github.com/w3c/testharness.js/blob/master/docs/api.md#callback-api

BUG=527262

Review URL: https://codereview.chromium.org/1303313006

git-svn-id: svn://svn.chromium.org/blink/trunk@201628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://html.spec.whatwg.org/multipage/scripting.html#script-processing-for
> 12. If the script element has an event attribute and a for attribute, then run
> these substeps:

Our implementation was "... has a non-empty event attribute and a non-empty for
attribute, ...".  This CL corrects isEmpty() checks to isNull().
The new behavior is compatible with IE and Firefox.

BUG=520844

Review URL: https://codereview.chromium.org/1305213005

git-svn-id: svn://svn.chromium.org/blink/trunk@201627 bbb929c8-8fbe-4397-9dbb-9b2b20218538