- 12 Jun, 2014 40 commits
-
-
alekseys@chromium.org authored
* add vendor id and custom display name to media selection * propagate selected media size in PrintSettings Related Сhanges in JS: * Use media custom diaply name received from the native layer * Make sure media size selection is propagated to the native layer BUG=239879 NOTRY=true Review URL: https://codereview.chromium.org/325313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276578 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=379961 NOTRY=true Review URL: https://codereview.chromium.org/329033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276577 0039d316-1c4b-4281-b951-d872f2087c98
-
jansson@chromium.org authored
While trying to figure out why Firefox does not work with the peerconnection.html page I discovered we never caught the actual error message for RTCPeerConnection and createAnswer/Offer in the error callbacks. TEST=P2P calls between tabs using Firefox and Chrome. BUG=378199 Review URL: https://codereview.chromium.org/306033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276576 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
(This CL merges changes until last Friday). Change the QUIC TLP to send new data instead of retransmitting old data when new data is available. Also tighten up the QuicSentPacketManagerTest for TLP per avd's request. Merge internal change: 68731782 https://codereview.chromium.org/327383002/ Use override consistently instead of virtual. Merge internal change: 68717267 https://codereview.chromium.org/325373002/ QUIC - added code to read kUAID in the server code from the CHLO message. The following is the list of kUAID strings for chrome built by google. The following is true for all platforms for clients built by google (android, posix, windows and chromeos). UAID: "unknown Chrome/37.0.2029.0" chrome developer's builds. UAID: " Chrome/37.0.2029.0" Stable UAID: "canary Chrome/37.0.2029.0" Canary UAID: "dev Chrome/37.0.2029.0" Dev UAID: "beta Chrome/37.0.2029.0" Beta Merge internal change: 68715745 https://codereview.chromium.org/333523002/ Minor change to keep the code similar between chromium and internal source tree. + use SupportedVersions. + One line per argument. + Minor fixes to comments. Merge internal change: 68659711 https://codereview.chromium.org/335433002/ Changed SetIpInfoInCmsg to return the length of the packet info structure used. Merge internal change: 68639530 https://codereview.chromium.org/329223003/ (minor) rename frames_ to buffered_frames_ in QuicStreamSequencer Merge internal change: 68571729 https://codereview.chromium.org/329403003/ Enables PacketGenerator's use of PacketCreator's FEC primitives. Adds methods in PacketGenerator that enable use of the PacketCreator's FEC primitives, and adds tests for these methods. Merge internal change: 68558082 https://codereview.chromium.org/326403006/ Connection level flow control (CLFC) accounting on receipt of FIN/RST for already closed streams. This implements the following behavior discussed internally. Proposal: implement rch/jar's solution from earlier in the thread, in which "bytes sent" is added to the RST frame, and each endpoint must send a FIN or RST containing "bytes sent" on stream termination. This gets the job done pretty simply, and will make our flow control very similar to SPDY. We can investigate more exotic dynamic stream window scaling (as per avd's suggestion earlier in the thread) in future if SPDY-style flow control is shown to be a problem. A stream *must* send either a FIN or a RST on termination, either of which contain enough data that the peer can definitively determine how many bytes were sent on that stream (this is already implemented). This CL implements the correct CLFC accounting of these frames when received after the stream has been closed locally. Motivating example: Client sends GET+FIN, Server sends response. Before response arrives, client RSTs the stream (user closed tab?), tearing down local state. Before this CL, when the server response arrives it just gets dropped - but the server has counted the bytes sent against its CLFC _send_ window. The client will not count these bytes against it's CLFC _receive_ window, and so the endpoint states are now out of sync. To fix this, when a stream is closed we store the current "last bytes received offset" in a map in the session, and handle a FIN/RST for a closed stream by removing the difference between the final byte offset from FIN/RST and the stored value from the map to the CLFC receive window. QUIC: Connection level flow control accounting on receipt of FIN/RST for already closed streams. Protected behind existing flag: FLAGS_enable_quic_connection_flow_control Merge internal change: 68555475 https://codereview.chromium.org/320263003/ Add QuicStreamSequencerPeer to quic/test_tools, to make stream sequencer tests more consistent with other tests. Merge internal change: 68553409 https://codereview.chromium.org/318333002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/327393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276575 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
MediaSource renderer wasn't marking keyframes properly, and as result SourceBuffer would keep all data it receives forever. Also added explicit remove() call to cleanup the buffers before each keyframe. Beside that changed default duration to a correct value instead of 1s It currently doesn't cause any problems, but it may in the future if MediaSource implementation is changed to handle overlapping frames differently. BUG=321825 Review URL: https://codereview.chromium.org/329663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276574 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=383100 Review URL: https://codereview.chromium.org/332513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276573 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=383153 Review URL: https://codereview.chromium.org/321363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276572 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
TBR=kalman@chromium.org BUG=383452 Review URL: https://codereview.chromium.org/327243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276571 0039d316-1c4b-4281-b951-d872f2087c98
-
shuchen@chromium.org authored
BUG=372291 TEST=None Review URL: https://codereview.chromium.org/305533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276570 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
For some devices, we does not include 2x theme assets. But the devices can be connected HiDPI displays. In that case, 2x assets are routed to fallback 1x assets. To show the fallbacks in correct size, we need to specify the icon size explicitly. BUG=382971 TEST=remove chrome_200_percent.pak and launch chrome with '--force-device-scale-factor=2' R=fukino@chromium.org Review URL: https://codereview.chromium.org/335563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276569 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
Make page_runner more tolerant to cloudStorageError (crbug.com/369611). BUG=368061 Review URL: https://codereview.chromium.org/329143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276568 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
The new translate UX uses bubbles instead of infobars. Views uses the new UX by default, Mac will soon too. (IDRs x-plat API should be removed after Mac switches) Remove code unused since r248162 (4 months ago). Stub out ChromeTranslateClient::CreateInfoBar for Views. This should simplify Elliot's WIP MenuButton CL: https://codereview.chromium.org/298813002 (these applied TextButtonBorders to MenuButtons instances) BUG=276181,288554,241691,383235,155363 TEST=No Translate behavior changes; no complaints. R=sky@chromium.org,pkasting@chromium.org,toyoshim@chromium.org TBR=hajimehoshi@chromium.org Review URL: https://codereview.chromium.org/325483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276567 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
The original r276450 was reverted in r276476 for leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954 Fixed here by calling AddChildView(title_) on Tab (duh). Add a Label view to Tab for displaying the title. Remove Tab::PaintTitle, bounds and font members. Remove unnecessary Tab::Get[Title|Icon]Bounds helpers. Update the text on Tab::SetData, not during paint. Use gfx::DirectionalityMode, remove the Label enum. Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment. Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD. Always flip left/right in Label::SetHorizontalAlignment. Have Tab and MessageBoxView use ALIGN_TO_HEAD. Update comments and tests, related minor cleanup. TODO: Make Label cache RenderText objects. TODO: Make RenderText support ALIGN_TO_HEAD. BUG=240037 TEST=No visible Views tab title changes. R=sky@chromium.org Review URL: https://codereview.chromium.org/329813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276566 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=370433 TEST=None R=sky@chromium.org Review URL: https://codereview.chromium.org/323763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276565 0039d316-1c4b-4281-b951-d872f2087c98
-
mithro@mithis.com authored
BUG=380987 Review URL: https://codereview.chromium.org/327943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276564 0039d316-1c4b-4281-b951-d872f2087c98
-
fangjue23303@gmail.com authored
Rename HistoryService::NotifyRenderProcessHostDestruction to ClearCachedDataForContextID. BUG=371827 R=sdefresne TBR=sky (chrome/test/base/testing_profile.cc) Review URL: https://codereview.chromium.org/322983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276563 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=383153 Review URL: https://codereview.chromium.org/329723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276562 0039d316-1c4b-4281-b951-d872f2087c98
-
sorin@chromium.org authored
The idea here is to elminate the ambiguity about who owns what and protect about misuse by callers. BUG=381710 Review URL: https://codereview.chromium.org/318143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276561 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276560 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
This patch adds the upstream libaddressinput strings into the Chrome build inside of chrome/app/address_input.grd[p] to work well with the translation tools. This patch should precede using upstream libaddressinput to ensure that the upstream libaddressinput has the correct strings well ahead of using it in Chrome. Although the strings include postal code examples and links for error messages, these features are optional and can be turned off if undesired. BUG=327046 Review URL: https://codereview.chromium.org/304223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276559 0039d316-1c4b-4281-b951-d872f2087c98
-
ksakamoto@chromium.org authored
Blink-side change: https://codereview.chromium.org/324003002/ BUG=380988 Review URL: https://codereview.chromium.org/328973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276558 0039d316-1c4b-4281-b951-d872f2087c98
-
sashab@chromium.org authored
Changed the layout of the App Info Dialog according to UI feedback. This includes removing the tabs, and replacing it with a single, scrollable dialog that has all the information in a single pane. BUG=364681,266739 Review URL: https://codereview.chromium.org/327743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276557 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This is to get a baseline in tests so we can track coverage of future CLs. With this CL, 182 views_unittests pass (up from 125), but that's incidental. BUG=378134 Review URL: https://codereview.chromium.org/328103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276556 0039d316-1c4b-4281-b951-d872f2087c98
-
yunlian@chromium.org authored
BUG=chromium:373548 TEST=the warnings are gone. Review URL: https://codereview.chromium.org/318833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276555 0039d316-1c4b-4281-b951-d872f2087c98
-
alexst@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/325133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276554 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
Create ActionRunner wrapper API over TapAction and ClickElementAction. Add EvaluateJavaScript to ActionRunner. Replace all existing use cases. BUG=361809 Review URL: https://codereview.chromium.org/323833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276553 0039d316-1c4b-4281-b951-d872f2087c98
-
tiago.vignatti@intel.com authored
This CL adds MediaOzonePlatform, a new Ozone component for abstracting media and related. In particular it adds CreateVideoDecodeAccelerator method so Ozone implementations can use that for abstracting video decoding acceleration (i.e. GPU based video decoding). Eventually MediaOzonePlatform will be used as well for many windowing systems abstractions related to media, e.g. video encode, audio, etc. We will add support for these others as needed. Media platform is called and created on demand whenever a video playback is set to play. Different than ui::OzonePlatform methods, the one added in here is non-pure virtual so the implementations can decide themselves whether a video implementation is actually wanted, based on its hardware capabilities. This work is aimed at internal implementations like Ozone-DRI, Ozone-test but also for externals like Ozone-Wayland. Different targets like Chromium Browser, Chrome OS, ChromeCast and others can now take advantage of it. BUG=380884 TEST=manually on Ozone-Wayland, using: $ export GYP_DEFINES='chromeos=0 use_ozone=1 proprietary_codecs=1 ffmpeg_branding=Chrome' $ ninja -j16 -C out/Release content and to run: ~/git/chromium/src/out/Debug$ ./chrome --no-sandbox --user-data-dir=/tmp/chrome --ignore-gpu-blacklist ../../third_party/WebKit/PerformanceTests/resources/bear-1280x720.mp4 --vmodule=*/ozone/ui*=3 --v=0 additionally, in Release builds you can start chrome with --disable-accelerated-video-decode to compare the results. Review URL: https://codereview.chromium.org/269673005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276552 0039d316-1c4b-4281-b951-d872f2087c98
-
mateuszs@opera.com authored
This is initial work package to reflect this change, making it possible to add hi-resolution resources in the future (if needed). Review URL: https://codereview.chromium.org/327503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276551 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Some touch devices report either zero or unreasonably small touch sizes. While this doesn't present a problem for gesture detection, it does affect the behavior of the touch-derived gestures. For example, tap disambiguation is prevented if the tap gesture's size is sufficiently small. As a workaround, provide a platform-specific minimum gesture bounds length in GestureProvider. On Android, this value is the same as was used before the unified gesture detector, and on Aura we simply use half the default touch size. BUG=379876 Review URL: https://codereview.chromium.org/321563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276550 0039d316-1c4b-4281-b951-d872f2087c98
-
fangjue23303@gmail.com authored
BUG=380143 R=sdefresne TBR=shess (add sql to DEPS) Review URL: https://codereview.chromium.org/322113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276549 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
It should be in namespace views::internal. BUG=378134 Review URL: https://codereview.chromium.org/325163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276548 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
BUG=383251 TEST=run the test. R=fukino@chromium.org, mtomasz@chromium.org Review URL: https://codereview.chromium.org/325953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276547 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
BUG=None TEST=None R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/328183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276546 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
R=peria BUG=380615 NOTRY=true Review URL: https://codereview.chromium.org/329953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276539 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
Based on patch 290083004. Third party IMEs provide a privacy risk as they can monitor everything you type. The patch provides an additional measure of security by prompting the user for confirmation with a warning of the potential risks. BUG=367861 Review URL: https://codereview.chromium.org/325633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276535 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
ViewTest.RecreateLayers creates a layer hierarchy that includes child widgets and pulls an aura dependency into view_unittest.cc. This CL moves the test into a new file - view_unittest_aura.cc to isolate the aura dependency and allow view_unittest.cc to compile on MacViews. After this, an additional 56 views_unittests are compiling (39 pass). BUG=378134 TEST=views_unittests Review URL: https://codereview.chromium.org/329473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276534 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Move search_engine_type.h from chrome/browser/search_engines to components/search_engines Move prepopulated_engines* to components/search_engines TBR=asvitkine@chromium.org for the comment fix in tools/metrics/histograms/histograms.xml BUG=371535 TEST=git cl try Review URL: https://codereview.chromium.org/330433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276533 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276532 0039d316-1c4b-4281-b951-d872f2087c98
-
vivek.vg@samsung.com authored
Python 2.7.x includes pySerial version 2.5 as a distribution package. This conflicts with our repository version of pySerial i.e. 2.7. The submodule serial.tools.* was included in pySerial after 2.6 as per [1]. The utility function util.AddDirToPythonPath(...) appends the path at the end of the path list. Due to this, the python interpreter picks up the pySerial library from system include path at /usr/lib/python2.7/dist-packages/serial. This CL modifies AddDirToPythonPath(...) API to always prepend the path. [1] http://pyserial.sourceforge.net/pyserial_api.html#module-serial.tools.list_ports NOTRY=true Review URL: https://codereview.chromium.org/321773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276531 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/5713352a64936428d37a721382d021f4a9002172..b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749 TBR=scroggo@google.com NOTRY=true BUG= win_chromium_64 sync failure unrelated to this CL NOTRY=True Review URL: https://codereview.chromium.org/328163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276530 0039d316-1c4b-4281-b951-d872f2087c98
-