- 02 Sep, 2020 40 commits
-
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Use cases of these functions in TTS Engine are updated to use the new APIs. This CL does not change any behavior. Bug: 1060940 Change-Id: I8b5c3c4386e8d5c82172a5d34e0c4dc25b40257f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388124Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#803858}
-
David Bienvenu authored
Also fix some cpp lint warnings. Bug: 1010217 Change-Id: I5bb165e80cadfb435b417d80b438ac26a184add6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388905Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803857}
-
Alexander Surkov authored
Bug: 1115489 Change-Id: I6e63b50875abf7ee1296b72818c23d0c20cd2009 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365977 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803856}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598939551-51febd9296737e06a064f51f5c719578c85be72c.profdata to chrome-win64-master-1599025789-3a109ab6fe2db36da4d9ead01eda119b5774b91d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Iaf67bd4fb667af648b20ee9f10a17b28e5fbb75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803855}
-
Antonio Gomes authored
... and use WTF::HashMap instead. BUG=787252 R=guidou@chromium.org Change-Id: I4950b6fc9b677cdb0c26814373955f4addc68251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364216 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#803854}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc53046b29f8..121d985642fd 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 86334243 to 09df13c2 (356 revisions) 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f1315472247d to b0337a548273 (2 revisions) 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8a0ebd40f86d to c278dada96d9 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8ca08b0592b867a2f05c316a855b28af655d5323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390041Reviewed-by:
-
Raphael Kubo da Costa authored
WakeLockTest.LossOfDocumentActivity has been flaky since r803272 ("[HeapMojo] Make HeapMojoWrapperMode::kWithContextObserver default"), but that CL simply uncovered a bug in MockWakeLock: when the ExecutionContext is destroyed, MockWakeLock::OnConnectionError() may be called before we call MockWakeLock::WaitForCancelation(), in which case the latter will loop forever. Bail out early if |receiver_| is not bound, which indicates that there has been a Mojo connection error and MockWakeLock::CancelWakeLock() has already been called. Bug: 1123879 Change-Id: Ia2f29fe560a3d7ca49b083dfec01fdcd6c48a504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390065 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803852}
-
Simon Zünd authored
Instead of modifying TestExpectations, this CL changes the test to install a sniffer on the current, and the future method. This is only temporary and will be removed once sdk/RemoteObject.js is TypeScript-ified. R=tvanderlippe@chromium.org Bug: chromium:1011811 Change-Id: I4cdbde2cca81cf5548defaee71f680856ced6310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390340Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803851}
-
Gyuyoung Kim authored
OpenURLInterceptor introduced by crrev.com/c/2259537 couldn't intercept OpenURL method because OpenURLInterceptor should intercept the message of RenderFrameProxyHost interface instead of FrameHost interface. This CL makes OpenURLInterceptor intercept OpenURL method via RenderFrameProxyHost interface. TEST: SecurityExploitBrowserTest.InvalidRemoteNavigationInitiator Bug: 1093920 Change-Id: I64b7039e07186f9728e0d69ee6c4ba5298d98600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387548Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#803850}
-
Antonio Sartori authored
This CL completes the implementation of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#subsume-policy in the services/network Content Security Policy module. Bug: 1094909 Change-Id: I880d4b31044a15dffe054ed83c2080e302f6906c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315348 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803849}
-
Thiabaud Engelbrecht authored
This CL lets us schedule a purge of unlocked discardable memory from the foreground tab to run every minute. This is hidden behind a feature which is disabled by default, so there should be no changes to functionality. Bug: 1109209 Change-Id: Icb2474b1026e2283ccc772cd3a602d46ef628dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370655Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#803848}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/000948ecdba8..b7642c19404f 2020-09-02 fmayer@google.com Merge "Merge symbols into symbolized trace." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icfc706a436341ad3ffbef0e13d62111eafa6ec78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390044Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8e596ab5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: npm@chromium.org, yoavweiss@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0191abdacdb8b91236ef34ad6c022eb5bdc8df22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390280Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803846}
-
Samuel Huang authored
Android resource_sizes.py suppresses the following command line params to confirm to isolate script interface: --isolated-script-test-filter --isolated-script-test-perf-output The initial version of lacros_resource_sizes.py did not copy the suppression code, resulting in failure when integrated with a trybot. This CL fixes the issue. Bug: 1106626 Change-Id: Iee4cc1e1e9fba7e070b4c03ef6501fc259e1390a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389422Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803845}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Since all usage of the preference has been removed, the preference can be removed and existing settings cleared. Bug: 1104836 Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#803844}
-
Lukasz Anforowicz authored
This CL adds URLLoaderFactoryParams::debug_tag that can be used to differentiate URLLoaderFactory objects by their creator and log that information in the crash keys associated with an incorrect/mismatched request_initiator_origin_lock. This extra crash key should help ensure that the expected values are seen in the most common cases of DwoC seen in https://crbug.com/1056949. See also the "Callstack and request properties corresponding to the most frequent DwoC" section in a (Google internal) doc here: https://docs.google.com/document/d/1Q8UxpBLyv0SorQKLvY8M5npvyMroMlo9i6ZpUMol9aY/edit#heading=h.hquty15bu38n Bug: 1056949 Change-Id: I6add8fa24d87b715192acee19ff9d9a35e4e695f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388154Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8696f9a062e2..444c13c078a7 2020-09-02 daniel.l@hpcnt.com Fix tests in WebRtcVideoChannelBaseTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c7c619de341ff8729784676177f2a2ef1a2e9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390043Reviewed-by:
-
Liviu Tinta authored
I've observed some flakiness related to timeouts. Remove timeout promise in call to EventWatcher. Move around actual/expected in assert_array_equals. Bug: 1085549, 1085647 Change-Id: Icb18a6f7812557b77dfc4b5ae6b7af84b6dc478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388880Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#803841}
-
dpapad authored
Fixed: 1123801 Change-Id: Ie2749eafcd7970211d4cfd1e0e42b6a190b18085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389104 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803840}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that inherited properties that apply to text can be set on ::marker and should affect the marker text. Therefore, this patch allows 'hyphens', 'letter-spacing', 'line-break', 'overflow-wrap', 'tab-size', 'word-break', and 'word-spacing' in marker. Note it was already possibly to set these properties in the list item and the ::marker would inherit them. This patch just lets authors set them directly on the ::marker. I would have allowed 'text-justify' too but it's not enabled by default and in LayoutNG it has no effect on inline boxes (bug 1124043), so it didn't seem worth it. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-hyphens.html TEST=external/wpt/css/css-pseudo/marker-letter-spacing.html TEST=external/wpt/css/css-pseudo/marker-line-break.html TEST=external/wpt/css/css-pseudo/marker-overflow-wrap.html TEST=external/wpt/css/css-pseudo/marker-tab-size.html TEST=external/wpt/css/css-pseudo/marker-word-break.html TEST=external/wpt/css/css-pseudo/marker-word-spacing.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html Some tests fail in legacy because ::markers with 'content: normal' are not implemented with actual text. Change-Id: I2086854796fd355928591ee4c85f241337b33445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388384Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#803839}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/16ee2a22abb6..51a5e3389cef 2020-09-02 apodtele@gmail.com [truetype] Reduce Infinality footprint. 2020-09-02 apodtele@gmail.com [truetype] Refactor compensation color. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I0c88321ccd595fc0bd42045d41f1c2aa9346f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389461Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#803838}
-
Roman Aleksandrov authored
Bug: 1123899 Change-Id: Iecb14a15c714126b8eab2198368efc0ebe22d493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387022 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803837}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5e37cae6..581fdd9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide8aff2f7ad9e64069edf8dd8d928ef6f20e3459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803836}
-
Himanshu Jaju authored
Removes webrtc related code from Unido infra. Bug: 1114108 Change-Id: If56ec8e7ef1f656f92d349655cb74a499ff53311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386731 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803835}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ef8112b0c27..a62890115c98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC markusheintz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1021394,chromium:1085419,chromium:1106626,chromium:1119897,chromium:1121576,chromium:1122409,chromium:1122784,chromium:1123975,chromium:897470 Tbr: markusheintz@google.com Change-Id: Id38829ef606aade8aeca89ac4ba2479fb7e26019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389344Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803834}
-
Antonio Sartori authored
This CL implements the part "Does source list A subsume source list B?" of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#subsume-source-list in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: Id8cecc37c12a1db79cd0a97e616e0f46c98bdc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315145 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
Ewann authored
This CL updates the name and adds an image to this action. Bug: 1093302, 1121996 Change-Id: I915726687eff87649482d09cf40697a637a85806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387567Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803832}
-
Rouslan Solomakhin authored
This patch adds a test for JSON serialization of a very long networkData byte array passed into PaymentRequest API. Bug: 1110324, 1115091 Change-Id: I22418541b80205a58d1afc27595a95c7f84715db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348540 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#803831}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f94fc53d493..8696f9a062e2 2020-09-02 mbonadei@webrtc.org Adding documentation to become a WebRTC committer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib5f56a763b586972c51a68da43ca734422ce0250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389345Reviewed-by:
-
Himanshu Jaju authored
The flakiness is due to the check for file existing on disk. Needs further investigation, but re-enabling the test to ensure other checks for success case are still in place. Bug: 1123022 Change-Id: Ic04663c0670dd1ef2799e43e47d935445f47a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390160Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#803829}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I617f6cf6565c723a12bda5c942a6153b41ed9f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387760Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#803828}
-
Alexander Surkov authored
Bug: 1115489 Change-Id: I0eec812a35bab1d49183279c87e31d87e1216a8e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363840 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803827}
-
Yunke Zhou authored
Bug: 1107303 Change-Id: Ibbe21e221e2f46a4256d498547726174f336cad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372426Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#803826}
-
Stephen Nusko authored
This test is flaky on the nexus 5x webview. This is due to a timeout Exception. This was recently added in http://crrev/c/2367753. No-Try: True TBR: johnchen@chromium.org CC: behdadb@chromium.org,jonross@chromium.org,sadrul@chromium.org,yiyix@chromium.org Bug: 1124237 Change-Id: I9086c4f1a7b443fe35924cad15ea287bc6259c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390063Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803825}
-
Joanmarie Diggs authored
When AXSelection::Select is called to set the caret in an unfocused input, FrameSelection::DidSetSelectionDeprecated focuses the node by default. If this focus event happens to trigger a DOM mutation, the DOM tree version associated with the selection will not match the version associated with the document. As a result, when AXSelection::Select goes to cache the selection range, the DCHECK for this condition in SelectionTemplate<Strategy>::AssertValid fails. We can stop this condition from happening by using the same logic in FrameSelection::SetSelection, namely call SetSelectionDeprecated and if true, then call DidSetSelectionDeprecated -- but only after we have cached the selection range. If instead the DOM mutation is a consequence of the selection itself, there will be a similar check failures, both for the DOM tree version and the fact that layout is needed. Therefore, if a layout is pending immediately after we dispatch the selection start, update the layout, the AXPositions, and our stored DOM tree and Style versions. AX-Relnotes: N/A Change-Id: Ifbd63744d77db10b8895905a130b0b901cad3e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346329 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803824}
-
Nektarios Paisios authored
When an accessibility text or value changed event is raise, assistive software, such as VoiceOver and ChromeVox, doesn't really know how the previous text was modified. The event doesn't specify for example if: a character has been typed, a new line inserted, a piece of text has been cut, something was pasted, or the current selection replaced with a new piece of text. Assistive software, such as screen readers, need to either monitor key presses, or rely on heuristics to determine what to announce. This patch adds such information to text and value changed events through a list of event intents which describe the command that was carried out. R=dmazzoni@chromium.org, yosin@chromium.org AX-Relnotes: n/a Bug: 989156 Change-Id: Ie33cfd73d195086c80883315ee8fef13bdff251e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214951 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Four tests are updated to use the new API. This CL does NOT change any behavior. Bug: 1060940 Change-Id: I84280adbef886e727a008c2e9502a42c8ec08e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389203Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#803822}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c1ced4e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I470f2a24acb43e131ed223394c21d46e78f6badf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389900Reviewed-by:
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I0b245f28d1acc6a28251c0c4b19fc49b27047562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372564 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803820}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6eeb3d8bf667..bc53046b29f8 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a2e6c1a149f4 to e1051cbaad46 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I3e68fc301f0956cdd1bd9839de27ab7fcc11bf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389782Reviewed-by:
-
