- 31 Jan, 2020 40 commits
-
-
Ted Meyer authored
Also add a note saying it can be dismissed with a click. Bug: 1041809 Change-Id: I193c111666c340f9b064a023fbee9e08e1b55ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033635Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#737511}
-
Samuel Attard authored
When chromedriver is built with a dynamically linked ffmpeg on macOS we need to set the rpath so that ffmpeg.dylib is loaded correctly. Change-Id: I204810ac8610375aa8b0a2e7fae78464c1a3371e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033343Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#737510}
-
Eric Orth authored
Host resolution will soon use per-context result tracking for the DoH activation probes. ContextHostResolver now owns a ResolveContext that gets passed around in place of raw URLRequestContext to everywhere that will need access to per-context data (probe results, DoH server availability, server stats, etc). Minor behavior change because JobKey now contains ResolveContext. This means that requests from two different ContextHostResolvers will never be merged into the same job, even if both are given the same URLRequestContext. This shouldn't make a difference in practice because we only create ContextHostResolvers 1:1 with URLRequestsContexts. Bug: 1022059 Change-Id: Ia9b7bd4d1055630dbfdab627429638bb5f63eb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002899 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737509}
-
Ahmed Mehfooz authored
Expand message center / quick settings bubble when it gains accessibilityfocus. Allow quick settings to collapse / expand with chrome vox enabled. Bug: 1047538 Change-Id: I50626e7116ee51cd35f99199715501c6cb504d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032508Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737508}
-
Peter Kasting authored
This is slightly less verbose now, but mostly will be convenient in the future if/when updating things about the flex rule calling convention. Bug: none Change-Id: I59e41714abf2d23290e56350c0daa83f71419a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026588 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#737507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f18fddd279d2..9b0c794156ba Created with: gclient setdep -r src-internal@9b0c794156ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046904 Tbr: jbudorick@google.com Change-Id: I3854b0b85c20f9f62c43d8219edd820e0e5d56de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033594Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737506}
-
Jared Saul authored
With the release of the cardholder name fix flow on iOS and conflicts with Project Butter resolved in M76, we finally have feature parity across all platforms and can enable this feature by default client-side. Change-Id: I7ab9779188c3a1d913b998554568a6e03ef53415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017911Reviewed-by:
Manas Verma <manasverma@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#737505}
-
Mia Glaese authored
The identity disc visibility is set to gone on sign out. After it is set to gone, it is not considered onLoayout, but it keeps its position and size. Therefore the gone view will be hanging around the middle of the screen in landscape and overlay with the logo. Now we only consider views that are not GONE when determining whether the logo intersects with any sibling view. Bug: 1044914 Change-Id: I3b79119c3f6dad002a0cc8366677447b0146e1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020889 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#737504}
-
Lukasz Anforowicz authored
In some scenarios (e.g. http range requests for linearized PDFs) the PDF plugin may need to initiate requests on behalf of the PDF's origin. Such requests are currently proxied by the renderer process hosting the plugin (i.e. the renderer hosting the PDF extension - mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through URLLoaderFactory that is locked via request_initiator_site_lock to a different origin (i.e. the origin of the PDF extension, rather than the origin of the website that hosts the PDF file). Before this CL, such requests would be classified by CorsURLLoaderFactory::IsSane and VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly malicious. After this CL, the request_initiator checks are relaxed by PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism similar to AddCorbExceptionForPlugin exemption available for Flash. We don't want to relax request_initiator_site_lock checks for renderer processes hosting arbitrary origins from the web, so as a defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess that verifies the origin lock of the renderer process that is granted the extra capabilities. Relevant tests: - ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range request do not result in a request initiator lock mismatch) - PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF plugin may only be embedded in trustworthy contexts) - PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase tests non-range requests initiated by the PDF plugin) Bug: 1027173b Change-Id: Ib5111fd7a5d5b31727a9754c46c316e75def5143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986923 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737503}
-
Lukasz Anforowicz authored
[ This is a reland of https://crrev.com/c/1970834 + changes that remove a redundant test in //chrome/browser/portal/portal_browsertest.cc (see CR comments). Original CL description follows below. ] Tab contents may get focused during some renderer-initiated navigations (e.g. navigations from an NTP-replacement extension - see the regression test added in r723022). This CL ensures that the focus decision is applied not only to navigations that go through OpenURL, but also to navigations that go through (more freqeuent, usual) BeginNavigation. This change helps ensure that we retain the right focus behavior after more navigations switch to the BeginNavigation code path (e.g. after relanding ShouldFork removal in https://crrev.com/c/1949448). The CL covers both the OpenURL and BeginNavigation code paths by handling the focus decisions in a newly added TabContentFocusingHelper class (replicating/moving the focus decisions from OpenURL-only Browser::UpdateUIForNavigationInTab). Adding a new tab-helper class is useful, because the existing, OpenURL/BeginNavigation-shared navigation notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot distinguish between replaceState and new navigations (see also new steps in the OmniboxFocusInteractiveTest.NtpReplacementExtension test). While this CL changes how focus behavior is implemented, it should have no effect on end-to-end/high-level expectations of focus behavior (as observed by end users or browser tests). browser_tests do not guarantee window activation and/or focus, but before this CL navigation in browser_tests would focus WebContents. This is not happening after this CL, and requires moving a handful of focus-dependent tests from browser_tests to interactive_ui_tests. Bug: 1029161 Tbr: Karan Bhatia <karandeepb@chromium.org> Tbr: Rouslan Solomakhin <rouslan@chromium.org> Tbr: Brian Sheedy <bsheedy@chromium.org> Tbr: Bill Budge <bbudge@chromium.org> Tbr: Peter Kasting <pkasting@chromium.org> Tbr: Charlie Reis <creis@chromium.org> Change-Id: I7324e7ecb08a51601b12fba3f57c68af59f33128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024155Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737502}
-
Doug Arnett authored
This is a follow up to rename refactor in cl/2007319 to rename the corresponding test class for TranslateAgent. No functional changes. Bug: 1043351 Change-Id: I06db57f2b07c603f769e6dd4c8d9cda2f163659d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031191Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#737501}
-
Stephen Chenney authored
This completes the provision of reasons for all lifecycle updates. The next round of patches will use this information for UKM data and emit UMA for the most important reasons (particularly hit testing). A best effort has been made to associate the true reason, though in some cases code is used by multiple paths so there is some ambiguity. For metrics purposes that is unlikely to matter as it will still allow us to identify a small set of sub-systems for any performance regression. Bug: 902436 Change-Id: Iaff728a6fdf407af3c7cb70b81290553a59df2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033429Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#737500}
-
sczs authored
Fixed: 1040844 Change-Id: I99dea98fa8568b135b74e577004af4ed61fde731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031927Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737499}
-
Nick Harper authored
Change-Id: I20d563880bc4ddca37cd5a31143db23286c9a4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031438 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737498}
-
Sergio Collazos authored
This reverts commit dbdd4ac1. Reason for revert: This CL causes the Save/Update Password Infobar to stop presenting itself. Original change's description: > Fixing race condition in webState:didSubmitDocumentWithFormNamed... > > The FormData extraction code was racing against new page load even > though FormData was already passed into a function in string format. > Now the FormData is extracted from a passed in string. > > Bug: 418827 > Change-Id: I845b539974b57d1f430016f4500af5a4da5fcbf2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022771 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Maria Kazinova <kazinova@google.com> > Cr-Commit-Position: refs/heads/master@{#735936} TBR=dvadym@chromium.org,kazinova@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 418827 Change-Id: Id35a4cd9b09cd370281f705a903bcbb887485131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033580Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737497}
-
John Budorick authored
Fixes at least one test in content_browsertests that was increasing the minimum frame size above the current screen width. New screen dimensions roughly match the dimensions of the N5, N5X, and P2. Bug: 922145 Change-Id: Iaf7fca25bfc56abfedd647dcc80fdb378a7ab5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033685Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#737496}
-
Brandon Wylie authored
This flag can be used to turn the feature off if there are problems in production. Bug: 1031332 Change-Id: I69c158111daccf2c4cc7faf35450b1c55613192a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016205 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737495}
-
Anton Bikineev authored
The initialization of "char empty_" union-member in Optional is redundant and causes the compiler to generate extra code to ensure zero-initialization. Using an empty Dummy class for the union member is more optimal, since it guarantees that no code for its initialization is generated. Explicitly touching this char member in the constructor also causes a problem for conservative GC. Compiler is free to split shared and not shared parts of the union in separate memory locations on stack (or keep them in different registers). If a conservative GC is triggered at this moment, stack scanning may not find the correct object (this is exactly what happened in the bug 1044331). This can be tested in a minimized example: https://godbolt.org/z/t5q5ry. Bug: 1046776 Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737494}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c73475fb3c99..4dc1eb42a4de git log c73475fb3c99..4dc1eb42a4de --date=short --first-parent --format='%ad %ae %s' 2020-01-31 ynovikov@chromium.org Add UWP builders to CQ 2020-01-31 jgilbert@mozilla.com Allow overriding ANGLE_PLATFORM_EXPORT. 2020-01-31 cclao@google.com Vulkan: Disable restartRenderPassAfterLoadOpClear workaround 2020-01-31 cnorthrop@google.com Capture/Replay: Implement Manhattan ES 3.0 support Created with: gclient setdep -r src/third_party/angle@4dc1eb42a4de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I476f7b9130978a6dfacbd1318beb1f4d61ed8d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737493}
-
yilkal authored
This CL adds WebTimeActivityProvider which is BrowserListObserver, a TabStripModelObserver, AppServiceWrapper::EventListener, and WebTimeNavigationObserver::EventListener. It is hosted in AppTimeController. The instance of this class observes the TabStripModel of each Browser in BrowserList. It also observes the WebTimeNavigationObserver instances of each WebContent hosted in each Browser window. The instance also observes AppServiceWrapper to learn about the activation/deactivation of chrome application windows. WebTimeActivityProvider informs its observers when Chrome becomes Active, Active with whitelisted content or inactive. Bug: 1034551 Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737492}
-
Yao Xiao authored
What: Record a use counter whenever a large sticky ad is detected on a page. Large sticky ads stands for ad iframes with size >30% browser viewport size, and stick to the page regardless of a user’s efforts to scroll. Why: We’d like to learn where and how often they are used, as a signal to Centrifuge and eventually to unload them automatically as a browser intervention. How: Add a StickyFrameTracker to FrameView that tracks and stores the latest 10 viewport_offset/main_frame_scroll_offset through FrameView::UpdateViewportIntersection, which will be called whenever there's a scroll on the main page. Apply the detection heuristic (see sticky_frame_tracker.h) and record a use counter as necessary. We calculate/propagate the flag can_skip_sticky_frame_tracking to child frames to save the cost of most rendering/sticky-tracking, as most frames should be small so we could skip tracking its children. However it's still hard to gauge the performance impact of those cases that needs the extra renderings, so hide this functionality behind a feature flag. Bug: 1013070 Change-Id: I17d65ac915593ea3496bd6391fe6e163f0c57e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852105 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#737491}
-
Kenneth Russell authored
After many recent changes, including the switch to Skia Gold for maintaining baselines, this test is passing at least on the Nexus 5, 6, 5X, 6P, and 9 on the chromium.gpu.fyi waterfall. Remove the global suppression for [android no-skia-renderer]; will re-add specific suppressions if needed. Bug: 927107 Change-Id: I370fa474a3bd006ae7dff6cdff92b4bfec85c55b Tbr: ccameron@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033565Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737490}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e98c0e1d115..c0c0522e8076 git log 3e98c0e1d115..c0c0522e8076 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 mtklein@google.com let's try to fix nullptr + k 2020-01-31 robertphillips@google.com Minor GM cleanup 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-31 drott@chromium.org Remove CGFontRef parameter from SkMakeTypefaceFromCTFont 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-31 jvanverth@google.com Enable async MTLLibrary and MTLRenderPipelineState creation. 2020-01-31 jlavrova@google.com Small fix: 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ee07cb317579..e196bc85ac2d (3 commits) 2020-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 430def835f9f..79b36b640692 (6 commits) 2020-01-31 herb@google.com Add reverse iterators to SkSpan 2020-01-30 herb@google.com Cleanup GrStrike management because we do not abandon strikes 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-30 fmalita@chromium.org [sksg] Clean up public headers 2020-01-30 scroggo@google.com Expose the ICC profile from SkAndroidCodec 2020-01-30 mtklein@google.com pdf rasterization 2020-01-30 egdaniel@google.com Update GrSurfaceProxy::Copy to return a view. 2020-01-30 hcm@google.com update release notes page to include M81 2020-01-30 hcm@google.com new section and formatting 2020-01-30 brianosman@google.com Reland "Fix skshaper in component builds" 2020-01-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-01-30 rosasco@google.com Change fidl tables from cpp to c. 2020-01-30 robertphillips@google.com Add compressed backend textures to Metal (take 2) 2020-01-30 jlavrova@google.com Fix placeholders in cache 2020-01-30 jlavrova@google.com Dead code 2020-01-30 hcm@google.com Update Skia milestone to 82 2020-01-30 halcanary@google.com decs/examples: Support more fiddle types: offscreen, srgb 2020-01-30 brianosman@google.com Revert "Fix skshaper in component builds" 2020-01-30 brianosman@google.com Revert "Use separate SKSHAPER_DLL define to activate shared library logic" 2020-01-30 fmalita@chromium.org [skottie] Cleanup: convert remaining effects to new adapter pattern Created with: gclient setdep -r src/third_party/skia@c0c0522e8076 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033478 Tbr: reed@google.com Change-Id: Ie0574670c81ea0aeecbd094e9f55876885334da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737489}
-
arthursonzogni authored
content's CSP are gone. They have been merged into network::mojom's CSP. This patch updates the content/common/native_types.mojom to reflect this. See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I1b254e196f5162844d9f9ae2b466b17259d8a07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030963 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#737488}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I34d9be35fa6f05f872e2f306ede93bb02f45269b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737487}
-
Eugene But authored
This CL adds 2 new user actions: - MobileLocationBarTapped - MobileToolbarSearchButtonTapped And documents MobileOmniboxFocused as not_user_triggered, because MobileOmniboxFocused is logged far from the actual UI action handler. These 2 new metrics will allow to distinguish the way how omnibox was focused (tapping search button on bottom toolbar vs. tapping the omnibox). This CL will help to improve the quality of breadcrumbs logs, which is attempt to attach steps to reproduce to crashlogs. Breadcrumbs will ignore MobileOmniboxFocused and will log MobileLocationBarTapped, MobileToolbarSearchButtonTapped and MobileFakeboxNTPTapped. Bug: 1046223 Change-Id: Iae681615fb9eae491618f93f44a251e8c515eca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031879 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#737486}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/261f792f836a..9d56b0113fff git log 261f792f836a..9d56b0113fff --date=short --first-parent --format='%ad %ae %s' 2020-01-31 steveanton@webrtc.org Re-enable a couple PortAllocator tests under ASAN 2020-01-31 steveanton@webrtc.org Remove benwright@webrtc.org from WATCHLISTS 2020-01-31 danilchap@webrtc.org In RtpFrameReferenceFinder VP8 clean not yet received before filling it Created with: gclient setdep -r src/third_party/webrtc@9d56b0113fff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3fd9a8efdbc97eafad63c8850d885cc8837a11ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737485}
-
Rouslan Solomakhin authored
This patch passes the origin of the iframe that called the PaymentRequest API to the fetcher of manifest files, which uses it for sec-fetch-site headers. This patch is for service worker based payment handlers on both Android and desktop. This patch does not alter how iOS or native Android apps work. Bug: 966507 Change-Id: I97b6ca08fd9e08d1762f95d7b78edf7d73450aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636635 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#737484}
-
Francois Doray authored
The DCHECK passes most of the time, but not always. It is inherently racy, as external code could change the thread priority between when we set it and when we DCHECK it. Removing it as the failures are not actionnable. Bug: 1044882 Change-Id: I0adb7a801c10fb15ada3ed229175fb08c0232b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031705Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#737483}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Id810a00d8135d6e742f314bc01573aa3fe7c463c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032330 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#737482}
-
David Dorwin authored
Change-Id: Ia549368f095c81a296081aacaf8fd6a05da2b4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026407Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737481}
-
Ovidio de Jesús Ruiz-Henríquez authored
This reverts commit 57213418. Reason for revert: Causing compile error in win-chrome builder: https://ci.chromium.org/p/chrome/builders/ci/win-chrome Original change's description: > [3P blocking] Fix tests accessing the ModuleDatabase on the UI thread > > The ModuleDatabase was moved to its own sequence but both the > IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest > test fixtures were not updated. > > This CL moves the accesses to the ModuleDatabase instance to the right > sequence. > > Also added an override for the OutOfProcessQuarantine feature to allow > local testing. This was not an issue on the bots because they respect > the fieldtrial_testing_config.json file. > > Bug: 850517 > Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737448} TBR=chrisha@chromium.org,pmonette@chromium.org Change-Id: I6067a3b50bb835025807ff1b81e7787cda35625d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033634Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737480}
-
Christopher Thompson authored
This adds an exemption for legacy TLS errors from being fatal errors. This also adds a browser test (to ensure the interstitial is always bypassable) and a unittest (to ensure that legacy TLS errors aren't marked as fatal). Bug: 1047777 Change-Id: Ia50bff281d7c68f4f678e9b6209f7bc7aaa495f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033644Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#737479}
-
Joe Downing authored
I noticed that we leave a crufty debug.log file in the directory when our MSI is removed. I added a custom action to clean it up so we don't leave cruft on the system during upgrades or uninstalls. Change-Id: Ibbb13dcdcbc60dc95c3db4996d1243637354afe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033625Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#737478}
-
Charlene Yan authored
the editor bubble. Bug: 1040657 Change-Id: I532ffcc9257e038292f7a3d2d33ae31a50744558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028161Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737477}
-
Andrew Grieve authored
* Remove no-longer-relevant default exclude filter for assets/unwind_cfi * Fix diff size colorings not being correct upon first load * Make method count mode size colorings a thing * Add a devtools log message to show how to query the web worker Bug: None Change-Id: I27344c50ee0c6d1a93b97055fa7d2176fff263c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032807 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737476}
-
Annie Sullivan authored
These will be used to debug extreme outlier values of the PageLoad.InputDelay3 histogram. First, add all event types used to calculate PageLoad.InputDelay3 to Event.Latency.OS. Move the calls to generate the histogram into the functions that build the events, because the calling functions for the new event types have much more complex logic. Second, add new versions of Event.Latency.OS without the call to ValidateEventTimeClock(). This call fixes some potential causes of extreme values, so adding histograms which do not include it can help determine if it masks the problem. Bug: 1039833 Change-Id: I48cfa3613dd7c6a1d15b75e7a91f53b3f46a90c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022346Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737475}
-
Elly Fong-Jones authored
These are largely straightforward. Bug: 1011446 Change-Id: Ifaf8be23c5e64743beafa0025817e3e0271788e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033437 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737474}
-
Sam Bowen authored
The C++ code generated will be used in Blink's document_metadata_extractor. Bug: 1044250 Change-Id: I49db529fa95bf6868eabeb6f0718476fd904898a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029010 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#737473}
-
Sven Zheng authored
I can't repro locally nor using mb tool to repro. mb tool can only launch jobs in chromium.tests pool which is a different pool than internal bots. I hope with the android id logged, we can find out what's going on on the server side. Bug: 1043347 Change-Id: I70ac3005b0b568284a18d76b35dee160d27c00b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031537Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#737472}
-