- 07 Feb, 2019 40 commits
-
-
Cecilia Ni authored
This CL changes all the "==" in JavaScript to "===", to adhere the style guide. Bug: 906508 Change-Id: I77961c553c71decb313560b5cadf89c28fda99c1 Reviewed-on: https://chromium-review.googlesource.com/c/1454111Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#629832}
-
Avery Musbach authored
When you enter docked mode while tablet mode is forced via chrome://flags#force-tablet-mode, that setting to force tablet mode shall still be respected, whereas the current behavior is to enter clamshell mode and then stay in clamshell mode even if the lid is flipped to tablet position. Test: TabletModeControllerForceTabletModeTest.DockInForcedTabletMode Bug: 929373 Change-Id: I3d0c2ec937f424b02c53ee1d2ab9019271f7f1d0 Reviewed-on: https://chromium-review.googlesource.com/c/1457466Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#629831}
-
Kai Ninomiya authored
Bug: 905001, 929398, angleproject:1465 TBR: kbr@chromium.org Change-Id: Id567b273948df0cab079c1a5d32b5c413e1fd1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1453939Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#629830}
-
Nigel Tao authored
BUG=826982 Change-Id: Ieae4773919ec7446cefe41cf497d907386cc890f Reviewed-on: https://chromium-review.googlesource.com/c/1454110 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#629829}
-
Maksim Ivanov authored
Add an enum that identifies the type of the component that initiates an extension messaging channel (e.g., whether the sender was an extension or a web page). Pass this enum alongside with the source's ID in function parameters and IPC messages. This is a preparatory change for adding possibility of initiating extension message channels from native applications. The new enum will allow to easily distinguish between multiple cases when the sender's ID is nonempty, most importantly between the case of an extension and the case of a native application. This is a pure refactoring CL, no functional change is expected. BUG=chromium:898746 TEST=existing unit and browser tests; additionally executed with each of the switches "--enable-features=NativeCrxBindings" and "--disable-features=NativeCrxBindings". Change-Id: Ic4267c17efb3ac2b99c6af701d950032c1592a77 Reviewed-on: https://chromium-review.googlesource.com/c/1424804 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629828}
-
Brandon Wylie authored
This is an attempt to reduce the memory footprint LevelDB has on the Feed experiment. This will reduce performance, but also reduce the impact Feed has on memory usage. We want to prioritize memory here. Bug: 914597 Change-Id: I42e36b126606cadd5212dab620aef867acdc8f76 Reviewed-on: https://chromium-review.googlesource.com/c/1387948 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#629827}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7771f58c7f24..96e1911b0bad git log 7771f58c7f24..96e1911b0bad --date=short --no-merges --format='%ad %ae %s' 2019-02-06 bryan.bernhart@intel.com Memory manager: buffer uploads (Vulkan) - Part 2 Created with: gclient setdep -r src/third_party/dawn@96e1911b0bad The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5eab8b0c3b39791b1880c61b2c87b498379769c0 Reviewed-on: https://chromium-review.googlesource.com/c/1457536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629826}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e98954c35e97..7ca375c8ca54 git log e98954c35e97..7ca375c8ca54 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 sprang@webrtc.org Implement encoder overshoot detector and rate adjuster. Created with: gclient setdep -r src/third_party/webrtc@7ca375c8ca54 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I12fbd0a46074d7eb4241236acb8892bda8dd9ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1456605Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/740db7fd2795..f9cc785c3f6a git log 740db7fd2795..f9cc785c3f6a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 cnorthrop@google.com Docs: Add glmark2 instructions for Android 2019-02-06 spang@chromium.org Vulkan: Move vulkan config target to $angle_root:vulkan_config 2019-02-06 jonahr@google.com Fix ShCompileTest.DecimalSepLocale failing on Linux/AMD Created with: gclient setdep -r src/third_party/angle@f9cc785c3f6a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ib2901b6f4d6d80758b0f7c81952adb1abd124103 Reviewed-on: https://chromium-review.googlesource.com/c/1456612Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98385ba6c5c6..c1a2ea33a340 git log 98385ba6c5c6..c1a2ea33a340 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 halcanary@google.com bin/gn format gn/skia.gni 2019-02-06 herb@google.com Remove the distinction between key and device descriptors 2019-02-06 bungeman@google.com Roll HarfBuzz 2019-02-06 halcanary@google.com SkLoadICU: simplify 2019-02-06 robertphillips@google.com Move GrContextPriv methods to their own .cpp file 2019-02-06 mtklein@google.com add mad() and shuffle() to SkVx 2019-02-06 csmartdalton@google.com Add a GpuGM class for GPU-only tests 2019-02-06 mtklein@google.com fill in most remaining skvx operations 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-06 herb@google.com Remove filterRec bypass on MakeRecAndEffects 2019-02-06 rmistry@google.com Have the RecreateSKPs bot upload to partner bucket 2019-02-06 herb@google.com Reorganize MakeRecAndEffects and SkScalerContext ctor 2019-02-06 reed@google.com per-contour variant of SkPathMeasure 2019-02-06 rmistry@google.com Remove PerCommit-Bookmaker Created with: gclient setdep -r src/third_party/skia@c1a2ea33a340 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2487c1ff67762d46030138a7fab29a3437bdcc71 Reviewed-on: https://chromium-review.googlesource.com/c/1457277Reviewed-by:
-
Dave Tapuska authored
Frames that aren't loading are not visible in the viewport will be frozen if --enable-features=FreezeFrames is provided. This will eventually be converted to testing feature policies for frames. BUG=907125 Change-Id: Ib0badb3f92df4ce4921dd4a4cb29c45749f64f47 Reviewed-on: https://chromium-review.googlesource.com/c/1450406Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#629822}
-
W. James MacLean authored
The associated bug was closed a long time ago, so updating the comment is long overdue. TBR=nasko@chromium.org Bug: 470662 Change-Id: I510b1a51f32f2e11291ddede7c20328558eafc4b Reviewed-on: https://chromium-review.googlesource.com/c/1456939Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#629821}
-
Sami Kyostila authored
This patch fixes a crash when a GPU channel is established on the IO thread while the BrowserGpuChannelHostFactory is being terminated on the UI thread. If the factory has gone away when the channel is established, don't try to set another timeout to re-establish it. Bug: 863341 Change-Id: I084de6110d0de3a1eedf29d81211eb62405f1376 Reviewed-on: https://chromium-review.googlesource.com/c/1456061 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#629820}
-
Erik Jensen authored
Bug: 679313 Change-Id: Iae29d398c31e8791420ab27ce6cf08d46db79574 Reviewed-on: https://chromium-review.googlesource.com/c/1447311 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#629819}
-
Gayane Petrosyan authored
image is specified. Bug: 929393 Change-Id: Id7a0ad132f2266e4e5ce5843034379ceca3c468c Reviewed-on: https://chromium-review.googlesource.com/c/1457336 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629818}
-
Reilly Grant authored
The device chooser dialog code is now flexible enough for this to be enabled. The popup will be visible as long as the requestDevice() API is called with a user gesture and the WebContents has an associated Browser which means it works from tabs and app windows but not from the background page. Bug: 770896 Change-Id: I0a6df9934099ba3c243e468d4bcd22c1ce9acad3 Reviewed-on: https://chromium-review.googlesource.com/c/1448239 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#629817}
-
Min Chen authored
Bug: 926990 Change-Id: I9db8486d10837c8af29aaa19c6f534f4be768670 Reviewed-on: https://chromium-review.googlesource.com/c/1453538Reviewed-by:
-
Sky Malice authored
Bug: 928782 Change-Id: I448b7882f13c12ff39c4774ef750cfbf22f1b5ad Reviewed-on: https://chromium-review.googlesource.com/c/1456998Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#629815}
-
Anne Lim authored
This is a reland (with modifications to accommodate recent changes) of https://chromium-review.googlesource.com/c/chromium/src/+/1446665 StrikeDatabaseV2 is now explicitly enabled or disabled for all Strike-related tests. Bug: 884817 Change-Id: I1d0f483db82593872a903fa259afe2fba44bfaf5 Reviewed-on: https://chromium-review.googlesource.com/c/1455107Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#629814}
-
Jimmy Gong authored
- RequestUpdatedSharePathCallback is injected to SmbFileSystem in the constructor. - Allows SmbFileSystem to request an updated share path. Bug: 922273 Test: compiles Change-Id: Ie748a19febb88929216d092d8916c33e7cc271f3 Reviewed-on: https://chromium-review.googlesource.com/c/1445233 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629813}
-
Lei Zhang authored
Change-Id: I0d096d161eb4d98fce431eb9db8cb1df58ddd2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1457019 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629812}
-
Nigel Tao authored
BUG=826982 Change-Id: I12fd7ed12431a8d89c0fd3f7070cbeb8b1bd3ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1455837 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Leo Zhang authored
Export 2 functions so the XKB extension can handle messages in text or protobuf format from Engine side. Bug:837156 TBR=shuchen Change-Id: I5cdd77818f4e0692d99743d02436f0e00d63edd0 Reviewed-on: https://chromium-review.googlesource.com/c/1448082Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#629810}
-
Ahmed Fakhry authored
We used to use default sunset / sunrise times (6pm to 6am) whenever we couldn't retrieve a valid geoposition. This led to a bad user experience and confusion, especially in the event when there's no connectivity. Now we store the most recent valid geoposition in the user's prefs, and use it only until a valid geoposition is available. We make sure that these cached values don't leak from one user to another. BUG=923713,928994 TEST=Added a new test. Change-Id: I613df0ced6f474d11ec52dba3a3766582ed3d02e Reviewed-on: https://chromium-review.googlesource.com/c/1450838Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#629809}
-
Justin Cohen authored
Sometimes the underlying ios/web page used for the NTP (about://newtab) takes a long time to load. Loading any page before the newtab is committed will leave ios/web in a bad state. Instead, block any most visited and content suggestion taps until the underlying NTP is committed. See: crbug.com/925304 for more context. Remove this when ios/web supports queueing multiple loads during this state. Bug: 929148 Change-Id: I78bf8c58127c19f96432e68510c1565ad4b6d973 Reviewed-on: https://chromium-review.googlesource.com/c/1456645Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629808}
-
Jun Mukai authored
Bug: 826614 Test: exo_unittests Change-Id: Ia2fe9a39c38b0ea93d1f0a0f5aa820536a656a08 Reviewed-on: https://chromium-review.googlesource.com/c/1399722 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#629807}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/971e4cb2b43d..f0a00cd7f17b git log 971e4cb2b43d..f0a00cd7f17b --date=short --no-merges --format='%ad %ae %s' 2019-02-06 dhanyaganesh@chromium.org build_status_lib: Replace cidb handle with buildstore argument 2019-02-06 dhanyaganesh@chromium.org BuildStore: add an optional argument 'for_service' to __init__ 2019-02-06 evanhernandez@chromium.org cros_branch_unittest: Comment tests. 2019-02-06 evanhernandez@chromium.org cros_branch_unittest: Simplify all tests. 2019-02-06 evanhernandez@chromium.org cros branch: Support create from local manifest. 2019-02-06 evanhernandez@chromium.org cross branch: Sync happens in BranchCommand class. Created with: gclient setdep -r src/third_party/chromite@f0a00cd7f17b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7528b9f3c338eae12af8ff69ee41a40a326836a5 Reviewed-on: https://chromium-review.googlesource.com/c/1456611Reviewed-by:
-
Garrett Beaty authored
Bug: 925575 Change-Id: Ia337a7a22f1b60523257e6eb037536b7ef55bf15 Reviewed-on: https://chromium-review.googlesource.com/c/1457220 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#629805}
-
Alex Khouderchah authored
Prior to chromeos CL:1452314, shill used kFailureUnknown to represent both unknown failures and no failure. Consequently, the metrics we collect on connection failures suffer from this ambiguity as well. This change modifies the ConnectionFailureReason enum such that these two cases can be distinguished. In order to preserve historical data for of other failure values, we deprecate the existing unknown failure value and create two new values, rather than simply renaming the enum entirely. BUG=chromium:596197 Change-Id: Icdcc91365a1fd5c26a0ddd999e81b99a7a984a84 Reviewed-on: https://chromium-review.googlesource.com/c/1457123Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Cr-Commit-Position: refs/heads/master@{#629804}
-
Steven Bennetts authored
This CL moves the logic in network_icon::GetDefaultNetworkImageAndLabel, which currently makes multiple calls to fetch the active networks when a default icon is required (tray and feature pod) and moves it to a separate ActiveNetworkIcon class owned by the system tray model. Note: There should be no behavior changes with this CL. Bug: 923444 Change-Id: I79c3d6a30c2d48079dd3f237c9e2ff27fdae38fe Reviewed-on: https://chromium-review.googlesource.com/c/1447318 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629803}
-
Dmitry Gozman authored
This patch makes RenderFrameImpl load the full mhtml response body before trying to commit it. This is required for synchronous commit (see doc linked to the bug, steps 8.a and 8.b), because we have to parse the archive to retrieve the main resource and its mime type and commit a correct document type. Brief summary: - Introduced MHTMLBodyLoader which consumes data from existing NavigationBodyLoader and puts it all to WebNavigationParams. - Split RenderFrameImpl::CommitNavigationWithParams from CommitNavigationInternal so that we can commit mhtml after loading the response asynchronously. Most of the time we just call CommitNavigationWithParams synchronously. - DocumentLoader now tries to commit mhtml synchronously, and loads empty document if that fails (similarly to archive parsing failure). Bug: 855189 Change-Id: Id27a4e593c1586e1f48591ee0685fdb93aaf8827 Reviewed-on: https://chromium-review.googlesource.com/c/1408351 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629802}
-
Zhongyi Shi authored
Currently when running with --v=1, all the flags are printed whenever QUIC_RELOADABLE_FLAG_COUNT* is hit, a single flag may be printed multiple times and is not very useful most of the time. Change-Id: Icc8e702a4b5855b243a1d72337d03e924e7d2756 Reviewed-on: https://chromium-review.googlesource.com/c/1456952 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#629801}
-
Zhenyao Mo authored
They become obsolete after https://chromium-review.googlesource.com/c/chromium/src/+/1448518 BUG=924148 TEST=bots R=piman@chromium.org,dcheng@chromium.org Change-Id: I0ad5995caf4ea94c76712d76380072a28a5daeed Reviewed-on: https://chromium-review.googlesource.com/c/1450836Reviewed-by:
-
Takumi Fujimoto authored
The test was added in crrev.com/c/1446869 but has been flaky on Mac. Also add "Pass" as an acceptable outcome for RTCPeerConnection-track-stats.https.html. TBR=rtoy@chromium.org Bug: 929435 Change-Id: I37ef496d7d6f382ffad5dc8d75935d9faba8e225 Reviewed-on: https://chromium-review.googlesource.com/c/1457222 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#629799}
-
Clark DuVall authored
This reverts commit 11f8a9d4. Reason for revert: The crash still showed up in canary, and I have a better (simpler) fix for this. Original change's description: > Fix webRequest issues with redirects and extraHeaders listeners > > This is an alternative fix for http://crbug.com/918761, since the > original fix in http://crrev.com/c/1409915 caused some other issues and > had to be reverted (see http://crbug.com/926606). > > There are two issues that this fixes, both have regression tests in > this CL: > > (1) If a request using extraHeaders was redirected, it's possible the > OnBeforeSendHeaders event can come in from //net before > OnBeforeRequest has finished running on the newly redirected URL. This > was the cause of the crash, because it could cause situations like: > - request made to a.com > - redirect to b.com > - blocking listener running for OnBeforeRequest on b.com > - //net sends OnBeforeSendHeaders for b.com > - OnBeforeSendHeaders listener runs for b.com <- bad, should wait until > we know if OnBeforeRequest will cancel/redirect the request > - OnBeforeRequest finishes for b.com, may redirect the request and run > OnBeforeSendHeaders again before the bogus one is done > > This is fixed by holding the OnBeforeSendHeaders event until we know > OnBeforeRequest is finished, and canceling the old request if there is > a redirect. > > (2) If a request without a listener using extraHeaders redirects to a > request with a listener using extraHeaders, the listeners for the > redirected request will not get the additional headers. > > This is fixed by always using the extraHeaders path if there is any > extraHeaders listeners registered for the context. > > Bug: 918761 > Change-Id: I879ee6a78d34348fc15a80c27613b7ffbe66e749 > Reviewed-on: https://chromium-review.googlesource.com/c/1446367 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628905} TBR=rockot@google.com,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918761 Change-Id: Ie054dc4a84d05a69f982d41f158e7bfe23bb12ff Reviewed-on: https://chromium-review.googlesource.com/c/1457216Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629798}
-
Kevin McNee authored
We believe that this issue is now fixed, so we'll re-enable this DumpWithoutCrashing to confirm that there are no more occurrences of this. Bug: 828422 Change-Id: I3ab2b9b949ee50bf15d883b86a938bde46eafa9c Reviewed-on: https://chromium-review.googlesource.com/c/1456875 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
Alan Cutter authored
The methods BrowserNonClientFrameView::ShouldPaintAsThemed() and BrowserFrame::ShouldUseTheme() are used for the same purpose and have equivalent behaviour. This CL replaces ShouldPaintAsThemed() with ShouldUseTheme() to avoid divergence in behaviour. This is a follow up clean up CL to https://chromium-review.googlesource.com/c/chromium/src/+/1453558. There are no changes in behaviour in this patch. Bug: 927381 Change-Id: I2f4f28a79d0b24395057cb13f58ef8f56508ad20 Reviewed-on: https://chromium-review.googlesource.com/c/1453217 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#629796}
-
Jazz Xu authored
Enable native controls in Cros player by default. Remove integration tests for old controls. Bug: 909963 Change-Id: I40a08bfd51ab757ac74c14dbbf80129764670c19 Reviewed-on: https://chromium-review.googlesource.com/c/1427575Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629795}
-
Lei Zhang authored
Change-Id: I7cca1653fff5f990785d7c1cf28e83a6d96ba26e Reviewed-on: https://chromium-review.googlesource.com/c/1456981 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Wez authored
Migrate callsites from ComponentContext/zx::channel to strongly-typed APIs and ServiceDirectoryClient. Bug: 920920 Change-Id: I8fe642112562e3e75ad7230d55415d05e35b6cf8 Reviewed-on: https://chromium-review.googlesource.com/c/1450587 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629793}
-
