- 08 May, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1300ba188eee..81404f2d6e94 git log 1300ba188eee..81404f2d6e94 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 sugoi@google.com Ignore VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT at pipeline creation Created with: gclient setdep -r src/third_party/swiftshader@81404f2d6e94 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie3b12f771147016eed819c5fe2d24e5bbd151804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657588}
-
sangwoo.ko authored
Previously, animations were ticked by base::Timer. This wasn't aligned with Compositor so animation can jank or stutter. Thus, we need a way to use custom animation runner which is aligned to compositor's frame. In favor of layering, we should inject custom animation runner from a layer views/ or chrome/ to animation system. For this reason, AnimationRunner is introduced and clients can inject this dependcency via AnimationRunner. For example, Widget provides CompositorAnimationRunner which observes compositors animation frame. TODO: We need to investigate other callsites where gfx::Animation/LinearAnimations are used. Bug: 824026 Change-Id: Id4d7d88a38a823fea7c860510f11ba38f7eb4e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475023 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#657587}
-
Kent Tamura authored
This CL fixes a regression by crrev.com/632459. Suppose that we have the following XML document: <root xmlns:x="uri1"> <table xmlns="uri1"/> </root> XMLSerializer generated the following result: <root xmlns:x="uri1"> <x:table xmlns="uri1"/> </root> We don't need to run "retrieving a preferred prefix string" algorithm if the element has no prefix and its namespace matches to the default namespace. This is an error of the specification, and Edge, Firefox, and Safari match to this CL's behavior. This CL adds a testcase following the specification error, and the testcase fails with all major browsers. Bug: 958298 Change-Id: I3af9e643a9f91221e56024192f7257a82b6f18cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598929Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#657586}
-
Anne Lim authored
When Project Butter and the credit card upload cardholder name fix flow are shown at the same time, their respective (i) help icons are merged and tooltip messages get combined. Bug: 958637 Change-Id: I3cad0dc45b6ee4b0f4e6b006a538a1ac09e926eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595116Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#657585}
-
Asanka Herath authored
Setting the auth_path_ field of HttpAuthController was intended to be set to an empty string if the target of authentication was a proxy. Due to a typo, this branch was never taken. Instead HttpAuthController uses the full URL as provided by the caller. This change removes the unused condition and assumes that the input URL is already well formed. Bug: 927182 Change-Id: I79211e9c9e071dab8730255c56ca95409f8d7f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597109Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#657584}
-
Nate Fischer authored
This deletes a redundant block of code which manually checks arguments (this is already done by the argparse module). This resolves a bug, since this code references an undefined `actions` variable. Bug: 960598 Test: tools/grit/pak_util.py # useful help output Test: tools/grit/pak_util.py not-a-command # useful help output Test: tools/grit/pak_util.py repack # useful help output Change-Id: Idda7d8c16878c2cc99a1407eaeeb7c7d56f8d8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600605 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#657583}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d22a780f989..b2db64812c02 Created with: gclient setdep -r src-internal@b2db64812c02 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: I5a5eb27fb28531cf7844d4c47ea084006822a59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600383Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657582}
-
Maggie Chen authored
This reverts commit 4a3bc42c. Reason for revert: <The needed V8 change has been rolled in version 7.6.116. This CL can be checked in now. > Original change's description: > Revert "Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase" > > This reverts commit 23971187. > > Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.> > > Original change's description: > > Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase > > > > Increase max_old_space_size to 4 GB based on availability of physical memory. > > The purpose of this finch is to support web apps that require more heap space > > for their data sets > > > > Bug:958974 > > > > Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Commit-Queue: Maggie Chen <magchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656851} > > TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 958974 > Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657461} TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org Change-Id: Ifdd7cee050d3e9855539fee14dfd5dee608029ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600715Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657581}
-
Naoki Fukino authored
DocumentsProvider files have capabilities to rename/delete/createChild in a similar way as Drive files do. This CL make chrome.fileManagerPrivate.getEntryProperties handle DocumentsProvider files and return canDelete/canRename/canAddChildren metadata to update Files app UI (e.g. enable/disable context menu items) properly. Bug: 952104 Test: Tested manually on device, Ran unit_tests and browser_tests. Change-Id: Ibb7311776d79366b1ceb7717b51e8894e9ef8c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584522 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#657580}
-
Erik Luo authored
One step towards building a distance tool is to send rects to the overlay page, which will calculate what to draw. In this CL, rects for elements and individual text lines are sent and outlined in gray. In the future, the list of boxes will be fewer (only interesting elements) and gray outlines will not be shown. Drive-by: zooming the page w/ Cmd +/- now scales the boxes. Screenshot: https://imgur.com/a/n6a46YS Can be enabled in DevTools on DevTools via: `Main.sendOverProtocol( 'Overlay.setInspectMode', {mode: 'showDistances', highlightConfig: {}} )` Bug: 946873 Change-Id: I1d9aa0fb4fdc6aab435fb4d60ae8c24221475b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546504 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657579}
-
Eric Willigers authored
Test that contents of a shared file with acceptable file extension are received successfully. BUG=903010 Change-Id: I0608bc83899459ed14dfe1c8cc8f942163d5a64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594382 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#657578}
-
Makoto Shimazu authored
Bug: 956838 Change-Id: Ic3868a4f85fc8e4c13f07022800234978b870ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598390 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#657577}
-
Brian Sheedy authored
Changes aapt2 and bundletool to be installed from CIPD via copying instead of symlinking. This is a temporary workaround for swarming isolation not working properly with symlinks that point outside of the src/ directory, which is the case for things downloaded via CIPD. This can be reverted once symlinks are properly supported. Bug: 950727 Change-Id: I3b92959cf6e33e0d2edfd5adfc05d4b04ad7b909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599683 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#657576}
-
Andres Calderon Jaramillo authored
This CL disables the JpegDecodeAcceleratorTest.OddDimensions test when using V4L2: it's not high priority now since odd dimensions are not expected in camera captures. However, the bug is available and should be fixed prior to implementing general JPEG decoding for ARM devices. Bug: 852236 Test: None. Change-Id: I0c5be22d4dcfeb3cc279434a6fa4ebeca9692464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599628 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#657575}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aab823a8. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia30ac02c4d057e7161a9742f28d40a9e0dae7eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600596Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#657574}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4403107f9908..e5e444045846 git log 4403107f9908..e5e444045846 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e5e444045846 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1ce7747fa40746518f4e54e34fb6a188293a4c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657573}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/887824b5..f6bb591e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7bb213b86ec001b82ea430a70589dd45dfd5b441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657572}
-
Takashi Sakamoto authored
This reverts commit 712c3cf3. Reason for revert: This patch causes webkit-layout-tests failure on WebKit_Linux_Trusty_ASAN bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20ASAN/25720 Unexpected Failures: * external/wpt/css/css-scroll-snap/scroll-snap-type.html * virtual/threaded/external/wpt/css/css-scroll-snap/scroll-snap-type.html STDERR: ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x61200023f8d8 at pc 0x5620c924e56d bp 0x7ffde3c56830 sp 0x7ffde3c56828 STDERR: READ of size 8 at 0x61200023f8d8 thread T0 (content_shell) STDERR: #0 0x5620c924e56c in get ./../../base/memory/scoped_refptr.h:212:27 STDERR: #1 0x5620c924e56c in Style ./../../third_party/blink/renderer/core/layout/layout_object.h:1615:0 STDERR: #2 0x5620c924e56c in GetPhysicalSnapType ./../../third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc:88:0 STDERR: #3 0x5620c924e56c in blink::SnapCoordinator::UpdateSnapContainerData(blink::LayoutBox&) ./../../third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc:107:0 STDERR: #4 0x5620c924e74b in blink::SnapCoordinator::UpdateAllSnapContainerData() ./../../third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc:76:5 Original change's description: > Correctly handle scroll-snap-type changes to 'none' > > > Previously when a scroll container's snap type is changed to 'none' its > data was discarded including all of its snap areas. However this is > incorrect. Because while the snap type is 'none', the element is still > a scroll container which per spec [1] means that is should continue to > captures the snap areas in its subtree for whom it is the nearest > ancestor scroll container . The only difference is that it no longer > snaps. > > The fix is that we no longer remove the snap container data just > because is has a 'none' snap type and instead keep it and its snap > areas. But we check the snap type before performing any snap. > > To ensure this does not introduce any performance regression, this CL > also includes an optimization where we avoid re-calculating > snap_container_data when the snap type is 'none'. So keeping these snap > data should not be cheap. > > Note that there is another problem where if the current snap container > is no longer a scroll container (e.g., overflow: scroll => overflow: > visible) we release its snap areas and they become "orphan". But if we > are to do this correctly, we should re-assign these areas to the next > stroller in the chain. Similarly when an element becomes a scroll > container, it can potentially take over snap areas from its parent snap > container. > > > This patch does not address that situation yet but fixes the easier > problem. > > [1] https://drafts.csswg.org/css-scroll-snap/#overview > > Bug: 953575 > Test: > - wpt/css/css-scroll-snap/scroll-snap-type-change.html => Changing snap-type should work correctly > - wpt/css/css-scroll-snap/scroll-snap-type.html => Add a specific test for type 'none' to ensure it does not snap > > Change-Id: Ie493ad68ecba818ed41c0ee103ccf44725ff6e3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589899 > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657460} TBR=bokan@chromium.org,majidvp@chromium.org Change-Id: I3a327f6e342e95d045194d24ceaf49de52b2b921 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600437Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#657571}
-
Ehsan Karamad authored
The HeadlessContentRendererClient does not implement CreateBrowserPluginDelegate which causes a renderer crash in the headless mode for objects which set their type to "application/browser-plugin". This CL adds a null check to RenderFrameImpl to stop the crash. Bug: 958678 Change-Id: Ic90ecbded86e764fb81eb9796b5d9e2732966fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598323Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#657570}
-
Yusuke Sato authored
This reverts commit 6f1b99ba. Reason of the revert: With this CL, Chrome on R76-12184.0.0 (eve) crashes when an ARC++ app is launched. TBR=sandersd@chromium.org,dcastagna@chromium.org,dcheng@chromium.org,rjkroege@chromium.org BUG=957381 TEST=R76-12184.0.0 (eve) works with this revert Change-Id: I1d833880611b4d3d1c03e074ccfcb8db12d7acd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600792 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#657569}
-
jchen10 authored
This makes the query of GL_COMPLETION_STATUS_KHR to programs much cheaper by minimizing the round-trip to the GPU thread. Bug: 881152, 957001 Change-Id: Iadfa798af29225e752c710ca5c25f50b3dd3101a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586630 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657568}
-
Caroline Rising authored
Bug: 910739 Change-Id: I66a8c9465dfe3ec3a29792e56028491ee5733056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600399Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#657567}
-
Karan Bhatia authored
This is a reland of ac4285c8. We now ensure that all primitives in WebRequestInfoInitParams are correctly initialized. Original change's description: > Extensions: Make most of WebRequestInfo immutable. > > This CL makes most of the WebRequestInfo data members const. To achieve this, a > new helper struct called WebRequestInfoInitParams is introduced. This will help > with guarantees around WebRequestInfo's immutability. > > BUG=696822 > TBR=mmenke@chromium.org > > Change-Id: I36bd8284aca9e68e115fba94b579456902f968ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594066 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656970} TBR=mmenke@chromium.org Bug: 696822 Change-Id: Ib86bdf1ad6e66f80d86adb038fafcd0d341c937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600593Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657566}
-
Ilia Samsonov authored
Refactored TestLauncher to enable mocking in unit tests. Added couple of basic unit tests for TestLauncher. Bug: 936244 Change-Id: I67538d2bb3a05713905a8f6801a3b3bd9813afcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597958Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#657565}
-
Nektarios Paisios authored
Previously, if a user had set a selection on the page and then removed it by carrying out an action that would not otherwise refresh the accessibility tree, such as clicking with the mouse at a random location, the accessibility tree would never find out that the selection had been removed. R=dmazzoni@chromium.org, yosin@chromium.org Change-Id: I0f50accdc6715d706aeed84c051aa125709ae205 Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596150 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#657564}
-
Suman Kancherla authored
The optional attribute is only specified because the argument is a dictionary, XRRenderStateInit, with no required members based on https://heycam.github.io/webidl/#dfn-optional-argument. Bug: 956301 Change-Id: I5e3823e24b7e34310e31eb38dfc3affa8dce2796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599687 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#657563}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84e7932d2737..19905aea14e0 git log 84e7932d2737..19905aea14e0 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 ianelliott@google.com Vulkan: Set the Vulkan scissor to the GLES viewport 2019-05-07 tobine@google.com Vulkan:Only apply invariant pragma to output vars 2019-05-07 staphany@chromium.org Add using-declaration to support Googletest roll. Created with: gclient setdep -r src/third_party/angle@19905aea14e0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I169fefb2e8e5c4610ccb86a50ab32195f8e61720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657562}
-
kyle Ju authored
Command: python third_party/blink/tools/wpt_update_expectations.py Bug: 934919, 881513, 927187 Change-Id: I3248058c467711e605db890948bbe97f5311e260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484616 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#657561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7978f9cb6d33..5d22a780f989 Created with: gclient setdep -r src-internal@5d22a780f989 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: Ib9e3e937c03f9ddb2e42e4faf6e07f3fcb3e0081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600692Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/195bcae748c7..f8847c1a94bb git log 195bcae748c7..f8847c1a94bb --date=short --no-merges --format='%ad %ae %s' 2019-05-08 kbr@chromium.org Allow subproject in bug link in test expectations. Created with: gclient setdep -r src/third_party/catapult@f8847c1a94bb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sadrul@chromium.org Change-Id: I1f029fa6465f59a70a40461c11e52501a2432aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657559}
-
Daniel Libby authored
Currently the time between the finger touching down and the recognition of a scroll is not captured in any of our metrics (perhaps for good reason, since it is dependent on how fast the user initially moves their finger to get out of the slop region). We'd like to add this histogram to understand what this looks like for users in the wild. R=bokan@chromium.org, nzolghadr@chromium.org, tdresser@chromium.org Change-Id: I25c32bbd096c9f397588fbba8dc4ece198f6660a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590960 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#657558}
-
Kinuko Yasuda authored
This no longer seems to be needed. Change-Id: Ib3cc8c454fb8863b986a23882815013acee5d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598928 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#657557}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/73e2413865fc..a037b8b34eab $ git log 73e241386..a037b8b34 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 fkastenholz Refactor QuicFramer::Get...ConnectionCloseFrameSize 2019-05-07 quiche-dev unbreak TachyonIOS, remove const on bool return value in quick_session.h 2019-05-06 renjietang Use a QuicSession member to latch gfe2_reloadable_flag_quic_eliminate_static_stream_map_2. 2019-05-06 dschinazi Make client drop packets with wrong versions 2019-05-06 dschinazi Support IETF RETRY from client 2019-05-06 quiche-dev Create a helper that wraps a competing QuicEndpoint for Quartc simulator tests. 2019-05-06 ianswett gfe-relnote: n/a (Refactor) Move the only method in ConnectionCloseDelegateInterface into QuicPacketCreator::Delegate and delete ConnectionCloseDelegateInterface. No functional change, not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ic003434d2852fd3d65ca3b3c4215876f46f2fafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599709 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#657556}
-
Yusuke Sato authored
This allows us to pass more tests with --enable-features=AppServiceAsh. In some unit tests, the Profile object outlives ArcServiceManager. ArcApps object whose lifetime is equal to Profile's need to check if ArcServiceManager is still alive in its destructor. This CL requires Chromium >=r656870. BUG=None TEST=try TEST=unit_tests --gtest_filter='*AppSearchProviderTest.Basic*' --enable-features=AppServiceAsh TEST=unit_tests --gtest_filter='ArcAppModelBuilderRecreate.*' --enable-features=AppServiceAsh Change-Id: I6905eb01dcb6e69492b97dba2a7f9f7d90c986da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597125 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#657555}
-
Ben Kelly authored
This CL makes the following changes: * Modify URLLoaderClient::OnReceivedCachedMetadata() to take BigBuffer. * Make Blob::ReadSideData() return a BigBuffer. * Pass the BigBuffer through the ServiceWorkerSubresourceLoader. * Pass the BigBuffer down from URLLoaderClientImpl as a span. * Improve the tracing of WebURLLoaderImpl to show number of code cache bytes received. Bug: 867848 Change-Id: I49c30b66dacc85166de64fc1cc1049f79c81f9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599710Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#657554}
-
Mike Wittman authored
Checks that walking stacks from C++ through JavaScript and back to C++ works as expected. Bug: 909957 Change-Id: Ib881d082990df701c7f22da63cff89880b97764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590607 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657553}
-
Peng Huang authored
Bug: 959800 Change-Id: I990dd544fe1d3b1a4ceacc5eda5c98e9f5c5ce22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599856 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657552}
-
Hanfeng Zhu authored
This reverts commit 6a7745fd. Reason for revert: http://crbug/960172 Bug: 960172 Original change's description: > Disable signin promos for special users. > > Add a new method "isSignInPromoAllowed()" in SigninPromoController to > check whether promos are allowed. The reason is that in some regions > signing in may be problematic, thus promos should be suppressed. > > Bug: 948983 > Change-Id: I389b1d2d693a0bcb63571e78991f7287f734672f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548875 > Commit-Queue: Hanfeng Zhu <hanfeng@google.com> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647994} TBR=msarda@chromium.org,tedchoc@chromium.org,bsazonov@chromium.org,hanfeng@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 948983 Change-Id: I5b5ee040891272ae5010becf11529055a08c1324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596790Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Cr-Commit-Position: refs/heads/master@{#657551}
-
Mike Wittman authored
Platform expectations are that the stack is aligned to 8 bytes on 32-bit platforms and 16 bytes on 64-bit platforms. Having the stack buffer aligned will facilitate alignment-correct implementation within the stack copying itself. Bug: 956626 Change-Id: I217c1948d271839e22283f884adbaa6a14f1c4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593803 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#657550}
-
Chris Cunningham authored
We already have a use counter for decodingInfo(), but suppling the key system configuration implies EME usage, which is the recent foucs for investments and upcoming experiments. Bug: 953500 Change-Id: I22b07b1c579d7e7bb0427ec85c765ebec1629bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592696 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#657549}
-