- 28 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99221b12be67..9b9f09268b2b git log 99221b12be67..9b9f09268b2b --date=short --first-parent --format='%ad %ae %s' 2020-01-28 szuend@chromium.org Revert "Introduce more accurate breakpoint decoration waiter for web tests" Created with: gclient setdep -r src/third_party/devtools-frontend/src@9b9f09268b2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ae594dbf7a16c57420c106cdc1f23e51d71f6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024969Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735838}
-
Sylvain Defresne authored
As lpromero@ stopped working on Chromium, remove them from the OWNERS files (thus people will stop sending them CLs they won't review). Bug: none Change-Id: I0fb6aa9bf7774ff6dda6111c5238dae4ce1191db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023651 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735837}
-
Tanmoy Mollik authored
Add SyncErrorInfoBarAndroid to chrome://flags for the testing plan. Bug: 1044903 Change-Id: I1bcfbb381b21de92c0295daa6badfdbdd1723771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016631Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735836}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6136fdb28790..7a284e1614a3 git log 6136fdb28790..7a284e1614a3 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 jonaso@webrtc.org TCPConnection: Defer FailAndPrune by signaling to self Created with: gclient setdep -r src/third_party/webrtc@7a284e1614a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4fe1a93bbd81c41296b369b97e86c5006ed65f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024968Reviewed-by:
-
Marc Treib authored
It was used to check if "GCM is enabled" by calling a special API on the Sync service, but in practice this has always been true for years. Removing this code will let us (eventually) shut down this API. Bug: 1009361 Change-Id: I9de53187fc85e5b4eac0a7c566aafe36dbb3442c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017429Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735834}
-
Omer Katz authored
Tracing an HashTable involves checking whether keys are empty or deleted. This can result in data races with the mutator if the HashTable is modified while it is traced. To avoid such data races, we create a local copy of the key on the concurrent thread and perform the check on the copy. Using the local copy on the mutator thread would result in significant regressions. Measured locally on the facebook_infinite_scroll:2018 story from v8.browsind_desktop benchmark, showed an increase ranging from 70% to 110% in the time it takes to process ephemerons (this measurement doesn't cover all HashTables, just the ephemeron HashTable). To avoid these regressions, the local copy is used only for concurrent visitors. For further details see https://drive.google.com/open?id=13DTRcF3xfVjJ2QaKzAOYFzqvTfGRNiX6WWL3CCACSoM Bug: 986235 Change-Id: Ie135c1076bd1834ae7f8b97ca6446890fc30a02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012961 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735833}
-
Roman Aleksandrov authored
Create a list of component extensions which could not leak Signin profile. Unload all other extensions. Bug: 1036419 Change-Id: I2f055f9f0f36e59ffe99ea156796b0e3ef240dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980612 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735832}
-
Olya Kalitova authored
Removes translatable flag for Crostini container configuration messages. Bug: 1000287 Change-Id: Ia8878a0ba0624cb5629f4b6ec417239e688ff009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020970Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#735831}
-
Colin Blundell authored
This CL componentizes SSLErrorHandler for sharing with WebLayer. The componentization must be done together with that of CaptivePortalHelper as the two have a mutual dependency. After a *long* chain of leadup CLs, the actual componentization is now straightforward. \o/ NOPRESUBMIT=true Bug: 1030692 Change-Id: Idf572bfb45db2e4958028a9f361fa9498dc792f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022708 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#735830}
-
Rune Lillesveen authored
With BlockHTMLParserOnStyleSheets enabled, these unit tests needed RunPendingTasks calls to resume and finish the blocked parsing. Bug: 891767 Change-Id: Ie65a0ec884b70208bbbf2290ab86aa67684819bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014454Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735829}
-
Rakina Zata Amni authored
Attempting to reland https://crrev.com/c/1543258 which was reverted in https://crrev.com/c/1626417 because of a bug (not collapsing successive navigations into one), which is not a problem anymore now that PerNavigationMojoInterface has landed. With this CL, about:blank navigations (except initial navigations) will always go through the browser process. Some additional changes: - SitePerProcessBrowserTest.SubframeBlankUrlsAfterRestore is also updated in this CL because now about:blank navigations will use its initiator origin instead of the parent's origin when determining which SiteInstance it should use after getting restored. - about:blank navigation requests that go through the browser process got their referrer URL sanitized incorrectly, causing a WPT to fail, so we're updating Referrer::SanitizeForRequest too. Bug: 936696 Change-Id: I15adfc0ded269a9a10b1d4f5e820f3a627e9c101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006997Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#735828}
-
Rune Lillesveen authored
The method checks if the parser should be paused when a parser blocking stylesheet is added. That is currently for sheets in body, but that is not the only case with BlockHTMLParserOnStyleSheets enabled. Bug: 891767 Change-Id: I9597ed2072ad18ba4552b4b6bc98cca8b85c8e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023788Reviewed-by:
-
vitaliii authored
Disable DumpAccessibilityEventsTest _AccessibilityEventsDescriptionChangeIndirect _AccessibilityEventsDescriptionChangeNoRelation The comparison was made stricter in https://chromium-review.googlesource.com/c/chromium/src/+/2015429. These tests fail with the new comparison. TBR=aleventhal@chromium.org Bug: 1046298 Change-Id: I7739a5c69c6e3d7a0935e20d1b273a7b1939282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024889 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735826}
-
Yuki Shiino authored
We've been observing crashes at LocalWindowProxy::Initialize void LocalWindowProxy::Initialize() { CHECK(!GetFrame()->IsProvisional()); ... } through calls to ToScriptState. This patch patchworks to stop the crash by checking frame->IsProvisional() beforehand. This patch makes ToScriptState return nullptr when the frame is provisional, and it'd potentionally cause crashes on the call sites. (ToScriptState is designed to return nullptr in some cases, so the call sites must have been checking the return value.) Anyway, Blink has been crashing in the case that this patch is bailing out, thus the situation won't become worse. Bug: 1037985, 578349, 1046282 Change-Id: I9497aa740d7b1d14e400c5e416d4a988ff8f488e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024189 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Javier Ernesto Flores Robles authored
Disables testDeleteCustomSearchEngineSwipeAndTap which is failing on ios13-beta-simulator. TBR=sczs@chromium.org Bug: 1046290 Change-Id: Ibaef117159c9624f5e0b81eb28672f7bbcd9c3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023789Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735824}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7a76b287ab0..99221b12be67 git log b7a76b287ab0..99221b12be67 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 szuend@chromium.org Introduce more accurate breakpoint decoration waiter for web tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@99221b12be67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6093bf41b304bd62216548a270523245e875c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024908Reviewed-by:
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: I74e5e0a5cd729b92bfb22af60f60f5d094d78121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014969Reviewed-by:
-
Friedrich Horschig authored
This CL should have no visible effect (yet). By adding a reason whenever the autofill popup is asked to be hidden, the controller can decide whether it should close the popup immediately. This comes in handy when a popup is closed only to be reopened with fresh suggestions (see linked bug). With the reason, the popup can be kept open and directly updated which prevents flickering. TBR=vasilii@chromium.org TBR Reason: API change for autofill client. Bug: 1043963 Change-Id: I77cb4b920114c37012b9383508d04fc4250422c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015055Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#735821}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8a6f9a03f020..6136fdb28790 git log 8a6f9a03f020..6136fdb28790 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 saza@webrtc.org Whitespace change Created with: gclient setdep -r src/third_party/webrtc@6136fdb28790 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I254cce231a0461dfe8cdcb797933e4b978c1a84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024586Reviewed-by:
-
Finnur Thorarinsson authored
This CL creates a custom View (PickerVideoPlayer) to encapsulate the code in PickerCategoryView that relates to playing videos. The xml components have already been factored out to a separate xml, and this moves the corresponding Java code to a separate class also. Bug: 895776, 656015 Change-Id: I4435f3a02bf18bc7c1afb35f35f34cb156908544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016649 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Peter E Conn authored
Bug: 1040143 Change-Id: If698ecc2b828895ab7308e805ed7a1f81857c439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020706 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735818}
-
Sami Kyostila authored
Turn down the startup scheduler A/B test since it's not being tracked any longer. Change-Id: I4ec6b494fd88400d3d2f82bff6030a9ab82b92ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023548 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#735817}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b83d660071cb..a8bd48a1c523 Created with: gclient setdep -r src-internal@a8bd48a1c523 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8366962a63ab53ceb7192e4a9b5684e94af684fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024585Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735816}
-
Javier Ernesto Flores Robles authored
Disables ContentSuggestionsTestCase/testReloadPage which is failing on iphone-device. TBR=gambard@chromium.org Bug: 1046258 Change-Id: I8688122f2daab124b063059b6187f5fe0a7a6026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024888Reviewed-by:
-
Mikel Astiz authored
This reverts commit f52179a5. Reason for revert: dependencies not ready on Android. Original change's description: > Enable sync trusted vault support by default > > The feature is in a working state can be enabled by default. > > Bug: 1000146 > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731898} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000146 Change-Id: I24d9ed1570db010ebca418e428bfc6d0e8536c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020925Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735814}
-
Javier Ernesto Flores Robles authored
Disables failing tests on iphone-device: NTPHomeTestCase/testOmniboxPinnedWidthRotation NTPHomeTestCase/testTapFakeOmniboxScrollScrolled NTPHomeTestCase/testOmniboxWidthRotation NTPHomeTestCase/testFavicons NTPHomeTestCase/testTapOmniboxSearchButtonLogsCorrectly NTPHomeTestCase/testCollectionShortcuts NTPHomeTestCase/testTapSearchButtonFakeOmniboxScrolled NTPHomeTestCase/testOmniboxWidthRotationBehindSettings TBR=gambard@chromium.org Bug: 1046253 Change-Id: I7fd7a7b0f524ad9614f0f83fac0a4426ac28f7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023527Reviewed-by:
-
Yoshisato Yanagisawa authored
If we rebase the path, gn seems to confuse to set paths from current working directory to have chrome/ios directory. However, it should not have that. Since XCRun path won't be sent to Goma, we do not need to normalize that here. Bug: 1015730 Change-Id: If175706ae564cbf124c53f0e0e1255b439cea682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022046 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=peter@chromium.org Bug: 1042208 Change-Id: I06cfd4c1857415875049030e7d7f5c262050a079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017525Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4025.0-1579517934-benchmark-81.0.4019.0-r1 to 81-4028.0-1580121249-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I32a7f242d2d2972185540f72489f00da3345b0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024907Reviewed-by:
-
Yoshifumi Inoue authored
This patch Introduces |LayoutObject::BeingDestroyed()|, was |LayoutBlockFlow|, for ease of tracking life time of |LayoutObject|. Bug: 982194 Change-Id: I2203aac9a87afa61e5054f2659070b89fa5c9b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024131 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735809}
-
Colin Blundell authored
This CL cleans CaptivePortalTabHelper of its remaining //chrome dependency by passing in the CaptivePortalService from the embedder rather than obtaining it internally via the Profile. It also componentizes the class. Componentization of its unittest will be done in a followup. The motivation for this componentization is to enable the componentization of SSLErrorHandler for sharing with WebLayer. Bug: 1030692 Change-Id: Ibca11f2f3d603a411cfe03f00c26ca5be71ada33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019102 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#735808}
-
Delan Azabani authored
DeprecatedEqualIgnoringCase (“DeprecatedEqual”) returns true iff the two given strings are equal under non-Turkic case folding (full iff both strings are 16-bit, simple otherwise). DeprecatedEqual was deprecated in favour of EqualIgnoringASCIICase or EqualIgnoringUnicodeCase [1]. The former is usually the appropriate choice for web platform features that need to check for equality with a constant keyword. This CL optimistically migrates the safest subset of DeprecatedEqual calls to EqualIgnoringASCIICase: those where one of the arguments is an 8-bit literal that contains only ASCII but neither “s” nor “k”. {s,k,S,K} are the only ASCII characters whose equivalence classes would change when switching from simple non-Turkic case folding to ASCII insensitivity [2], so we shouldn’t need web platform tests. This commit in particular was generated by the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"skSK]|(?&escape))*"){0} (?<other>(?:[^(),]|(\((?:[^()]+|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*(?: (?&literal)\s*,\s*(?&other) |(?&other)\s*,\s*(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.ccls-cache/* Replace: EqualIgnoringASCIICase$5 [1] https://codereview.chromium.org/2811793004/patch/1/10109 [2] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt Bug: 627682 Change-Id: I6ee08a9378c782a91ce616362a91a7e0c64c989b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015875 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735807}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/086aded3cb74..43c070193ede git log 086aded3cb74..43c070193ede --date=short --first-parent --format='%ad %ae %s' 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 748ad200897b..34e16df059f8 (6 commits) Created with: gclient setdep -r src/third_party/angle@43c070193ede If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ifd03752571b3f0db8e5e0c87f807f55079eb4ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024581Reviewed-by:
-
nancy authored
BUG=1044844 Change-Id: I7ff65c9335ff864d46bd036e96ce3176132a8f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018622 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#735805}
-
Javier Ernesto Flores Robles authored
Disables testAccessibilityOnCreditCardEditPage on iphone-device. TBR=sczs@chromium.org Bug: 1046096 Change-Id: I6ac90cf5291f5e683a45f33ed24fd90c784090fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023549Reviewed-by:
-
David Grogan authored
This is a reland of 4fb5e9ec which should be fine after 4548e4da landed. Bug: 635619 Change-Id: I374a1f4bc4d8c0ea4fbb91cf9f560ff145c371db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024467 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#735803}
-
Alex Newcomer authored
The hotseat can be dismissed when the user interacts outside of the shelf widget. Record this in metrics for UX. Bug: 1041907 Change-Id: I18fb9b6de63d17bbaf3ac13887a991d2a90bc71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024071 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#735802}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL uses mojom::blink::ScrollAlignment::Behavior and clean up ScrollAlignmentBehavior enum in Blink. Bug: 1039285 Change-Id: I43743284c1ed33f5f720b4973dccfd72de4801ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023711 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Eriko Kurimoto authored
This CL adds referrer-policy web-platform-tests for module shared workers. "sharedworker-module" is added to spec.src.json and it auto-generates tests. Files I changed without auto-generation is 1. referrer-policy/spec.src.json 2. common/security_features/resources/common.sub.js (added WorkerOptions argument to requestViaSharedWorker, added "sharedworker-module path) 3. upgrade-insecure-requests/support/testharness-helper.sub.js (added the second argument in requestViaSharedWorker modified in common.sub.js) Change-Id: I044e4174c5077e7eb0e6790a55aa48534d3e6966 Bug: 824646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023710Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735800}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL uses mojom::ScrollIntoViewParams::Type and clean up ScrollType enum in Blink. Bug: 1039285 Change-Id: Ib0e6db68d371807892831ffabce5cd3d04d4be8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024628Reviewed-by:
-
