- 06 Oct, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/aeaf34ca03f8..778430a2f76b $ git log aeaf34ca0..778430a2f --date=short --no-merges --format='%ad %ae %s' 2017-10-05 oysteine trace-viewer: Let the gzip_importer use Pako directly instead of JSZip 2017-10-05 simonhatch Dashboard - Generate same tir_label for /add_histograms as chartjson. 2017-10-05 achuith Copy set so its size doesn't change. Created with: roll-dep src/third_party/catapult BUG=771421 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5a36807411db3f0d4b44275cf2c517f1e78bb986 Reviewed-on: https://chromium-review.googlesource.com/704261 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506968}
-
James Cook authored
This places it next to the other accessibility code. Move the test delegate there as well to be consistent with other ash test delegates. Bug: none Test: compiles TBR=reveman@chromium.org for exo Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I276b231c23ffa4241d1cb08782886c4e43d762e6 Reviewed-on: https://chromium-review.googlesource.com/703434 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506967}
-
Toni Barzic authored
Extract lock screen profile creation out of lock_screen_apps::StateController into a separate, LockScreenProfileCreator class. Primary motivation is to delay lock screen profile creation until lock screen note taking is enabled (i.e. to avoid profile creation if the user does not have lock screen note taking apps). AppManager requires lock screen apps profile (as it installs the note taking app to the profile). Instead of providing the profile to the AppManager directly, the interface is changed to accept LockScreenProfileCreator, which can be used to get the lock screen profile. LockScreenProfileCreator will observe lock screen note taking availability, and if it detects lock screen enabled note taking app, it will create the lock screen apps profile. If the profile is not created by the time AppManager needs it (i.e. the screen is locked and the user has a lock screen note taking app set), the AppManager will be able to use AddProfileCreatedCallback API added to LockScreenProfileCreator to observe profile state. When the profile is created, and initialized, the AppManager will be able to proceed to set up the note taking app. CL also adds FakeLockScreenProfileCreator that can be used in unittests to create lock screen (testing) profile and simulate lock screen profile creator state changes, and adds unittests covering lock screen apps profile creation. BUG=765029 Change-Id: I33fdf3a91ea4817a3576b66c950570fc76b3c9c9 Reviewed-on: https://chromium-review.googlesource.com/662403 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506966}
-
Dirk Pranke authored
We require every time Chromium talks to the network to be explainable. In order to do this, we annotation functions that call out to the network. This CL adds the tooling to ensure that all of the functions are correctly annotated and that the annotations are syntactically correct and semantically complete. Bug: 690323 Bug: 656607 Change-Id: I3e5a8a3d753b70768dd42ad4aa880087a089b61d Reviewed-on: https://chromium-review.googlesource.com/592721 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506965}
-
dpapad authored
It is unnecessary since all tests did load chrome://extensions as |browsePreload| anyway, but most importantly this causes the extensions page to load twice during optimized builds, which leads to runtime errors. This is in preparation of turning on optimize_webui for MD Extensions. Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5e8b903bd4b5589af26fea6b3a25290d56188a7a Reviewed-on: https://chromium-review.googlesource.com/703861 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#506964}
-
Ian Kilpatrick authored
This implements our current behaviour for 'auto' sized FCs within a BFC. We need to perform layout twice under two scenarios: 1. 'auto' inline size child. In this case we need to perform layout once, and if the child doesn't fit, we perform layout a second time with an "open" layout opportunity, so we can guarantee it will fit. 2. Non-adjoining margin strut and unpositioned floats/current layout. In this case we need to perform a relayout as the BFCOffset where floats will be positioned will change. This happens if the child doesn't fit on the "top" of the exclusion space. This also adds more TODOs everywhere which we can handle later. I kept this as small as possible to keep sanity. :) Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I499dc9722fac47f43694f35c507e9d2742d317db Reviewed-on: https://chromium-review.googlesource.com/680176 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#506963}
-
Mohammad Refaat authored
Reverted because it broke Cronet tests, the reason was CookieStoreIOSClient used to get IO Taskrunner is not initialized on Cronet Initialization. [NEW] * Create CronetCookieStoreIOSClient and set it up with Cronet Network IO TaskRunner * In Cronet initialization Set CookieStoreClient to CronetCookieStoreIOSClient. [OLD] * Converts SystemCookieStore to Async * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous functions. * Move creation time management to systemCookieStore. * Update cookie_store_ios_presistent_unittest & cookie_store_ios_unittests to account for SystemCookieStore changes * (As CookieStoreIOS is using systemCookieStore internally). Another CL is in progress to add WKSystemCookieStore & unit_tests for systemCookieStore (to handle async methods) with template for both NSHTTP & WK systemCookieStore. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5c56a7b88868ad24d34dd7109273f2cdc5880d91 Reviewed-on: https://chromium-review.googlesource.com/704014 Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506962}
-
Francois Doray authored
The WithBaseSyncPrimitives() trait is deprecated. ScopedAllowBaseSyncPrimitives(ForTesting|OutsideBlockingScope) should be used instead. Bug: 766678 Change-Id: Ib782e9904ddb14ec0c56973abf0324695383451f Reviewed-on: https://chromium-review.googlesource.com/702655 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#506961}
-
Takayoshi Kochi authored
As discussed in email and here, removing dominicc@ and cpu@, adding scottmg@ and dcheng@. Change-Id: I37ed0e49209f84668ac4b5b04f659e008b604515 Reviewed-on: https://chromium-review.googlesource.com/696744 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506960}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I0b53a125fccf3376bdb30c7702f92de6bcfda930 Reviewed-on: https://chromium-review.googlesource.com/704161Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506959}
-
Hiroki Nakagawa authored
This reverts commit 6c1f5306. Reason for revert: Speculative revert for build failures on the Mac bot https://build.chromium.org/p/chromium/builders/Mac/builds/33456 Original change's description: > egl: Use khronos version of __APPLE__ section in eglplatform.h > > Bug: 769415 > Change-Id: I8e16a2a35286144eaa2d97b4d5f7cf239a00a8e5 > Reviewed-on: https://chromium-review.googlesource.com/703739 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Anderson <brianderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506957} TBR=brianderson@chromium.org,kbr@chromium.org,cwallez@chromium.org Change-Id: Ia96b247a9080be24a8c53dca6a7033aed43eb40f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769415 Reviewed-on: https://chromium-review.googlesource.com/704334Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#506958}
-
Brian Anderson authored
Bug: 769415 Change-Id: I8e16a2a35286144eaa2d97b4d5f7cf239a00a8e5 Reviewed-on: https://chromium-review.googlesource.com/703739Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506957}
-
Leo Zhang authored
Our PM wants to make the font color of the non-selected language finch-able to figure out a path forward with making the font darker. Group 1 will be the default color and group 2 will be the 87% black. I created the params with our feature TranslateCompactUI and tested by '--force-fieldtrials=TranslateCompactUI/Enabled --force-fieldtrial-params =TranslateCompactUI.Enabled:translate_tab_default_text_color/1' Bug: 771835 Change-Id: I0d2d4eea3707685b45b83e5d7d4079fa855deecd Reviewed-on: https://chromium-review.googlesource.com/701994Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506956}
-
Ryan Sturm authored
In this case, we don't want to serve a preview. Bug: 772175 Change-Id: I320d6ad26cb7cf51dba9797447e388816115df91 Reviewed-on: https://chromium-review.googlesource.com/703859Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506955}
-
Brian Anderson authored
Bug: 769415 Test: Trace events that use this extension look good. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3f051d4f86894f9029774e73b1327262c514fd53 Reviewed-on: https://chromium-review.googlesource.com/685402 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506954}
-
Quinten Yearsley authored
TBR=wjmaclean Bug: 772196 Change-Id: I4ea0411a8ab5a5e88ac1098cabe4103a0761ceb0 Reviewed-on: https://chromium-review.googlesource.com/703860Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#506953}
-
Naina Raisinghani authored
This should increase coverage by allowing the fuzz to produce test cases in quirks mode too. HTMLQuirksMode has it's own issues in our code base and getting fuzzer to run these tests would be great. Change-Id: I0ea188d480d7bc605e0ddf62b665ba88ffde9b45 Reviewed-on: https://chromium-review.googlesource.com/701855Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506952}
-
Kent Tamura authored
for snake_case. Bug: 770603 Change-Id: Id07cbd58c190cac0ccbc9fcbf92747d83705be64 Reviewed-on: https://chromium-review.googlesource.com/701879Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#506951}
-
Kent Tamura authored
for snake_case. Bug: 770603 Change-Id: Ic158606ea9eb5f6cdf78e1fed72fefaa3ec613c5 Reviewed-on: https://chromium-review.googlesource.com/702200Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#506950}
-
Timothy Loh authored
This patch removes obsolete values from InfoBarIdentifier, and labels all removed values with "(Obsolete)" in enums.xml so it's more obvious when looking at UMA data. Change-Id: I4f463462d52954066a5ce38726d4694ed0f2f924 Reviewed-on: https://chromium-review.googlesource.com/702177Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506949}
-
Sergey Ulanov authored
Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I19a1edacd4cda27c06f4df631bea9a0b2f9e6a2c Reviewed-on: https://chromium-review.googlesource.com/690626 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506948}
-
Hiroshige Hayashizaki authored
IsErrored() and HasInstantiated() are to be removed because they are removed from the HTML spec in https://github.com/whatwg/html/pull/2991. This CL - Replaces IsErrored() calls in unit tests with checks for Instantiate() results or with HasEmptyRecord(), depending on whether instantiation errors or parse errors are tested, and - Removes EXPECT_FALSE(HasInstantiated()) from ModuleMapTest.cpp, because instantiation is already prohibited by NOTREACHED() in DummyModulator::InstantiateModule(). Bug: 763597 Change-Id: I272a03f3d5ce8ddf6ea645a3d0d1a1ae7543f2be Reviewed-on: https://chromium-review.googlesource.com/703483Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#506947}
-
Vladimir Levin authored
Right now the MakeSubset and MakeStatic are the only mutating PaintImage functions. This patch moves those to the PaintImageBuilder and allows users to use either the full copy or just the properties of a given PaintImage. This also makes it simpler to add mutations to the PaintImage via the builder if no builder is initially available. R=khushalsagar@chromium.org, chrishtr@chromium.org TBR=dalecurtis@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic766cef20e77dcd3b34fc5abc9373177e5b94eba Reviewed-on: https://chromium-review.googlesource.com/702646 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506946}
-
Yoshifumi Inoue authored
This patch gets rid of redundant argument |VP_DEFAULT_AFFINITY| for |CreateVisiblePosition()| for improving code health. This patch is a preparation of renaming |VP_DEFAULT_AFFINITY| to |TextAffinity::kDefault|. Bug: 657237 Change-Id: I16e8af4d874afc5059c09f2401cb1f1dc9c98f67 Reviewed-on: https://chromium-review.googlesource.com/701902Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506945}
-
Yoshifumi Inoue authored
This patch makes |LayoutSelectionTest.CommitAppearanceIfNeededNotCrash| simpler for improving code health. Change-Id: I3f0c930c31870968432c326207ec930a15eecbb1 Reviewed-on: https://chromium-review.googlesource.com/702118Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506944}
-
Yoshifumi Inoue authored
This patch gets rid of unused parameter |TextAffinity| from |TrailingWhitespacePosition()| for improving code health. This patch is a preparation of renaming |VP_DEFAULT_AFFINITY| to |TextAffinity::kDefault|. Bug: 657237 Change-Id: I0c354cbbbe09afc757d23c23db0c8df244c6b09a Reviewed-on: https://chromium-review.googlesource.com/701904Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506943}
-
Qiang Xu authored
changes: (1) Since |tablet_controller_| is created OnAccelerometerUpdate, itself is enough to represent ShouldHandlePowerButtonEvents(). (2) Remove IsTabletModeSupported() in PowerButtonDisplayController. It is used on stylus removed. Nowadays, stylus is configured on convertible only. Even for clamshell device with stylus, SetDisplayForcedOff(false) should be OK since it will be a no-op because of early return. TEST=covered by tests Bug: none Change-Id: I0dd883d9bf97e1c24c1b9acd5e1856b630f97fec Reviewed-on: https://chromium-review.googlesource.com/702919Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#506942}
-
Ryan Hansberry authored
Previously the FeatureState was recorded as Tether was being destroyed. However, this was failing to reach the metrics dashboard, likely because there are no guarantees that the metrics pipeline can persist a log when the machine is shutting down. There's no need to do this recording at tear down, so this CL simply moves when the call is made. Bug: 772078 Change-Id: Ib002fb41ae1c5df814fc9cefc6772c1141df8307 Reviewed-on: https://chromium-review.googlesource.com/703915Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#506941}
-
proberge authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/692554 which disabled extension content verification from tests inheriting from ExtensionBrowserTest. For pref hash browsertests, there seems to be a time window between the PRE_ tests and their normal counterpart during which which extension content verification is enabled. During this time window, the good.crx extension installed by PrefHashBrowserTestUnchangedCustom is disabled. This should fix the failures described in https://bugs.chromium.org/p/chromium/issues/detail?id=770001#c8 and allow us to re-land https://chromium-review.googlesource.com/c/chromium/src/+/698985 Bug: 766806 Change-Id: I261eaef5eae9cf192a6f514092c3b5ad4feafc8e Reviewed-on: https://chromium-review.googlesource.com/703508Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#506940}
-
Reilly Grant authored
When SetLoFiModeActiveOnMainFrame is called with false it takes no action. This patch replaces this method with SetLoFiUsedThisSession which unconditionally performs the action taken when this method was called with true and removes all instances where it was called with false. Bug: None Change-Id: Ic3e624ea2e74a1a01f9be4d4efb825f52f5558ed Reviewed-on: https://chromium-review.googlesource.com/704016Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506939}
-
Jian Li authored
The experiment value obtained from the field trial will be sent in a custom header X-Offline-Prefetch-Experiment in all requests sent to the Offline Prefetch Server. This value will help the server decide how to process the request. Bug: 701939 Change-Id: I94366d6162dffcaf3988f4cb1d042c3f3d2db265 Reviewed-on: https://chromium-review.googlesource.com/699736 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506938}
-
Ken Rockot authored
This reverts commit 95ae7232. Reason for revert: Breaking windows compile, e.g. https://build.chromium.org/p/chromium/builders/Win/builds/59641 Original change's description: > Make CQ run vr_common_unittests on Windows > > There were a few clang-specific C++ extensions in use, and some warnings that hit only on MSVC. > gltf tests had to be disabled because url->path parsing is not correct on Windows. > > BUG=744675 > > Change-Id: Ica976477da4b5009a68d738e71ee995af871d1f7 > Reviewed-on: https://chromium-review.googlesource.com/695807 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506866} TBR=cjgrant@chromium.org,bsheedy@chromium.org,billorr@google.com,jochen@chromium.org,billorr@chromium.org Change-Id: I0047a3d865fc7ee4eadc9bbaf1ff5942366daa53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 744675 Reviewed-on: https://chromium-review.googlesource.com/704056Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506937}
-
Ke He authored
BUG=728223 Change-Id: I4241852401000b5d68b9547dbd23a3d405838020 Reviewed-on: https://chromium-review.googlesource.com/701324 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506936}
-
Xianzhu Wang authored
This is a preparation CL for SPv175 raster invalidation which will use CompositedLayerRasterInvalidator in GraphicsLayer. To reduce differences between SPv1 and SPv175, in this CL we also let SPv1 use CompositedLayerRasterInvalidator but only use its raster invalidation tracking functionality. 1. RasterInvalidationTracking is converted from a struct to a class. 2. Now each GraphicsLayer is associated with a RasterInvalidator instead of a RasterInvalidationTracking. Previously the association was implemented by a hash map, now is directly owned using unique_ptr. 3. Empty invalidation rect is no longer reported in SPv2. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I125ffc2e6cdff8931eabdaf7e4630d17135a5189 Reviewed-on: https://chromium-review.googlesource.com/701663 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506935}
-
Jialiu Lin authored
account_info_ is initialized when ChromePasswordProtectionService is created (browser startup time).So if user changed their signin state afterward, CPPS cannot capture it. We should in fact get AccountInfo struct from SigninManager whenever it is being used. Bug: 772041 Change-Id: Idedbcc71c444d84446662d2b9ed595901ac25ae8 Reviewed-on: https://chromium-review.googlesource.com/702915 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506934}
-
smut authored
Bug: 756270 Change-Id: I68e4b762f3324c19fe8a20e8d5a180adb6a30305 Reviewed-on: https://chromium-review.googlesource.com/703889Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506933}
-
Devlin Cronin authored
Add a OneTimeMessagingHandler to handle sending one-time messages (such as those from chrome.runtime.sendMessage) with native bindings. These messages open a message channel, similar to the long-lived connections of chrome.runtime.connect(), but the channel is only open for a single message-and-response cycle. The OneTimeMessagingHandler is responsible for creating and maintaining these message channels, and cleaning them up when complete. Add tests for the same. Note: currently, these constructs are still only used in tests. A later CL will hook them up to the bindings system. Bug: 653596 Change-Id: Ibeae3bda73b66306a85b13749f1cab1a1edfb33b Reviewed-on: https://chromium-review.googlesource.com/675305 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506932}
-
Lei Zhang authored
Use a single map with a struct to keep track of incoming requests, instead of two separate maps. Change-Id: If5dbb806de2b42f95bbe2697512beaedd39c80df Reviewed-on: https://chromium-review.googlesource.com/703493Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506931}
-
Ilya Sherman authored
BUG=772159 R=mark@chromium.org Change-Id: I596b085a93b0dde4717f03db2e5d2cd4cd2fec82 Reviewed-on: https://chromium-review.googlesource.com/703919Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506930}
-
Cait Phillips authored
Bug: 700812 Change-Id: I4ab2534057debd0d1c94b20e6c8b8844fd364d87 Reviewed-on: https://chromium-review.googlesource.com/666059Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#506929}
-