- 10 Nov, 2020 40 commits
-
-
John Palmer authored
Bug: 1111135 Change-Id: I0ecb9491026851d01331a95d20b29fc1e5caf0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521552 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825722}
-
Ryo Hashimoto authored
This CL depends on CL:2517272 BUG=b:171408795 TEST=components_unittests TEST=Launch Play Store Change-Id: Ie79568e6f03b3433b8d9af1b50fd1db817d76794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517269 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825721}
-
Yu-Hsuan Hsu authored
Change stream type to CRAS_CLIENT_TYPE_LACROS for lacros-chrome. The stream type is used while recording UMA logs in CRAS. So we can separate data between ash-chrome and lacros-chrome. BUG=b:167941044 Change-Id: I35a8320bd9b5d372d9f5ac883078d010ed42ee9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521473Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825720}
-
Mathias Carlen authored
The Autofill Assistant stack's lifecycle is not using Chrome's framework designed to provide exactly that. This patch introduces a TabHelper that will become a proper entry point to control construction and destruction of components of the Autofill Assistant stack that depend on a WebContents. This initial patch only adds an empty TabHelper and test and hooks it up in the tab_helpers registry behind a default disabled AutofillAssistantTabHelpers feature. Bug: b/169389571 Change-Id: I3129fd04e5e4dd6c65c1df891383cf29cad508d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521620 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825719}
-
Keishi Hattori authored
This CL adds accessors to PartitionFreelistEntry::next in order to Hide encoding/decoding of PartitionFreelistEntry pointer as much as possible. Change-Id: Ia01251e27464d33ecff660eb7867f9c06b8f5449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513846Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825718}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/background/js: - app_window.js - app_window_wrapper.js - background_base.js Bug: 1133186 Change-Id: I5d90323c2f330eb4967c4710141d52ce9cd26b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525885 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825717}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I95c93df05b77c03b3686d7bd9430dfde74229761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461547 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#825716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/528ae31edd58..36787dcb4382 2020-11-10 syoussefi@chromium.org Vulkan: Fix PBO assuming color images 2020-11-10 m.maiya@samsung.com Vulkan: Bug fix in texture respecification code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: ImageTest.Source2DTarget2DTargetTextureRespecify* Change-Id: I72906b4d0039a58000ec1c8286d63d0e98e42fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825715}
-
Koji Ishii authored
r824961 crrev.com/c/2515933 copied the code from |LayoutBlock| but the code in |LayoutBlockFlow| that prevents it from running when |ChildrenInline| was not copied. This patch adds the check. Note, the test creates |LayoutNGCustom| in legacy, and adds a |LayoutTextFragment| as a child of the |LayoutNGCustom|. Not to blockify the child is likely an issue in |LayoutNGCustom|, but this case could probably be reproduced by inline custom layout or other inline objects that forces NG. Bug: 1146789 Change-Id: I7ffacc2465ad205d13702dfda03433cc50c423f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526702 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825714}
-
Victor Hugo Vianna Silva authored
No behavior is changed. Old code is migrated to OnceCallback/BindOnce() or RepeatingCallback/BindRepeating(), using OnceCallback whenever possible. Some instances of base::*Closure() are also migrated to base::DoNothing(). TBR=rdevlin.cronin@chromium.org Bug: None Change-Id: I489a44033b5ffeefb0a68100ba8480c7399970d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527142 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#825713}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c32d29e103de..7f9e30c27f7b 2020-11-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0819e05b662de1cd62bb10ee9a49413dce123c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527959Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I982dd85364561c588f4457dc80047fba48082a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528801Reviewed-by:
-
sandromaggi authored
This refactors WaitForDocumentReadyState (and GetDocument ReadyState) to take an (optional) ElementFinder::Result instead of an optional Selector. An optional ElementFinder::Result is here defined as having an empty node_frame_id (which will map to the main frame). Bug: b/2523176 Change-Id: I7db89cc0ec2ede071616b30db42c1f8de9ab2d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526441 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825710}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ib9e67a3cccd20549836019db36c507d71db70aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494202 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825709}
-
Ben Reich authored
Move the JavaScript script output from being saved in the devtools_code_coverage directory instead moving into a subdirectory called scripts. This avoids pollution of the devtools_code_coverage directory as merged coverage files will be saved there. R=noel@chromium.org Bug: 1113941 Test: browser_tests --gtest_filter=*FilesApp* --devtools-code-coverage Change-Id: I109846b21d2d31e9a677f68f360409e2ecb3897e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527903Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Auto-Submit: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#825708}
-
sandromaggi authored
The previous implementation used a differing strategy based on the optional selector. This CL changes to use the |EvaluateParams| based approach for both cases. This is step 1 in a plan to refactor * WaitForDocumentReadyState * WaitForDocumentToBecomeInteractive to become one. Bug: b/172542134 Change-Id: I5d8cd765e4cb4e922bd3f5e65a03678caa0d52c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523176 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Yusuf Sengul authored
Bug: 1147244 Change-Id: Ib0931d9d8090c343483a1d2c0bcf98ddc2c7d18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527687Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#825706}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0833ef41..4f7c1ce4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7cc1004b02a6dc76d3f8c713c0668f162b0a88ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527538Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825705}
-
Kenichi Ishibashi authored
It owns remotes to ServiceWorkerResource{Reader,Writer} which can be disconnected at any time. Handle these disconnections to provide graceful error propagations. This CL doesn't add tests for some comparison cases (copying and resuming). Follow-up CLs will add these tests. Bug: 1133143 Change-Id: Ie8d76b93ff0ffbf3bfde4ddfe2dfe98b2ab920d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525702Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825704}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/common/js: - file_type.js - file_type_unittest.js - lru_cache.js - lru_cache_unittest.js Bug: 1133186 Change-Id: Id2b0dc75b4bc18969e6e7b862d0c9282baa0ba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521886 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
We're currently evaluating performance of PartitionAlloc-Everywhere (PA-E). Any regressions from zeroing would be inedvartantly attributed to PA-E, as it hugely increases number of memory allocations going through this path. The best course of action would be to postone zeroing until PA-E is fully evaluated and enabled in trunk. Then we should re-enable zeroing and properly re-evaluate it in the new world. Change-Id: I06ee7c63d10b2a14c76a7bd51faab7b616621c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521881Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825702}
-
Trent Begin authored
This change adds an implementation of the net error diagnostics dialog for Chrome OS. Now if the connectivity diagnostics webui feature is enabled, the new application is launched, otherwise the legacy chrome app is launched. Bug: 1144261 Change-Id: I924cc5c2fbedfb1a7a5cba90fcd6bbf0b3f48855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510799 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825701}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6999d94c051..ca2031075565 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064151,chromium:1078229,chromium:1131897,chromium:1136305,chromium:1141619,chromium:1146194,chromium:1147190 Tbr: ricea@google.com Change-Id: I275b0cdd2cb00115c4574053e978cac57d40d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825700}
-
Yuchen Liu authored
b6f2d0699633 [Android] Fix un-paired namespace declare for higher __ANDROID_API__ Change-Id: I6894e4f9a9455f180fdca0b81e8540ff4613f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527799 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#825699}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d532cbd0baa..eba8b028ddbc 2020-11-10 adsrini@google.com Merge "Add a proto for frametimeline events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7aaee782b151bcd021fc3c44ee1ec566eb38e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528610Reviewed-by:
-
Alan Cutter authored
This CL migrates the Chrome OS JSON config for the Google Docs preinstalled web app (located here [0]) up into the Chrome binary. This default web app is going to be used by Chrome Windows/Mac/Linux so this CL is deduping the offline data into one place. A separate CL will clean up the redundant JSON config. [0]: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/master/chromeos-base/chromeos-default-apps/files/web_apps/docs.json Bug: 1104692 Change-Id: I4f713bf1dec230fe4c6f3c691d4d954ac0c5f340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524809 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#825697}
-
Steven Valdez authored
Design: https://docs.google.com/document/d/1-4n1RLaJs8ANw34TsS6BVt7ARa7lK70F6aHFG2CL3Rc/edit#heading=h.6a92f2gfl9le Bug: 1133310 Change-Id: I70210d3f6ac82450607acd89a78d08a53dd52ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436763 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825696}
-
Robert Ogden authored
This CL implements a small class that will keep track of all Retry-After responses from prefetched origins. Not done in this CL, saved for follow-ups: * Integrating with BrowsingDataRemover * Persisting to prefs Bug: 1146210 Change-Id: I19aa8f8272da40a88ca457286a1f8aac46640424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522193Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#825695}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I34cfe1a8d474a2b146138ce2502c4cb1875c37cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494194Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825694}
-
James Vecore authored
Change-Id: I686ea0b14646a318aa4e6e1e2da47cde5022f6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526629 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#825693}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604931688-79a6ca0d5aca76d3d27163162f00dd49eb38f0e8.profdata to chrome-win32-master-1604955437-61247d42a6140f126d61086b5421948904b6ffb0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibef9174ab493d69e5426c561d503463deba1bff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528609Reviewed-by:
-
Mohamed Amir Yosef authored
... upon opt-in to account store passwords. Bug: 1145971 Change-Id: Ib8f9e07db5ddf4267afe42324bcdd76ec9841a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526103Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#825691}
-
Luciano Pacheco authored
Elements: <track-info-panel>, <track-list>, <control-panel> and <audio-player>. Move the <link> tag inside the <template> because this is enforced by polymer_modulizer() this requires changing from rel="import" to normal rel="stylesheet" which in turn requires to changed the URL to request the CSS. Fix all closure errors. Bug: 1133186 Change-Id: I633ef710307afa8b1237a188a7b4d8932cbc0cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526004Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825690}
-
Morten Stenshorne authored
This is a partial revert of patch set 4 in CL:2515399 (to the initial patch set). The change in patch set 4 was done in order to improve readability, but with one oversight: We'd set a non-zero distance when actually within range, since we'd always subtract one edge from another. This helps fix 6 tests, but the tests themselves also had to be updated, because legacy PositionForPoint() for multicol is broken when hitting above or below columns, in that it assumed UNIX / Mac editing behavior, which makes a difference when hitting just above the character at e.g. offset 2 in the first column. UNIX / Mac would return 0 as startOffset ("above the first line... okay, we're before the text, then"), while Windows should return 2 ("we're above the first line, but the nearest character is the one at offset 2 - use that"). Force Windows editing behavior in the tests, to fix this. The PositionForPoint() implementation for LayoutNG multicol is now behaving way better than the legacy engine, which allows us to add the missing parts to those tests (what we tested for vertical-rl was really limited due to legacy bugs). Legacy was also off-by-one for RTL columns, when hitting near the middle of a column gap (assigning one pixel too many to one column, and one too little to the other column). Rebaseline the tests. Everything now passes in LayoutNG, but there are obviously failures when running with the legacy engine now. Bug: 829028 Change-Id: Iecdecf1454318e645fa91bac29119df0fc7ca377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526402Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Fletcher Woodruff authored
Add a function to cancel the currently running scan job to LorgnetteManagerClient. Has the limitation that it only works when one scan is running. Bug: b:171821976 Change-Id: Ib60cb27477ee6c26110655dbdd1a408795774585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523437 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825688}
-
Kent Tamura authored
This CL remove DEFINE_LAYOUT_OBJECT_TYPE_CASTS() for LayoutInline, and converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for LayoutQuote. This CL has no behavior changes. Bug: 891908 Change-Id: I2ade507d24cb59b9d99c419cc566cd6b00d315ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528512 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Brian Geffon authored
Node channel messages need to be packed. Bug: b:172869067 Change-Id: I30ac9d44347fef9e0b74267d6d09ec8589e4d3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527532Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825686}
-
Yu Su authored
- Add a ChipRenderParams class to wrap the params used when displaying the chip - add new LensController methods to retrieve chip params, generate Lens intent and launch Lens. Will implement these methods in a follow up clank cl. - update LensQueryParams to be a temperate wrapper object for Lens init params. Will split out Lens init params into a separate wrapper object once we have the Direct intent SDK. Change-Id: If90ac5f407889069fe2f58ef210055d2c144df46 Bug: 1145748, b/171252338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527724 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#825685}
-
Mark Mentovai authored
In a change from x86_64, macOS on arm64 requires MAP_JIT for code not using the hardened runtime. However, if MAP_JIT is specified for signed code lacking the JIT entitlement, mmap and mprotect fail with EINVAL, so it’s still not possible to use MAP_JIT everywhere it could conceivably be required. A wasm attempt to mprotect a region as PROT_READ | PROT_WRITE | PROT_EXEC was succeeding in signed builds but failing in non-hardened-runtime processes with EPERM as a result of the mapping lacking MAP_JIT. In a previous (post-facto drive-by) review of this code (https://chromium-review.googlesource.com/c/2078792), I noted “I would have preferred the caller coming in with affirmative knowledge of whether it wanted JIT or not” but the callers aren’t necessarily aware of the entitlement regime they’re expected to run under. Bug: 1144200 Change-Id: I2edde64922dfbd8ba7158cc741b0e82d680235b8 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523446Reviewed-by:
-
Alex Moshchuk authored
This modifies an existing test, DynamicIsolatedOriginTest.NewBrowsingInstanceInOldProcess, to explicitly exercise a scenario where a process's minimum BrowsingInstance ID changes, and where this may affect a CanAccessDataForOrigin decision. In particular, this would happen if the new minimum BrowsingInstance ID makes a particular origin eligible for isolation. Currently, the minimum BrowsingInstance ID stored for a process in ChildProcessSecurityPolicy does not change even if the corresponding BrowsingInstance goes away, so the outcome of CanAccessDataForOrigin can't change. This will change once multiple BrowsingInstances are tracked for each process, rather than just a minimum ID, in issue 1135539. In particular, after this change, CanAccessDataForOrigin may start denying access to an origin which is considered isolated in all of the process's remaining BrowsingInstances, due to citadel enforcement. Bug: 1135539 Change-Id: I8d388f6099f224172b8a77129362de8300e37ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528128Reviewed-by:
-
