- 23 Jun, 2020 40 commits
-
-
Clark DuVall authored
The components scaled resources were added in http://crrev.com/c/2250920, and are only needed for WebLayer. Bug: 1023811 Change-Id: I58d9b8aa331e6a102bc9b97367d095f0bd7ed089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258686 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781329}
-
Ioana Pandele authored
Change-Id: I2327855180203f746dc91e966c7c4a6b18749c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260613Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781328}
-
Hans Wennborg authored
Bug: 1097990 Change-Id: Ic77aecc775a879a937282698d1dddfcefcf76d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259916 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781327}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2f46c16ab67..2bf27f21f8d1 2020-06-23 jvanverth@google.com Revert "Reland "Fill in GrD3DGpu::onUpdateBackendTexture"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I03197af1d990ce054e9f4c1b0b441c2bbb853568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781326}
-
Chris Sharp authored
This reverts commit 1e56c551. Reason for revert: Broke compile on Mac Builder (dbg) Failure Step compile failed. Error logs are shown below: [724/7143] CXX obj/base/base_unittests/power_monitor_device_source_unittest.o FAILED: obj/base/base_unittests/power_monitor_device_source_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../base/power_monitor/power_monitor_device_source_unittest.cc:32:3: error: use of undeclared identifier 'DVLOG' DVLOG(1) << PowerMonitorSource::DeviceThermalStateToString(current_state); ^ 1 error generated. More information in raw_io.output[failure_summary] Original change's description: > base/power_monitor: Add method to query thermal state > > wip wip > > Add PowerMonitor::GetCurrentThermalState() > > Bug: 1071431 > Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781322} TBR=fdoray@chromium.org,mcasas@chromium.org,hbos@chromium.org Change-Id: I54bbdc02423890b8443cb2f1deec909b68d87ebf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260792Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781325}
-
Liviu Tinta authored
Adding this TRACE would make it easier to look into wheel events bugs. Bug: 1087088 Change-Id: Id90516476e6112699e8d030107f16c80a97e0773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250592Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#781324}
-
Nohemi Fernandez authored
The NewSigninArchitecture feature has been enabled by default. Bug: 971989 Change-Id: I7289a97541d239edbfc1b3b65aea04abe9c46edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260553Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781323}
-
Miguel Casas-Sanchez authored
wip wip Add PowerMonitor::GetCurrentThermalState() Bug: 1071431 Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781322}
-
Oriol Brufau authored
ListMarker::MarkerText was not checking whether the marker had 'content' set to 'normal' or something else. Therefore, in the accessibility tree, something like <style>::marker { content: "foo" }</style> <li style="list-style-type: decimal"></li> would appear as ▽ listitem ▽ ListMarker "1." text "foo" with the "1." despite 'list-style-type' being overridden by 'content'. This patch turns it into ▽ listitem ▽ ListMarker text "foo" Bug: 457718 TEST=All/DumpAccessibilityTreeTest.AccessibilityListMarkerStyles/linux Change-Id: Id022ab6dab5268101380a06936275598b225a0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255598Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781321}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592902529-d2a08100040b803a390f39eecb31cf1400764c19.profdata to chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9fbb19589759012404960c28c50f7245aaca4fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260513Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL adds metrics that record, every time Chrome offers to move a password from the profile store to the account store, what was the user action that triggered the flow to be offered. Bug: 1063852 Change-Id: Ie416b1b234dbd94421ecd13125377abbe6db148e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254028 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592891992-7e90ec0b60a74a0e681805c7cbe855e46353b429.profdata to chrome-mac-master-1592913526-8a6b109b6b3679eaf9b2e9a04d6e6b258b48adc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I16ec7ac90360f951211602586e5ed390c17e5bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260515Reviewed-by:
-
Mikel Astiz authored
This patch deletes a bunch of semi-related tests that are no longer interesting because they only exercise the legacy codepath, and the concepts being tested no longer exist in core sync machinery or at all. Roughly, the deleted tests are about: 1. Naming-related requirements: outdated long ago, no longer relevant. 2. Hierarchy-related: now specific to bookmarks, have decent coverage under components/sync_bookmarks. 3. Local conflict-resolution: no longer implemented within the sync engine and a core responsibility of ModelTypeProcessor implementations, e.g. tested in ClientTagBasedModelTypeProcessorTest. Change-Id: If8572374bff2ebd27e0c6798f79dcb7273d07883 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257327Reviewed-by:
-
arthursonzogni authored
1. A test should check only one things. Previously, support for every "CrossOrigin" attribute was checked in 4 different tests. This part is now merged into property.https.html. The 4 other tests are now checking only one property and are now passing/failling consistently without timeouting. 2. Checking all the accesses to "CrossOrigin" attributes are now also checked in the same-origin case. 3. The helper file try-access.js has been added to check the reported source location. 4. Several simplification here and here. Bug: 1090273 Change-Id: I6cb53aa20b48e8b4d9064d8d593120323dbdf8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259912 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781316}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I3b61e067b09c70c555ccd37bb048d8b78bba9f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241682Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#781315}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia09cd19fa8d3d4dd69f46168478225994cbef7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259482Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781314}
-
Etienne Pierre-doray authored
A UniversalSuccessor lock can be taken after any other lock but another UniversalSuccessor. This is needed in https://chromium-review.googlesource.com/c/chromium/src/+/2248159 in order for JobTaskSource to use worker_lock_ as a inner lock. Change-Id: If2d6fc25083cecf285d066289a170b43da00fb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610646Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#781313}
-
Makoto Shimazu authored
Let's extend the expiry date because it's one of the health check metrics. Bug: 1089490 Change-Id: I49622b3ec2f14b2b8a6e4878802558f881b27e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259395 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#781312}
-
Stephen Nusko authored
android go webview This test flakes 21% of the time due to a timeout. See bug for details. Bug: 1098225 Change-Id: Ia0daed5759712abea78c43557dc192fb31d30a4d No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260733 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781311}
-
Henrik Boström authored
The variable still has the "k" in its name, but the string name used in --enable-features is now without it; "WebRtcThermalResource". Bug: chromium:1094844 Change-Id: Id32c0de43b9fc7ab0b977defda675b1e3bfb4af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260633Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781310}
-
Maks Orlovich authored
Experiment showed not using the heuristic prevents accumulating too many files and performs well Bug: 1075545, 1073514 Change-Id: I7cb374e7f3283ea809f1bf7635f1ade91009742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255651Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#781309}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Currently, IdentityServicesProvider gives |Profile#getLastUsedRegularProfile| param to the native. By this CL, sync classes pass |Profile#getLastUsedRegularProfile| to the IdentityServicesProvider to be used by native. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ib987c4b1e57c6490cd3b844dd9786a3b8459fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253749Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781308}
-
Sebastien Marchand authored
Bug: 1061899 Change-Id: Iae643053601f2d9553212418deb72adb08d19b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240043 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#781307}
-
Patrick Brosset authored
Users can configure settings in chromium for the fonts they prefer. These settings are set in the page frame that the DevTools overlay creates for itself. This change just adds a missing setting for fixed size fonts. Additionally, this fixes a bug whereby the font-family defined in the grid overlay for line number labels was not applying correctly. Before: https://i.imgur.com/kox646s.jpg After: https://i.imgur.com/4AOLmiY.jpg Bug: 1096542 Change-Id: I727932184f5ddd04336539d1849d8233103a6933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251086Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781306}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d69e945fe7dd..2841ab4841b1 2020-06-23 sigurds@chromium.org Update protocol for HeavyAds 2020-06-23 wolfi@chromium.org [Issues] Change style of 'issues infobar' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1095617,chromium:1096973 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I630b117571bbeed9d8445c45718ed31448464f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260512Reviewed-by:
-
Makoto Shimazu authored
It's one of the health check metrics. Let's add one more year. Bug: 1077803 Change-Id: Id6ce1775917a07e4fe64c74e754135a6d9843817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259419 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Stephen Nusko authored
android go webview This test flakes 19% of the time due to a timeout. See bug for details. Bug: 1098223 Change-Id: I5e65949433a4deddb020ffa3f73af220d78d6235 No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260556Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea15439b6b92..d8ac1d219713 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from e20ac35adbfd to 839704450200 (3 revisions) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 71c1a611fdbb to 76ddcca9f3a4 (5 revisions) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae1007957f09 to 9167e1e22a46 (1 revision) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d4b9f576ebb4 to 36b5bb701da9 (1 revision) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 977b7ccbacc1 to 0f4d5f74f199 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ideb126604017be9b301fe049015a987f1f289a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260115Reviewed-by:
-
clamy authored
This CL adds a check in NavigationRequest::OnWillProcessResponseProcessed to return early if the call to ReadyToCommit leads to the deletion of the NavigationRequest. Bug: 1090543 Change-Id: Ida21db80caef1772f2f21c5d2449d3efe4dd1bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254119Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781301}
-
Maria Petrisor authored
Add the new method chrome.platformKeys.getKeyPairBySpki() that, similarly to chrome.platformKeys.getKeyPair() returns subtleCrypto objects for a private and a public key. The key pair already exists on the device, and getKeyPairBySpki() receives a public_key_spki_der as input to identify which key pair to return. The already existing API function getKeyPair() receives a certificate, extracting the public_key_spki_der from it and returning the key pair based on that spki. In our use case (the Imprivata extension) we don't have access to a certificate in order for us to use getKeyPair(). A key pair is needed in Imprivata for sending authorization requests (signing data in the request with the private key) to the Imprivata server, which verifies our authorization request using the public key. Bug: 1073466 Change-Id: I44ef0335ede498b0e5f4878554050999dbbeda85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190675 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781300}
-
Maria Petrisor authored
Grant permissions to the Imprivata login screen to use chrome.platformKeys and chrome.enterprise.platformkeys (_permission_features.json). The Imprivata in-session extension does not need to be added here since it already has access to them as a regular extension. The login screen also needs to be able to sign with the private key obtained from chrome.platformKeys.getKeyPairBySpki() multiple times. Thus we add an allowlist to SignTask (extension_platform_keys_service.cc) in order to approve multiple sign operations in the Imprivata login screen. The Imprivata in-session extension will be covered by the KeyPermissions user policy. Bug: 1073466, 1065112 Change-Id: Iaf9bb6f1522706b76406c43604097f74dbcf1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193615 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ca5e5ee..bbe343d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40878d1fa9de379a83d5763b8a0631cea95ef923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781298}
-
chrome://managementDominique Fauteux-Chapleau authored
Context for those string changes can be found in the bug. After this change the page will look like http://screen/TMKxaozRA7m.png when every Connector is enabled. Bug: 1092559 Change-Id: I955dd062d464641add5fd332766f94fbe54b28c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254459 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#781297}
-
Rob Buis authored
These tests add children to mspace, but mspace does not allow children. Nevertheless the internal framework, using Element.getBoundingClientRect, assert based on these disallowed children which get bounding boxes that are empty rects. To fix this, special case mspace and only check size and that the children are empty and positioned at (0, 0). Bug: 6606 Change-Id: Ic78720547f7e4909cf63ceeb92b3bfbf22d7e15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256212 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#781296}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d01eda10798..47124be594aa 2020-06-23 khokhlov@google.com [Telemetry] More performance mode control If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096589 Tbr: nuskos@google.com Change-Id: I7ff37395c5ca0c28c458fd18a4e2452d39d66a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260116Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements the range overloads for the alg.copy algorithms std::copy, std::copy_n, std::copy_if and std::copy_backward. Bug: 1071094 Change-Id: I26f746acc594761f0a1ae1c21ea858f0b1c0c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257914 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781294}
-
Victor Hugo Vianna Silva authored
Mock: https://screenshot.googleplex.com/opD1RHQ3qmN Implementation: https://storage.cloud.google.com/chromium-translation-screenshots/34c070526b05e911eec3972b16c715c065ac4d96 Bug: 1049141 Change-Id: Ie93f72ec1d6d95c8f517fc2aad75873652bacddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257421 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59b5b97b. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I1efe228060818d7980d2611b8212e65a926c55cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260392Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781292}
-
Victor Hugo Vianna Silva authored
PasswordsListHandler contains a cr-toast-manager. PasswordsSection and PasswordsDeviceSection both embed PasswordsListHandler. This means when one navigates from one page to the other, Chrome attempts to create two instances of cr-toast-manager, which is supposed to be a singleton. This causes error messages to be displayed on Dev Tools. This CL replaces the toast manager with a <cr-toast>, solving the problem. We also use the occasion to fix the arity of the callback passed to the requestPlaintextPassword() call in the file. Fixed: 1096040 Change-Id: I07159913b6a8492118f1eefa09faae6d26874ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254281 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL implements the agreed upon proposal in this doc https://docs.google.com/document/d/1ZJnlpeqdhd_a-ypovOmHLrIPYbbdlK8h3OIggGuj5G4/edit?usp=sharing By making sure the following fields are preserved when updating password in MultiStorePasswordSaveManager date_created date_synced times_used moving_blocked_for_list times_used is incremented upon update. Bug: 1012203 Change-Id: Ife4731381f317efddab032fe416d835c0ec86228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257932 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
