GitLab

This likely leads to using the wrong locale for non-english systems.

BUG=819369
TEST=none

Change-Id: Ie432f038567f077ab10a18257b4b89c8a1a3282e
Reviewed-on: https://chromium-review.googlesource.com/951708Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542018}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=anantha@chromium.org

Change-Id: Ic8e7d26164a8f8fcf016abe5b3c24c1e10e66406
Reviewed-on: https://chromium-review.googlesource.com/955913Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542017}

This adds a field trial testing config for the SimplifyHttpsIndicator
experiment (https://crbug.com/803138), using a default of the
EV-to-Secure variation.

Bug: 803501
Change-Id: I7bc008d9c9a447d69ce9038f4ef06872407cff43
Reviewed-on: https://chromium-review.googlesource.com/956354
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542016}

Replace anachronistic name with more meaningful name.

Bug: 814690
Change-Id: I89b90cdfdb377318eb2652fdca9912e1f8fbea41
Reviewed-on: https://chromium-review.googlesource.com/954505Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542015}

It allows to break infinite loops started using Runtime.evaluate, e.g.
from console.

R=dgozman@chromium.org

Bug: chromium:820258
Change-Id: I9110ba6db50b60b803b2ec50291d31b854e216bf
Reviewed-on: https://chromium-review.googlesource.com/956525Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542014}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I32976b5a681bf39d5679e0f2acda7da390d4bae4
Reviewed-on: https://chromium-review.googlesource.com/956893
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542013}

This patch:
- Splits existing tests into different files testing different parts of
  the IDL (e.g. separate file for cssUnparsedValue.length)
- Fix some stylistic issues.

Bug: 774887
Change-Id: I8b37679b96d1b1b6e44c4eb596036dcafa88264b
Reviewed-on: https://chromium-review.googlesource.com/954525Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542012}

r501291 changed ExtensionWebContentsObserver::RenderFrameCreated such that
InitializeRenderFrame was no longer called for non-extension frames. This CL
changes it back so that InitializeRenderFrame is called for all frames; and
documents the same in the header. This would cause us to initialize the window
ID for non- extension render frames as well (which is consistent with other
code).

BUG=811384

Change-Id: I20a7039f8ba82fffbb1d17b635cfe0beb0279469
Reviewed-on: https://chromium-review.googlesource.com/956549Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542011}

a) if a dangerous download is cancelled, don't try to update it (with
a potentially half-destroyed profile). Like other notification types,
just close and return.

b) make the download service depend on the NotificationDisplayService.

Bug: 810302, 810738, 578868
Change-Id: Ibc3080510e128954e233485606d8de520b72a97c
Reviewed-on: https://chromium-review.googlesource.com/956087
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542010}

This avoid a conflict with class OmniboxState in an anonymous enum of
omnibox_view_views

Reland: Collided with another CL in flight
Reviewed in: https://crrev.com/c/954527

Bug: 801583
Change-Id: Id13084c7076f4934d34cad36fb932fac71c80c77
Reviewed-on: https://chromium-review.googlesource.com/956642
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542009}

Exposes an InkDropRipple SnapToHidden() as a replacement for animating
the inkdrop to a hidden state when removed from a parent.

This intends to remove unnecessary addition of new layers to the old
parent as it's still set when the Button is notified of its removal.

Bug: chromium:808639
Change-Id: I6d5a96409635caeaef2f2c1460172de9b0563595
Reviewed-on: https://chromium-review.googlesource.com/953658Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542008}

https://skia.googlesource.com/skia.git/+log/4997e14c80f1..dc0b12ec7a2d

$ git log 4997e14c8..dc0b12ec7 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 weili Harden size check during textblob deserialization
2018-03-08 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5164b797c..80964f97e (6 commits)
2018-03-08 reed Change behavior of custom image serial/deserial
2018-03-08 egdaniel Add ability to uninstantiate lazy proxies after every flush.
2018-03-08 brianosman Fill in some missing virtuals from canvas subclasses
2018-03-08 robertphillips Split GrDDL- & GrDirect- Contexts into their own files
2018-03-08 reed tighten check when we might overflow legacy shader math
2018-03-08 liyuqian Use clippedIR instead of clipBounds to filter coverage deltas
2018-03-06 benjaminwagner Upgrade IntelIris540 Win10 GPU driver, take 2.
2018-03-05 pirama Re-enable PGO for Skia
2018-03-08 robertphillips Fix preAbandonContext bot
2018-03-08 csmartdalton Revert "ccpr: Draw curves in a single pass"
2018-03-08 csmartdalton Revert "ccpr: Simplify triangle corners"

Created with:
  roll-dep src/third_party/skia
BUG=809200


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I9eaaf639d3a8850ef6dec1c62a067569b8b49f74
Reviewed-on: https://chromium-review.googlesource.com/956612
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542007}

We don't call this from outside GPU process. It's hard to properly
support this anyway except for enabling/disabling vsync which we do
based on command-line flags in PassThroughImageTransportSurface.

Follow-up CL will remove SetSwapInterval from GLContext and add
SetVSyncEnabled to GLSurface which will be used for enabling/disabling
vsync.

R=piman
BUG=480361

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If742a9c6b7a87644b76d42b6f602cd440826550b
Reviewed-on: https://chromium-review.googlesource.com/956550
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542006}

This patch changes "query-command-state.html" to utilize
|selection_test()| for ease of maintenance.
Before this patch, selectFirstTwoWords() is actually selects
latter two words of three words, so this patch tests actual
behavior cases.

Change-Id: I40c60de8ad510d025d6896e294eb6f71fb59acef
Reviewed-on: https://chromium-review.googlesource.com/945592Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Hikaru Nishida <hikarun@google.com>
Cr-Commit-Position: refs/heads/master@{#542005}

Rotate OOPIF content needs a render surface to apply correct clip. Make
sure that render surface is not skipped in surface aggregator.

Test https://codepen.io/anon/pen/jZJVBY the green rect should be clipped
by iframe.

R=enne

Bug: 817999
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie7692840efc089534ac0430e6422cbe98d392802
Reviewed-on: https://chromium-review.googlesource.com/946633
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542004}

I increased ninja -j for buildbot from 50 to 150 in crrev.com/877743
But this increase is not applied to LUCI bot.
Let me enable high build parallelism for LUCI also.

Bug: 731558
Change-Id: Ibd9ece5954142a67a1632b3d4a4a391e4d6f7805
Reviewed-on: https://chromium-review.googlesource.com/954766
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542003}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53014653d8eb..44048672dcd7

$ git log 53014653d..44048672d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I105b71aff616c2bb14066ebf729e24825480049b
Reviewed-on: https://chromium-review.googlesource.com/956407
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542002}

Previously this UI would be overlaid atop the content quad, making it
quite hard to read.

Bug: 820261
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib44d055e1774bdbb86c9a18f92d1fbe1d6e17bbb
Reviewed-on: https://chromium-review.googlesource.com/956504
Commit-Queue: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542001}

The fuzzer's corpus grows too large (10 GB). Disable it on ClusterFuzz
until it can be figured out why.

Bug: 820089
Change-Id: Ic9ef393dae9e27e13398817e2dfb9d6df3a40067
Reviewed-on: https://chromium-review.googlesource.com/956102
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542000}

BUG=728163

Change-Id: Ib519ec4a7ee122301c1ff17dc2f76cf66e48e465
Reviewed-on: https://chromium-review.googlesource.com/932014
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541999}

The toast only shows once, if the user goes from sync-confirmation-dialog to
the sync settings page via clicking "settings".

It will not show if the user clicks "ok I'm in". It also doesn't show after
subsequent visits to the sync settings page.

Bug: 800979
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8fc75f3b13dfe5c1e4088070a545e240baf26a85
Reviewed-on: https://chromium-review.googlesource.com/952463Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541998}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I12d82a0c1e4a8dd28157f928170285aa194ae2c5
Reviewed-on: https://chromium-review.googlesource.com/956246Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541997}

Bug: 819566
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90c75a6fe56117a42758118b158a26d75f3df0c2
Reviewed-on: https://chromium-review.googlesource.com/954011
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541996}

The new SDK fixes NET-559. net_unittests should no longer timeout with
this change.

Bug: 707030, 818046
Change-Id: Ie97df38a6bd02e1e9fcc22dce7f50888a3ad6f7e
Reviewed-on: https://chromium-review.googlesource.com/949970Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541995}

This should match the metric that is currently recorded in the
extension.

Bug: 698940
Change-Id: I2c1310a9b0911f4d610dfd5d8c74714ff8132913
Reviewed-on: https://chromium-review.googlesource.com/944719Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541994}

A common pattern for converting base::Optional<T> to T* is:
  optional ? &*optional : nullptr
This patch adds a helper to make the pattern simpler: OptionalOrNullptr.
This expression is relatively common, in part, because the styleguide
recommends T* parameters over Optional<T>:
https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md#When-not-to-use

This patch also updates callsites in third_party/WebKit/* and cc/*.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2c8b31b52480ad69228123df951486634edec006
Reviewed-on: https://chromium-review.googlesource.com/950226
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541993}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/670a0ff9f5a1..e22d01d973dc

$ git log 670a0ff9f..e22d01d97 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 vpalatin biod: add new biometrics manager
2018-03-08 nverne Added Start/StopVmConcierge to debugd dbus constants.

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 820128
Change-Id: I3916922443ca1ce9cbbecf56918e23df5c9d916e
Reviewed-on: https://chromium-review.googlesource.com/956625Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541992}

[1] Move tests
mkdir chrome/browser/ui/app_list/search/tests/
tools/git/move_source_file.py ui/app_list/search/*unittest.cc chrome/browser/ui/app_list/search/tests/
tools/git/move_source_file.py chrome/browser/ui/app_list/search/*unittest.cc chrome/browser/ui/app_list/search/tests/

[2] Move other files
tools/git/move_source_file.py ui/app_list/search_provider.* chrome/browser/ui/app_list/search/
tools/git/move_source_file.py ui/app_list/search/* chrome/browser/ui/app_list/search/

[3] Clean up, and move items from //ui/app_list/BUILD.gn into //chrome/browser/ui/BUILD.gn or //chrome/test/BUILD.gn
rmdir ui/app_list/search
grep -rl "#include \"ui/app_list/app_list_export.h\"" chrome/browser/ui/app_list/search/* | xargs sed -i "s/#include \"ui\/app_list\/app_list_export.h\"//g"
grep -rl "APP_LIST_EXPORT" chrome/browser/ui/app_list/search/* | xargs sed -i "s/APP_LIST_EXPORT//g"
git cl format

Bug: 733662
Change-Id: I493fcc9c16b8c75a0ba57f8258f6c6d11c5589ea
Reviewed-on: https://chromium-review.googlesource.com/955884Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#541991}

Remove |new_window| param from
ash::WindowPositioner::GetBoundsAndShowStateForNewWindow(). This
was not what it sounded like --- when it was non-null, it was a
pre-existing window. This was added in [a] (and later refactored
around), seemingly as a way to allow unit tests to call
positioning code on Browser objects that already had a
window (and that was the topmost). In production, this was
already always null. Update those unit tests to also use a
Browser in a non-fully-initialized state with a null window and
a DCHECK to enforce this.

TabsApi is the only other place that calls the positioning code.
It was using the browser window that originated the call to
window.create as the param to WindowSizer, but this doesn't make
sense because the param doesn't mean "base the position off this
other browser's window", but rather "position this browser's
window". On !CrOS, you can trace through the code to find that
because the passed-in bounds are always null, this parameter is
completely ignored anyway. See
WindowSizer::DetermineWindowBoundsAndShowState(). On CrOS, that
parameter wouldn't have been ignored, but I find it very
unlikely that was an intentional difference.

[a] https://chromiumcodereview.appspot.com/11072002/

Change-Id: I32adb6849d1a16add0022ef36d25a85a66d65c3f
Reviewed-on: https://chromium-review.googlesource.com/950416Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541990}

These DCHECKs don’t tell us anything other than that we fail to update
the browser-side notion of location when a document writes into an
about:blank document, but we know that.

BUG=820063,718570

Change-Id: I469d75afaafcd87c98529037a1fbbca155ce806c
Reviewed-on: https://chromium-review.googlesource.com/956282Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541989}

Added the Lookup menu item to the textfield context menu.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/923548

This is a reland of https://codereview.chromium.org/2164483006

Bug: 617436
Change-Id: I6a84f8f5611de48bee05160b719cb2cc8c040a87
Reviewed-on: https://chromium-review.googlesource.com/941733
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541988}

This CL mojofies the legacy IPC
ServiceWorkerHostMsg_PostMessageToWorker.

BUG=772713,813749

Change-Id: I7e6ad8d411c820d22fe7b91b0bd2036b48aabe69
Reviewed-on: https://chromium-review.googlesource.com/933867Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#541987}

Bug: 820070
Change-Id: I61115868be9edf2bb6be1214e7eb4283faf1cf7b
Reviewed-on: https://chromium-review.googlesource.com/956308
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541986}

This patch makes DataTransferAccessPolicy to be an enum class for better
type safety and improving code health. Using forward declaratuion in
other header files instead of including |DataTransferAccessPolicy.h|.
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Id516b37b0d71ba348b9f146f5ce546cf28316cf7
Reviewed-on: https://chromium-review.googlesource.com/954777Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541985}

if menu animation started.


Bug: 799524
Change-Id: I1d87a7944a8f98f9617ccb071ffae1adef491605
Reviewed-on: https://chromium-review.googlesource.com/953823
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541984}

R=dpranke@chromium.org

Change-Id: I25bf5c2b3c64649a7cfa49481a4a9e3a0d20a58f
Reviewed-on: https://chromium-review.googlesource.com/941205
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541983}

Remove include of <vector> and <string> within Blink when it isn't
needed.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8d3cf66ecc95c02865153dbd4af475b400804476
Bug: 820271
Reviewed-on: https://chromium-review.googlesource.com/954764Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541982}

In SPv1 mode, LayoutObject::AdjustStyleDifference will cause subtree paint invalidation
(including PaintLayer repaint) on change of paint properties or z-index, but only
if there is no direct compositing reason for the object. The reason for the LayoutObject
paint invalidations was to cause raster invalidation as a side-effect. Painted
display list output of individual LayoutObjects does not change as a result of these
updates.

In SPv175 mode, we don't need to invalidate paint of individual LayoutObjects just
becaue of these changes, since raster invalidation happens via a new PaintChunk
mechanism. However, we still need to cause PaintLayer repaint if any paint property
tree nodes are added or removed, or z-index changes, to cause re-drawing of PaintChunks
with the correct paint properties and order.

There is already invalidation of PaintLayer repaint for paint property node change,
in PaintPropertyTreeBuilder::UpdateForSelf and ::UpdateForChildren (it was added
recently, after the code being removed in this CL was committed). Therefore we
only need to invalidate repaint for z-index change. Further, this is only needed
if the LayoutObject already had a PaintLayer, because z-index has no effect on
objects without a PaintLayer, and there is already invalidation happening on
PaintLayer addition or removal.

Tested by:

LayoutTests/paint/invalidation/compositing/chunk-reorder.html
svg/transforms/change-transform-to-none-shape.html

Bug:814711

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I208b03b9e6b1a6635dab9585b8884ed0e2f8688d
Reviewed-on: https://chromium-review.googlesource.com/954352
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541981}

Flakily fails with:
../../chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1681: Failure
Value of: IsHelpAvailableOnDetailMenu()
  Actual: false
Expected: true

NOTRY=true
TBR=xiyuan@chromium.org

Bug: 819987, 787024
Change-Id: I133007c1411f714f2b7646c0c0d949c577c63037
Reviewed-on: https://chromium-review.googlesource.com/956276
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541980}

Convert all messages with prefix IDS_FILE_BROWSER_METADATA.

Also fix 2 types: "for" and "screenshot" that I noticed.

Tested in a local chromeOS build.

Bug: 769395
Change-Id: Ie286f00f2ec54b3227ded5fedcd944e55ade1685
Reviewed-on: https://chromium-review.googlesource.com/952108Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541979}