- 09 Apr, 2019 40 commits
-
-
Kush Sinha authored
Screenshot: https://crbug.com/933482#c3 Bug: 933482 Change-Id: I0a260745503bb46be895896c95492a9c35815d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556794 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649070}
-
Anders Hartvoll Ruud authored
This is needed for the Cascade Project, which will use CSSPropertyName as the HashMap key. HashTraits requires the key object to support "empty" and "deleted" values. This is implemented by storing kEmptyValue and kDeletedValue in an integer which is shared with the CSSPropertyID. Constructing empty or deleted CSSPropertyNames is not advisable outside of HashTraits, hence the relevant constructor is exposed via friendship. (Inspired by PropertyHandle). BUG=947004 R=futhark@chromium.org Change-Id: I48bfb3707f73f0cadd7696075fce622352f9dee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553555Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#649069}
-
Dominic Battré authored
This reverts commit d5b00821. Reason for revert: Breaks compilation. ../../content/public/common/web_preferences.h:18:10: fatal error: 'third_party/blink/public/mojom/v8_cache_options.mojom.h' file not found #include "third_party/blink/public/mojom/v8_cache_options.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > This CL moves bluetooth folder from public/platform/modules to > public/mojom/ to gather mojom files to mojom folder with > creating web_bluetooth_mojo_bindings. > > Bug: 919393 > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649061} TBR=kinuko@chromium.org,blundell@chromium.org,haraken@chromium.org,jbudorick@chromium.org,dougt@chromium.org,hnakashima@chromium.org,jkim@igalia.com Change-Id: I0ebd0abd67e8ed975cb2f517800296493cdda513 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559180Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649068}
-
Dominic Battre authored
This CL fixes a crash that was introduced in ~PrefNotifierImpl(). The call of pref_service_->HasInMemoryUserPrefStore() dereferenced the user_pref_store_ of the PrefService which was destroyed before the pref_notifier_ was destroyed. Bug: 942491, 946668, 945772 Change-Id: I1f5749e013311a4a13f94214435f8a1b7e99329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559138Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649067}
-
Stephen McGruer authored
Intent to ship with 3x LGTM: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/UMxgGkxhdCo/CHZ2H9DsBgAJ Bug: 948657 Change-Id: I9c9ac4969f5708c310c9a8a95120fd5a0d3cdc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553448Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649066}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b81b08e4eeb2..304f857d260e git log b81b08e4eeb2..304f857d260e --date=short --no-merges --format='%ad %ae %s' 2019-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src e8c2d95ed45f..d90aae9a5a6c (5 commits) Created with: gclient setdep -r src/third_party/angle@304f857d260e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I09554af90addb34beaf15df17df335effdc61bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649065}
-
Peter E Conn authored
This change is apart of a larger sequence of CLs for implementing notification delegation auto-enrolment. See https://crbug.com/945258. Bug: 945278 Change-Id: I6e3d29049c78a2803d376d55247b2dd2bdeb3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547738 Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#649064}
-
Marc Treib authored
This changes syncer::GetTimeDebugString from base::TimeFormatFriendlyDateAndTime to using icu::SimpleDateFormat directly. This results in a locale-independent format, which (a) eases debugging, and (b) is also more consistent with the rest of chrome://sync-internals. This also lets us include the time zone, which again helps with debugging, especially when comparing with server-side logs. While we're here, this also removes the weekday (which seems useless) and switches to a 24-hour clock. Before: Monday, April 8, 2019 at 6:36:38 PM After: 2019-04-08 18:36:38 +02 Bug: 948074 Change-Id: I6e166850201cc7fc9f8c32c7e3aacf7f661c74c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556810Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649063}
-
W. James MacLean authored
Simple re-factor to avoid allocating with 'new'. TBR=alexmos@chromium.org Bug: n/a Change-Id: I4668235abf84eb3d07c2eb56f1a96196928cdf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559014Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#649062}
-
Julie Jeongeun Kim authored
This CL moves bluetooth folder from public/platform/modules to public/mojom/ to gather mojom files to mojom folder with creating web_bluetooth_mojo_bindings. Bug: 919393 Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#649061}
-
Dominic Battre authored
If ShowAndFocusNativeWindow() fails, the always_on_top_window_killer_win does not capture a screenshot because the test fails with a CHECK instead of a timeout. This CL just makes sure that a screenshot is captured every time ShowAndFocusNativeWindow() fails. Bug: 711256 Change-Id: Ica8a4ff7493ca0de36a17e147c9c2806c275f30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559173 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649060}
-
Abhijeet Kandalkar authored
This is a reland of commit 98136ca8. Original change's description: > Revert "Rename platform/wtf/size_limits.cc to platform/wtf/size_assertions.cc" > > This reverts commit 7a110199. > > Reason for revert: Breaks the build -- must also update references in BUILD.gn. Not sure how CQ didn't > catch it. > > Original change's description: > > Rename platform/wtf/size_limits.cc to platform/wtf/size_assertions.cc > > > > Bug: 950138 > > Change-Id: If8e9c4bb1df64d05d94e1044b1856484641989d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557482 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#648876} > > TBR=haraken@chromium.org,abhijeet@igalia.com > > Change-Id: I87618a4cdc6c520cdb279765966be908abf26e35 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559017 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648880} Bug: 950138 Change-Id: I2dcc4e1a28717e17ed73199aab93fce3b1be6f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559102Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f0fbbe4639b..4ed2d0537be1 Created with: gclient setdep -r src-internal@4ed2d0537be1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I628b44fad320f19369dd70d75dc24b5437123a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649058}
-
Marc Treib authored
This error was already shown in the avatar menu, but settings still looked like everything was working fine. The fix is in syncer::GetStatusLabels, which now returns SYNC_ERROR instead of PRE_SYNCED in this case. Pre-Unity, there was an actual message saying that Sync was reset from the dashboard, but with Unity it seems that we only ever show the generic "isn't working" message. Bug: 943983 Change-Id: Id7458bf8fab7e73fa1aa14934fe6505f0ba9980a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559176Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649057}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/86820d1f3a7d..e82336dd47a5 git log 86820d1f3a7d..e82336dd47a5 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 lalitm@google.com Merge "trace_processor: properly handle nulls for ref_type enum" Created with: gclient setdep -r src/third_party/perfetto@e82336dd47a5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1028ec34717cdbb02da1077f0176e2c98b970fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559265Reviewed-by:
-
David Roger authored
When the reconcilor does multiple cycles, we need to be able to wait until all the cycles are finished. To enable this, this CL adds a SCHEDULED reconcilor state: when the reconcilor does multiple cycles, it will go to the SCHEDULED state without going through the OK state. For example, if there are two reconcilor cycles, the state will be: RUNNING -> SCHEDULED -> RUNNING -> OK Bug: 948140 Change-Id: I145c30eb38fdc06d72e88ddd4ecbc568440fa62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550430Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#649055}
-
chrome://sync-internalsMarc Treib authored
In some past investigations, it might have been useful to know since when an auth error state has existed. Bug: 948074 Change-Id: I4220dbea552725cd0d75b35e563e292f7d5eea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557027Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 27dbbe2f. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I12987ab6505cca2413993d216f5a9204d02540af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559357Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649053}
-
Martin Kreichgauer authored
r1552248 changed the WebAuthn behavior for user refusing attestation consent to remove the attestation statement rather than fail the request. Hence we should change the button label of the new WebAuthn UI attestation permission sheet (r1547344) from "Cancel" to "Block". Bug: 929423,850955 Change-Id: I885df62cae3dcadc858a63c11c8a0a619afbc360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559332 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#649052}
-
Maksim Moskvitin authored
Bug: 906611 Change-Id: I63a397b720c186df461d2e55dbe5ced19418d26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1449677 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Oleg Davydov authored
In order to investigate problems with force-installed extensions we have statistics of failures divided by feilure reason. One possible reason is “at the time of check extension is still installing”, in this case we want to know more precise stage of installation process. We already collect this stage in InstallationReporter/InstallationTracker, this commit enables sending this data to UMA to get broad picture of problems. Change-Id: I40153c2999c8393c8b927f9ef97b09f9fe016ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556850Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649050}
-
Marina Ciocea authored
The ICE transport object has been renamed in DTLS idl from transport to iceTransport. Update WPTs accordingly. Mark the ice connection state test flaky for now because the state surfaced in blink layer is currently not consistent with the state in WebRTC layer. Bug: 907849 Change-Id: Ifc88cb8e877ce15729c355f54c85cc1a34556d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533878 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#649049}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I8d258f57f8c376cf3bcbdfa33bf60aafa222e59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559074 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649048}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6145021beb12..072a6f14b64c git log 6145021beb12..072a6f14b64c --date=short --no-merges --format='%ad %ae %s' 2019-04-09 msalama@google.com Add a metric that tracks native code memory footprint. Created with: gclient setdep -r src/third_party/catapult@072a6f14b64c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947012 TBR=skyostil@chromium.org Change-Id: I5d6bad653b902b3eba56ae6ab550e26aea801e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559408Reviewed-by:
-
Ramin Halavati authored
Incognito toolbar menu shows the number of incognito open windows in a disabled button that is not navigable and readable by screen narrators. The accessible title of the menu is updated to tell the number of open incognito windows. Example accessible title: "2 open incognito windows." Bug: 896235 Change-Id: Idc91eae7d40e0299b6b3d6448d3cb05b5fe7e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553543 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649046}
-
Abhijeet Kandalkar authored
This CL moves platform/wtf/string_hasher to platform/wtf/text/ and ports other dependent files to refer to a new include path. Bug: 950134 Change-Id: I9776b7d5139d1857fb39812d30f649189730710d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557669Reviewed-by:
-
Oskar Sundbom authored
The APM experiment no longer includes a variation that launches the process on startup, so the field trials probably shouldn't as well. Bug: 874784 Change-Id: I1f8b6fabbb010ef496fc0e37e89afdcf140eabba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524279Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649044}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/82418c821689..b81b08e4eeb2 git log 82418c821689..b81b08e4eeb2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src e06c7e9a515b..0527c9db8148 (1 commits) Created with: gclient setdep -r src/third_party/angle@b81b08e4eeb2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7cab0837928501aac37bb2552c4f9deba8949bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559648Reviewed-by:
-
Nikita Podguzov authored
Bug: 950502 Change-Id: Ia22aff8acd78603b55e67f048878a495fa625162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556843Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#649042}
-
Andreea Costinas authored
Add the strings for the notifications that will inform the user about a planned TPM firmware update that will result in user data being deleted. Bug: 875266 Change-Id: I8cd812ddd4374b6c0cd3e71fb8d271008d50834d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554348Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#649041}
-
Henrik Boström authored
Spec: https://w3c.github.io/webrtc-stats/ Updates the whitelist to reflect the RTCMediaHandlerStats hierarchy, allowing up-to-date "track" stats to be exposed, as well as "sender" and "receiver" stats objects. In order to deal with the fact that some dictionaries share a common type (i.e. audio and video metrics are in different dictionaries with the same type) the MergedRTCStats class is introduced. Also, to allow the test to pass even though some dictionaries have not been implemented yet ("sender", "receiver") these are marked as optional. Implemented dictionaries are marked as mandatory, making the test fail if a regression makes them not be present during the call. Bug: webrtc:10428 Change-Id: Ieb5a849f804fdeffcec819e4a3f0c2bef063e4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553554Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf52d711fbcb..865cad89b916 git log cf52d711fbcb..865cad89b916 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 jiawei.shao@intel.com Support multisampled rendering on Metal - Part I Created with: gclient setdep -r src/third_party/dawn@865cad89b916 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I335970e43aefac97e45b26d16dcd4df8583cbd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559771Reviewed-by:
-
Andreea Costinas authored
This CL is based on comments on CL:1470751. It - moves initialization code from gtest SetUp() to constructors. See https://github.com/google/googletest/blob/master/googletest/docs/faq.md - moves FakeSessionManagerClient PODs initialization from constructor initialization list to header. Bug: none Change-Id: If83c75cba304c0bbdc87b78102312ad31548366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543549 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#649038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/397220b4e542..5f0fbbe4639b Created with: gclient setdep -r src-internal@5f0fbbe4639b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I921963049b9c7cec83ef067649aa10cd9b1cd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559770Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ec122ba..78334315 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f96d47c2a6ef2064fd93e40602cd0210b54a126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649036}
-
Oleg Davydov authored
There was a path in ExtensionDownloader code, where failure was silently ignored: bad URL for CRX in ExtensionDownloader::FetchUpdatedExtension. Also there was a problem in kiosk app managed tests: they checked only app data fetching from chrome web store, but wrongly considered extension downloading failure as app data fetching failure. Bug: 938265 Change-Id: Iccd59cf10bd92767bee2c35e142ab590001fa8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558232 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Adjust to changes in coding style and renames that have happened over the years. TBR=haraken Change-Id: I9ceef9ad75d255eed856c53ee27a94d4730b4287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559171Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#649034}
-
Mikel Astiz authored
We leverage ModelTypeStore's built-in functionality to run logic in the backend sequence, via ModelTypeStore::ReadAllDataAndPreprocess(). As detailed in the linked bug, this avoid UI jank of ~100 ms at the 95th percentile and 500 ms at the 99th. Bug: 902203 Change-Id: I86a9709c63d4fa0f402120fc05d73540ea43b7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559313Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 5d60b670. Reason for revert: this patch causes webui_polymer1_browser_tests failure on Linux Chromium OS ASan LSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32626 E.g. [ RUN ] ContextMenu2/FilesAppBrowserTest.Test/checkDeleteDisabledForReadOnlyFolder_DriveFs [FATAL:pref_service.cc(137)] Check failed: (sequence_checker_).CalledOnValidSequence(). #5 0x555945f0598c in PrefService::GetBoolean(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const ./../../components/prefs/pref_service.cc:137:3 #6 0x555938160f41 in chromeos::AccessibilityManager::IsSpokenFeedbackEnabled() const ./../../chrome/browser/chromeos/accessibility/accessibility_manager.cc:502:44 #7 0x55593816d6a9 in chromeos::AccessibilityManager::UpdateChromeOSAccessibilityHistograms() ./../../chrome/browser/chromeos/accessibility/accessibility_manager.cc:1174:3 Original change's description: > Compute image description histograms on the right thread. > > The code to compute image description histograms was > hitting a DCHECK because it was running on the wrong > thread. I temporarily disabled that code, this change > re-enables it and fixes the underlying issue. > > I noticed that we had code to compute accessibility > histograms that were split by platform - on some platforms > we were running the code on the UI thread, on other platforms > on a separate thread. > > To solve this, I changed the code so that we can update > histograms on either thread on any platform. > > Bug: 940805 > Change-Id: I6967ed58810f75f61e2b91a2e00a778de76d4960 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551803 > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648795} TBR=dmazzoni@chromium.org,jam@chromium.org,katie@chromium.org Change-Id: Ia256fd7be70574be2218ba7ad78ce94496575ca1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559413Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#649032}
-
Mikel Astiz authored
Trivially rename the class in accordance to more modern naming conventions, in particular SyncEngineImpl. Bug: 950852 Change-Id: Iea1761ef3866bcf25e1373e6bb3a83a2fac29fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559312Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649031}
-
