GitLab

This refactoring is needed to access Profile
within ExtensionManagemnt class in
https://crrev.com/c/1268938

Bug: none
Test: update unittests
Change-Id: Icdd53213a270d68e535d9846c5cc60dc19a1fb9e
Reviewed-on: https://chromium-review.googlesource.com/c/1275889Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598908}

Note that the default policy value used to be only "PIN", so fingerprint may
be disabled for users until their prefs are reset to default values (for
example, they can remove and re-add their account).

To avoid this issue in the future, the default policy value is changed to "ALL".

Bug: 884266
Change-Id: I8809a2fcd571149df60cd2ef2013ac6d73971397
Reviewed-on: https://chromium-review.googlesource.com/c/1271586
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598907}

This will partly fix the problem of Settings and Discover internal apps.
Both of their kAppType are set to BROWSER, which is not what we want for
window drag. For real browser window, its frame will only be hidden when
it is full-screened. Add the restriction here to avoid the problem of
Settings and Discover when they are only maximized.

Bug: 877723
Change-Id: Ib6b6708b8065940a1a94be89cdde6b317093cdb2
Reviewed-on: https://chromium-review.googlesource.com/c/1274839Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598906}

This flag is now true and the feature is guarded by an actual
FeatureFlag.

Bug: 61248
Change-Id: I10633a52d5b4fc94fea882d495e8bd02d17a8c70
Reviewed-on: https://chromium-review.googlesource.com/c/1277185Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598905}

This change speeds up reaction time by:
 - adding a retry mechanism to ScriptTracker::CheckScripts when finding
 elements on the page.
 - merging conditions that look for the same elements into one call to
 WebController::ElementExists

This change also introduces a helper for running multiple ElementExists
or GetFields at the same time. The helper makes things simpler and also
hides the fact that we temporarily have to run these in sequence,
instead of in parallel.

This changes reproduces the behavior of the Java implementation, which
would retry looking for elements to satisfy unmet precondition checks
every 100ms for up to 2s. The approach taken is quite different, since
in Java, this happenened on separate threads.

The idea is to have the helper keep track of everything the
preconditions want to check and reporting the result incrementally to
the preconditions, and eventually to the controller.

CheckScripts now:

1. applies all the static checks on preconditions, such as URL or
   parameters
2. looks for all elements mentioned in preconditions
3. reports the resulting set of scripts to the controller
4. waits 100ms
5. looks for all elements mentioned in preconditions that were
   not found in the previous run
6. reports the new set of scripts to the controller, if there's
   been any change
7. go back to 4 until all elements were found or the 2s deadline
   is reached

Bug: 806868
Change-Id: I796c83f156531bd3999fc464ca162be0d70ad4b0
Reviewed-on: https://chromium-review.googlesource.com/c/1273299
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598904}

Change-Id: I597847a123db38e2fe648a87ef19e920c7ebec06
Reviewed-on: https://chromium-review.googlesource.com/c/1274047Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598903}

Adds bool parameter for enabling/disabling NTLM on Remount.

Bug: chromium:888096
Change-Id: I072362ef347f57831db518ebe10dcaa11327ea8b
Reviewed-on: https://chromium-review.googlesource.com/c/1269175Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598902}

When the user is signed in and syncing, the signin-allowed
toggle is now disabled.

Note: This CL is adapted from crrev.com/c/1273517 and
removes the hint, i.e. there are no string changes here.

Bug: 892745
Change-Id: I1778115390518860fca4b4f11588d5ca7c7b9210
Reviewed-on: https://chromium-review.googlesource.com/c/1275849Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598901}

This requires a special DEPS exemption for feature policy to use url::Origin
objects.

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7a49c9da4f2401e96f44800456d4109338c44941
Reviewed-on: https://chromium-review.googlesource.com/c/1011571Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598900}

Generalizes the NoScript page load metrics observer to also support
ResourceLoadingHints since it has the same steps.

Bug: 894133
Change-Id: I0b4d6ed8ae72b9157bead694f82af5fd524a9184
Reviewed-on: https://chromium-review.googlesource.com/c/1274049Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598899}

We allow using multiple profiles but ARC works only with primary. This
checks this condition (wider case) and does not create provider.

TEST=Manually. no longer crash.
BUG=891749

Change-Id: I706f2c4c6f10e0eb889d52d546d4a7bc34459d99
Reviewed-on: https://chromium-review.googlesource.com/c/1277377
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598898}

Bug: 884817
Change-Id: Ie08d29f7f5b1b8715740a34be8d5894fd3b90d2b
Reviewed-on: https://chromium-review.googlesource.com/c/1277645
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598897}

This CL uses document fragments to append scripts faster. Also, we do
not need to wait until onload of one script to begin appending the next.

Bug: 626703, 883837
Change-Id: I0bc010640793d6a7113d404f2838fd5cfe88ab25
Reviewed-on: https://chromium-review.googlesource.com/c/1265901Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598896}

Change-Id: Ia1e7de76592b48ad376ed77cfcb5dbe6e0106f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1276865Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598895}

Previously, a PaintLayer whose compositing inputs changed didn't propagate those
changes to the squashing layer, if the PaintLayer was squashed.

Bug: 890638

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0ad3bb79aa15e59eca9efd443f40cd5b66dcd583
Reviewed-on: https://chromium-review.googlesource.com/c/1274895
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598894}

- extract all URLRequestContextGettter and NetworkContext creation logic into HeadlessRequestContextManager;
- reconcile network service and non-network service code paths as much as possible;
- fix a couple of issues with handling of redirect URLs in DevToolsURLLoaderInterceptor that
    were different from URLRequestJob-based interception and caused headless tests to fail;
- plumb a call to NetworkServiceTestHelper::RegisterNetworkBinders() in headless utility
    process when running tests to let network service tests inject the magic client certificates;
- update traffic annotations as they just moved;

Bug: 838291,792676

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia29143a85b0c0293fae13079ec9f88ff5ba924f9
Reviewed-on: https://chromium-review.googlesource.com/c/1263566Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598893}

We don't need it during CommitNavigation - we already
called WillSendRequest during BeginNavigation instead.

This is a preparation to stop (ab)using WebURLRequest when
committing a navigation - the callbacks won't be issued as well.

Bug: 855189
Change-Id: If0b792cd3e43171fe3830005af61c660b93e8c6e
Reviewed-on: https://chromium-review.googlesource.com/c/1271875
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598892}

Bug: 890598
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2aee8bf37891a163ce8182ef1c4e620eab5dcf2a
Reviewed-on: https://chromium-review.googlesource.com/c/1276890Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598891}

Add assumptions/requirements for the FeedHistoryHelper class in
comments.

Bug: 831641
Change-Id: I8c6a1a1c0acc667fc4c2da00a41b9bab7c3574a7
Reviewed-on: https://chromium-review.googlesource.com/c/1274463
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598890}

Bug: none
Change-Id: I8c83cc8ca8184aa4bf2f991e947a716d785bd455
Reviewed-on: https://chromium-review.googlesource.com/c/1274128Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598889}

Bug: 805600
Change-Id: Ibed20e07b9f52a80302c2ea294f204182bd917d7
Reviewed-on: https://chromium-review.googlesource.com/c/1260505Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598888}

https://chromium.googlesource.com/webm/libvpx.git/+log/ecc31d28781c..e188b5435de7

$ git log ecc31d287..e188b5435 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 marpan Revert "vp8: Increase rate threshold for overshoot-drop"

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I0bcae4a78be88747ccf8a42148b4a8fca8e91c0d
Reviewed-on: https://chromium-review.googlesource.com/c/1276553
Commit-Queue: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598887}

A child can be "throttled" for an arbitrary length of time if it is never
embedded. This skews blocked duration metrics. Simply don't report those
metrics if a surface is blocked on a parent.

Bug: 890767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I3c8a8494a5b1e5a973b2e5c2b61cffe5c2b76f6f
Reviewed-on: https://chromium-review.googlesource.com/c/1274591
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598886}

To facilitate sharing logic between DataReductionProxyURLLoaderThrottle and DataReductionProxyInterceptor.

Bug: 721403
Change-Id: I8dd9493346d58c1c6fb99b7887d3775645b650a3
Reviewed-on: https://chromium-review.googlesource.com/c/1273950
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598885}

We need to update the bottom margin on initialization in case that
browser controls constraints are not updated during navigation.

Bug: 884803
Change-Id: I117aa9566b73cd1434d4f8b1331c08688b347573
Reviewed-on: https://chromium-review.googlesource.com/c/1277369Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598884}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/a44009e38ccd..801cca810424


git log a44009e38ccd..801cca810424 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 johnkslang@users.noreply.github.com Merge pull request #79 from Thog/csharp-definition


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@801cca810424

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4d367ec17f47c9412d727f2706a6362615140f49
Reviewed-on: https://chromium-review.googlesource.com/c/1277465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598883}

Adds bool parameter for enabling/disabling NTLM on Mount.

Bug: chromium:888096
Change-Id: Ie2f380da0965472b663b8997d21de1c727edb718
Reviewed-on: https://chromium-review.googlesource.com/c/1259286Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598882}

Grab the device scale factor from the client instead (which is more
correct anyway). This will pave the way for getting rid of
OnFirstSurfaceActivation.

Bug: 893731
Change-Id: Ib274ade2fcb3295cc667bf7bcf389e9c83e66d47
Reviewed-on: https://chromium-review.googlesource.com/c/1274452Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598881}

This reverts commit 8b3faf7c.

Reason for revert: crbug.com/894193

Original change's description:
> Refactor menu footnote unittests
> 
> Bug: 889229
> Change-Id: I7b2a0f0c64b136f7210fda4c6ead654558de1e56
> Reviewed-on: https://chromium-review.googlesource.com/c/1271780
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598076}

TBR=msw@chromium.org,nicolaso@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 889229
Change-Id: Idc3a12270c7f11b84cfc3f6437a85f3472d0f405
Reviewed-on: https://chromium-review.googlesource.com/c/1276545Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598880}

crrev.com/c/1156995 introduced a regression in locked fullscreen mode where it
became possible to exit the mode using the controls that auto-hide at the top
of the screen (normally they should be disabled in locked fullscreen mode).

Fix this by disabling immersive mode if we're in locked fullscreen, and also
disable the FullscreenControlHost which shows a bubble exit target when no
other UI is shown.

Bug: 883104
Change-Id: I489e471aed2b3f9f809ad1d11f76b37d6c6b4a00
Reviewed-on: https://chromium-review.googlesource.com/c/1234334
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598879}

The KA relies on the FocusedNodeChanged event that it receives as a
RenderFrameObserver. This event however is not triggered when the focus
moves outside the frame (e.g. on the omnibox). In order to detect such
a focus change we use DidEndTextFieldEditing to hide the KA, same as
for the autofill popup.
When the user taps back onto the field DidCompleteFocusChangeInFrame is
called, which leads to the accessory being shown again.

TBR for 1 line in components/autofill/content/renderer/autofill_agent.cc
TBR=dvadym@chromium.org

Bug: 893695
Change-Id: I76a66ce43fad0a74c0abbc10c42d8916fd7e891a
Reviewed-on: https://chromium-review.googlesource.com/c/1268246Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598878}

This was added when I thought the bug was a CHECK, but none of the dumps
include any data in the value aliases, which leads me to believe the bug is
that |this| has been deleted.

BUG=867035
TEST=none

Change-Id: I4189b97f62c1a581086cdc6bb4563b54ae3724f2
Reviewed-on: https://chromium-review.googlesource.com/c/1277187Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598877}

Details :
1 - Search filter is cascaded before the type filter in the filter chain,
    hence chips that don't have item types in the search text will be hidden.
2 - Empty view will show a different string when we are in search mode
    and we have no matching results.

Bug: 892332
Change-Id: Ib99534b9c1a0b3f5333d4646356863a8639cd926
Reviewed-on: https://chromium-review.googlesource.com/c/1275140
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598876}

Some of the DCHECKs were disabled due to a bug which was causing
same anchor element to be reported multiple times to the browser process.
Now, since that bug has been fixed, we can reenable some of the
DCHECKs in navigation predictor which ensure that the size occupied
by any target HREF (after aggregating across all anchor elements
that point to the same target) does not exceed 1.0.

Bug: 894092
Change-Id: Iec003a857e8b990bcc01f522e49ed8cdd6191137
Reviewed-on: https://chromium-review.googlesource.com/c/1277372
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598875}

Also fixed swiftshader symbol generation on MacOS

Bug: chromium:719257 chromium:888082
Change-Id: I5e8754c278914c519e71c77ed792f198516a1556
Reviewed-on: https://chromium-review.googlesource.com/c/1276550Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598874}

This is a follow up fix for go/cgcl/1272238.

Bug: 893521
Change-Id: I3ea08e13eb0909e7b216448d9cdad2761c5e4647
Reviewed-on: https://chromium-review.googlesource.com/c/1277385Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598873}

The feature will be rolled out gradually to M70 and should be enabled by default on M71

Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib69d8f919a48be151b282ba78677c19749481723
Reviewed-on: https://chromium-review.googlesource.com/c/1269183
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598872}

This CL adds the metrics for download media parser, so we can
understand the overall reliability of the feature.

TBR=jwd@chormium.org

Bug: 826021
Change-Id: I2f556b3ab206c2a2cdbca9bd8d7d99979cd385a9
Reviewed-on: https://chromium-review.googlesource.com/c/1257859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598871}

Move the existing SadTabBulletSpan to a new
ui/widget/../ChromeBulletSpan.java and re-use for the material design
incognito NTP. This fixes a text wrapping issues caused by the bullet
previously being included in the text string.

BUG=740619,740619

Change-Id: I172ee3e388962efc90d0defe01525828491883cf
Reviewed-on: https://chromium-review.googlesource.com/c/1277376Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598870}

The mobile setup UI loads carrier activation site in a webview.
The webview is initially hidden, and then shown when the carrier
content is loaded. This prevents any interstitial pages from getting
displayed - in particular, an SSL error page in M71+.

While the issue should be fixed server-side, by the carrier, not showing
the interstitial (however scary it is), prevents the user from
proceeding with mobile activation. To unblock testing the flow, update
mobile setup UI to display the webview contents sooner - when the
carrier page load starts (instead of when the navigation to the target
page is committed, which will not happen if interstitial is shown).

BUG=894281

Change-Id: I36de9d00afcf0f058bac95a938381c75d5e9a18e
Reviewed-on: https://chromium-review.googlesource.com/c/1275138Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598869}