- 18 Jul, 2017 40 commits
-
-
Emil A Eklund authored
Follow up to the CL that moved PaintFillLayer to BoxModelObjectPainter, this change moves the PaintFillLayers method to the box model class. Bug: 743221 Change-Id: Iefcb91e4e2ec21e338fa0d6f6ea00f5a87ebaa7a Reviewed-on: https://chromium-review.googlesource.com/572146Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487518}
-
Edward Jung authored
Set the blue action buttons on a per interstitial page type basis rather than having it as a default colour. Bug: 731250 Change-Id: I45d8d6f3beacf211522ea2cc2de2569914aa20cc Reviewed-on: https://chromium-review.googlesource.com/570036Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Edward Jung <edwardjung@google.com> Cr-Commit-Position: refs/heads/master@{#487517}
-
Yusuf Ozuysal authored
Change-Id: I410e86b47399202ca2871d9e284e37d7668897e0 Reviewed-on: https://chromium-review.googlesource.com/575661Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#487516}
-
Bence Béky authored
Change-Id: If62f6b1eb3ea7b84ad80512d33930b3dc3ce331b Reviewed-on: https://chromium-review.googlesource.com/570859 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#487515}
-
Kenichi Ishibashi authored
We don't have to use V8PrivateProperty to anymore because PerformanceObserver holds PerformanceObserverCallback in TraceWrapperMember and wrapper tracing makes sure that a callback will be alive while the corresponding observer is alive. BUG=700680 Change-Id: I4aeabe6c379f6a07fd4bc882206db1a24dcba87f Reviewed-on: https://chromium-review.googlesource.com/574985Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487514}
-
Wez authored
Bug: Change-Id: I8a06cac29c4820b02b3f4d0fee971fd3b1b5cb3e Reviewed-on: https://chromium-review.googlesource.com/575610Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487513}
-
Wez authored
PostDelayedTask_Basic verifies that the call waits at least as long as the requested delay, but was using wall-clock time to verify this, rather than the tick-clock that PostDelayedTask itself should use. Bug: 738001, 738275 Change-Id: Ia12423ae46646a348932a8eff6dd1c4e8047fdb7 Reviewed-on: https://chromium-review.googlesource.com/575788Reviewed-by:
-
Bernhard Bauer authored
Bug: 718925 Change-Id: Icf37ad3a7f6ace1869b9d17721960e6c844b0b88 Reviewed-on: https://chromium-review.googlesource.com/576093Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487511}
-
Cooper Knaak authored
This CL sends a notification to FeatureEngagementTracker when the user clears their browsing data. The notification was added to -[ClearBrowsingDataCollectionViewController clearDataForDataTypes:] because both entry points (History and Settings page) use this code path. The notification was not added to -[MainController chromeExecuteCommand:], despite it ultimately being the place that executes the action, because chromeExecuteCommand also is used for non-user initiated actions (such as clearing the browser data on sign out). Non-user initiated actions should not be logged by the FeatureEngagementTracker because that would interfere with the ability to present in-product help promotions to users who haven't used a given feature. Bug: 738164 Change-Id: I7f79b724757fc990f93cdaff95c5bfa44f10c36f Reviewed-on: https://chromium-review.googlesource.com/560721Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Cooper Knaak <cooperknaak@google.com> Cr-Commit-Position: refs/heads/master@{#487510}
-
Takumi Fujimoto authored
This CL limits the height of the sink list view in the Media Router dialog to 5 items (including the search box). This CL also adds margin-bottom to #sink-list-view instead of dynamically adding padding-bottom to various elements. Screenshots: https://docs.google.com/document/d/12e2KFrz_sltuGsI6VcB_0W7FdgQD8_Z3j3xQXHXOiTU/edit Bug: 738580 Change-Id: Ie97e4d04faec148ceb9a2870cbcebce494738f78 Reviewed-on: https://chromium-review.googlesource.com/574972 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#487509}
-
David Tseng authored
Rather than relying on events, use the isFocused data from Android AccessibilityNodeInfo. This resolves various issues including: - initial focus. Users can now use Search+left and Search+right on initial launch of the app since focus properly points to content within the app - text field focus/input tracking. Since ChromeVox only reads output from focused text fields, we need this data to be accurate. This was sometimes flakey. TEST=verify consistent tracking of focus when clicking on text fields and other focus transitions. Bug: 744714 Change-Id: I5a304d95a927c6a25f0fa5c3bc002a1771c3a065 Reviewed-on: https://chromium-review.googlesource.com/575568 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487508}
-
Florin Malita authored
Remove SK_SUPPORT_LEGACY_BILERP. Change-Id: I38b9154cdc1e2ee064158af9d92d08d1c6297458 Reviewed-on: https://chromium-review.googlesource.com/575675 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#487507}
-
Sylvain Defresne authored
Those tests are consistently timing out on iPad, disabling them on iPad until the root cause is fixed to turn the bots green. Bug: 745798 Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12 Reviewed-on: https://chromium-review.googlesource.com/576171Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487506}
-
Reza.Zakerinasab authored
This change addresses a couple of issues: - Simplifies the color correction code path in ImageBitmap by using the same general code path for all the constructors (except ImageData which needs a separate code path). - Adds resize option to the constructor from ImageData. - Updates ImageBitmap resize layout tests to enlarge the source (instead of shrinking) such that the correct application of filter quality can be checked. Bug: 627855,665919,734587,734588 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I73d021a8e07c5a2387111c8daec0122cddb85ebb Reviewed-on: https://chromium-review.googlesource.com/542959Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487505}
-
Brian Salomon authored
Bug: 745776 Change-Id: I95868b7bead32c96c5fb4ccf084d887e8f28eb19 Reviewed-on: https://chromium-review.googlesource.com/576211Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#487504}
-
Thiemo Nagel authored
There was a server-side proto change on June 30. Bug: 725124 Change-Id: I90806333e3571e426126110a899781d2f4c58c8d Reviewed-on: https://chromium-review.googlesource.com/574601 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487503}
-
Ian Vollick authored
With this patch set, we permit setting transitions on UiElement instances in the same way one might set CSS transitions on DOM elements. This change also includes some syntactic sugar to make this easier to accomplish (namely UiElement::SetTranslate, UiElement::SetRotate, and UiElement::SetScale). Bug: None Change-Id: Ib52e83e638a580f3048ea6614d0c393de09952ba Reviewed-on: https://chromium-review.googlesource.com/575813 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#487502}
-
bratell authored
With jumbo (unity builds, merged translation units) a "using blink" statement intended for just the local translation unit will affect many other translation units which causes various issues. There is also (with jumbo) a warning about such usage that will prevent things from compiling. Without this patch this file will have to be manually excluded from jumbo builds and I am trying to avoid such exclusion lists for performance and maintenance. Review-Url: https://codereview.chromium.org/2965323002 Cr-Commit-Position: refs/heads/master@{#487501}
-
Theresa Wellington authored
Modify the view hierarchy to allow BottomSheetContent to draw beneath the toolbar. Exposes a new BottomSheetContent#applyDefaultTopPadding() interface method. Classes that do not need to draw beneath the toolbar return true and BottomSheet handles setting padding correctly so that contents will be shown below the toolbar holder. Also adds BottomSheetNewTabController#Observer interface ands registers SuggestionsBottomSheetContent as an observer. This is scaffolding necessary for BottomSheetNewTabController to display a doodle on the NTP UI. BUG=735556 Change-Id: Ia24f13dc222bf2a0cf3804aac4db59e40c91bca4 Reviewed-on: https://chromium-review.googlesource.com/572160Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#487500}
-
Theresa Wellington authored
BUG= Change-Id: I0068ef6a064ead8886fdda68cfcd71ca5af0e806 Reviewed-on: https://chromium-review.googlesource.com/576140Reviewed-by:
-
Lukasz Anforowicz authored
r485361 has made AreCrossProcessFramesPossible return true on all platforms, including Android. This CL makes an equivalent change for layout tests - after this CL all platforms will return |true| from LayoutTestContentClient::IsSupplementarySiteIsolationModeEnabled. This will mean that URLs matching the *oopif.test pattern will be caught by LayoutTestContentBrowserClient::DoesSiteRequireDedicatedProcess and pushed into a separate renderer process. Bug: 745064 Change-Id: I1311c9e89b1fe45d30575ef923e3b78a097a9dbf Reviewed-on: https://chromium-review.googlesource.com/574970Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#487498}
-
Matthew Jones authored
The animation logic in the BrowserControlsOffsetManager did not previously account for bottom controls when triggering an early exit. This change only skips animation if both top and bottom browser controls are 0. BUG=713911 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9b4a24abfcb3cdd9184370d7bc401dbdec37daa9 Reviewed-on: https://chromium-review.googlesource.com/557953Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It's banned, and the code is simpler with C++11 lambda anyhow. Change-Id: I68e4edad5c529b457fe59292278b8c97423b6336 Reviewed-on: https://chromium-review.googlesource.com/574428 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487496}
-
gklassen authored
GpuRootCompositorFrameSink creates an instance of HitTestAggregator and provides the notifications required when surfaces are added to the next CompositorFrame, destroyed and when the next frame begins. BUG=732399 Review-Url: https://codereview.chromium.org/2937233002 Cr-Commit-Position: refs/heads/master@{#487495}
-
eugenebut authored
BUG=None Review-Url: https://codereview.chromium.org/2978143002 Cr-Commit-Position: refs/heads/master@{#487494}
-
Jérôme Lebel authored
DCHECK always references the condition, even in Release. So no need for DCHECK_IS_ON. Bug: 661794 Change-Id: I255be0acbadc38b29f9b39e8694de331ca0b1c22 Reviewed-on: https://chromium-review.googlesource.com/575056 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Quinten Yearsley authored
Change-Id: Idb78bd2d8fdc6a194f1bda9db233f56fb21090eb Reviewed-on: https://chromium-review.googlesource.com/573527 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487492}
-
Sammie Quon authored
This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. This approach of adding a back button expands the current app list button to be modal and have two functionalities depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the meantime. Screenshots: https://screenshot.googleplex.com/ZVNP0aq0cc3 https://screenshot.googleplex.com/fDcGTuoyZg5 https://screenshot.googleplex.com/ZFBzk72LLVt Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" Bug: 721940 Change-Id: I0b2be5cc66583d521721ec1378a19e0026c5c7e1 Reviewed-on: https://chromium-review.googlesource.com/572434 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#487491}
-
Martin Sramek authored
resource.html runs 4 test cases, representing [in]secure resource load on an [in]secure page. The expected result is that Clear-Site-Data is honored iff the resource is secure. The embedding page does not matter. Bug: 607897 Change-Id: Id17bc6d52bca4da46fab214bcc71ca7c7070cdb0 Reviewed-on: https://chromium-review.googlesource.com/571458Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#487490}
-
xiaochengh authored
This CL constructs the DOM-to-TextContent offset mapping of a block. It adds the following API: NGOffsetMappingResult NGInlineNode::BuildOffsetMapping() const; See ng_offset_mapping_result.h for information about NGOffsetMappingResult. See ng_inline_node_offset_mapping_test.cc for examples. Note 1: The patch can be made cleaner if we do not write whitespace-collapsed strings back to LayoutText after layout. Note 2: The built offset mapping is wrong when text-transform expands/removes characters (e.g., ß => SS) BUG=699017 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2963093002 Cr-Commit-Position: refs/heads/master@{#487489}
-
Geoff Lang authored
BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Icaa5c0f7cf3130770d89b34eb46afbfd8379bee9 Reviewed-on: https://chromium-review.googlesource.com/574688Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487488}
-
Hector Dearman authored
After crrev.com/c/565510 the PID is received asynchronously after the start of a service. It is possible to get a dump request between the point when a client process is started and the point when the PID is received. In this case just temporarily skip that client's dumps. Bug: 744722 Change-Id: I69a70747408232063a1d57933d8d0ff985e153c9 Reviewed-on: https://chromium-review.googlesource.com/575127 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487487}
-
xunjieli authored
This CL adds a build flag (INCLUDE_TRANSPORT_SECURITY_STATE_PRELOAD_LIST) for //net embedders to configure whether to include the preload list (~258KiB) in their binary. BUG=603597 Review-Url: https://codereview.chromium.org/2906633003 Cr-Commit-Position: refs/heads/master@{#487486}
-
Daniel Bratell authored
MediaControlsImplTest and MediaControlsOrientationLockDelegate use the same class names for Mock classes. Such as MockChromeClient and StubLocalFrameClient. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the class names unique suffixes so that media_controls tests don't have to be excluded from jumbo. Bug: 745732 Change-Id: I6c3a4d5d92ae690ece53aa093ffb4039eb79137e Reviewed-on: https://chromium-review.googlesource.com/575140 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
liberato@chromium.org authored
ContentVideoView uses both an alpha channel and a transparent background at the same time. AndroidOverlay will need only the former. Currently, they're set together in CompositorImpl. This CL separates them with SetRequiresAlphaChannel, and updates CVV callers to call both. Bug: 744706 Change-Id: I7c9e5d258e68fa35c7a5f8a611d942dc9c460389 Reviewed-on: https://chromium-review.googlesource.com/574640Reviewed-by:
Bo Liu <boliu@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#487484}
-
Bernhard Bauer authored
The observer references in the UI config caused memory leaks after the bottom sheet was closed and (to a lesser extent) when cards were scrolled out of view. Also, drop thumbnail bitmaps from cards when they get recycled. This also avoids (non-discardable) references to bitmaps staying around after a comes stops being visible. Bug: 718925 Change-Id: I6e59dd6d68b559eeab63dc6e172c42eddf427e33 Reviewed-on: https://chromium-review.googlesource.com/574373 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#487483}
-
Quinten Yearsley authored
Bug: 710535 Change-Id: I6ce8350af1f1bad0ef1577b67b927381f1c4842f Reviewed-on: https://chromium-review.googlesource.com/575031Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#487482}
-
Gabriel Charette authored
This fixes hangs in https://codereview.chromium.org/2890853002/. New regression test hangs without matching test_browser_thread.cc changes. We support adding a TestBrowserThreadBundle on top of an explicit ScopedTaskEnvironment (i.e. to add named threads in unit tests that already otherwise inherit a ScopedTaskEnvironment or need to provide a custom one). However if the ScopedTaskEnvironment uses a QUEUED mode, trying to flush it in ~TestBrowserThreadBundle() results in a hang. Flushing TaskScheduler when it's not managed by that TestBrowserThreadBundle was wrong anyways. Bug: 708584, 689520 Change-Id: I3087537ad4f1065fc974170b00c25a676ff5e4c9 Reviewed-on: https://chromium-review.googlesource.com/575593Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487481}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b56b94be..1c7f2213 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If56fcb26c5ecde062ad923553f459c55a6946f8a Reviewed-on: https://chromium-review.googlesource.com/575874Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487480}
-
Daniel Bratell authored
Both PresentationReceiverTest and RemotePlaybackTest use a local test class named MockEventListener. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes so that no tests have to be excluded from jumbo. Bug: 745732 Change-Id: Ic9a5e4e896b226d5ef7f99f2549cd3d4bb66fc42 Reviewed-on: https://chromium-review.googlesource.com/575141 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
