GitLab

Using wpt-import in Chromium f88ee785.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: Ic06f87a8013745c063cb511088e1373f3177ce71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391544Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804106}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88d9ad2f3b2d..a6cebd4f5bf5

2020-09-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8f071df2533db0a6306a7711c6ad74f4c1a39c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804105}

A runnable is set to run once the slide-in show animation is complete.
However, the show animation is never run if a tab modal dialog is shown.
Once the dialog is dismissed after the status indicator is hidden
(though it was never really shown), the runnable ends up running and
tries to access the model, which is null.

The fix is to check that the indicator has a positive height in addition
to checking that the current min-height offset is equal to the height.
This makes sure we don't run the mOnShowAnimationEnd runnable after the
status indicator is hidden.

Bug: 1122906
Change-Id: I1a0a7d9ef231b198de1ee96fd9af89602ede03e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382874Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#804104}

VaapiWrapper owns VABufferIDs of the VA buffers that are used
outside of VaapiWrapper. This CL moves the ownership out of
VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order
to prevent the buffer leakage.
Ths ScopedVABuffer will be used for other VABufferIDs later.

Bug: b:166646505, b:162962069
Test: video_encode_accelerator_tests on atlas
Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest
Test: vaapi_unittest --gtest_filter=VaapiUtilsTest
Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804103}

Bug: 1123686
Change-Id: Ide2078acfcbe13404a41afb6df9eceb870986d09
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386117Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804102}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: If18a818ef82e7b5a0256e2d385eeb6fb1db292bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382072Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804101}

This reverts commit 8258fb07.

Reason for revert: The test seems to be still flaky. https://crbug.com/1123786

Original change's description:
> Reland "[Cast MRP] Stop mirroring immediately when a the tab is closed."
> 
> This is a reland of f51b93d7
> 
> Original change's description:
> > [Cast MRP] Stop mirroring immediately when a the tab is closed.
> > 
> > Bug: 1095764, b/159154368
> > Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911
> > Reviewed-by: Yuri Wiitala <miu@chromium.org>
> > Commit-Queue: John Williams <jrw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803343}
> 
> Bug: 1095764
> Bug: b/159154368
> Change-Id: Ib3fbf021e10e48b3cb7289427ed130b01109a71d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388153
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Auto-Submit: John Williams <jrw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804019}

TBR=miu@chromium.org,jrw@chromium.org

Change-Id: I39378cce3c1e9951fc4d10d64f535d44ca87832b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1095764, 1123786
Bug: b/159154368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392224Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804100}

Extensions can be "transitively-visible" in the toolbar, such as when
they are unpinned, but showing a popup. Add test coverage for checking
the "pin" string in the context menu during this state.

Bug: 1100412
Change-Id: I5880111fc4a31bc35cb2e49dd8846a2f919031ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390951Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804099}

- This class exposes an AttemptConnection() function to connect the
  local Chrome OS to a remote phone device.
- Also exposes a GetStatus() function to retrieve the current status
  of the connection.

Bug: 1106937
Test: unit_tests
Change-Id: I2851cd28ba83034af8c2bddcc17f5a50ddd0c90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387149
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804098}

- Displays trending icon for non-historical matches with SUBTYPE_TRENDS.
- Adds Vector and SVG icons for use in Omnibox and Realbox respectively.

The SVG was optimized using svgomg and converted to .icon using skiafy.

Omnibox: https://screenshot.googleplex.com/7iRhFnNGXP2Kh4j
Realbox: https://screenshot.googleplex.com/FjvWaT4DXonaFWz

Bug: 1122669
Change-Id: Ic9fd6594e633128eed0c2ff621509acdddf100f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386096Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804097}

This change completes the implementation of
PpdProvider::ResolvePpdReference(). Note that
PpdProviderTest.CaseInsensitiveMakeAndModel does not yet pass, as
it exercises other unimplemented methods.

Bug: chromium:888189
Test: chromeos_unittests --gtest_filter='PpdProvider.RepeatedMakeModel'
Test: chromeos_unittests --gtest_filter='PpdProvider.UsbResolution'
Test: chromeos_unittests --gtest_filter='PpdProvider.ResolveUsbManufacturer'
Change-Id: Iea05ee2e8cb4fd5c86343ca0f14848dcf42dee60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354907
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804096}

Make sure callers of GetCompositeRequest() are passing a valid cookie.

Fixed: 1124155
Change-Id: Idb3b88c29de39c17ac3a67f7905e73e924c35316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390994
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804095}

This is a pre-requisite for Beta and Stable experiments.

Bug: 1072756
Change-Id: I6b2b97dce06342af96f1c724f11d48be16fd905f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376448
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804094}

Bug: 1124200
Change-Id: I451298e4dd719f711a7e176278a409d4dc1e3439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392260
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804093}

This CL moves printing::PrintMsg_PrintPages_Params to print.mojom
to pass it to Mojo interfaces. This is a precursor CL to
mojofy PrintHostMsg_UpdatePrintSettings and PrintHostMsg_ScriptedPrint.

Bug: 1008939
Change-Id: Iecb559323fdced0b1328795a900d6bcaea4c945d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340854Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#804092}

This CL is setting the experiment to on by default.

This feature is ready to be launched.

R=fdoray@chromium.org

Bug: 1074332
Change-Id: If57666f6983a4877a8367d6460ece182dd3e2669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391600
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804091}

https://pdfium.googlesource.com/pdfium.git/+log/11cb4f444271..1877f680e3b2

2020-09-03 tsepez@chromium.org Make CFX_Font retain its own files.
2020-09-03 tsepez@chromium.org Remove CFGAS_FontMgr::RemoveFont().
2020-09-02 tsepez@chromium.org Check EnumFonts() is fine in XFATestEnvironment::SetUp().
2020-09-02 tsepez@chromium.org Roll v8/ 63911905f..c577d027e (39 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Iab288c04df469b449969950b77283c56738192d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391049Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804090}

Currently we always query ItemSuggest when Drive FS finishes mounting.
This is too frequent, because mounting doesn't only happen at login, it
also happens when waking from sleep. This CL does two things:

1. Ensures we do a warmup query only once.
2. Adds a metric to measure how often we issue the warmup query, so we
   can estimate its qps contribution.

Bug: 1124162
Change-Id: Ib2fbf6ead631ebfa3cef10fa8786f4af858c4171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387915Reviewed-by: Rachel Wong <wrong@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804089}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bef95c091b2d..f76c76d25df8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC wjmaclean@google.com,dfried@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1093825
Tbr: wjmaclean@google.com,dfried@google.com
Change-Id: I30afebe67bad7b84f8aaa0dd81a579b3a50813cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391408Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804088}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4dd8ba9285c..d9c616f80fb6

2020-09-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I1786e370e9cdb5594148c48d9a943300bbb26bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391831Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804087}

https://webrtc.googlesource.com/src.git/+log/444c13c078a7..0ade98316c21

2020-09-02 peah@webrtc.org Cleanup of the APM creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I3e237fbab86da1d600c3a84bd3e7a3a70e2b11c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391841Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804086}

Expose a new routine through cros_healthd's ServiceConnection.

Bug: chromium:1094018
Change-Id: I25d2b2e1eb6652d127dcfb50925e75950423b6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388432
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804085}

This CL prevents Remote Apps from being pinned when dragging the
launcher item onto the shelf.

Remote Apps already do not have a context menu item for pinning, so this
CL makes Remote Apps unpinnable.

Bug: 1101208
Change-Id: Iaa25530dc84d20cc420a8a407898979ef7a558de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382606
Commit-Queue: Jit Yao Yap <jityao@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804084}

This patch moves two fields from RenderPassInternal into
AggregatedRenderPass, effectively removing them from CompositorRenderPass
since they are not used there.

R=weiliangc@chromium.org

Bug: 1106418
Change-Id: I46a156420b0dd53fe44afae012011c4e040258d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389421Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804083}

Relaxed ordering is insufficient since the resulting task id is used by
the caller for order operations. Test case written by omerkatz@
demonstrates the race:

TEST_F(ConcurrentMarkingTest, JobTaskIds) {
  static constexpr size_t kNumTasksToRun = 2;
  static size_t tmp[kNumTasksToRun] = { 0 };
  base::JobHandle handle = base::PostJob(
      FROM_HERE, {base::ThreadPool(), base::TaskPriority::USER_VISIBLE},
      ConvertToBaseRepeatingCallback(WTF::CrossThreadBindRepeating(
          [](base::JobDelegate* job) {
            uint8_t id = job->GetTaskId();
            size_t& slot = tmp[id];
            slot++;
          })),
      ConvertToBaseRepeatingCallback(WTF::CrossThreadBindRepeating(
          [](size_t) { return kNumTasksToRun; })));
  handle.Join();
}

Thread 1 can release its task id and thread 2 immediately pick it up,
which causes a data race on tmp when both thread access the same idx
with no memory fence in between. Adding memory_order_seq_cst on
Release/AcquireTaskId ensures that different thread with same task id
are sequential.

Bug: 1119518
Change-Id: Ifa35ca03e3663f53f76ee830bcaa8654bc48838c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387554Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804082}

CriticalPersistedTabData is a replacement for TabState which usess
protocol buffers to serialize persisted Tab metadata in a file. It
is imperative we compare the old and the new methods of persisting
Tab metadata across restarts.

Bug: 1122220
Change-Id: I649fe8271c1301c76e9a7c9bb317ab03c30b2fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380603
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804081}

The profile sign-in state is reported via UMA and can be accessed at
go/chrome-sync-signin (Googlers only, sorry).

The number of Google accounts on the device is no longer relevant, since
Play Store can update Chrome without a Google Account on modern devices.

Bug: 1110338
Change-Id: I130f2a6b3edffd1f1f730dbaad0f65784f9fb5e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346725
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804080}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/482642324c4e..00e17f2cebef

2020-09-02 rharrison@google.com Start SPIRV-Tools v2020.4
2020-09-02 rharrison@google.com Finalize SPIRV-Tools v2020.3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: radial-bots+chrome-roll@google.com
Change-Id: Ie038bca4c16cfb0e0fa6f51c877a3695af304793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804079}

not_loaded_image_resources_ is being modified while iterating.
If this CHECK doesn't catch anything, it means weak processing is triggering while iterating even though it shouldn't be.

Bug: 1108676
Change-Id: Iae00862b28fe3e324ac654c1e57834071ce5ddc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392021Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804078}

We now enforce that Tab attributes are acquired on the UI thread

Bug: 1117396
Change-Id: Ia7d41be25ae3dc201e8ad7a7f96255b7ca09f60d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390869Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804077}

The ConnectionMedium enum was previously only used within the
SecureChannel implementation, since there was only a single medium
(i.e., BLE). This CL moves the enum to a public directory where it can
be used from outside the directory.

This CL is in preparation for clients being able to specify the
connection medium by passing a parameter to connection attempts
facilitated by SecureChannel.

Bug: 1106937
Change-Id: I8a8ab2d862b02ab88d3db0b8485c64d59fbf3d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391517
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#804076}

This reverts commit f5793ebb.

Reason for revert: Random (but high frequency) failure of untar tast-cmd-0.0.1-r771.tbz2.
Example build: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/19679

Original change's description:
> Roll Chromite from 168986591cc1 to dcb0e91ca94b (4 revisions)
> 
> https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..dcb0e91ca94b
> 
> 2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes
> 2020-09-02 chrome-bot@chromium.org Update config settings by config-updater.
> 2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed.
> 2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/chromite-chromium-autoroll
> Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
> Tbr: chrome-os-gardeners@google.com
> Change-Id: Ib815a99e16e81b13f2680639a71b7d223cb94498
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390894
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804026}

TBR=bpastene@chromium.org,newcomer@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: I92ec34d95ac27ae60f262cf20abb58c3052f2f6d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390606Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804075}

This change introduces a client interface for Media Router
which separates the embedder specific actions from shared
behavior, MediaRouterClient. The term "client" is used over
"delegate" because it's a singleton.

Additionally, symbol names that use "Chrome" are updated to
use "Browser" instead.

After this change, all of [...]chrome.browser.media.router
(save the new client, ChromeMediaRouterClient, which is
Chrome specific) can be moved to [...]components.media_router.

Bug: 1057100

Change-Id: I94b538b4fdb5868eda2149847b5e23c048f3cd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373293Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804074}

Rather than relying on the root of an isolated file system to determine
the scope of permission grants, explicitly expose the scope of
permission grants. This will make it easier to support special volumes
on Chrome OS.

Bug: 1093653
Change-Id: I17ef72864af6441a9f5f4392d537f7d7f7328cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391384Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804073}

This reverts commit f0b702c0.

Reason for revert: The CL being reverted was attempting to fix a presentation issue, but ended up breaking mouse handling for all button row buttons.

Original change's description:
> [omnibox] Fix pedal buttons misplacement
> 
> The first time when match changes its height, pedal button is misplaced
> and overlaps with another match. This was caused by setting wrong bounds
> for button row.
> 
> Bug: 1121934
> Change-Id: I297a3551c370f8efd7c4079e14b9c6fcace70e84
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385378
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
> Cr-Commit-Position: refs/heads/master@{#803217}

TBR=tommycli@chromium.org,bsep@chromium.org,olesiamarukhno@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1121934
Change-Id: Ic32e7cc083e06285348a2857e201d1da268de077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391107Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804072}

Change Files app to navigate to the directory when a "selectionURL"
provided in the launch params. Before this CL Files app would only show
the directory selected.

This change is to support the workflow from Issue:1090211. From ARC++
the intent to "ACTION_VIEW_DOWNLOADS" will open the Files app in the
Downloads folder.

Bug: 1090211
Change-Id: Ic6b9d290936f4a25576f3bfd5a799c37f6fa2195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379345Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804071}

Bug: 1045266
Test: NetworkComponentsNetworkConfigTest*

Change-Id: Ic585489fae7711e483e1759d6dcda5473b43d418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353557
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804070}

After crrev.com/c/2372888, all cases of mMerchantSupportsAutofillCards
are accessed after defined, we can limit that it's used only after it's
not null.

Bug: 1107039

Change-Id: Iea978142c9a9e7d755cb294d9acf3eff80f13d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388561
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804069}

Change-Id: Iff940839243bf27974860e1e32b5fe25d8a59b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391730
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804068}

Change-Id: I1a32006dc0d91102b24a16bc591284dc88ca7ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387415Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804067}