- 20 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78047ef063bb..050ddbde62d0 git log 78047ef063bb..050ddbde62d0 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@050ddbde62d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I37cec3bcdd3086cd922b027df2f1ca3d99aadcb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726709}
-
Daichi Hirono authored
For some cases, we are going to use window ID instead of task ID to identify a11y tree. To avoid having additional map between window ID and tree, the CL does refactoring to unify maps for multiple key types. Bug: b:146591913 Test: ArcAccessibilityHelperBridgeTest Change-Id: If735dbeb8d13b979809afbe9b9af2b7025ffd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976144 Auto-Submit: Daichi Hirono <hirono@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#726708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e2dea568299..0237c1f947bb git log 7e2dea568299..0237c1f947bb --date=short --first-parent --format='%ad %ae %s' 2019-12-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4fd7fccd6db5..6d29348ddb7e (3 commits) Created with: gclient setdep -r src/third_party/skia@0237c1f947bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ifa5fbee922e700f0cd17bbf2a4e16203b7a60555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978244Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit f1f1258e. Reason for revert: Broke BackgroundXhrWebstoreTest.PolicyBlockedXHR on linux-chromeos-chrome bot. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/497 Original change's description: > Fixed overwriting of static default_policy_hosts > > The default policy for allowed or blocked hosts is overwriting > from different contexts(profile) and can lead to wrong policies > being applied to extensions (see bug #1028577). > > This fix creates a static map that stores the profile (by id) and the > relevant default_policy_allowed_hosts/default_policy_blocked_hosts in > a struct. > > TODO: > Write integration tests (crbug.com/1031179) > > R=marcgrimme > > Bug: 1028577 > Change-Id: Ie08447ddd5175562b474fa5801f6959315372c6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946368 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Marc Grimme <marcgrimme@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726333} TBR=rdevlin.cronin@chromium.org,mkwst@chromium.org,nrpeter@chromium.org,burunduk@chromium.org,marcgrimme@chromium.org Change-Id: I499dfc19516176953721178a663992bc3c1636ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978456Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726706}
-
Alan Screen authored
Supporting both XPS and GDI print paths requires ability to switch between them. This is based upon the document type (modifiable or PDF) and the associated use flag associated with that type, be that "use-xps-for-printing" or "use-xps-for-printing-from-pdf". Added a PrintJob::ShouldPrintUsingXps() helper function for making such determination, to share logic with what was already in PrintViewManagerBase::PrintDocument(). Bug: 1034053 Change-Id: Ib94f00c1e78788ceda19c09a94f505575dbcd994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970841Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726705}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I1d45ec8c964ca3b2a30e87a00a78f88b5ba2eb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977878 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726704}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c59c9d8f1f0..f5798b5b7d9b Created with: gclient setdep -r src-internal@f5798b5b7d9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7ce863100b694593ec4eb78b71d90fab309198cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726703}
-
Arthur Wang authored
R=carlosk@chromium.org, harringtond@chromium.org Bug: 1028976 Change-Id: I3c2480641220110fd8f71735cd6a0f94279367e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976281Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726702}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/95d876ef330f..4cd621ee21ae git log 95d876ef330f..4cd621ee21ae --date=short --first-parent --format='%ad %ae %s' 2019-12-20 dberris@chromium.org Reduce attempts to schedule multiple tests Created with: gclient setdep -r src/third_party/catapult@4cd621ee21ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: Id62d14720e4f66e950e66e7565c5fac0d8f004bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978240Reviewed-by:
-
Hirokazu Honda authored
VAEncMiscParameterRateControl has parameters about minimum and maximum of quantization values. These values should be filled. Bug: 1034382 Test: VEA test on atlas Change-Id: I185b3e710c05095313aa71bc9fe90b23c8885345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969196 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726700}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3a72085d..c5adad75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8da1bba7d78aaeffbd98afb5e99d435fe4df172a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977846Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726699}
-
Hirokazu Honda authored
VideoFrame might not have the same number of fds as the number of planes. We duplicate the fd of the last plane of the VideoFrame in CreateGpuMemoryBufferHandle() until the number of fds is the same as the number of planes. Bug: 1011281 Test: VDA test on hana Change-Id: I6738e74ddc43f6c9457ba37beb44ee656866a633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978296Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726698}
-
jessing authored
This is an example of how to register a system web app as a system app. Bug: 1032810 Change-Id: If1e6c67305a7baeef8467eab6580e86fdf75db8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971039 Commit-Queue: Jessica Huang <jessing@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726697}
-
yjliu authored
Bug: 1035943 Change-Id: Ic2cb63db33bd3bf3ccac8528fa1df53f5f3a3355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976821Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726696}
-
Demetrios Papadopoulos authored
Also removing the option about Google Drive from the same parent page. These options are only displayed in OS Settings. Bug: 986596 Change-Id: Ibf685aff9a3db0e6a7b81945fe81c87b07c54fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977200 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726695}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I8a8809fd6c3db39b9495c2760d327d998e38ade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978238Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21b29fed64d8..3c59c9d8f1f0 Created with: gclient setdep -r src-internal@3c59c9d8f1f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0157b4215ab6fd621a91426c46deb2cc702e79e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977783Reviewed-by:
-
Rachel Sugrono authored
myDriveContent moved to the if statement that it's used. Bug: 1035220 Bug: 1035220 Change-Id: I9bef0cf1894bd18d76fc79936a41e13ba87fc6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977887Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#726692}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I733f49fd407ca9cadb08665aecb1d393b977c483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978256Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726691}
-
Regan Hsu authored
Currently, when any inactive digit area is clicked or tapped in the row containers (i.e backbutton when pin is empty or empty digit button next to 0), the pin input loses focus momentarily. This CL ensures that extraneous clicks on the immediate parent of the digits will not cause the pin input form to lose focus. Fixed: 1034939 Change-Id: I7d687508944411cb596b1453e3f61eaeb9b9d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977746 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726690}
-
Fergus Dall authored
GLImageMemory will, under some circumstances, convert its internal image buffer into a different image format before copying it to the GPU. It assumes that the new buffer is the same size as the old, but if the new format is more compact then the old this is not the case. This can allow untrusted processes to trigger a GPU process crash. This CL fixes this by tracking the amount of memory allocated for the new buffer. Expand GLImageCopyTest.CopyTexImage to test multiple sizes of image, since CopyTexImage follows different code paths depending on image size. This previously prevented this issue from being detected. Fix an unrelated issue exposed by the test change where large images with a stride > row_size would fail to be copied to the texture. This would happen because GLImageMemory sizes the GL buffer object used to render assuming that bytes_per_pixel * width * height is always enough space. The code path for smaller images doesn't use this buffer object, again preventing the issue from being detected. Fix this by using the stride passed into ::Initialize for the row size. Disable GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage on Windows due to a pre-existing issue exposed by the test change. Finally, re-enable some GLImageCopyTest variants on sanitizer bots, since they no longer seem to fail in that environment. Bug: 1029426, 1033320, 830653, 1036138 Change-Id: Ie79b96d7ecda8965e57fc2c4bf92ef54b0e64414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951267 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726689}
-
Sadrul Habib Chowdhury authored
Add DCHECK() to verify that every impl-frame started is also terminated as expected: either a frame is submitted, or no-damage is explicitly reported. Also, add 'R' to the debug-log for a reset, and always report 'e' for end, even for an invalid sequence-number. BUG=1035382 Change-Id: I1aeab1453fa0c1b80a02b2f1795ab898be71a060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976912Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#726688}
-
Sajjad Mirza authored
This is a reland of 8e917b47 Original change's description: > [code coverage] Bot definitions for Windows coverage tryjob > > Add definitions for tester machines for Windows coverage. > > Add buildbot definitions so the tryjob can run tests. > > Bug: 1033753 > Change-Id: I3d933b1beaedd24ad206c9e5d2528ed5e4496b67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972753 > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726609} Bug: 1033753 Change-Id: Iff0f570f0a1c2853a2de129f6469402ed5843500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977836 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726687}
-
Chris Lu authored
Bug: 987646 Change-Id: Ie711f50c6062370fce8d7bfa96b466a9a774df3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974304 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726686}
-
Khushal authored
This change does a couple of things to ensure we don't track any unnecessary data for checker-imaging: 1) During discardable image metadata generation, the decoding mode only needs to be tracked if the image is discardable. 2) We don't need to store any decoding mode metadata if checker-imaging is disabled. R=ericrk@chromium.org Bug: 1003886 Change-Id: I2802af3bcf69beb970b98a6c179032a72b588f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973152 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL modifies the VAAPI error-check and log macros to accept just the name of the function, adding itself the "failed" suffix, or prints out the function name if successful. This allows for quick following up of the VA function interactions. Callsites are adapted. Same thing applies to VA_LOG_ON_ERROR() calls. A singleton LOG_VA_ERROR_AND_REPORT+return is corrected to VA_SUCCESS_OR_RETURN I also took the chance to make VADisplayState::Deinitialize() to return the VAStatus ISO filling an argument var. Change-Id: Idcc24f3c09b79bc3f971ae8c3827aa07082261d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967217 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726684}
-
Chris Lu authored
TBR=olivierrobin@chromium.org Bug: 1036094 Change-Id: I2f29c4f60b3cde9ee444ea2b5b79c82fbf4a54c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976139Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#726683}
-
Chris Lu authored
TBR=gambard@chromium.org Bug: 1036078 Change-Id: I56a72c22c886be2f302d6fdd1683a47bf4b34236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976137Reviewed-by:
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I3a0a3131a57172a56787aec74c783fcd64fff94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977149Reviewed-by:
-
Sebastien Marchand authored
The script fails with the following error on Windows when using the --fetch flag: Traceback (most recent call last): File "tools/clang/scripts/build_clang_tools_extra.py", line 97, in <module> sys.exit(main()) File "tools/clang/scripts/build_clang_tools_extra.py", line 90, in main FetchLLVM(GetCheckoutDir(args.OUT_DIR), args.revision) File "tools/clang/scripts/build_clang_tools_extra.py", line 54, in FetchLLVM subprocess.check_call(args, cwd=checkout_dir) File "C:\python_27_amd64\files\lib\subprocess.py", line 185, in check_call retcode = call(*popenargs, **kwargs) File "C:\python_27_amd64\files\lib\subprocess.py", line 172, in call return Popen(*popenargs, **kwargs).wait() File "C:\python_27_amd64\files\lib\subprocess.py", line 394, in __init__ errread, errwrite) File "C:\python_27_amd64\files\lib\subprocess.py", line 644, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified With these few changes the scripts works fine on Windows. This also switch this script to using GN instead of cmake. Change-Id: I2af10fd0d03d4d18394b792e1b7780f2084bfa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968071Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#726680}
-
Matthew Mourgos authored
Bug: 1031651 Change-Id: Ic6d663fc798078db3f5099e3bae4f2737a111503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973150Reviewed-by:
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was requesting 8 buffers for in-flight output frames. Reduce that number to 6. Bug: 1034692 Change-Id: I303b5012541b7c291b4b945091a73a291afe4a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977386 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726678}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/104d95744f44..95d876ef330f git log 104d95744f44..95d876ef330f --date=short --first-parent --format='%ad %ae %s' 2019-12-20 fancl@chromium.org Return only private sheriff when matched both public and private Created with: gclient setdep -r src/third_party/catapult@95d876ef330f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: nuskos@google.com Change-Id: Id0a0c6c082e1b9f17f2cb9f622850983f549c8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977785Reviewed-by:
-
Andrey Kosyakov authored
MessageLoopImpl was removed by crrev.com/c/1440828, but there are still somce forward declarations around. Change-Id: I39d1e18632b97aa6a7aa2e59fca61db997651034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974817 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726676}
-
Kunihiko Sakamoto authored
This reverts commit 6f0c3820. Reason for revert: StackSamplerImplTest.CopyStackTimestamp is crashing on MSan bots. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21249 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16883 Original change's description: > [Sampling profiler] Provide timestamp with sample > > Records timestamps along with samples and plumbs them through to > the ProfileBuilder interface. The CallStackProfileBuilder subclass > will be updated in a following CL to record the timestamps, to > support retrospective tagging of metadata on the samples. > > Bug: 1034758 > Change-Id: Ic631d47773db5ce8ed5117c08aba5d5931cb7884 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972931 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726526} TBR=thestig@chromium.org,wittman@chromium.org,oysteine@chromium.org,etiennep@chromium.org Change-Id: I752676dd15b9a6e2aad897c4c9442eaad1dda9b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977893Reviewed-by:
-
Johannes Henkel authored
The interfaces in content/public currently use const std::string& for devtools messages. This requires client code as well as implementation code to use an std::string for representing the messages (depending on the code that's providing the const std::string&). Moving to base::span allows code to use any container that gives access to a sequence of bytes without having to make a copy, including: - std::string (just like now) - std::vector<uint8_t> (base::span<const uint8_t>'s implicit constructor takes it). - the BigBuffer from Mojo (provides a base::span<const uint8_t> already). - base::span<const uint8_t> - crdtp::span<uint8_t> (base::span<const uint8_t>'s implicit constructor takes it). - base::StringPiece (going to / from this one requires a reinterpret_cast, but at least it's efficient). The switch removes a few copies of byte sequences (e.g. from BigBuffer to std::string). It introduces a few conversions between the non-owning representations, but these are cheap. This PR includes a roll of third_party/inspector_protocol. New revision is: 3b0551d3904f7fc067e78905ce697002187fa7a5 Change-Id: I4bea62307378f72ae95fa631db42c3bc95694d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965407Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#726674}
-
Jiahe Zhang authored
Change-Id: Ie2fe348928333e7a8162fc891fb53d2acb87f574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975451 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#726673}
-
Isabella Scalzi authored
The transferBetweenVolumes function adds the file to be moved into the list of expected files after the move, only runs if the flag "isMove" is false. Because of this, the file that was moved was not added to the list of expected files, and the test can fail. Removes this condition, and do not add the file to be moved to the list when the source is the same as the destination, or if the test is expected to fail. All tests that use transferBetweenVolumes now pass in step-by-step mode, to complete issue 1035220. Bug: 1035220 Change-Id: If9031eab26340af6af2440f2fd9e30d48b5a248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976138Reviewed-by:
-
Alan Screen authored
Printing on Windows involves a two-step process, first converting pages to the Windows metafile format (EMF) and then later playing that metafile to print to the destination device. The PrintedPage objects which contain this metafile data are retained in the PrintedDocument until the document completes. This has caused the extra metafile representation to stay in memory well after it's required lifetime has passed. For jobs with many pages that include full page rasters this triggers a memory spike that subsides only once the last page is sent and the document is destroyed. Avoid such memory spikes by dropping the PrintedPage object from the document as soon as the page has been rendered to the destination, so that its destructor can run and release the associated |metafile_| memory. Bug: 1031438 Change-Id: If6ff81f63e11989bc7ef1b341ee37be0cd8d4af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975993Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 03dfdf62. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 9899425d "[css-layout-api] IntrinsicSizes Implementation" d75fede5 "[EventTiming] Fix crossiframe test" 93b03639 "Roll WebGPU CTS" d0d26288 "CSP: Parse and report violations from Content-Security-Policy-Report-Only headers in the browser process." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2e5e26ebb3132f77954736753529434f27b8562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977756Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726670}
-
