- 01 Nov, 2018 40 commits
-
-
Dominic Mazzoni authored
Currently we have a single root accessibility tree (the "desktop" tree) containing all aura Windows and views in the browser process, and all WebContents accessibility trees are direct children of that tree. Under multi-process mash, we're going to want it to be possible for a remote app to host a WebContents, so we need to remove the assumption that the parent accessibility tree of a WebContents must be the root accessibility tree. To do this, modify AutomationInternalCustomBindings::GetParent so that it checks for any tree that lists the current tree as its child tree, rather than only trying the desktop tree. To make this efficient, have AutomationAXTreeWrapper keep track of a map from child tree ID to its host. This is reasonably well-covered by existing tests - if GetParent doesn't work correctly, nearly all automation tests break. Bug: 888147 Change-Id: Ib7350d51dffed345dd03ec11e6cc0b7591bb243c Reviewed-on: https://chromium-review.googlesource.com/c/1286903 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604729}
-
Peter Kotwicz authored
BUG=900464 Change-Id: Iabdce98f4f3a362d1376860277fc9d1c31757c12 Reviewed-on: https://chromium-review.googlesource.com/c/1309296 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604728}
-
Bin Wu authored
Add quic tag kEPID and set it in the public reset packets sent from GFE. GFE side change protected by --quic_reloadable_flag_quic_enable_server_epid_in_public_reset. The intention is to use this tag in Chrome to differentiate public resets received from Google servers vs. Non-google servers. Merge internal change: 219217158 R=rch@chromium.org Change-Id: I81977087ece589c5081f644d330e92c4e5038cf8 Reviewed-on: https://chromium-review.googlesource.com/c/1309116Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#604727}
-
Evan Stade authored
Bug: 814675 Change-Id: I522890e1252535832aed187e7add7034f46fb30c Reviewed-on: https://chromium-review.googlesource.com/c/1311800 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604726}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: Iddf657f4f14b9ba4d273d2a4973dd763c28dcc51 Reviewed-on: https://chromium-review.googlesource.com/c/1313562Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#604725}
-
Chris Morin authored
Chrome had to proxy through session_manager to start the arc-remove-data Upstart job, but now it calls it directly. BUG=b:115779632 TEST=Disable ARC++ and ensure arc data removal occurs Change-Id: I0f30570c665efc85538b9de4bcd63bb158b37417 Reviewed-on: https://chromium-review.googlesource.com/c/1311124Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#604724}
-
Joe Downing authored
This change is required due to new security restrictions in Mojave. We can no longer inject input w/o being added as an accessibility app in the security applet. While this sounds like a usefulk speedbump, it causes remote access applications quite a bit of trouble: 1.) We don't use the restricted API until a user connects so they cannot approve remotely 2.) The dialog appears to only show up once (regardless of approve/deny status) 3.) Users connecting to a locked machine will never see the dialog This is affecting quite a few CRD users, basically everyone who upgrades to Mojave will experience this one way or another. This is the simplest fix (and easiest to merge) that I could think of to unblock users. The prompt will only be shown on 10.14+ platforms and the request is only shown if the app has not been approved. I'd like to look at the user feedback after releasing this change to see if more work is needed. One problem I anticipate is that the dialog shown doesn't have a lot of context and it refers to the wrapper script (org.chromium.chromoting.me2me.sh) instead of Chrome Remote Desktop. If this is confusing, we can wrap the prompt request in a dialog where we control the text. My concern with checking in the feature first is that the new strings won't be available for merging. Another behavior to call about this impl is that the prompt will be displayed in two instances: 1.) When the host is first started (choosing enable via app/website) 2.) When the user signs in and the host service is started Scenario #2 will have less context but that is the only way to ask for permission for users who upgraded and had CRD installed previously. The dialog is not displayed at the login screen (i.e. when no one is signed in). One last note, there is no way that I can see to specify this permission in the manifest or set up via a script / at install time. It requires a user action to complete. Bug: 901021 Change-Id: I9dd1b24b6d4d083e7e019af32a0da816f6060a86 Reviewed-on: https://chromium-review.googlesource.com/c/1313170 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604723}
-
Siddhartha authored
R=wittman@chromium.org Change-Id: I171d11f25c2903894feb015adff53d6280a88be7 Reviewed-on: https://chromium-review.googlesource.com/c/1306496 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604722}
-
Ted Choc authored
Now all the model building no longer needs the view to build the properites, so we can just pass in the Model instead of the View. We should now be able to pull out the model building to a mediator and out of the adapter. BUG=898522 Change-Id: I5b0bff0778975bce0e5b27f9dd95c9f9385396c2 Reviewed-on: https://chromium-review.googlesource.com/c/1312560Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604721}
-
Nicolas Capens authored
Recently the SwiftShaderTest.h file was moved. Chromium shouldn't directly depend on any header or source files within SwiftShader. The class defined in this header is practically empty anyway, so just move it to the Chromium side test setup. TBR=kbr@chromium.org Change-Id: Iea7cb482457a1a1aa935868489757e97994b1dff Reviewed-on: https://chromium-review.googlesource.com/c/1311084Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#604720}
-
Yuichiro Hanada authored
Bug: 899137 Bug: 845079 Change-Id: Id196b62707f7f5d66fc7f011b8cd4bc8bdc2f743 Reviewed-on: https://chromium-review.googlesource.com/c/1308237Reviewed-by:
-
Patrick Monette authored
Bug: 884075 Change-Id: I08094816c99b1ba0c0b8519318a57c957c7648e2 Reviewed-on: https://chromium-review.googlesource.com/c/1308669Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#604718}
-
James Hawkins authored
The remaining call sites just (re)loaded/disabled the app but did not use any of the app for functionality. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Idf93dea3d8dd6fbff5e842c283055ab67bc2b779 Reviewed-on: https://chromium-review.googlesource.com/c/1312301 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604717}
-
Ryan Sturm authored
This CL reduces collisions due to re-used memory addresses for NavigationHandles by using GetNavigationID, which has stronger guarantees about never being re-used. Bug: 898557 Change-Id: I6ceecebd61f034ccd830dabbdbcf0aa2a9ab5e0e Reviewed-on: https://chromium-review.googlesource.com/c/1306293Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604716}
-
Jun Mukai authored
This is a reland of crrev.com/604473 with fixes of: - addressing some review comments which are missed in CQ - the test flakiness The test flakiness comes from my misunderstanding; this test case actually creates a window server process which runs test_ws. The default behavior of PerformWindowMove in test_ws is to fail immediately. Therefore this CL changes test_ws -- PerformWindowMove now remembers the done_callback, and then call it when cancel is requested. BUG=900363 TEST=repeat 20 views_mus_unittests Change-Id: I61bcb06bf626a73d0a9d998c0bb1511feea45494 Reviewed-on: https://chromium-review.googlesource.com/c/1312985Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 866932 Change-Id: I10d7543af43e778265d73b4b10b3a27b8fbf2e29 Reviewed-on: https://chromium-review.googlesource.com/c/1308263Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604714}
-
Toshiki Kikuchi authored
This CL adds UMA for recording the number of created notifications for the various types of sources (e.g. System/ARC++/Crostini). Also, this CL adds new notifier type for Crostini notifications to specify the notification comes from Crostini applications. BUG=chromium:900089 TEST=compose some notifications and open chrome://histograms Change-Id: I2d8ef041fa2f8530b9119b4d3a6a598428113665 Reviewed-on: https://chromium-review.googlesource.com/c/1306947Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Cr-Commit-Position: refs/heads/master@{#604713}
-
Ryan Sturm authored
This CL removes code that allows observers to be added from other threads than the UI thread. We never supported posting to multiple threads (note: IO used to be primary), so this is not needed. Bug: 895618 Change-Id: I23e85793eb6b18f8ad26799ad8b205787251f294 Reviewed-on: https://chromium-review.googlesource.com/c/1308612Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604712}
-
David Quiroz Marin authored
Added the prefix "Blink." for consistency with the rest of canvas' histograms. Used the new ENUMERATION macro. Cleaned the enum strings in enums.xml for the following histograms: Canvas.CreateImageBitmapSource Canvas.GPUAccelerated2DCanvasDisableDeferralReason Canvas.RequestedImageMimeTypes Canvas.HibernationEvents Bug: 894043 Change-Id: Ifa6afc223e123fea3ef4915b26ff9309e69c710f Reviewed-on: https://chromium-review.googlesource.com/c/1310914 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604711}
-
sczs authored
Currently there's some flakiness for testEditFunctionalityOnSingleURL, since this is one of the longest test cases we have I'm hoping that splitting it in two will reduce the flakiness. Bug: 898572 Change-Id: Ifd623dada4a369c9b1af3586e750e34f31f5dc52 Reviewed-on: https://chromium-review.googlesource.com/c/1311799 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#604710}
-
Erik Luo authored
Bug: 865674 Change-Id: I42c6a50ca475615179ccd33bd1c8efb1549f1d69 Reviewed-on: https://chromium-review.googlesource.com/c/1300415 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604709}
-
Chris Morin authored
BUG=b:76152951 Change-Id: Id64901e4434c77a06e65005dbb3cfaa0f047c94f Reviewed-on: https://chromium-review.googlesource.com/c/1312616Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Sahel Sharify authored
Registering the FlingScheduler after processing a GFS causes a frame of jank at the beginning of the fling. This is because the first OnAnimationStep call after observer's registration might be missing and/or incorrectly have the timestamp of the last begin frame before the observer's registration rather than the first begin frame after the registration. To avoid this issue, in this cl we register the observer on GSB instead of GFS so that the potential missing/incorrect OnAnimationStep call passes by the time that the GFS is processed. We unregister the observer on GSE instead of when the fling stops since not all GSBs are followed by GFS events. Bug: 882907 Test: GestureEventQueueWithCompositorEventQueueTest.FlingSchedulerOpbserverRegisteredOnGSB Change-Id: I149469fce31c9146c7282bee5cba7152ee65b1ea Reviewed-on: https://chromium-review.googlesource.com/c/1313270Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604707}
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to reduce the usage of legacy js-test.js. It is also preparation for using Element.innerText as text dump, as the layout test produces different text dumps on Android and other platforms after using innerText (*). (*) See crrev.com/c/1308253 Bug: 887148 Change-Id: Ie3df2db21e6779af4f70bc8fec2ebc37458fba89 Reviewed-on: https://chromium-review.googlesource.com/c/1312302 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604706}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7216ea73e7fd..9b86cb69f2f2 git log 7216ea73e7fd..9b86cb69f2f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 tsepez@chromium.org Add pdf_cjs_util_fuzzer. 2018-11-01 thestig@chromium.org Roll third_party/freetype/src/ abd997aa7..f56830ed4 (18 commits) Created with: gclient setdep -r src/third_party/pdfium@9b86cb69f2f2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0589a3f166aa5d698fca64ab6e98fbeb2fd11a4e Reviewed-on: https://chromium-review.googlesource.com/c/1313272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604705}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d546b5cd1b6..21d4b4c50dbe git log 6d546b5cd1b6..21d4b4c50dbe --date=short --no-merges --format='%ad %ae %s' 2018-11-01 benjaminwagner@google.com Un-omit Win10 IntelIris540 Vulkan tests. 2018-11-01 michaelludwig@google.com Remove vertex-shader perspective divide 2018-11-01 michaelludwig@google.com Expose aaType in simple mesh draw op helper 2018-11-01 michaelludwig@google.com Send correct 3rd component for uvr vertex attribute 2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader adfbbcbed6e7..75889d00033b (1 commits) Created with: gclient setdep -r src/third_party/skia@21d4b4c50dbe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I837d025dd1a1ed9e5dfa216dedb565839f7b2b5b Reviewed-on: https://chromium-review.googlesource.com/c/1313271Reviewed-by:
-
Robert Ma authored
The service account was created at https://crbug.com/863229. Bug: 863229 Change-Id: Iec2bf7379955bd15169b475a4855cc1479c54471 Reviewed-on: https://chromium-review.googlesource.com/c/1313553Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#604703}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/189013bef993..096d016accb0 git log 189013bef993..096d016accb0 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 sprang@webrtc.org Update MultiplexEncoderAdapter to use EncoderInfo 2018-11-01 apehrson@mozilla.com Add guards to VideoCaptureDS::Init for when pins are null 2018-11-01 sprang@webrtc.org Use EncoderInfo in SimulcastEncoderAdapter 2018-11-01 Peter) Slatala Plug-in media transport state listener Created with: gclient setdep -r src/third_party/webrtc@096d016accb0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id8a3e86cb163512e80cd6a705f51d7125df95662 Reviewed-on: https://chromium-review.googlesource.com/c/1313128Reviewed-by:
-
John Chen authored
On environment that doesn't support maximizing window, try to simulate its effect. Bug: 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604701}
-
Mohamed Heikal authored
This reverts commit d3fd7a3e. Reason for revert: breaks ui tests Original change's description: > Reland "[Android] Remove most resource names in resources.arsc" > > This is a reland of 86259392 > > TBR=This is the same cl no changes > > Original change's description: > > [Android] Remove most resource names in resources.arsc > > > > resource names are stored in the resources.arsc file to allow for > > getIdentifier with the string name of the resource to work. This cl > > obfuscates all of those resources to one name (and thus stored only > > once) for all resources that are not accessed via getIdentifier. > > > > This improves binary size by about 200KB. > > > > Bug: 894208 > > > > Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530 > > Reviewed-on: https://chromium-review.googlesource.com/c/1265897 > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603229} > > Bug: 894208 > Change-Id: Id023518c91c0c98cf68f15efad286c4874b4976d > Reviewed-on: https://chromium-review.googlesource.com/c/1308991 > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604426} TBR=torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: I1e4d1de0ea707d6dddfc82b13a44854fc30be753 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894208 Reviewed-on: https://chromium-review.googlesource.com/c/1313279Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604700}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I866e601bea944e76070eb16853ac448a5aaf62ca Reviewed-on: https://chromium-review.googlesource.com/c/1313229Reviewed-by:
-
Shimi Zhang authored
Bug: 900778, b/110313642 Change-Id: Ic530e933fd5e9b14e5f54e2a9d34d5e46b83a41f Reviewed-on: https://chromium-review.googlesource.com/c/1287829Reviewed-by:
-
Regan Hsu authored
MultiDevice.DeviceSyncService.FindEligibleDevices.Result* Add success of finding eligible devices (FindEligibleDevices), and metrics which breaks down the percentages of reasons when failure occurs on FindEligibleDevices. Bug: 870138 Change-Id: I63140be659f5d4723998a0cc87b53e830f36f09d Reviewed-on: https://chromium-review.googlesource.com/c/1311086 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Owen Min authored
The policy force installs Chrome Reporting Extension and overrides any other extension policies about extensions black list, blcoked permissions, allowed/blocked runtime hosts, minimum version requirment, allowed type and update url. The policy does not override install source policy as it does not affect force-installed extension. Bug: 898673 Change-Id: I8f17d2073b200448d268a34dc07ab61ff65753d8 Reviewed-on: https://chromium-review.googlesource.com/c/1306233 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604696}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6fd71fba4d7..669b0a7d9028 Created with: gclient setdep -r src-internal@669b0a7d9028 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892384 TBR=mmoss@chromium.org Change-Id: I2006a448fb1e57466af14659cc8e030bdb4db7bc Reviewed-on: https://chromium-review.googlesource.com/c/1313033Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604695}
-
Eric Karl authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1311835 Re-enables tests after rebaselining. TBR=kbr@chromium.org Bug: 900599 Change-Id: I4f3adb6adb934f73868c5f3e047d5ac4763e304a Reviewed-on: https://chromium-review.googlesource.com/c/1313269Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604694}
-
Scott Violet authored
Adds explicit and removes unused function. BUG=none TEST=none Change-Id: I3e7d09498384660d1d3c3eacd27d7cae34bf2ac1 Reviewed-on: https://chromium-review.googlesource.com/c/1312980Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51fdcfba7593..b281d52b301d git log 51fdcfba7593..b281d52b301d --date=short --no-merges --format='%ad %ae %s' 2018-11-01 nednguyen@google.com Remove keychain util code Created with: gclient setdep -r src/third_party/catapult@b281d52b301d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:714231 TBR=sullivan@chromium.org Change-Id: I56b6c60a5ef489282695ae8e318d66576f949d4f Reviewed-on: https://chromium-review.googlesource.com/c/1313228Reviewed-by:
-
Ryan Sturm authored
This requires 2 things: more robustly setting the Network Quality and turning on Data Reduction Network Service feature. The latter is required because IsDataReductionProxyEnabled is used by previews to determine whether the user is a data saver user. Bug: 778793 Change-Id: Ib0721ecb6bc25f2f324a966a997d3a6c2f5e60a5 Reviewed-on: https://chromium-review.googlesource.com/c/1313070Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Alexander Timin authored
As a final step, replace all includes back: - mv message_loop_current.h message_loop.h - s/message_loop_forward.h/message_loop.h/ in all includes. - s/message_loop_forward.h/message_loop.h/ in base/BUILD.gn - Remove message_loop_forward.h from third_party/DEPS. TBR=gab@chromium.org R=gab@chromium.org BUG=891670 Change-Id: I623077025701459ddb7045cbcfdad138aa90a9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1313110Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604690}
-
