- 25 Nov, 2020 40 commits
-
-
Peter Kasting authored
This is a reland of e0e81ba9 Original change's description: > More inclusive terminology for chrome/browser/win/conflicts/. > > Bug: 1097283 > Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830830} Bug: 1097283 TBR: gab, hwd, pmonette, tedchoc, chrisha, waffles Change-Id: I97eacb76ce1009f2534e42d20933fcd6fd9abade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560684Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#831029}
-
Yann Dago authored
BrowserCloudManagementStatusProvider::IsManaged was using policy::BrowserDMTokenStorage::RetrieveDMToken to determine if the browser was managed, and that call was making some blocking I/O, now we look at the existence of a MachineLevelUserCloudPolicyManager. MachineLevelUserCloudPolicyManager will be created only if the browser is managed by CBCM. Bug: 1150377 Change-Id: I3ec4b165577ffac864c5f2a5045d53b21196e3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547327 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#831028}
-
shivanigithub authored
This CL keeps track of the top-frame sites for each resource cached in the blink cache and updates metrics to see the cache hits if the cache was partitioned by top-frame site. These metrics will then be compared with the per-document cache metrics added in https://chromium-review.googlesource.com/c/chromium/src/+/2543684 to help decide between the two design choices. Bug: 1129860 Change-Id: I41a4dc7d3283a2e232df21c87afe9877c0482a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558763Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#831027}
-
Morten Stenshorne authored
When an atomic inline is the closest element, but we're not *inside* it, we shouldn't look for stuff inside it, either. (Note that the change here in LayoutBlock::PositionForPoint() will make us enter PositionForPointIfOutsideAtomicInlineLevel() also for (inline) tables, since the atomic inline check has been moved before the table check. This doesn't make much of a difference, though, since LayoutBox::PositionForPoint() already has special code for tables, which does pretty much exactly the same as PositionForPointIfOutsideAtomicInlineLevel()). The test included here used to fail with LayoutNGFullPositionForPoint enabled, in the inline-flex case, but also in the inline-table case, if LayoutNGTable is enabled in addition. This also fixes GranularityStrategyTest.UpdateExtentWithNullPositionForCharacter and GranularityStrategyTest.UpdateExtentWithNullPositionForDirectional on Android and Windows (when LayoutNGFullPositionForPoint is enabled). Bug: 1150362 Change-Id: Ied71317aaaa8e380600461436ee979a56b5a4584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552866 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831026}
-
Wenbin Zhang authored
Reducing the shard size when we only have 3 devices for this builder. Bug: chromium:1152120 Change-Id: I0188d35af9a249e7356c7d02bc2820c64860cc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559224 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#831025}
-
Christian Dullweber authored
To ensure that all fragments are removed when the PageInfo dialog is closed, the subpage controller needs to be notified when the main controller is dismissed. Bug: 1152724 Change-Id: I075a214223ceee675578615226b958880a103946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560628Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#831024}
-
Stepan Khapugin authored
Connects the auth button, through the dispatcher, to the scene agent, which allows the tab switcher to actually authenticate. Bug: none Change-Id: Ic6c30f74e55bd6f1b143c00e9c41b2154e142531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547680 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#831023}
-
Thomas Guilbert authored
This CL makes sure all videos have produced a video frame before proceeding to the next step of the test, by using the requestVideoFrameCallback API. video-object-fit-change.html still has a risk of flaking, since we cannot use rVFC to be notified on object fits. Bug: 963141 Change-Id: I17903cb9914977d113c8ba3093e2eb298328141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556497 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#831022}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011250600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/UEDryZf_VuC_LfcEXlTJ_7tEzVfL6qKZIy8qC-wjmbIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/169287051,b/172278041,b/173974940,b/174114212 Tbr: media-app@grotations.appspotmail.com Change-Id: Ib16ffa1fea3e76ed4289872b1ebc2c378ece8dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831021}
-
Olivier Robin authored
WebFaviconDriver::DownloadImage has a max size parameter to avoid issue with image decompression bombs. Add a parameter to ImageDataToSkBitmaps to respect this max size. Bug: 1095383 Change-Id: Id52783abae71d27e8c829ac43d9b4ee37220ae6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560742Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831020}
-
Nico Weber authored
This reverts commit a06a6eb7. Reason for revert: Seems to break non-goma builds on macos. Original change's description: > [ios] Always use symbolic links to system Xcode in build_root_dir > > Goma RBE only supports paths that are relative to the source dir > while build not using Goma or using old Goma backend supports both > so always use symbolic link to system Xcode on iOS. > > This fix the compilation for people using Goma as Goma RBE is now > the default backend and without this change, the build would fall > back to local compilation, drastically slowing the build. > > Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe > gn variables as they are now always expected to be `true`. Keep > the variable ios_use_goma_rbe to avoid breaking the bots that do > override the value but ignore it (bot set it to true anyway). > > Bug: none > Change-Id: I2a3c098304594fb20491ab92100e9a4101a048db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555117 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830616} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: I5aed7d701a1d2d04d389cb4d746bc975e80b0f0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831019}
-
Igor Tukh authored
PermissionAuditingService is a service which allows to store and audit the basic information about the permissions usage. Bug: 1152769 Change-Id: If22ed0ad189eca8dbdd8502d3a1151d7561aeffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517443 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831018}
-
Palak Agarwal authored
Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. This is an API for capturing the current tab. Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Bug: 1136942 Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#831017}
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: I061a82a990b60a07952e4c6203b1b6260de97d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554569 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#831016}
-
Janusz Majnert authored
If input file contains non-utf-8 characters, running GetResourceAllowlistFileList in python3 fails with a variation of: "UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 24: invalid start byte" This change makes python3 treat data as bytes, while leaving python2 behavior unchanged. Change-Id: Idb6f4cf8fe3a98551df91b1249a1b74ba2916acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560505Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831015}
-
Alex Turner authored
Use of base::CancelableCallback is deprecated in favor of the more explicit base::Cancelable{Once,Repeating}Callback. The uses were often missed when converting directories from base::Bind/Callback to the Once/ Repeating versions. This cl completes this conversion for directories already marked as fixed. A follow-up cl (crrev.com/c/2506350) will enforce a presubmit for this deprecation on converted directories. Bug: 1142629 Change-Id: I0453280104339d359b4a9dfa90507104d154b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505963Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831014}
-
Gauthier Ambard authored
This CL changes the key used in the error to pass the URL of the failed navigation as it is not the one used in the rest of the navigation code. Fixed: 1140976 Change-Id: I752feef45742477ca38f9e3e89f3921378889f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550674Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831013}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1e79537bc8ee341113d56edc4da819c6daeb1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831012}
-
Thomas Tellier authored
Bug: 1152041 Change-Id: I040b4d71be130b0a0102e66a13976c3a940123eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560102Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#831011}
-
chrome://flagsViktor Semeniuk authored
This features allows obtaining Change Password URLs from the Affiliation Service. Also UseOfHashAffiliationFetcher enables usage of Affiliation Service for non-synced uses. Bug: 1108279 Change-Id: Iaf9551af033b0636596ba6d3abab156c111c9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556843Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#831010}
-
Egor Pasko authored
Just a tiny fix to follow the API contract. Bug: None Change-Id: I2ed632b45d802ddc100340121b7e29b37abc5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560123Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831009}
-
Wei Lee authored
Bug: b/172344305 Test: Build successfully Change-Id: Ibef322d2c968a844c778baa6d8ca9cd0a2909b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554262Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831008}
-
Adrian McCarthy authored
The `got_clang_revision` property is no longer available, so point out that the LLVM revision range is available in the `gclient runhooks` log. Change-Id: I5adde8dfc5e0a9ee6da0b852803744497d4c240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537700 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831007}
-
Andres Calderon Jaramillo authored
Bug: 1152030 Test: None Change-Id: I24840d83ec6fe3ee14c387943740d606491151a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559445 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#831006}
-
Rouslan Solomakhin authored
Before this patch, a Mojo message PaymentRequest.Init() with null details, id, or total would not be rejected and could cause null pointer dereferences in the browser. This patch adds checks for null details, id, and total in the browser, so the invalid Mojo IPC messages are rejected. After this patch, a Mojo message PaymentRequest.Init() with null details, id, or total is rejected, so the transaction is aborted. Bug: 1148074 Change-Id: I39c821eef034cafc4ed830769785fb812304f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556470Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831005}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606283471-f8912cacc34d1ac24aa30fb74f9ef98ec89268aa.profdata to chrome-linux-master-1606305050-8edbd758527486c76db2fc42225801a21c253468.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie8c9f0df5dc5d26c8becf2f2cf1a6defd4c52812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831004}
-
Roman Sorokin authored
Check if it's inited before setting a callback to wait Fixed: 1151851 Change-Id: I94ae394067474c277d0f7c5786c611d637aa98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560508 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831003}
-
Robert Ma authored
And add more logging (consistent with other parts of wpt-export). Change-Id: If2d1e2b6e80fe3600e2dc1b9ff63f11ec41f2018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559230Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#831002}
-
Liquan (Max) Gu authored
Since the raw PaymentMethodData array may have null elements, this CL null-check element and reject these cases. Bug: 1152662 Change-Id: I51382071f1f90966f9ed16e88b6b3ed2691ae482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559642 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831001}
-
Gauthier Ambard authored
This CL unfocusing the omnibox when the NTP is created. This is needed as the NTP is re-created when the browsing data are cleared. This can happen while the omnibox is focused on multiwindow. Unfocusing the omnibox ensure that the NTP state (i.e. scrolled down) is matching the omnibox state. Bug: 1139191 Change-Id: I07d050bc1c2d90178bf80786150fd2cbc1d4e4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550044 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831000}
-
Ulan Degenbaev authored
The performance.measureMemory API relies on PerformanceManager, so we need to enable PerformanceManager to run web platform tests. Bug: 1085129 Change-Id: I5e49a35025928526d8e5a36a07e8dcecf2793977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551122Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830999}
-
Boris Sazonov authored
Improves testability of AccountManagerFacadeLacros - mojo::Remote is now passed explicitly to the ctor. Bug: 1117472 Change-Id: I81475ea7bf369a51ff0b0bdf8e43117737d09706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550809 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#830998}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I492fc44a2805ada0577fff025343470e685b653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830997}
-
Philipp Hancke authored
this will intentionally break when adding new codecs and we can not add new codecs anymore because we do not have enough payload types. BUG=webrtc:12194 Change-Id: Ic1dff5f479377280111729f6443fc60a7d2e2658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550806 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830996}
-
Jack Franklin authored
It was disabled to allow a DevTools Frontend CL to land, but it should now be able to run again. I thought the test would need updating given the changes in the source file, but it doesn't. There was a legitimate bug in the source CL (which has since been fixed) which I mistakenly took to mean I needed to disable the test before my frontend change could land. Fixed: 1150854 Change-Id: I672b336941e5f9a797a09d3139af1ea61f516ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558338 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830995}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606283471-7d9c21277781bbef8f12040d64fba3a4328552df.profdata to chrome-mac-master-1606305050-ea6ce0091e94442cf03fb928da3568602c7b69e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee98d112dc96901b7c15d69d5c5543d643a65680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830994}
-
Maciek Slusarczyk authored
When the online sign-in flow is executed after password change CrOS shows old password confirmation dialog. If the old password provided by the user is incorrect the dialog is displayed with an error message. The message stays there even if we cancel the flow and start from scratch. This CL introduced a new flag that checks if the flow was restarted anew and if so hides the error message. Bug: 1138083 Change-Id: I8a6c6cafcbedf154f8d0cc008ed0510ed6373e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537639 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#830993}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaf49c6587ad..16534e267df0 2020-11-25 tvanderlippe@chromium.org Remove Python infrastructure for the Closure Compiler 2020-11-25 jacktfranklin@chromium.org [DarkMode]: rename patchThemeSupport to enableLegacyPatching 2020-11-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-25 jacktfranklin@chromium.org [DarkMode] turn off legacy patching in CSSOverviewStartView 2020-11-25 alexrudenko@chromium.org Allow expanding/collapsing details in the Layout panel using arrow keys 2020-11-25 yiorsi@gmail.com Add copy object context menu in Console and Sources panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1148353,chromium:1149859,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f65ff96ffcc72b7f849ca24d9a58c644d948acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830992}
-
Pavol Marko authored
The test was failing/flaky on some MSAN bots, presumably because the listener was registered after the event was fired. Introduce a helper class that allows us to easily register the listener, perform the event, then wait for the listener to have fired. TBR=josiahk@chromium.org, dtseng@chromium.org Bug: 1145612 Test: Runs locally but real test will be whether this fixes failures on the 'Linux ChromiumOS MSan Tests bot' Change-Id: I16303d96b101113e80ab4f484b4e604faeab4c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560622Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830991}
-
Ewann authored
PageInfoRefactoring has been launched. This CL removes The Legacy PageInfo implementation as well as the implementation of the PageInfoRefactoring flag. Bug: 1038923 Change-Id: I24d60982ca1de28ef12faa6f2e89d3883c3046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529162 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#830990}
-