GitLab

The problem was here:

for (size_t i = children().size() - 1; i >= 0; --i) {

The loop variable |size_t i| was of an unsigned int type, so |i >= 0|
was always true.

Repro on Windows by exploring the tree with Inspect on the link provided
in the crbug description.

Bug: 988153
Change-Id: I1cae093da68f12ed1630a568ec7529703c73cf89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737870
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684428}

This is a speculative fix.

Bug: 979565
Change-Id: I140d9a3fa2334f7137e1491c40c61d96bcded8b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729922
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684427}

Patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1692627

Made us consider inline-level OOF-positioned nodes as adjoining, as
their static-position depends on where other floats are placed.

During the first pass the BFC block-offset gets resolved here:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc?l=986&rcl=e6157bb7afb778d5c15bb2bb09a457d9632151da

This aborts as it has an adjoining inline-OOF, and *doesn't* resolve
the BFC block-offset at |child_bfc_offset_estimate| instead applying
clearance.

Upon the second pass we now hit the DCHECK as neither of the options
has clearance applied.

Bug: 987004
Change-Id: I2634d56726a4664c869b2ecfa1e7a8a13458e78f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731917
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684426}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=zmin@chromium.org

Bug: 968047
Change-Id: I5af561f465c55acc9b49898abe8051f475f1f873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739826
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684425}

This is another manual update on the Chrome OS orderfile name,
to reflect the recent change on the orderfile name format. This is
another preparation for the autoroller.

BUG=chromium:950627
TEST=The orderfile is tested on Chrome OS. No code is using the orderfile for now

Change-Id: If2a88ec35d89e397c00904f8b5fc093cc7b77dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739117
Auto-Submit: Tiancong Wang <tcwang@google.com>
Reviewed-by: Eric Boren <borenet@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684424}

The primary goal of this CL is to use IsA<HTMLDirectoryElement>(element)
in place of IsHTMLDirectoryElement(element)

Bug: 891908
Change-Id: Iab622a1653b9b24d27894bf2ede0ba18a59daf61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739487Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#684423}

Bug: 982122
Change-Id: I9dbf678992caec7ac97ef028e9ec16c2da7db02c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735523Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684422}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 968047
Change-Id: Ia108448a6cc6ffdcee488ef32c4d9fa77f3839a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739707
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684421}

Updates the expiry of these histograms, which are still
useful to keep around.
IOS.EnterTabSwitcherSnapshotResult
IOS.PageLoadedSnapshotResult

Bug: 974919
Change-Id: I2c5b8f20c02f89c76200a18e53f9c094dda3b81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737898Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684420}

A writer of a test will see a callstack anyway.

Bug: 877898
Change-Id: I0a77bf5374d59de3eb1249d89db0be8852b16fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738366Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684419}

It should never be null.

BUG=None

Change-Id: Ic1e72b42e4664177cd42af61d38caa4930c5713c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737741
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684418}

Bug: 967779
Change-Id: I456c2218ca23d9cd4878588f94a82410bfbf056e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692980
Auto-Submit: Mathieu Binette <mbinette@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684417}

r684202 set the wrong object member. (This fix is equally untested
because I have to wait for Canary in order to try it.)

BUG=990992

Change-Id: I140d081e53f2d10070a35cff8af312db7f3c77d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739395
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684416}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 968047
Change-Id: Ie4c905f2e8a679550fe00953a010c62ceaa9b806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739709
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684415}

R=drubery
TBR=holte (since http://cl/261944627)

Bug: 965587
Change-Id: Ic8a8c8a05be012bae3bf375d511399eba47c1ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739588
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684414}

Set picker value to the exact value that user selected instead of the
darkest of the calculated colors. These 2 colors are similar but not
always the same. Therefor picker value to the exact value so that selected color doesn't jump
after OnThemeUpdate.

Bug: 990379
Change-Id: Iac9ddae122be5daf01ec95bca571ec832aa5a981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737330
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684413}

With flag kConsolidatedMovementXY enabled, we compare the incoming event's
coordinates with the |synthetic_move_position_| to tell if the event is a
synthetized move that comes from |MoveCursorTo| call.
The check didn't consider the error introduced by converting from pixel to
dip, which causes a failure when there is a fractional device_scale_factor.

This CL makes the check use the same logic as w/o kConsolidatedMovementXY.
This also removes |synthetic_move_sent_| boolean and use
|synthetic_move_position_| for both the flag enabled/disabled.


Bug: 802067
Change-Id: I4847397e317d29b62328d02910b7cb3e8de13759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704743Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684412}

BUG=984159

Change-Id: I18d9882adc86ad163a7ef161bd8f48ee2484f80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739113
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684411}

This is a reland of 053b22e8

The CacheStorageManagerTest.TestErrorInitializingCache test has been modified
to reduce flakiness.

Original change's description:
> CacheStorage: Write index after simple disk_cache.
>
> When we load the cache_storage index we try to determine if its fresh
> or stale by comparing its timestamp against the timestamp of the
> various simple disk_cache directories.  Both cache_storage and simple
> disk_cache write their index files out using a delay.  The
> cache_storage delay is 5 seconds and the simple disk_cache delay is 20
> seconds.  This means that the simple disk_cache index is always written
> last and as a result the cache_storage index is almost always
> considered stale.
>
> This CL fix this by extending the cache_storage delay to match the
> simple disk_cache delay.  It also implements a shorter delay on android
> when in the background like simple disk_cache uses to avoid losing
> data when the app is killed by the operating system.  Finally, the CL
> also now properly flushes the index to disk if there is a pending write
> when the cache_storage subsystem is torn down.
>
> Over time this should cause ServiceWorkerCache.UsedIndexFileSize to
> show more cases where the index file is used to provide the size.
>
> Bug: 988001
> Change-Id: Idaa09b956edcfa9e70ac1fdb9b43adcd73ec0508
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721389
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682409}

Bug: 988001
Change-Id: I12aa006bf1d18be5ae121c0330d97e51a97ff906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739408Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684410}

https://swiftshader.googlesource.com/SwiftShader.git/+log/060fcf777159..3aec8a3be749

git log 060fcf777159..3aec8a3be749 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 chrisforbes@google.com Tidy around sampler handling

Created with:
  gclient setdep -r src/third_party/swiftshader@3aec8a3be749

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/134584057
Change-Id: I3b892e49f28ce5261a3ad54b056c681e8e1012bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738992Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684409}

UKM collection review doc (Google-only):
https://docs.google.com/document/d/17roFDpjKXeglB9_dzfX7uGykoWeRCVTa_4SDDJyv04Y/

Bug: 973844
Change-Id: I2a8d36286ff7b0472c64313b222f7404f88e241e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724077Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684408}

- Move order of menu header items (e.g. back button and daily toggle) so
  that they follow the submenu nav buttons using keyboard navigation.
- Support selection on SPACE for color/background tiles.
- Like backgrounds/colors, use arrowkeys instead of TAB to navigate the
  shortcut options (i.e. TAB to focus the shortcuts menu, then use
  arrowkeys to move between the shortcut options).
- Add role=button to upload & default background tiles for screenreader
  support.

Bug: 953822
Change-Id: Iae8c1b8390d917f1513e234b46f0b75cc9bae3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737743
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684407}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.
R=eladalon@chromium.org

Bug: 968047
Change-Id: I32f6d432ffa2550f58d433775e0adef216cf9ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738593
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684406}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36756e459041..c5f95c03ada3

git log 36756e459041..c5f95c03ada3 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@c5f95c03ada3

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: None
Change-Id: Id342cf080995fdd38d5ece41d466daca5b6ea30f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738995Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684405}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=alph@chromium.org

Bug: 968047
Change-Id: Ib6128dd00c45055be4f045a73665fa61cc6a0a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728588
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684404}

https://webrtc.googlesource.com/src.git/+log/61b15905b014..7cbee84610a8

git log 61b15905b014..7cbee84610a8 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 srte@webrtc.org Reland "Adds PeerConnection scenario test framework."
2019-08-06 sprang@webrtc.org DegradedCall: fake network using TaskQueue instead of ProcessThread
2019-08-06 mbonadei@webrtc.org Disable RunPythonTests on rtc_tools.

Created with:
  gclient setdep -r src/third_party/webrtc@7cbee84610a8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I696d68c872e0622c9fc9cb635c5ac7d929b84639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738994Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684403}

The app list view already skips events during overview, but this is not
enough because the app list window still consumes the tap event, and
then gets activating, exiting overview. Its ok now as we'd want to exit
overview anyways, but we're introducing side scrolling soon, so we need
the tap down event to not exit overview.

SearchBox view now does not need to check if we are in overview anymore,
since searchbox widget is a child of AppList window.

Test: manual
Bug: 991040
Change-Id: Ice13a42eff72a5897fb4ba44cb56152aee57e479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737823Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684402}

Replaces the png graphics that blends into the default-color highlight
effect.

Bug: chromium:978388

Change-Id: I33e63b1e15c225761f6f089aac5e853463169b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736440Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684401}

This CL adds the MVC components for TabGridIph component. Right now
there are no consumers for this part of logic.

Bug: 987043
Change-Id: I877d5909a164fad79d1f7206652e98eab8c54efe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731178
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684400}

Instead of adding a variable to check if the test should be finished,
we can create a promise object and end the test at its last callback.

Bug: 606367
Change-Id: I6be3a61db1f54fa88b56e919b8be6dfa318b21c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704865Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684399}

https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/3668
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905912644874073840/+/steps/compile/0/stdout
[7588/69449] CXX obj/chrome/updater/win/installer/lib/installer.obj
FAILED: obj/chrome/updater/win/installer/lib/installer.obj
...
In file included from ../../chrome/updater/win/installer/installer.cc:31:
In file included from ../..\base/files/file_path.h:114:
In file included from ../..\base/stl_util.h:26:
../..\base/logging.h(23,10): fatal error: 'base/logging_buildflags.h' file not found
#include "base/logging_buildflags.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

TBR=waffles
CC=​jdonnelly

Bug: 989772
Change-Id: I4f660a6a5fc420c691a8c8c4018c90e32e76f2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739319Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684398}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites with
       tools/git/mffr.py.

This CL was uploaded by git cl split.

R=oshima@chromium.org

Bug: 968047
Change-Id: I9ee81e17587644f1651afd664168c0f864df93ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728877
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684397}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77c12644ba94..fc9e4928e7c0


Created with:
  gclient setdep -r src-internal@fc9e4928e7c0

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I0e2a5b91336ea8422d82b52f621b45a4f25b9d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738993Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684396}

The link icon is presentational, so take it out of the tab order.
Add an aria-label to the clear button.

This is needed to get a11y browser tests to pass when we flip the
SplitSettings flag.

Bug: 950007
Test: enable Chromevox, tab through settings
Change-Id: Id5be0809de94f4107231f5a7f4d932e5cb143479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739392
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684395}

Adds the Intel UHD 630 to the list of approved Intel GPUs on Windows in
the GPU integration tests. Without this, one of the
info_collection_tests fails on the new Optiplex 7060 that is being
qualified.

Bug: 986939
Change-Id: I2d71c2a8499367e8c6de131e8f41279e0f4b3b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737810
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684394}

https://skia.googlesource.com/skia.git/+log/3a543aafd4e6..bdb0919dcc6a

git log 3a543aafd4e6..bdb0919dcc6a --date=short --no-merges --format='%ad %ae %s'
2019-08-06 robertphillips@google.com Use GrComputeTightCombinedBufferSize in GrMtlGpu::uploadToTexture

Created with:
  gclient setdep -r src/third_party/skia@bdb0919dcc6a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@google.com

Bug: None
Change-Id: I6b3ea554bb09d275d7108afe9a05c18d47d1d633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738329Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684393}

In ObjectManager, when ConnectToNameOwnerChangedSignal is called the first time,
we could have already missed the NameOwnerChanged signal if we get a value from
UpdateNameOwnerAndBlock. This means NameOwnerChanged callbacks will
never be called until that service restarts. In ObjectManager we run
into this problem:

1. ObjectManager::SetupMatchRuleAndFilter is called, calling
bus_->GetServiceOwnerAndBlock shows empty service name owner.

2. ObjectManager::OnSetupManagerRuleAndFilterComplete callback will call
object_proxy_->ConnectToSignal, which in turn calls
ConnectToNameOwnerChangedSignal the first time. At this point,
UpdateNameOwnerAndBlock calling bus_->GetServiceOwnerAndBlock returns the
current name owner of the service, this means the NameOwnerChanged signal
is already sent on system bus.

3. As a result, ObjectManager::NameOwnerChanged is never called while
the service is already online. This in turn causes GetManagedObject to
never be called, and the object manager interface never added.

See detailed sample logs in b/138416411.

This CL adds the following:

1. Make SetNameOwnerChangedCallback run
ConnectToNameOwnerChangedSignal when called. Since ObjectManager calls
SetNameOwnerChangedCallback before posting SetupMatchRuleAndFilter (in which
ObjectManager attempts to get the service name owner through a blocking call),
this removes the time gap described above that causes lost signal.

2. Make dbus thread the only writer to |service_name_owner_|, given that
connecting to the NameOwnerChanged signal right away in ObjectManager
ctor causes potential data race in writing to |service_name_owner_| in
both NameOwnerChanged (on origin thread) and SetupMatchRuleAndFilter (on
dbus thread).

BUG=b:138416411
TEST=Manually on device.


Change-Id: Ie95a5b7b303637acadebda151cc478e52b6a1af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733111
Commit-Queue: Bing Xue <bingxue@google.com>
Auto-Submit: Bing Xue <bingxue@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684392}

This change separates updating AXNodeData in AXTree::UpdateNode from
notifying that the node data will change, and node data has changed.

---

Problem :
  AXTree notifies AXTreeObservers of node and subtree changes in the middle
  of a tree update, which means observers may be seeing a tree state that's
  incomplete. This can lead to subtle bugs when observers access nodes in the
  AXTree other than the node being updated.
  e.g. |GetUnignoredParent| may be invalid during a notification, but
  correct afterwards.

Proposed solution :
  Separate notifications from updates in AXTree::Unserialize.

  This requires the following steps :
    1. Record all operations that would be performed on the tree.
    2. Fire all on destroy and OnNodeDataWillChange callbacks.
    3. Apply all update operations.
    4. Fire all created and node data changed callbacks.


  For additional context, see these comments by Nektarios and Dominic :
  https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24
  https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416

  I  plan to submit approximately 3 CLs to resolve this :
    1. Handle Pre/Post Tree changes (create node / destroy subtree)
    2. Handle Pre/Post Node data changes (attributes will / have changes)
    3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining
       work required to do so, to help harden these paths.

Bug: 974444
Change-Id: Iade343a572003e31d79039b08cced689fb6e9cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710128
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#684391}

If we need to recalculate style for a pseudo element, we forced it
through the StyleRecalcChange passed in, even if the only reason was
that the pseudo element itself was style dirty. The problem with that is
that it would look like an ancestor change made the recalc necessary. If
an ancestor change made it necessary we could not use the optimized base
computed style path for style recalc.

Make sure we only translate kUpdatePseudoElements into kRecalcChildren
and still benefit from base computed style if the incoming
StyleRecalcChange propagation is kNo.

Bug: 988834
Change-Id: Ib2efcd6a932623bfec6226512eb3692418c84928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738559Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684390}

https://quiche.googlesource.com/quiche.git/+log/7be3caccf..a0c8f5aa0

$ git log 7be3caccf..a0c8f5aa0 --date=short --no-merges --format='%ad %ae %s'
2019-08-04 bnc Add QpackEncoder::SetMaximumDynamicTableCapacity() and SetMaximumBlockedStreams() and call them when corresponding settings are received.
2019-08-02 dschinazi Fix coalesced packet processing
2019-08-02 renjietang Remove incorrect uses of GetHeadersStreamId().

Change-Id: I8d44ef3d884f4321050d795d376a3ed06be74d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739290
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684389}