Commits · 74c8b6283df8afb2b98290d97449b80936a6bdeb · eriksson monteiro / tangled

19 Jun, 2014 1 commit

Switch to the new SkCanvas::willSave() API. · 74c8b628

fmalita@chromium.org authored Jun 19, 2014

Skia's save() SaveFlags bits are going the way of the dodo. At this
point all callers have been updated to always pass kMatrixClip, but
SkCanvas subclasses also need to use the new willSave() API.

(depends on https://codereview.chromium.org/338833003/ rolling)

BUG=skia:2297
R=reed@google.com,senorblanco@chromium.org,malch@chromium.org

Review URL: https://codereview.chromium.org/338863002

git-svn-id: svn://svn.chromium.org/blink/trunk@176465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

74c8b628

18 Jun, 2014 39 commits

DevTools: Revert stepping over/out on a call frame backend code. · ba767df0

aandrey@chromium.org authored Jun 18, 2014

This code is unused.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/333153003

git-svn-id: svn://svn.chromium.org/blink/trunk@176464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ba767df0

Notify font loads via FontLoader · 5f74419a

ksakamoto@chromium.org authored Jun 18, 2014

Before this patch, font load was noticed to CSSFontSelector through the
following path:

 RemoteFontFaceSource
 -> CSSFontFace
 -> CSSSegmentedFontFace
 -> CSSFontSelector

However, StyleEngine clears FontFaceCache upon stylesheet changes and
reconstruct it lazily, it is possible that CSSSegmentedFontFace is
absent when a load is completed. As a result, loaded font is not
rendered.

This patch fixes the problem by changing the notification path as follows:
 RemoteFontFaceSource -> FontLoader -> CSSFontSelector.

BUG=378238
TEST=fast/css/font-face-css-change-while-loading.html

Review URL: https://codereview.chromium.org/321403003

git-svn-id: svn://svn.chromium.org/blink/trunk@176463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5f74419a

Cleanup Blink's Platform from Screen Orientation stuff. · 1a794ff9

mlamouri@chromium.org authored Jun 18, 2014

The embedders should now use WebScreenOrientationClient instead.

BUG=None

Review URL: https://codereview.chromium.org/339343003

git-svn-id: svn://svn.chromium.org/blink/trunk@176462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1a794ff9

Isolated world injected inline styles should bypass main world CSP. · bc808758

jww@chromium.org authored Jun 18, 2014

Inline styles that are added to a page from an isolated world should bypass the
main world's CSP, much like how scripts do. As an example, this is important for
extensions to make sure they can bypass the page's CSP when they inject a style
tag into the page.

R=mkwst@chromium.org
BUG=385246

Review URL: https://codereview.chromium.org/341443003

git-svn-id: svn://svn.chromium.org/blink/trunk@176461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bc808758

Reduce forward declarations in core/svg · e2ab53e6

rob.buis@samsung.com authored Jun 18, 2014

BUG=

Review URL: https://codereview.chromium.org/344693003

git-svn-id: svn://svn.chromium.org/blink/trunk@176460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e2ab53e6

Removed the frame parameter from didChangeBrandColor because · 1a693b1f

michaelbai@chromium.org authored Jun 18, 2014

the RenderFrame and WebFrame has 1:1 mapping now

Review URL: https://codereview.chromium.org/339133004

git-svn-id: svn://svn.chromium.org/blink/trunk@176459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1a693b1f

Reduce forward declarations in core/rendering · 0ecd0b3e

rob.buis@samsung.com authored Jun 18, 2014

BUG=

Review URL: https://codereview.chromium.org/337113005

git-svn-id: svn://svn.chromium.org/blink/trunk@176458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0ecd0b3e

Correct the squashing origin w.r.t. the transformed ancestor to take into... · 139fc914

chrishtr@chromium.org authored Jun 18, 2014

Correct the squashing origin w.r.t. the transformed ancestor to take into account rounding to integer
offsets.

Review URL: https://codereview.chromium.org/345613004

git-svn-id: svn://svn.chromium.org/blink/trunk@176457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

139fc914

Make replaced preferred widths independent on available width · 400f8a96

davve@opera.com authored Jun 18, 2014

Prior to this patch, a replaced element with intrinsic ratio but with
no intrinsic width nor height and with 'width', 'height' both computed
values of 'auto', would have preferred width and preferred minimal
width that depended on the available width of the container.

After this patch, such a replaced element will have zero preferred
width and zero preferred minimal width.

Example:

<!doctype html>
<div style="width: 200px">
  <svg viewBox="0 0 1 1" style="background: blue">
  </svg>
<div>

<svg> becomes a 200x200 blue rectangle, intrinsic ratio (1) comes from
viewBox attribute. Preferred minimal width and preferred width would
be 200px prior to patch.

Changing the width of <div> would require recalculating preferred
widths on <svg>, something we rather not do, and does not currently
do. (See RenderReplaced::needsPreferredWidthsRecalculation()). This
means preferred minimal widths was left with stale values after
changes to the container.

The new behavior matches Firefox but is not yet in spec, possibly
because the sizing of such replaced element is undefined in CSS 2.1,
even though there is a suggestion, followed by Blink, in the spec.

BUG=382922

Review URL: https://codereview.chromium.org/325183002

git-svn-id: svn://svn.chromium.org/blink/trunk@176456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

400f8a96

Add tracing to ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities · 9901a65a

leviw@chromium.org authored Jun 18, 2014

I discovered while looking into LayoutState's fast
coordinate mapping that we can potentially do a lot
of localToAbsolute calls to determine if images are
onscreen in ResourceLoadPriorityOptimizer. These
calls are out-of-band from the RenderTree walk
done during layout, so don't benefit from the fast-
lookups. That made me believe the function may
actually be expensive.

Review URL: https://codereview.chromium.org/342763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9901a65a

DevTools: untangle paint profiler for better reuse · 53cb6155

caseq@chromium.org authored Jun 18, 2014

Make PaintProfilerView and PaintProfilerCommandLogView independent on
each other, make them both children of LayerPaintProfilerView and remove
layer-specific stuff into the latter, so that the former two operate on
just snapshots.

BUG=

Review URL: https://codereview.chromium.org/340043002

git-svn-id: svn://svn.chromium.org/blink/trunk@176454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

53cb6155

Adding Blink-side 3d Box and Bounds calculations to TransformOperations · 1388297d

awoloszyn@chromium.org authored Jun 18, 2014



BUG=280139

Review URL: https://codereview.chromium.org/328333003

git-svn-id: svn://svn.chromium.org/blink/trunk@176453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1388297d

Fix RenderLayer::scrollsWithRespectTo(). · fa9589ea

hartmanng@chromium.org authored Jun 18, 2014

scrollsWithRespectTo() currently tries to match up
containing blocks by keeping track of RenderObjects.
However, when it goes to check if a containing block
is a scrolling div, it actually checks the enclosing
RenderLayer. It doesn't make sense to do this since
RenderLayers and RenderObjects don't line up
one-to-one.

Since this function only cares about scrollability,
and the RenderLayer is the object that handles an
elements overflow-scrollability, it makes more
sense to keep track of containing blocks by storing
the enclosingLayer() instead of the RenderObject
itself.

BUG=384642

Review URL: https://codereview.chromium.org/343623003

git-svn-id: svn://svn.chromium.org/blink/trunk@176452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fa9589ea

Fix invalid syntax for JS setters in tests · a609e5f6

arv@chromium.org authored Jun 18, 2014

ECMAScript setters require exactly one parameter.
We had a bunch of tests with zero parameters which
is not valid and should have been SyntaxErrors in
the first place.

BUG=383596

Review URL: https://codereview.chromium.org/339363002

git-svn-id: svn://svn.chromium.org/blink/trunk@176451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a609e5f6

Mark flaky battery-status tests in TestExpectations · c6c7e2a8

jamesr@chromium.org authored Jun 18, 2014

TBR=timvolodine@chromium.org
BUG=384396

Review URL: https://codereview.chromium.org/343683003

git-svn-id: svn://svn.chromium.org/blink/trunk@176450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c6c7e2a8

Bindings: Add ScalarValueString support · e5bbbb17

jsbell@chromium.org authored Jun 18, 2014

Spec:
http://encoding.spec.whatwg.org/#type-scalarvaluestring

Followup to:
Add ByteString support to IDL bindings
https://codereview.chromium.org/309553002/

Encoding API: Handle null input string
https://codereview.chromium.org/313393005/

BUG=379009
TEST=fast/encoding/api/utf16-surrogates-encode.html
TEST=fast/js/webidl-type-mapping.html

Review URL: https://codereview.chromium.org/313993002

git-svn-id: svn://svn.chromium.org/blink/trunk@176449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e5bbbb17

Update XMLHttpRequest use counter to count workers · 0a140486

mahesh.kk@samsung.com authored Jun 18, 2014

Move UseCounter to createRequest() and use executionContext
instead of document to count XHR sync requests from workers once
http://code.google.com/p/chromium/issues/detail?id=376039 is fixed.

Review URL: https://codereview.chromium.org/342703002

git-svn-id: svn://svn.chromium.org/blink/trunk@176448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0a140486

DevTools: fix for test inspector-protocol/page/enable-disable.html · 83f06db5

loislo@chromium.org authored Jun 18, 2014

BUG=316349

Review URL: https://codereview.chromium.org/340803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

83f06db5

Revert "Enable Scroll Animation for RenderLayerScrollableArea" · 5a455eb5

weiliangc@chromium.org authored Jun 18, 2014

This reverts commit 6fd2fdfc9696ee205daf9a43d07c49d30c246aad.

Conflicts:
	LayoutTests/TestExpectations
	Source/core/page/PageAnimator.cpp
	Source/core/rendering/RenderLayerScrollableArea.cpp

BUG=383946

Review URL: https://codereview.chromium.org/343663003

git-svn-id: svn://svn.chromium.org/blink/trunk@176446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5a455eb5

DevTools: [MediaQueryInspector] Compute media query length on backend · c4183830

lushnikov@chromium.org authored Jun 18, 2014

This patch pulls computed media query lengths values from backend.
Note: it is ok to create multiple MediaValuesDynamic objects because
they don't have any internal state and serve as a helper wrappers.

BUG=382996

Review URL: https://codereview.chromium.org/339553004

git-svn-id: svn://svn.chromium.org/blink/trunk@176445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c4183830

[DevTools] Add groups to device select. · 3f95fca4

dgozman@chromium.org authored Jun 18, 2014

This also fixes small UI problems.

BUG=327641

Review URL: https://codereview.chromium.org/346583002

git-svn-id: svn://svn.chromium.org/blink/trunk@176444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3f95fca4

DevTools: Extract CSS resources preloading from css agent to page agent controlled loader. · a1f4ee2e

vsevik@chromium.org authored Jun 18, 2014

R=pfeldman
BUG=354447

Review URL: https://codereview.chromium.org/347543002

git-svn-id: svn://svn.chromium.org/blink/trunk@176443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a1f4ee2e

Added an assertion verifying that a Canvas2DLayerBridge is not deleted · 2708c5a6

piotaixr@chromium.org authored Jun 18, 2014

when still in the Canvas2DLayerManager list.

In order to be able to call Canvas2DLayerManager::isInList,
the method has been changed from private to public.

BUG=385141

Review URL: https://codereview.chromium.org/340093003

git-svn-id: svn://svn.chromium.org/blink/trunk@176442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2708c5a6

Round in the range [-0.5, 0.5) when computing offsetFromRenderer and subpixelAccumulation · 0110067c

chrishtr@chromium.org authored Jun 18, 2014

for squashed layers.

Also remove the assert that the subpixel accumulation matches
the subpixel accumulation if the layer was separately
composited. This doesn't make sense, since the squashing
layer is positioned relative to the compositing ancestor
of m_owningLayer, not the squashing layer, which can have
different subpixel accumulations since subpixel
accumulation is relative to the compositing container of
the graphics layer.

BUG=369526

Review URL: https://codereview.chromium.org/343543005

git-svn-id: svn://svn.chromium.org/blink/trunk@176441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0110067c

Qualify RuntimeEnabledFeatures.h and remove unnecessary include dir. · b960653b

c.shu@samsung.com authored Jun 18, 2014

This CL removes the gen/blink/platform dir in core.gyp and qualifies
all the instances that include RuntimeEnabledFeatures.h.

BUG=381876

Review URL: https://codereview.chromium.org/344593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b960653b

Add Tracing.getCategories to protocol.json. · 81363d05

chrishenry@google.com authored Jun 18, 2014

BUG=

Review URL: https://codereview.chromium.org/331303002

git-svn-id: svn://svn.chromium.org/blink/trunk@176439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

81363d05

Removing using declarations that import names in the C++ Standard library. · 426b5983

harpreet.sk@samsung.com authored Jun 18, 2014

According to the coding guidelines for blink, we should not use
"using" declarations of any kind to import names in the C++ Standard
library. This patch removes all those "using" declarations.

Effected folder: Source/core/css

Review URL: https://codereview.chromium.org/342693003

git-svn-id: svn://svn.chromium.org/blink/trunk@176436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

426b5983

[IndexedDB] Use consistent enums on both sides of IPC. · b88b7eae

jsbell@chromium.org authored Jun 18, 2014

Numerous IndexedDB IPC messages sent renderer->browser are defined members that are enums from Blink (public/platform), and on receipt are static_cast to types
defined in Chromium:

blink::WebIDBCursor::Direction => indexed_db::CursorDirection
blink::WebIDBDatabase::TaskType => IndexedDBDatabase::TaskType
blink::WebIDBDatabase::PutMode => IndexedDBDatabase::PutMode
blink::WebIDBDatabase::TransactionMode => uint16 => indexed_db::TransactionMode

Nothing enforces the equality of these enums at compile time.

So the approach adopted here is to move the Blink-side enums into public/platform/WebIDBTypes.h and use it everywhere.

Patch spread across chromium content side as well as on Blink side.
Chromium side: https://codereview.chromium.org/320833002
Blink side: https://codereview.chromium.org/325683002

BUG=381848
R=dglazkov@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/325683002

Patch from Pritam Nikam <pritam.nikam@samsung.com>.

git-svn-id: svn://svn.chromium.org/blink/trunk@176435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b88b7eae

Custom Elements: Encapsulates Async and Sync Queues into one class. · 38544013

morrita@chromium.org authored Jun 18, 2014

This refactoring encapsulates sync and async microtask queues into
CustomElementMicrotaskStepDispatcher class.
Also, it renames CustomElementMicrotaskQueue to CustomElementSyncMicrotaskQueue
for clarifying the difference from the async queue.

This is a preparation for fixing crbug.com/384516

BUG=384516
TEST=none
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/334253005

git-svn-id: svn://svn.chromium.org/blink/trunk@176434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

38544013

Include HTMLFrameOwnerElement.h in fewer headers · 47c7dc1f

philipj@opera.com authored Jun 18, 2014

Because HTMLFrameOwnerElement.h includes Document.h, the consequence is
mostly that Document.h includes need to be added.

Locally, this reduces the number of recompilation steps when touching
HTMLFrameOwnerElement.h from 579 to 117, and when touching Document.h
from 1214 to 1160.

There is a risk of performance regressions due to outlining
Frame::deprecatedLocalOwner().

Review URL: https://codereview.chromium.org/343593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

47c7dc1f

Clear absolute clip rects when transform changes · 9d45adc6

ajuma@chromium.org authored Jun 18, 2014

A layer's absolute clip rects are no longer valid when its
transform or the transform of an ancestor changes, since the
layer moves in absolute space. This CL clears the absolute
clip rects of a layer and its descendants when the layer's
transform changes.

BUG=246965

Review URL: https://codereview.chromium.org/334373002

git-svn-id: svn://svn.chromium.org/blink/trunk@176432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9d45adc6

DevTools: [Console] Separate height caching from willHide event · db97e386

lushnikov@chromium.org authored Jun 18, 2014

This patch introduces ViewportElement.cacheHeight() method which is
called by viewport control in appropriate time to let viewportElement
cache its height. Currently, ViewportElement.willHide() method is
responsible for height caching.

ViewportElement.cacheHeight() must not invalidate DOM. This is not
the case for willHide() method due to the console.table implementation
which removes inner DataGrid views. The bug happens because of the
"scroller securing" (see ViewportElement.refresh method) being done after
the sequence of willHide() calls.

BUG=385685
R=aandrey, pfeldman

Review URL: https://codereview.chromium.org/340483003

git-svn-id: svn://svn.chromium.org/blink/trunk@176431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

db97e386

Make iterator for Element's attributes more lightweight · 1f0032a3

ch.dumez@samsung.com authored Jun 18, 2014

Make iterator for Element's attributes more lightweight. Kill the
AttributeConstIterator class and make the iterator a simple pointer instead
(similarly to the Vector iterator). Also rename the AttributeIteratorAccessor
class to AttributeCollection as I think it looks better. This CL adds a typedef
so that the iterator is now used as AttributeCollection::const_iterator.

Also rename the attributesIterator() method to attributes() for simplicity.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/337753005

git-svn-id: svn://svn.chromium.org/blink/trunk@176430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1f0032a3

Oilpan: Ensure that types definitions are known for traced weak members. · e391df68

zerny@chromium.org authored Jun 18, 2014

R=sigbjornf@opera.com
BUG=

Review URL: https://codereview.chromium.org/334623006

git-svn-id: svn://svn.chromium.org/blink/trunk@176429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e391df68

Clean up snapshot command log. · 07f0f8cb

malch@chromium.org authored Jun 18, 2014

Review URL: https://codereview.chromium.org/320423004

git-svn-id: svn://svn.chromium.org/blink/trunk@176428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

07f0f8cb

Use stricter typing for NodeLists throughout the code base · 84e8811e

ch.dumez@samsung.com authored Jun 18, 2014

Use stricter typing for NodeLists throughout the code base. This makes it
clearer what exact type we are actually dealing with. This also allows the
compiler to de-virtualize some function calls with C++11.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/334713006

git-svn-id: svn://svn.chromium.org/blink/trunk@176427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

84e8811e

Remove unneeded checks in RenderTreeBuilder · 04985e7b

rob.buis@samsung.com authored Jun 18, 2014

Remove unneeded checks in RenderTreeBuilder, the same check is done in RenderTreeBuilder::shouldCreateRenderer.

Review URL: https://codereview.chromium.org/334263007

git-svn-id: svn://svn.chromium.org/blink/trunk@176426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

04985e7b

DevTools: add emulation toggle button and splash screen. · 1d087b96

pfeldman@chromium.org authored Jun 18, 2014

BUG=327641
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/347583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1d087b96

[DevTools] Remove unnecessary emulation checkboxes and simplify UX. · 168212a1

dgozman@chromium.org authored Jun 18, 2014

BUG=327641
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/340723005

git-svn-id: svn://svn.chromium.org/blink/trunk@176423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

168212a1