- 09 Apr, 2018 40 commits
-
-
Raymond Toy authored
When computing the tail time for a BiquadFilterNode, we forgot to take the absolute value of the largest root when computing the tail. For the test case from the bug, the root with the larger magnitude was negative. Also, the computation of the larger root was incorrect; fix that. And the comments for the real root case was incorrect and wrote "r" when it should have been "r1". Manually verified that the test file causes a DCHECK failure in a debug build without this CL. Bug: 829349 Test: webaudio/BiquadFilter/biquad-829349.html Change-Id: I028331670a61da22a6f42bb7213869dc4cacf8ad Reviewed-on: https://chromium-review.googlesource.com/998518 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549195}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' extensions`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Change-Id: I28ad1f38f58669b14b5dde345cf84249e79ad9b8 Reviewed-on: https://chromium-review.googlesource.com/1000427Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549194}
-
Mihai Sardarescu authored
This CL logs the histogram Signin.SigninStartedAccessPoint and Signin.SigninStartedAccessPoint.{NewAccount|NotDefault|WithDefault} when the user enables sync from a DICE promo. Note that it always logs histogram Signin.SigninStartedAccessPoint.NewAccount for the cases when the user enables sync from the settings promos as this requires additional piping of the default account information from the settings WebUI. Change-Id: If13d59e5ff49b38de216b58afca086025c513d62 Reviewed-on: https://chromium-review.googlesource.com/986141Reviewed-by:David Roger <droger@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#549193}
-
Theresa authored
Report events for UI peeked, UI opened, UI closed (via close button), suggestion downloaded and suggestion clicked to the ContextualSuggestionsBridge. BUG=822947 Change-Id: I913678193bb83ec46d29e9f9d58d89e771725a18 Reviewed-on: https://chromium-review.googlesource.com/998824 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549192}
-
John Z Wu authored
This is done in preparation for supporting different builds of the framework with different features included. The generated header will include only the headers whose features are supported. This will allow us to have only one umbrella header AND not expose any of the build flags in public headers. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I21d390942c195e872ed8e5b6e3949194ef6b71f3 Reviewed-on: https://chromium-review.googlesource.com/993695Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#549191}
-
Peter Beverloo authored
Change-Id: I1023c48c0215c96e5c8f759d7b06ba420a4b2d20 Reviewed-on: https://chromium-review.googlesource.com/1001898Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549190}
-
Bailey Berro authored
This CL adds a small, temporary workaround to a bug introduced by the migration of AsyncFileUtil to OnceCallback in crrev.com/r/985343 . I should have caught this during review. I will followup with a long-term solution. Change-Id: I16038b17c2eb67cf3efc8e3305bc0bbf5985d95f Reviewed-on: https://chromium-review.googlesource.com/996912Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#549189}
-
Robert Phillips authored
Skia is deprecating the GrBackendObject since it isn't typesafe. This sets the stage for removing it. This must land before the Skia CL: https://skia-review.googlesource.com/c/skia/+/119140 (Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS) to preserve Chrome's current behavior. Change-Id: I3f89a79f4e24fe18a9be16712f022ff2b6ed80ed Reviewed-on: https://chromium-review.googlesource.com/999796Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#549188}
-
Elad Alon authored
Error-specific messages are produced for: * Feature not available. * Bad parameters (max size too small, too big, etc.) * Bad state (already logging, unknown peer connection, etc.) A generic error is produced for: * Incognito mode. * File system errors. * Too many pending logs. * Too many active logs. The purpose of using generic errors, is to not expose sensitive information, neither explicitly (specific-error) nor implicitly, which would be the case if, for example, only incognito mode could produce the generic error. Bug: 775415, 827191 Change-Id: I10c12d1a0fc7ad4476511fc5d6383c1cd5e9d512 Reviewed-on: https://chromium-review.googlesource.com/986575 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549187}
-
Eugene But authored
s/Download sucessfully finished/Download finished Bug: 821188 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b5bb837ed2c228b8b173010489d0db0b9251516 Reviewed-on: https://chromium-review.googlesource.com/1000100Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549186}
-
Ian Vollick authored
This CL cuts unnecessary work from our tree walks where we can. Bug: 828684,828688,828687 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3706deec5adeae6b4c4d186d45187854e79a840f Reviewed-on: https://chromium-review.googlesource.com/1000430Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549185}
-
Thomas Tangl authored
This CL changes the Dice accounts submenu positioning on Mac to be right aligned, as is the case on Windows and Linux. Screenshot before: https://drive.google.com/file/d/15M0bFasjm_TrRJkSPZUwzXj6X8N77I2e/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1TLyEvugA1yzyYekp3F4e7aa_hFtErtBv/view?usp=sharing Bug: 813805 Change-Id: I9bfee4eacae496a26bc304f4b0ef5f9b87c4d25f Reviewed-on: https://chromium-review.googlesource.com/999514Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#549184}
-
Yuichiro Hanada authored
ARC windows were the only one kind of clients, but it changed. We have to check an application id to distinguish ARC windows and other exo windows. Bug: 829383 Test: Manual. Confirm that input is still working on Linux apps after opening Android apps with a text input. Change-Id: Ib58a6e5b41cdd2a3c68d76b3baacd93f11602f70 Reviewed-on: https://chromium-review.googlesource.com/1001086 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:David Reveman <reveman@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#549183}
-
Koji Ishii authored
Following bot results are included. 4613 4616 4628 4630 4636 4639 4640 4645 4646 4647 4651 4652 4653 4654 4655 4656 4660 4661 4662 4668 19 lines were removed and 5 lines were deflaked by consecutive results since 4573. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0f9bf7aa4c11fb799c530bb51e0981bd166a1329 Reviewed-on: https://chromium-review.googlesource.com/999552 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549182}
-
Sylvain Defresne authored
The build.ninja file generated by ninja has changed and now include a "ninja_required_version" statement. To keep the rule to generate the build.ninja file, all the line up to the third blank line should be kept (this is what "gn clean" does). Bug: 830627 Change-Id: I493cc39f484c6da8a0784d9cf2b45337cb4672d3 Reviewed-on: https://chromium-review.googlesource.com/1001902Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549181}
-
Roger Tawa authored
Add missing information during token enrollment flow (OS platform and version) and fix a crash following the first policy fectch after the registration. Bug: 812641 Change-Id: I29a98dc5bdabaf61b0373595a28ce5576433784d Reviewed-on: https://chromium-review.googlesource.com/998417 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549180}
-
Mina Almasry authored
...and fix issues uncovered by the unittests. BUG= internal 73746352 TEST=cast_av_sync_backend_unittests, manual on device. Change-Id: Ib499983ea2dc99914a23d844d6c9a38926b6d725 Reviewed-on: https://chromium-review.googlesource.com/989334Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#549179}
-
Samuel Huang authored
(Committing on behalf of etiennep@). This CL adds DEX References read / write for 11 basic types. Details: - Add InstructionParser to visit DEX instructions in the insns member of a CodeItem, taking care to skip non-instruction "payloads". - Add InstructionReferenceReader to visit CodeItem References found in |[lo, hi)|, using provided callbacks to apply type filters and extract targets. - Add ItemReferenceReader to visit fixed-sized items to extract Referenes from a "member variable of interest", using a callback to extract targets. - DisassemblerDex: Add MakeRead*() and MakeWrite*() to return a visitor to read / write supported DEX References. - Add DEX unit test to audit the error-prone look-up table from DisassemblerDex::MakeReferenceGroups(). Change-Id: Ice12a867aab4fdcb4a152bb1946ea7515ad426ef Reviewed-on: https://chromium-review.googlesource.com/994066Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549178}
-
Alexander Hendrich authored
Corrected the captions that use an 's' verb to improve consistency. Bug: b:74368460 Change-Id: I0234ae37446b0b2b5a69caf6f2146a08879d63e6 Reviewed-on: https://chromium-review.googlesource.com/1001580 Commit-Queue: Alexander Hendrich <hendrich@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#549177}
-
Francois Doray authored
The DevTools toolbox holds a placeholder for the inspected WebContents. When the placeholder is resized, a frame is requested. The inspected WebContents is resized when the frame is rendered. This CL forces rendering of the toolbox at all times (even when occluded), to make sure that a frame can be rendered even when the inspected WebContents fully covers the toolbox. Bug: 828307 Change-Id: Id966ec985b97b3a0978f73f38929dc2b51cbd1c3 Reviewed-on: https://chromium-review.googlesource.com/996478 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549176}
-
Hiroki Nakagawa authored
This CL adds FrameOrWorkerGlobalScopeScheduler that is the base class of FrameScheduler and WorkerGlobalScopeScheduler. A motivation of this change is to abstract those schedulers for ExecutionContext-agnostic implementation. As an example, this CL changes access to the scheduler in WebSocket. Bug: 825740 Change-Id: Ie03869d35b502082e172672dad451720c31a937a Reviewed-on: https://chromium-review.googlesource.com/994552 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549175}
-
Thomas Tangl authored
When sync is complete, the title in the user menu is now "Syncing to". Bug: 828551 Change-Id: I51697fd752c0f8eb28c86be0ad56d6e5001585c4 Reviewed-on: https://chromium-review.googlesource.com/1000734Reviewed-by:
-
Calder Kitagawa authored
ClusterFuzz found an issue with the DCHECK for "hi <= image.size()" in rel32_utils.cc. This turned out to be a lack of undestanding on my part that the image gets shruken to the understood region on parsing in Win32 PE disassembler. As a result, we should be using this shruken image's size rather than the original image size when invoking the family of MakeRead functions. Bug: 830173 Change-Id: I957990ed0dacb38db4ce85df10a1ffe988e8cc2f Reviewed-on: https://chromium-review.googlesource.com/1002877 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
-
Philip Jägenstedt authored
It was disabled to unblock wpt-importer, and the test change has now been imported and the test should be passing. Bug: 830270 Change-Id: I5049adc3a5225b3feb7e934bcceeb416dd48ea4b Reviewed-on: https://chromium-review.googlesource.com/1002813Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549172}
-
Veranika Liaukevich authored
Used reboot prompt method is recorded in UMA, but because immediately after that Chrome initiates a machine reboot, the data is not always successfully recorded and uploaded. This CL forwards prompt method information to the cleaner so that this information would be available to it too. Bug: 770749 Change-Id: Iec3e4fd902ab20b0c1cf477b852153e3de5eaeb5 Reviewed-on: https://chromium-review.googlesource.com/986283Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#549171}
-
Jamie Madill authored
This reverts commit 19c9f7ae. Reason for revert: Causing multiple failures on the GPU.FYI bots. Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28NVIDIA%29/1259 https://chromium-swarm.appspot.com/task?id=3cc2bb505cb1c410&refresh=10&show_raw=1 Some failing stack trace: Thread 0 (crashed) 0 chrome!Elapsed [time.h : 393 + 0x0] rax = 0x0000000146fd75b9 rdx = 0x00000000000f0079 rcx = 0x9996dd6b71d9df00 rbx = 0x0000000000000000 rsi = 0x0000000000000000 rdi = 0x0000000146fd75b9 rbp = 0x00007ffc6dc15140 rsp = 0x00007ffc6dc15130 r8 = 0x0000000000000001 r9 = 0x000000000000156d r10 = 0x0000000000000000 r11 = 0x000000003a99d955 r12 = 0x00001475757e22c0 r13 = 0x00007f0a469dec79 r14 = 0x000000000000061a r15 = 0x00001475757e22c8 rip = 0x00007f0a4b5ae05e Found by: given as instruction pointer in context 1 chrome!OnSessionEnded [desktop_profile_session_durations_service.cc : 82 + 0x5] rbx = 0x00007ffc6dc152d0 rbp = 0x00007ffc6dc152a0 rsp = 0x00007ffc6dc15150 r12 = 0x00001475757e22c0 r13 = 0x00007f0a469dec79 r14 = 0x000000000000061a r15 = 0x00001475757e22c8 rip = 0x00007f0a4b416c6c Found by: call frame info 2 chrome!EndSession [desktop_session_duration_tracker.cc : 154 + 0x9] rbx = 0x00007ffc6dc152d0 rbp = 0x00007ffc6dc15450 rsp = 0x00007ffc6dc152b0 r12 = 0x00007ffc6dc152f8 r13 = 0x00007f0a469dec79 r14 = 0x00007ffc6dc152b0 r15 = 0x00001475757e22c8 rip = 0x00007f0a4b417ce5 Found by: call frame info 3 chrome!OnTimerFired [desktop_session_duration_tracker.cc : 127 + 0x8] rbx = 0x0000147575461c60 rbp = 0x00007ffc6dc155a0 rsp = 0x00007ffc6dc15460 r12 = 0x0000000000000000 r13 = 0x00007ffc6dc15fa0 r14 = 0x00001475761101f0 r15 = 0x00007f0a4b4183b0 rip = 0x00007f0a4b418473 Found by: call frame info Original change's description: > Add tracker for signedin/syncing browsing activity > > This tracker reports the time that the user spent actively using chrome, > with their associated sync and sign-in state. > > Definition of syncing: Having opted in to sync, and sync not being in an > "error" state because of a content-area sign-out. > Definition of signed in: The user is signed in to the content area. > > These metrics will let us track: > - How long on average users spend being signed in to the content area > - How long users on average spend syncing > - Which proportion of a user's time is being spent signed in > - Which proportion of a user's time is being spent syncing > > Bug: 820188 > Change-Id: I7c5c965d8ba0debf970158f77ae5b69675bdee27 > Reviewed-on: https://chromium-review.googlesource.com/960005 > Commit-Queue: Florian Uunk <feuunk@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549136} TBR=sky@chromium.org,droger@chromium.org,asvitkine@chromium.org,sdefresne@chromium.org,treib@chromium.org,bcwhite@chromium.org,feuunk@chromium.org Change-Id: If508d0e20b6813bb70933874ff699ada98a441d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820188 Reviewed-on: https://chromium-review.googlesource.com/1002854Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#549170}
-
Vasilii Sukhanov authored
TBR=hbos@chromium.org Bug: 829401 Change-Id: I112346b87535c6f78303da8e7b7ece905f4d6b0f Reviewed-on: https://chromium-review.googlesource.com/1001900Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549169}
-
Christian Dullweber authored
The change to allow non-secure cookies if https is allowed from https://crrev.com/c/926369/5/components/content_settings/core/browser/cookie_settings.cc still needs to be applied to properly match cookies for www.example.com against a rule like https://[*.]example.com. Bug: 775080 Change-Id: I50f5b28663e816016e0d047b5dbceb16352667aa Reviewed-on: https://chromium-review.googlesource.com/1002554Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#549168}
-
Fredrik Söderquist authored
Change-Id: I07129786b29acb7eea5fd1946e9301a370472125 Reviewed-on: https://chromium-review.googlesource.com/1002556Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#549167}
-
Eric Seckler authored
Testing basic canvas + svg support. Bug: 787197 Change-Id: I854a841da46123aafc4828c3de3ff2f10c819859 Reviewed-on: https://chromium-review.googlesource.com/985986 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#549166}
-
Guido Urdaneta authored
Thanks to recent changes in audio device enumerations, it is possible that USB audio devices report their vid/pid in enumeration results similarly to video input devices. This CL extends the heuristic to guess associations between video and audio devices by looking at coincidences in the VID/PID, if available. Also, this CL excludes the default and communications device entries from the heuristics since they could be incorrectly detected as duplicates. Bug: 627793 Change-Id: I870a033c1dff358025c5da7332ac90004f1d7f5a Reviewed-on: https://chromium-review.googlesource.com/992292 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#549165}
-
Gauthier Ambard authored
This CL fixes the callback of thedismissal of the popup menu. It was failing because the DCHECK assertion was wrong, as the presenter is reset at the begining of the dismissal. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb6e487c111521220c63e03738c69da24962bce1 Reviewed-on: https://chromium-review.googlesource.com/1000775Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549164}
-
Vasilii Sukhanov authored
TBR=junov@chromium.org Bug: 816045 Change-Id: Ie637acc5cdc50aab55882969b1489c0965f9eac3 Reviewed-on: https://chromium-review.googlesource.com/1001895Reviewed-by:
-
Lutz Justen authored
The destructor calls g_browser_process->IsShuttingDown(), but that's not hit in certain situations (see bug). Adding an additional check for browser_shutdown::IsTryingToQuit() solves this (see bug comment #9). BUG=chromium:823738 TEST=Enrolled with Chromad domain, which triggers a restart after enrollment, and it didn't crash. Change-Id: Ifc4430012da40ec729d8337a0c7b3be2f44eafb2 Reviewed-on: https://chromium-review.googlesource.com/980852Reviewed-by:Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#549162}
-
Mark Cogan authored
This CL makes the GridConsumer protocol not depend on the state of the items list that it reports changes for. To do this, it only uses list indexes as parameters for destinations (of insertions or moves). In all other cases, the mutations specified by the protocol are expressed in terms of the IDs of the items that are changed, including the selected item. GridViewController now keeps track of the ID of the selected item, and determines (finds) its index dynamically. Bug: 986379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id2465c9740e505be659126068bc2c0e0cbf8a8d3 Reviewed-on: https://chromium-review.googlesource.com/999712 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
It sometimes crashed before but it seems it's no longer flaky. I ran the tests under external/wpt/service-workers/service-worker 10 times each but I couldn't observe crashes (with dcheck_always_on = true). $ run-webkit-tests --release --iterations=10 --additional-driver-flag=--enable-features=NetworkService external/wpt/service-workers/service-worker/ Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I019c942b6caf98223205b9b66cea0ba926838a4e Reviewed-on: https://chromium-review.googlesource.com/1002792Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549160}
-
Oskar Sundbom authored
Before a stream has been added to an <audio> tag, its gain is set to 1.0. Once a stream gets attached to an <audio> tag, its volume is set to zero until the tag starts playing. Since remote streams are mixed in WebRTC before being passed on to Chrome, streams that haven't been added to a tag can still be audible, if only one other stream has. This CL attempts to fix this by setting the initial gain of WebRTC remote streams to 0. Bug: chromium:810848 Change-Id: I08b0acbd78d3f0bd06adbb70f62d42b66146a9f5 Reviewed-on: https://chromium-review.googlesource.com/925266 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a new flag for the new location bar. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf34e9fcfb05d01ee26a213428633d96d4bb3cbd Reviewed-on: https://chromium-review.googlesource.com/1000454Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549158}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80bcf1b0..f0600b8c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6af49b665a91b45db5dd6e6c2afd1b99a1e17782 Reviewed-on: https://chromium-review.googlesource.com/1001700Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549157}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. As the first step, this CL renames kUnspecedLoading to kInternalLoading simply as the current kUnspecedLoading usages are related to loading. Bug: 830489 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I674ca3b5842502a376731de921629f6f79dcd225 Reviewed-on: https://chromium-review.googlesource.com/1002719Reviewed-by:
-
