- 22 Sep, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff52c73e..eb373a50 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a9ca78044b2e5367b61e547aa09a1977c2ab881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424065Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809422}
-
Dave Tapuska authored
Use the WidgetBase implementations instead of going via the WebWidgetClient. BUG=1097816 Change-Id: Ib08b5748806fe3862ac291d354043326d3172282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419129Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809421}
-
Owen Min authored
In the past, Conflict(409) are used when 1) There are multiple device records for one device id. 2) Database concurrent update exception. Few months ago, the enterprise server began to return the Too Many Request(429) for the second situation above to allow the client side to setup different retry strategies. Policy Fetch and CBCM reporting will retry on 429 but not 409. Chrome OS demo mode will show the error message and retry. Chrome OS enrollment will record a different UMA value. Bug: 1108817 Skip-Translation-Screenshots-Check: True Change-Id: I3b302ab03e16a41a30103f809c1b51813647dd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419119 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809420}
-
Max Curran authored
Previously when navigating through a link from a page that was translated would case the new page to be translated automatically without any UI being shown. Now the normal translate UI will be shown, so that the user knows that the page is being translated. Bug: 1057731 Change-Id: I777955d2b755c212565ed374641eb819e636bd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422816Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#809419}
-
David Roger authored
This CL enables the profile switch interception, and adds performance histograms. It supports switching to an existing profile, whether it is already loaded or not. It also adds an histogram to measure the performance of the session startup (which in mainly the time to inject the account on the web). Screenshot: https://screenshot.googleplex.com/95FNoDH6QqSkCcV Note: strings are not finalized and will be updated in a follow-up CL. Bug: 1076880 Change-Id: Ia3ce4a816dc328d032d7660fac199a7a36338429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416349Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809418}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 91 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-21. TBR=chromium-metrics-reviews@google.com Change-Id: I3eb8a8b903a4d423a43ffd0216aefe5eaf86a50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424484Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#809417}
-
Roman Arora authored
Bug: 1099917 Change-Id: I33b7700dc218308af87373722afe7c7639f5cb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417074 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809416}
-
Mirko Bonadei authored
Chromium iOS recipes seem to be based on generic recipes like for example [1] nowadays. This is a follow-up of https://chromium-review.googlesource.com/c/chromium/tools/build/+/2418820. [1] - https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipes/chromium_trybot.py Bug: webrtc:11604 Change-Id: I3abc8b53f79ff5ca27fc9f2b965f611e396eeaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420609Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809415}
-
Mitsuru Oshima authored
Bug: 1123889 Test: manual. see bug for repro step. Change-Id: I3f99b00ccb6478a1bdc1dc871827a48e8560911f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422866Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#809414}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f82884d032c..f46b7d67f8f2 2020-09-22 cpinnamaneni@microsoft.com Network sort requests on type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130839 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic0695c0ce4cf998d3d58d8b12492c6f0af92099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424564Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809413}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 2 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-21. TBR=chromium-metrics-reviews@google.com Change-Id: Iacab9b2d240b398566ad36946caac6473e9b9cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423171Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009220800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/u9IxXetAD5rBCs-E3qW49qhhcWCVkh51yLFjLWQfwOIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/165872577,b/168547738 Tbr: media-app@grotations.appspotmail.com Change-Id: I72b1d5a7241225e24308c8663c6332eebb3d5c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809411}
-
Haiyang Pan authored
According the query https://console.cloud.google.com/bigquery?sq=575346572923:aac7a4bc484d424f93a1f65b7000c6cb, unit_tests has the second highest failure count. Also move the chrome_public_test_apk to MM-x86-rel-non-cq Bug: 997376, 1127110 Change-Id: I1ca4a1250233fe0cf1d0615f3580ccc10ba01ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422710 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#809410}
-
Alexandre Courbot authored
V4L2Request::ApplyCtrls(), which is called on the next line, will do this for us. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I34196a4d65c03a0bec7da87854d226b8905b3027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421992 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809409}
-
Adlai Holler authored
Change-Id: Ic258eb1562dc776805d1530c480493b0739ffba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423062 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#809408}
-
Xida Chen authored
We are deprecating the Universal throughput tracker. The first CL has been landed here: https://chromium-review.googlesource.com/c/chromium/src/+/2392768 Both UMA and UKM xml files has been updated where the related metrics are marked as deprecated. But the UKM reporting code isn't removed yet. This CL removed the code. It is basically a manual revert of the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2112953 Bug: 1128993 Change-Id: I2bb040fb4a0edf31aea3b304dbd60c91c95acae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418804Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809407}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009220800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/mkV9yCGYkfTE2DLD-MHNfrrbpo8vMhrcvgRQwtJGUjMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165375429 Tbr: help-app@grotations.appspotmail.com Change-Id: I39db595f59d99ebdabca1fe9a693e5343486360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424406Reviewed-by:
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: Ibc40863e1cfe31616b18c304358274ba89ba9bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420919Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#809405}
-
Alexandre Courbot authored
We were using SetFormat() when we wanted to just test the availability of a given format on a device. This is a bit misleading for the reader. Implement and use TryFormat(), which properly uses the TRY_FORMAT ioctl, and use it where relevant. BUG=None TEST=video.DecodeAccel.h264 passed on Trogdor Change-Id: I223a2911451bae753e8560180ccdaa5a3502a1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422103 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77960d9addc8..a9be76de8b43 2020-09-22 johnstiles@google.com Reduce the number of inliner temporaries by swizzling. 2020-09-22 johnstiles@google.com Calculate texture clamping X/Y coordinates in parallel. 2020-09-22 fmalita@chromium.org Fix skia_use_ffmpeg builds 2020-09-22 brianosman@google.com Change default of fBuiltinFMASupport back to false 2020-09-22 michaelludwig@google.com Use analytic coverage FPs with MSAA 2020-09-22 brianosman@google.com Remove RTAdjust plumbing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I67e2fe58ef1d8f1c463aa289b3177bd8b4c6630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424410Reviewed-by:
-
Andrew Grieve authored
Removes direct usage (StrictModeContext left for follow-up) These suppressions are safe to remove now that StrictMode handling in chrome has been switched to a filter-based approach. Bug: 1038384 Change-Id: I59ee33bd1e34249c6be7973e5d759007ec0b2533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410537 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809402}
-
Tommy Li authored
Adds all three shown header variations, as well as the default-hidden header variation, for a total of 4. I'm doing this because Android users, and our off-corp tester team cannot use the Google Experimental Web interface. Bug: 1106096 Change-Id: Ie87ea1c36afc3983dc8221d5ef7c695a54e6c60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422473Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809401}
-
Maria Kazinova authored
Created a feature and a flag to experiment with using numeric renderer IDs instead of string form and field identifiers in Autofill filling logic. Bug: 1075444, 1131038 Change-Id: I8a3110d3271028d5a347dbea21c6031274955e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418331 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809400}
-
Leonid Baraz authored
The server is free to process Records in arbitrary order, and timestamp will allow to rearrange them according to the order they were enqueued by the Client device. Change-Id: I3df98f61b4dfa67933eef322dc2959dd28c3d17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422721 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#809399}
-
Rob Buis authored
Add helper methods to NGLayoutInputNode to test whether the input node is MathML and to get the DOM node for the wrapped layout object. Bug: 6606 Change-Id: I4b12e81b2c044e9bd98479c1ab0cf8f0c7cea898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424183 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac231dd664d0..899ea244a8db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lgrey@google.com,rsorokin@google.com Change-Id: If311234950ce6fa90f4f711d681c8cbc21b736aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423978Reviewed-by:
-
Michael Thiessen authored
Migrates NavigationHandle to use GURL internally and adds getUrlString for callsites that still need URLs to be a string (to be fixed in followups). Some unit tests needed to be moved to Instrumentation tests, one requiring a change to CriteriaHelper to allow checking for a condition after every task. QualityEnforcerUnitTest was too difficult to migrate to Instrumentation tests, so it now uses JUnitTestGURLs to use GURL in junit tests. Bug: 783819 Change-Id: I1283d5d7d1946e666e964f8d24aeaf0352eb8805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419140Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#809396}
-
Victor Hugo Vianna Silva authored
Since the CallbackHelper was removed in crrev.com/c/2414194, there's no need for throwing TimeoutExcpetion in tests anymore. Bug: None Change-Id: I6eb4fea62e642840befb3461cb184a13e5198cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424308 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#809395}
-
ckitagawa authored
paint_preview::BuildResponse() shows up a fair amount in stack scans. Often times these are OOMs I want to try to understand if this is a material issue or if identical code folding is mangling BuildResponse with other symbols. This change does a few things 1) Try to reduce memory usage in FinishRecording() to reduce OOM risk. Mainly by freeing/reseting memory expensive objects earlier. 2) Log when paint_preview::BuildResponse() is legitimately called. 3) General refactoring/cleanup. I hope to revert 2 once we know if the issue is actually paint_preview::BuildResponse() at fault. Change-Id: I14d99f1fb733565f984fc93fc131ee448fd642f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423408Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#809394}
-
Raymond Toy authored
Basically add a mutex to protect access to allow_pulling_audio_graph_. The main thread waits until it has the lock before setting this. This prevents the main thread from deleting things while the audio thread is pulling on the graph. A try lock is used so as not to block the audio thread if it can't get lock. This is applied to both real time and offline contexts which required moving the original real-time-only implementation to audio_destination_node so we can use the same methods for the offline context. Tested the repro case from 1125635, and the issue does not reproduce. We're assuming this will fix 1115901, but I've not been able to reproduce that locally. Bug: 1125635, 1115901 Change-Id: I1037d8c44225c6dcc8fe906c29a5a86740a15e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410743Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809393}
-
Alex Newcomer authored
Just add basic tests. This will eventually contain histogram tests as well. Bug: 1130770 Change-Id: I160ef8e520f75a04d9d4c280f3c6b8b89504ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422267Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809392}
-
Gang Wu authored
Bug: 1120273 Change-Id: I599b51cab1d6b61c47f98cb85c4c935adcf58d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423354Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809391}
-
Polina Bondarenko authored
Add parsing/syncing to local state arc.snapshot pref of snapshot related info. Add blocked UI mode Chrome start up along with clearing outdated snapshots flow. Currently, ArcDataSnapshotdManager functionality is disabled for testing. BUG=b:161221001 TEST=components_unittests Change-Id: I6ccfe44c3b85a6dc864914609fa41c071e81e4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385396 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#809390}
-
Mohamed Amir Yosef authored
As per the attached bug, here is the logic for changing the header image - The illustration should change when the user switches between "Save to device" and "Save to account". - In the Update bubble, the illustration should change based on where the update will go. - If the update will go to both locations, use the "account" image. Screencast: Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ Bug: 1115936 Change-Id: Iaa3256fa1ff6dde3019da6a6da96940e577697b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421674 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809389}
-
Sinan Sahin authored
This CL refactors ChromeContextMenuPopulator#buildContextMenu to return a ModelList for each group instead of a list of ContextMenuItem structures. This way, the context menu coordinator will not have to convert the items into MVC models. Bug: 971513 Change-Id: Ic99dccde290e617076116df1e16732f147f84cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419010Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Austin Eng authored
This reverts commit 4ca48383. Reason for revert: Failing on Win10 FYI x64 Exp Release (Intel HD 630). See crbug.com/1131041 Original change's description: > Re-enable DirectComposition tests for HD630 > > Unsuppress the DirectComposition info_collection_test and > trace_test for HD630(0x5912). > > Bug: 1079393 > Change-Id: I6cdd7c146c69b7154dde27b10e9b18b5f989950a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413291 > Commit-Queue: Jie A Chen <jie.a.chen@intel.com> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809210} TBR=zmo@chromium.org,jie.a.chen@intel.com Change-Id: If6c2335d318581573da583c038feda89ef575960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424526Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#809387}
-
Patrick Noland authored
The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves. Bug: 1129783 Change-Id: Ia482a109576539d54f171950468e490972e72bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418981Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#809386}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I3c0c19c021b7b3aadfafbabe486aeee4cbda6dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423977Reviewed-by:
-
Patrick Monette authored
StartInspectingModule() was being called regardless of the state of the queue in the event of a connection error with the UtilWin service. This was wrong because the connection error can happen even if the ModuleInspector is idle. Bug: 1100982 Change-Id: I715a9014e54e143d37ed94a07925fd70d3caf456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422259Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#809384}
-
dpapad authored
Bug: None Change-Id: I825907f08eb3aed09e95a551338d9bbb3141ec7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423356 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809383}
-
