- 22 Jun, 2018 40 commits
-
-
Khushal authored
The JPEGDecoder ceils when rounding floats for mip level sizes while the cc code floors. This results in 1 pixel differences in the scaled sizes when using decode to scale. Avoid this by switching the cc mip size calculations to match the decoder. R=ericrk@chromium.org, chrishtr@chromium.org Bug: 761565,558070 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07069a4eff582ffbb621388ccae32b18aedebd3a Reviewed-on: https://chromium-review.googlesource.com/1107049 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569626}
-
Rune Lillesveen authored
SetPseudoElement created a PseudoElementData even if the input was a nullptr. Early out for null input to avoid unnecessary allocation. Bug: 836126 Change-Id: If21c9ff8db2f20427b32f124ea0b129ebbebfe80 Reviewed-on: https://chromium-review.googlesource.com/1109962Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569625}
-
Friedrich Horschig authored
This CL renders the options provided by the native backend. To do that, it introduces new |Item.Type|s. Bug: 853747 Change-Id: I6fcd833a1674d55da4e4e44d9517e3aff35da823 Reviewed-on: https://chromium-review.googlesource.com/1110217 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569624}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I31665bf71e42f703b38dad45da0891bd81ac669c Reviewed-on: https://chromium-review.googlesource.com/1111475Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569623}
-
Kyle Milka authored
When a background tile is selected apply the proper border and check mark. Then remove this stlying when the tile is de-selected. Bug: 850675 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib1b05121bc6beaae5af6591e3963d59584a1f2af Reviewed-on: https://chromium-review.googlesource.com/1110352Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569622}
-
Friedrich Horschig authored
Adds the test config for cl/201525996. Change-Id: Iddfbfb94ff898dab2b3860c3dd33ebdee044ac3d Reviewed-on: https://chromium-review.googlesource.com/1110133Reviewed-by:
-
Jérôme Lebel authored
Google services settings will be released with M70. There is no use to test it without RefreshUI flag. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib6a39f4ecae6c79f5c0729d8f347eb457d85da94 Reviewed-on: https://chromium-review.googlesource.com/1111612 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569620}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3cc2ab66d3d..a327030ca50b git log c3cc2ab66d3d..a327030ca50b --date=short --no-merges --format='%ad %ae %s' 2018-06-22 art-snake@yandex-team.ru Rework of Fixing metadata not read from linearized file. Created with: gclient setdep -r src/third_party/pdfium@a327030ca50b The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0217b33c9f8dbd9aa6481ee2efbd809ec0fbb072 Reviewed-on: https://chromium-review.googlesource.com/1111918Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569619}
-
Gauthier Ambard authored
This CL disables the FullscreenTestCase.testShowHeaderOnErrorPage test which is constently failing on iOS 10 devices. Bug: 855368 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I24b5e8cadb05505974af0e38e8e850593d03e386 Reviewed-on: https://chromium-review.googlesource.com/1111712 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3cacf69b56aa..8a4c49fb794e git log 3cacf69b56aa..8a4c49fb794e --date=short --no-merges --format='%ad %ae %s' 2018-06-22 jmadill@chromium.org Vulkan: Refactor DynamicDescriptorPool. Created with: gclient setdep -r src/third_party/angle@8a4c49fb794e The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9f63363cae198df2873e39c03dca20b47e3b32cf Reviewed-on: https://chromium-review.googlesource.com/1111919Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569617}
-
Marc Treib authored
All it did was setting some sticky state and then calling TryStart(). So let's at least make that explicit by having clients call a state setter plus TryStart(). This also lets us rename the "setup_in_progress" param for TryStart() to "force_immediate" which makes a lot more sense. Bug: 854978 Change-Id: Ifd72c94847582626fa60b4a973fd93ac9691fc56 Reviewed-on: https://chromium-review.googlesource.com/1111715 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569616}
-
Daniel Nicoara authored
BUG=855580 TEST=Compiled and ran ozone_unittests with msan Change-Id: I9f2d42b98210f9edca33d6d5defcae0ed29f1a07 Reviewed-on: https://chromium-review.googlesource.com/1111977Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#569615}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/600abcfe..f237b823 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I84ae42730333da450e70cd248ce53396fcbcfcdf Reviewed-on: https://chromium-review.googlesource.com/1111897Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569614}
-
Mounir Lamouri authored
This should enforce one Picture-in-Picture window per Chrome instance. It should also solve a few edge cases where a WebContents was closed and the associated PictureInPictureWindowController was still around and later used. Note that we may be able to better architecture this. It is a naive design that simply move the code out of browser.cc. Bug: 851775 Change-Id: Ib26ffadd1035f58ffa9bcf475070a469361c9e6e Reviewed-on: https://chromium-review.googlesource.com/1107304 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569613}
-
Gauthier Ambard authored
When opening a new tab in foreground, the tab should relayout its subviews after resetting the frame to have them correctly positioned. Bug: 852106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f886f68a55a28429d1ce39a908745acd24cbc12 Reviewed-on: https://chromium-review.googlesource.com/1105769 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569612}
-
Aga Wronska authored
to report child user status. ConsumerStatusReportingService is a KeyedService created for child users only. Moving StatusUploader from UserCloudPolicyManagerChromeOS helps to enforce that consumer status reports are only uploaded for child user. Additionally it simplifies DeviceStatusCollector by passing an already initialized pref service. Test: Run DeviceStatusCollectorTest, ConsumerDeviceCollectorTest, StatusUploaderTest, UserCloudPolicyManagerChromeOSTest. Manually add child account to device (managed/consumer) and observe status upload after ~60s. Manually sign in as child user to device (managed/consumer) and observe status upload after ~60s. Manually sign in as regular user and observe that status is not uploaded. Observe that enterprise reporting on managed device is not disrupted. Change-Id: Ib0ac071f96416e4c2a9ba30ce0c32a782b351bd1 Reviewed-on: https://chromium-review.googlesource.com/1089462 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#569611}
-
Manuel Rego Casasnovas authored
The spec is very clear about this (https://drafts.csswg.org/css-contain/#containment-size): "Replaced elements must be treated as having an intrinsic width and height of 0." The patch modifies LayoutReplaced::ComputeIntrinsicSizingInfo() so that it returns zero for elements with "contain: size". BUG=853441 TEST=external/wpt/css/css-contain/contain-size-013.html Change-Id: I91490b120a110be20a91d564da4fdc3d9a11b70a Reviewed-on: https://chromium-review.googlesource.com/1110819Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#569610}
-
Peter E Conn authored
Bug: 813100 Change-Id: Ia5e544af26ec221f026c40ed342ab41cc3c3d959 Reviewed-on: https://chromium-review.googlesource.com/1111855Reviewed-by:
-
Ioana Pandele authored
This is a temporary wiring that is no longer needed once crrev.com/c/1097478 lands. Bug: 835234 Change-Id: I0acc8816724dbc523755327f46515fbdcba4fde6 Reviewed-on: https://chromium-review.googlesource.com/1110227Reviewed-by:
-
Mikhail Montsev authored
Use ui::test::ScopedEventTestTickClock instead of SetEventTickClockForTesting. EventsXTest did not call SetEventTickClockForTesting(nullptr) and, eventually, GestureProviderAuraTest suffered from that. It's better to use RAII idiom in this case because RAII makes impossible to forget to call SetEventTickClockForTesting(nullptr). Change-Id: I80b079ef37a77618d76f14912f7d6c40d39ab66b Reviewed-on: https://chromium-review.googlesource.com/1030108 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569607}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7999d926809f..c5a26a769e69 git log 7999d926809f..c5a26a769e69 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 hferreiro@igalia.com [win-cross] Support using a zip file for the Windows SDK Created with: gclient setdep -r src/third_party/depot_tools@c5a26a769e69 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852347 TBR=agable@chromium.org Change-Id: I3801e60259035c8ffd595364ae65795e7f371be3 Reviewed-on: https://chromium-review.googlesource.com/1111917Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569606}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 888b6b53. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19958 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=robertma No-Export: true Change-Id: I1f8599db536df6562f936ec3162bdb059747080c Reviewed-on: https://chromium-review.googlesource.com/1111898 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569605}
-
Peter Beverloo authored
Right now they're additive, which is a bug. Bug: 800152 Change-Id: Ib1312dd921e18c17e872d4dea2c5962604cfecca Reviewed-on: https://chromium-review.googlesource.com/1110231 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#569604}
-
Adithya Srinivasan authored
Removes content/renderer/speech_recognition_dispatcher and moves functionality into blink. Also removes layering in blink/public/web that is now unneeded. Design doc is linked in the bug below (Comment #15). Bug: 781655 Change-Id: Ie777279386b08b2fd897bb5cefa1855733f19cb3 Reviewed-on: https://chromium-review.googlesource.com/1081092 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#569603}
-
Matt Falkenhagen authored
This UMA can be misleading because it also is recorded for controllers without fetch event handlers. These service workers don't run on page load and don't intercept requests, so it's probably best to not count them. But we are not currently using the UMA, and it's under "Experimental" so we can remove it now and add back an improved metric if the need arises. Bug: 854851 Change-Id: I6f40b573aa950c44a761f8c7ceebf3b7d8ded665 Reviewed-on: https://chromium-review.googlesource.com/1111751Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is for faster link time on compile and isolate tests step of linux-chromeos-rel builder Link time comparison of some binaries between this tryjob, https://ci.chromium.org/b/8943035780027076400 [1] and https://ci.chromium.org/b/8943036433296462960 [2] is like below. browser_tests: 54.076s -> 31.285s unit_tests: 1m49.235s -> 34.616s components_unittests: 1m36.197s -> 29.543s isolate tests step time is reduced from 6 mins 12 secs to 2 mins 10 secs. [1] https://chromium-build-stats.appspot.com/ninja_log/2018/06/22/swarm1444-c4/ninja_log.swarm1444-c4.chrome-bot.20180622-013034.23287.gz/table?dedup=true [2] https://chromium-build-stats.appspot.com/ninja_log/2018/06/22/swarm1476-c4/ninja_log.swarm1476-c4.chrome-bot.20180622-005824.18926.gz/table?dedup=true Bug: 794423 Change-Id: I09981de84d2ab3cc9a7a63a599f2284781f71368 Reviewed-on: https://chromium-review.googlesource.com/1111757 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569601}
-
Paul Meyer authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/z4CWYor4UpQ Bug: 731810 Change-Id: I8146e6af6edba7b0ab844a47afb4d889b081e117 Reviewed-on: https://chromium-review.googlesource.com/1110351 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#569600}
-
Colin Blundell authored
In preparation for porting GCM to use IdentityManager to fetch access tokens rather than ProfileOAuth2TokenService, this CL refactors how GCMAccountTracker internally stores pending requests. Currently it stores them as a vector of raw OAuth2TokenService::Request pointers; when such a pointer gets passed in OnGetToken{Success, Failure}, it looks it up in the vector to delete it. However, the IdentityManager facilities do not pass pointers to the analogous "request" objects (called AccessTokenFetcher), while the client is still responsible for deleting those objects when desired. This CL changes GCMAccountTracker to maintain a map of account IDs to OAuth2TokenService::Request unique_ptrs. When a request is complete, it simply erases the entry in the map by key. One hiccup is that GCMAccountTracker currently can make two concurrent requests for the same account: - It makes token requests for accounts in AccountTracker's list of accounts that are in GCMAccountTracker's TOKEN_NEEDED state. - When it makes a request, it transitions the state of the account to GETTING_TOKEN. - When it receives a notification that an account has signed out, it transitions that account to ACCOUNT_REMOVED state. - When it receives a notification that an account has signed in, if it has the account in ACCOUNT_REMOVED state it transitions that account to GETTING_TOKEN state and refetches access tokens. However, GCMAccountTracker already short-circuits out of taking any action on completion of access token requests if the account is in ACCOUNT_REMOVED state (beyond deleting the request). This CL simply changes GCMAccountTracker to never make two concurrent token requests for the same account by deleting a token request when transitioning an account to ACCOUNT_REMOVED state. Bug: 809923 Change-Id: I2bae540133ae4db3f2cfea47332b2907dd88dd6d Reviewed-on: https://chromium-review.googlesource.com/1104689 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569599}
-
Adithya Srinivasan authored
Directly use types in base/numerics/checked_math.h instead. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I883a476d93c316c4ff6ded62e453e939a4dbb5ec Reviewed-on: https://chromium-review.googlesource.com/1108976Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
The user gets a feedback that the password is saved during editing. TBR=rouslan@chromium.org Bug: 851021 Change-Id: I2d254b4b366d67fee5283898b769362902008b15 Reviewed-on: https://chromium-review.googlesource.com/1110229 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#569597}
-
Siddhartha authored
GetAllocatorDump is used to check if dump was created. Do not return black hole dump from here. BUG=854668 Change-Id: Ife41be2622e9476d8e45586ace3ea316012341c3 Reviewed-on: https://chromium-review.googlesource.com/1111017 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569596}
-
Sebastien Marchand authored
This is a reland of bdb95bb9 with a fix for a conflict with https://chromium-review.googlesource.com/c/chromium/src/+/1093091 Original change's description: > Reland "RC: Connect the Local DB to TabHelper and add browsertests." > > This is a reland of 8f4ffc9a with a fix > for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory, > the HistoryService::Delete task didn't always had time to run before we > assumed that the entry had been removed from the history, this fix this > by running RunUntilIdle() several time (until the deletion has > complete) > > > > Original change's description: > > RC: Connect the Local DB to TabHelper and add browsertests. > > > > Bug: 773382 > > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9 > > Reviewed-on: https://chromium-review.googlesource.com/1088196 > > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568519} > > Bug: 773382 > Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8 > Reviewed-on: https://chromium-review.googlesource.com/1106940 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569311} TBR: fdoray@chromium.org Bug: 773382 Change-Id: I9b2f648f30d418b22972d4eadd026311971a5ae9 Reviewed-on: https://chromium-review.googlesource.com/1110002Reviewed-by:
-
Farah Charab authored
base::FeatureList::IsEnabled call is relatively expensive, so we cache the values of the features in the main thread. Change-Id: Ic725ff1d695cf01150139240d4f1b60d8b9a72a7 Reviewed-on: https://chromium-review.googlesource.com/1109214 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569594}
-
Andy Paicu authored
'unsafe-hashed-attributes' renamed to 'unsafe-hashes' 'unsafe-hashes' matches style attributes correctly now 'unsafe-hashes' works for javascript: URLs 'unsafe-hashes' tests added and ammended spec (approved and to be submitted at the same time as this CR): https://github.com/w3c/webappsec-csp/pull/311 I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4dohVXDfEI4/tO6rhuv4AwAJ Bug: 771922 Change-Id: I018cc0f73d492cb4057ff4c41d9be4df8438036c Reviewed-on: https://chromium-review.googlesource.com/1095217Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569593}
-
Ryan Daum authored
This DCHECK was triggering on debug cast build while using a port of PartialMagnificationController. Bug: none Test: manual Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I31273be8602f5e9bf9a114d91119cf7b9b374d87 Reviewed-on: https://chromium-review.googlesource.com/1110024Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#569592}
-
Vaclav Brozek authored
The old (renderer-process) FormData->PasswordForm parser failed to ignore non-text inputs, such as radio buttons. This CL adds filtering non-text fields out. Note that the new parser (browser-process) does filter out non-text field already. Bug: 851808 Change-Id: I60b121cb5cc15bdae0d96dba9119c2d704d079b2 Reviewed-on: https://chromium-review.googlesource.com/1111849Reviewed-by:
-
Nico Weber authored
This reverts commit e092b1bd. Reason for revert: SecureChannelClientImplTest.TestMultipleConnections has been failing consistently on the waterfall since this landed. Started here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/9728 Original change's description: > [CrOS Multidevice] Integrate SecureChannel API into ProximityAuthMonitor. > > This injects a ClientChannel into ProximityAuthMonitor, which is used if the > chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used > to get the current RSSI of the connected remote device. > > In the future, the "rolling average RSSI" that is calculated in > ProximityAuthMonitor will be moved to the SecureChannel API, and returned > by it. However, to reduce immediate migration work, that logic is kept > in ProximityAuthMonitor for now. > > R=jhawkins@chromium.org, khorimoto@chromium.org > > Bug: 824568, 752273 > Change-Id: I8d6485a5a0018fe43595b880c25a2fa9af5a1b75 > Reviewed-on: https://chromium-review.googlesource.com/1106616 > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: James Hawkins <jhawkins@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569425} TBR=jhawkins@chromium.org,khorimoto@chromium.org,hansberry@chromium.org Change-Id: Ie22413bae9011ed505220115fa1c711fc1c7e626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824568, 752273 Reviewed-on: https://chromium-review.googlesource.com/1111937Reviewed-by:
-
Martin Šrámek authored
The Flash permission toggle is shown in page info iff Flash was ever used on a given website. When ephemeral Flash permissions are enabled, we Sync this piece of information to make the toggle appear on all devices, to somewhat counteract the reduced usability of the ephemeral permission. At the same time, migrate the Feature object to //components so that we can refer to it from the relevant code. Bug: 850062 Change-Id: I69a843233e8c1f13abdd7027fddeb4d4692a5af6 Reviewed-on: https://chromium-review.googlesource.com/1109685 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#569589}
-
Ulan Degenbaev authored
Currently resource_coordinator::TabLifecycleUnit controls reloading of a bloated renderer process and notifies the tab helper. This CL moves the renderer process reloading to the tab helper, so that all code related to bloated rendere is in one place. Bug: 835806,808143 Change-Id: I1577872a1adc043a87bb2f599b211d3be9708f5c Reviewed-on: https://chromium-review.googlesource.com/1097481 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569588}
-
Friedrich Horschig authored
This CL provides the native code to the "Manage passwords..." link in the passwords accessory bottom sheet. Bug: 853747 Change-Id: I275171b1889d3ea85e3d8c3eda7feab8eed06495 Reviewed-on: https://chromium-review.googlesource.com/1110131 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
