- 29 Dec, 2016 30 commits
-
-
dbeam authored
- os.path is provided by input_api, and it's preferred to use it - time does not seem to be used any more - input_api.change.AffectedFiles() with a "starts with my dir" filter is equivalent to input_api.AffectedFiles(); also, harness file_filter= - os.path.split()[1] is equivalent to os.path.basename(), which is more readable, IMO R=calamity@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2599593003 Cr-Commit-Position: refs/heads/master@{#440937}
-
jri authored
Include quic_str_cat.h in all the places it's used. Merge internal change: 142874387 https://codereview.chromium.org/2609483002/ QUIC - refactor in preparation for two streams per HTTP transaction. The IETF WG is moving to model of using a pair of streams per https://quicwg.github.io/base-drafts/draft-ietf-quic-http.html#rfc.section.4.2 This scheme above came about in the course of discussions on QUIC specific changes to HPACK that will hopefully eliminate HPACK induced HoL blocking. This change is a refactor of QuicHeadersStream and QuicSpdySession, moving per-session granularity items from the former to the latter. It does not yet make headers stream per request, but this helps prepare the way. na/ (refactor only - no functional change). Merge internal change: 142825457 https://codereview.chromium.org/2607873002/ BUG= Review-Url: https://codereview.chromium.org/2609493002 Cr-Commit-Position: refs/heads/master@{#440936}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/009b4fbe8df40 BUG=674098 TBR=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2609493003 . Cr-Commit-Position: refs/heads/master@{#440935}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#440934}
-
meacer authored
CertificateReportingService::ShutDown posts a task to the IO thread to delete reporter_. If the service's destructor is already run, this will cause a crash during shutdown. Instead, delete reporter_ using a static method and without referencing CertificateReportingService's |this|. BUG=677329 Review-Url: https://codereview.chromium.org/2601203002 Cr-Commit-Position: refs/heads/master@{#440933}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/e02d3caab823..a4cb388c0fe8 $ git log e02d3caab..a4cb388c0 --date=short --no-merges --format='%ad %ae %s' 2016-12-29 brianosman Revert "Add ImageToColorSpace helper in SkImageFilter" Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=liyuqian@google.com Review-Url: https://codereview.chromium.org/2608663002 Cr-Commit-Position: refs/heads/master@{#440932}
-
mmenke authored
New code should be using HttpRequestHeaders or HttpResponseHeaders, as appropriate. BUG=none Review-Url: https://codereview.chromium.org/2608563002 Cr-Commit-Position: refs/heads/master@{#440931}
-
avi authored
BUG=579229 Review-Url: https://codereview.chromium.org/2608613002 Cr-Commit-Position: refs/heads/master@{#440930}
-
chrishtr authored
Before this patch and the one that was the proximate cause of issue 674098, clips for composited bounds worked like this: 1. If there was a clip between the compositing container and a PaintLayer, the clip would be that PaintLayer's contribution to composited bounds. 2. If there was no such clip, we would fall back to physicalBoundingBox, and also recurse into children. After the patch causing issue 674098, we would always recurse, even in case 1. This patch observes that we can always use a local bound of the intersection of any clip with physicalBoundingBox. Recursion still always happens. This avoids situations like in issue 674098 where skew matrices yielded bounds much too large. BUG=674098 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2591883002 Cr-Commit-Position: refs/heads/master@{#440929}
-
chrishtr authored
They fail due to subpixel differences. TBR=wkorman Review-Url: https://codereview.chromium.org/2605203002 Cr-Commit-Position: refs/heads/master@{#440928}
-
leon.han authored
BUG= Review-Url: https://codereview.chromium.org/2607603003 Cr-Commit-Position: refs/heads/master@{#440927}
-
caseq authored
BUG=662859 Review-Url: https://codereview.chromium.org/2607833002 Cr-Commit-Position: refs/heads/master@{#440926}
-
yigu authored
BUG=645957 TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2595593002 Cr-Commit-Position: refs/heads/master@{#440925}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/7cf774573cc5..e02d3caab823 $ git log 7cf774573..e02d3caab --date=short --no-merges --format='%ad %ae %s' 2016-12-28 brianosman Add ImageToColorSpace helper in SkImageFilter Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=liyuqian@google.com Review-Url: https://codereview.chromium.org/2605093003 Cr-Commit-Position: refs/heads/master@{#440924}
-
yzshen authored
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder handle a navigation. This fixes the following layout tests in PlzNavigate mode: imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html BUG=673751 Review-Url: https://codereview.chromium.org/2600653002 Cr-Commit-Position: refs/heads/master@{#440923}
-
martijn authored
BUG=599523 Review-Url: https://codereview.chromium.org/2582323004 Cr-Commit-Position: refs/heads/master@{#440922}
-
avi authored
BUG=579229 Review-Url: https://codereview.chromium.org/2605953002 Cr-Commit-Position: refs/heads/master@{#440921}
-
rch authored
Review-Url: https://codereview.chromium.org/2600183002 Cr-Commit-Position: refs/heads/master@{#440920}
-
dgozman authored
This patch introduces a list control, which maintains an array-like model. This makes it possible to update model efficiently (not in O(n) all the time). It also improves fast smooth scrolling of viewport on mac (less flashes) by using gap elements instead of absolute positioning. Only supports fixed/measured height elements, variable height is coming next (to be used in treeoutline). BUG=none Review-Url: https://codereview.chromium.org/2592433003 Cr-Commit-Position: refs/heads/master@{#440919}
-
tedchoc authored
On Android, we restrict who can open incognito tabs to only Chrome. The logic to enforce this was spread across IntentHandler#shouldIgnoreIntent and ChromeTabbedActivity#processUrlViewIntent. It was unclear and confusing to read, so this removes the invalid paths and makes it more explicit about what is allowed. BUG= Review-Url: https://codereview.chromium.org/2601183002 Cr-Commit-Position: refs/heads/master@{#440918}
-
rbpotter authored
For print preview UI redesign, design team has requested tracking of number of HTML vs PDF prints as the UI elements for each case are different. This adds a histogram to track HTML vs PDF prints. BUG= Review-Url: https://codereview.chromium.org/2597343002 Cr-Commit-Position: refs/heads/master@{#440917}
-
ryansturm authored
Accelerated Mobile Pages (AMP) are pages that have limited sets of functionality to improve page load performance. AMP pages are discoverable by google and are served via GSA. These pages are cached by google to further improve page load time and GSA will use the cached pages when serving AMP to the user. The AMP cache is currently located at https://www.google.com/amp/* but will soon move to https://cdn.ampproject.org. See https://developers.google.com/amp/cache/overview#amp-cache-url-format for more details. A follow-up CL will track page size for AMP cache pages. BUG=658817 Review-Url: https://codereview.chromium.org/2595263004 Cr-Commit-Position: refs/heads/master@{#440916}
-
wangxianzhu authored
We snap visual rect to pixels differently in different paths, so ignore the subpixel differences. This fixes failure of VisualRectMappingTest.LayoutText on mac with patch https://codereview.chromium.org/2595323003/#ps160001 BUG=646176 Review-Url: https://codereview.chromium.org/2605163002 Cr-Commit-Position: refs/heads/master@{#440915}
-
brucedawson authored
Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 Review-Url: https://codereview.chromium.org/2608643002 Cr-Commit-Position: refs/heads/master@{#440914}
-
chrishtr authored
BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2607003002 Cr-Commit-Position: refs/heads/master@{#440913}
-
tedchoc authored
BUG= Review-Url: https://codereview.chromium.org/2607863002 Cr-Commit-Position: refs/heads/master@{#440912}
-
azurewei authored
BUG=677087 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2607493002 Cr-Commit-Position: refs/heads/master@{#440911}
-
stevenjb authored
While updating the text I discovered that changing the focus (e.g. by calling blur() on the focused button, or simply clicking or tabbing away from the dialog) would cause the keyboard event to not get triggered. This change was introduced in https://codereview.chromium.org/2180823004. The simple fix is to call window.addEventListener instead of this.addEventListener. BUG=660597 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2589353002 Cr-Commit-Position: refs/heads/master@{#440910}
-
chrishtr authored
BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2604973002 Cr-Commit-Position: refs/heads/master@{#440909}
-
takumif authored
This CL adds test cases to MediaRouterUITest and MediaRouterWebUIMessageHandlerTest that test recording and retrieving users' preferred cast modes (whether they chose tab mirroring for the current origin) in regular and incognito profiles. BUG=664671 Review-Url: https://codereview.chromium.org/2549323002 Cr-Commit-Position: refs/heads/master@{#440908}
-
- 28 Dec, 2016 10 commits
-
-
rdevlin.cronin authored
ErrorUtils are used to construct errors or warnings, and are usually based on const char[]s. Change method signature to take a string piece to avoid constructing a bunch of temporary std::strings. BUG=None Review-Url: https://codereview.chromium.org/2604033002 Cr-Commit-Position: refs/heads/master@{#440907}
-
chrishtr authored
Thus only transformed elements now paint with transform. The concept of painting fixed-position elements with transform was introduced in https://codereview.chromium.org/1110653003, to help with paint invalidation of SPv1. However we ended up invalidating whole subtrees on scroll in v1, so this is not necessary. Also added invalidation of paint properties when changing compositing mode, since this can affect whether paintsWithTransform changes its behavior. BUG=674623 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2570423003 Cr-Commit-Position: refs/heads/master@{#440906}
-
rch authored
Merge internal change: 143121845 Review-Url: https://codereview.chromium.org/2603723002 Cr-Commit-Position: refs/heads/master@{#440905}
-
rdevlin.cronin authored
Common test practice: compare a stringified property on an object to an expected value (we use strings for easy readability if something is unexpected). Add a method to streamline the process a bit. BUG=653596 Review-Url: https://codereview.chromium.org/2601143002 Cr-Commit-Position: refs/heads/master@{#440904}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f47962ef..b61ed8b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2608533003 Cr-Commit-Position: refs/heads/master@{#440903}
-
avi authored
BUG=579229 Review-Url: https://codereview.chromium.org/2606823002 Cr-Commit-Position: refs/heads/master@{#440902}
-
wangxianzhu authored
operator== should check all fields that are part of paint properties. toString() should output all fields that are checked in operator==, so that we can see what changed in the failure message of paint property under-invalidation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2606863002 Cr-Commit-Position: refs/heads/master@{#440901}
-
sammc authored
BUG=674766 Review-Url: https://codereview.chromium.org/2608503002 Cr-Commit-Position: refs/heads/master@{#440900}
-
meacer authored
https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Review-Url: https://codereview.chromium.org/2601093002 Cr-Commit-Position: refs/heads/master@{#440899}
-
tedchoc authored
BUG=673522 Review-Url: https://codereview.chromium.org/2602813002 Cr-Commit-Position: refs/heads/master@{#440898}
-