- 24 Sep, 2020 40 commits
-
-
Rouslan Solomakhin authored
Before this patch, several places in Web Payment, e.g., ServiceWorkerPaymentApp, held on to a PaymentRequestSpec* pointer that could become invalidated and used after free. This patch replaces PaymentRequestSpec* member variables with WeakPtr<PaymentRequestSpec> and checks it for null before use. After this patch, Web Payment holds WeakPtr<PaymentRequestSpec> member variable that is checked for null before use, thus avoiding use after free. Bug: 1127322 Change-Id: Icfe356c7321dfabc63f9fa68d6fcca7d3a4a761b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422432Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810263}
-
Rohit Agarwal authored
This CL allows READER_MODE to: a) Remove top row action icon menu: Forward, Refresh, pageinfo, Bookmark. b) Menu item to contain only "Find in page" and a custom menu item "Appearance". Screenshot: crbug.com/1128856#c1 Bug: 1128856 Change-Id: I9624da87b9a95a22a2fe0b4eb67c6676214b8ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426484 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#810262}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I7b43d2fcfcce720ac8a812034aade2cecbc2c715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428392Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#810261}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0a5d55ddbf4dd345572d8c5011f91fe15bcb342c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810260}
-
Kramer Ge authored
With overlay forwarding using wl_subsurface, a wl_buffer can be cropped and scaled to fit a display_rect. This CL adds the extension wp_viewporter to enable crop&scale, as well as buffer_transform. When calculating surface-local damage, take into account buffer_transform, crop and scale. This is 5/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: I5cd0a28b7043557aeca0664f59152fd05eadf885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327636Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#810259}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the file range [fake...http] in the //components/password_manager/core/browser directory. Bug: 1067347 Change-Id: If62b9017a4bf2deb82eab75b7968c6c395f6b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426709Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810258}
-
Frank Liberato authored
This is the first of several CLs to replace DecodeStatus with media::Status. This one adjusts DecodeCB to return a Status, and alters the consumers to expect it. It also adds the DecodeStatus enum values to StatusCode, so that old code continues to work without modification. DecodeStatus is aliased to StatusCode. DecodeCB implementations have been modified to check for "not ok, not aborted" where they used to check for `DecodeStatus::DECODE_ERROR`. While `DECODE_ERROR` is still defined in the enum, and decoders continue to return it, the consumers should now work even if individual decoders start sending more detailed status codes. `DECODE_ERROR` will be removed once all the decoders have been updated. For tests, there is now a `IsDecodeErrorStatus()` matcher that does the same thing. Future CLs will update other uses of DecodeStatus to do it more properly, and not rely on this somewhat hacky enum-merging. It can be done incrementally with these changes, which is the real goal. Change-Id: I77dd3ee9e3be5b17ca070e602f2b173ba98d4694 Bug: 1129662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392950Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#810257}
-
Victor Hugo Vianna Silva authored
This method also records counts for sync entities, so its name and documentation should be updated. The name is chosen to match the corresponding method in DataTypeControlller. Bug: None Change-Id: I6333884975c60ac78f7e3de5b54ed43ed51077ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424227 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#810256}
-
Samuel Huang authored
Previously, CreateMetadata() returns None if the resulting metadata is empty. Recently updates to _ParseApkOtherSymbols() requires |metadata| to be available (to add 'zipalign_padding') field. This leads to breakage when SuperSize is run on Trichrome. This CL changes CreateMetadata() to return {} instead of None to fix the issue. This does not affect existing metadata use in SuperSize; already it's not explicitly compared against None. Bug: 1040645 Change-Id: I8664148f647910cbb5f9dea216684262174e0e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427324Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#810255}
-
Leo Lai authored
This reverts commit 6d81ed25. Reason for revert: the project dependency, platform-side proxy, is currently only enabled with device policy and not universally available until M88. Original change's description: > deploy AttestationFlowIntegrated > > This CL deploys the usage of platform side of attestation flow because > attestation service at platform side knows better about the stat > machines of the enrollment. > > BUG=b:158955123 > > Change-Id: I902f8bfc43da9cb2cae0e65a0d244c31ce986dfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297061 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789858} TBR=emaxx@chromium.org,cylai@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:158955123 Change-Id: I429984e8ef2f7c0e3b52d829fa9c4abc8cbc47fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423700 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810254}
-
John Z Wu authored
This will make them easier to work with when used in collections Change-Id: I8225afc3076929c9d8c162ca2a4af30c390e7fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425400 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#810253}
-
Hugo Holgersson authored
Background (from the CSS2 spec): "Although margins, borders, and padding of non-replaced elements do not enter into the line box calculation, they are still rendered around inline boxes. This means that if the height specified by line-height is less than the content height of contained boxes, backgrounds and colors of padding and borders may "bleed" into adjoining line boxes". [1] Background about SpatNav: a. SpatNav's distance formula's input is only the origin's (current focus') rect and a candidate's rect. b. If two rectangles intersect, they are considered to be at zero (or negative) distance. Problem: When a link's inline box "bleeds" onto links below, then links on the same line (to the left or right) could get unreachable when SpatNav's distance formula favors the intersecting rects below, see snav-line-height_less_font-size.html. Solution: Shrink these bleeding inline boxes to their line box's [2] height. If a link is line broken over 2 lines, use 2x the line box height, and so on. [1] https://drafts.csswg.org/css2/#leading [2] https://drafts.csswg.org/css2/#line-box Bug: None Change-Id: I002da7af30721de45105f5ba1330f4679a5457af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410039 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#810252}
-
Nina Satragno authored
This reverts commit 1208732e. Reason for revert: likely making ExecuteScriptApiTest.ExecuteScriptInFrame flaky. Bug: 1131966 Original change's description: > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > guarantees that the platform cursor has been set. > > Bug: 1097556 > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810120} TBR=sky@chromium.org,hferreiro@igalia.com Change-Id: I60d2de90149af77a5d6ebdce2f02a859f9262f9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429229Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810251}
-
Ian Wells authored
Bug: 1110685 Change-Id: If30b18f3d1b0dd1643442cfd4a6fd5bd730bae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424666Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#810250}
-
Alison Maher authored
Similar to CL:2404109, ComputedStyle::DecorationColorIncludingFallback() was not handling system colors correctly with CSSSystemColorComputeToSelf enabled. Bug: 1081945,1129485 Change-Id: I3b01f5060c0758a9167a771058d365dbb4629008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424674Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810249}
-
manukh authored
Just a helper to check if both suffix and prefix autocompletion are empty. This is in preparation for the potential introduction of a 3rd autocompletion field. Bug: 1062446 Change-Id: I58aecb9cffb690618bb835ed97e1cb69cfdae635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426964 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#810248}
-
Daniel Libby authored
This allows the state from freezing the tree to match the updates we're about to send up to the browser process. On amazon.com homepage, activating the hamburger menu results in a focus to the hamburger menu, then a synthesized click. The click handler bounces focus to the popup menu's close button and also modifies its styles so that it is visible. The first focus event queues up a deferred notification for HandleNodeGainedFocusWithCleanLayout. This is then added as an AXEvent (and queues a SendPendingAccessibilityEvents) as part of the lifecycle update triggered by RenderAccessibilityImpl::PerformAction for the click. The click happens and script bounces focus to the other element. The SendPendingAccessibilityEvents task then runs, which snapshots the pending_events_ (and clears it) before freezing the tree and updating layout. Due to this there is an AXTreeUpdate where focus points to the close-menu. However the close-menu element has not yet recomputed to be unignored as the relevant events are queued up in pending_events_. This change runs the document lifecycle before snapshotting the pending_events_ and dirty_objects_ so that we send up a self-consistent set of accessibility updates. Also added some tracing to help narrow down Accessibility focus issues in the future. AX-Relnotes: N/A Bug: 1131827 Change-Id: Ia8133c9bff45c243018185041bd13762bac25295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427749Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810247}
-
Ehimare Okoyomon authored
Temporary remove non factory-default permissions from the summary string until we are able to populate the permissions subpage directly using this controller's returned permissions: https://chromium-review.googlesource.com/c/chromium/src/+/2410859 Bug: 1077766 Change-Id: If57829db3c656c0631dda7fc755b9a46b2abb714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429044Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810246}
-
Roman Arora authored
Bug: 1099917 Change-Id: I51249a533b84439513708d62e5f56ac83120cce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427184Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810245}
-
Steven Bennetts authored
The logic for determining whether a network is metered for the purpose of auto updates is implemented separately in session_manager. We need to resolve this before enabling the toggle. See issue for details. Bug: 1129994 Change-Id: I976e191b8b27017339876d747c01967bab6081dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426982 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810244}
-
Evan Stade authored
This reverts the changes to GoogleAccountsCallback and introduces a new API for retrieving the user email, name and avatar. - getEmail is synchronous because the information is UI-blocking. We could show the UI, then later update, but that would be more jarring and more likely to cause misclicks, since the UI would move under the user's fingers. - getAvatar is async because the above problems don't apply. Bug: 1129893 Change-Id: I2cde39cc18f1da9edf6c3004f4c909492cd424c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421444 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#810243}
-
Stepan Khapugin authored
Instead of exposing MainController's conformance to BrowsingDataCommands use the app state's dispatcher to access it. Bug: 1045659 Change-Id: I71bd5d4693d5d2eefdc67def9abb345a84d24ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418336 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810242}
-
Olivier Robin authored
Bug: 1088801 Change-Id: Ib266b90c1dabf72cc1b5e31ee2dfebc937e393f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421823 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#810241}
-
Robert Phillips authored
Skia has improved its blurred rect handling in: https://skia-review.googlesource.com/c/skia/+/318757 (Allow rect and circle blur fast cases to be used with rotation matrices) This resulted in layout test differences in: vulkan_swiftshader_blink_web_tests --- transforms/shadows.html Bug: 1131901 Change-Id: I2485b867b37941abb65ed3f2b985d268a91e16df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427301Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#810240}
-
Javier Fernández García-Boente authored
Change-Id: I42b1dbf1318feb44f90edef02e71e64c97380a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426452Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#810239}
-
Richard Knoll authored
This adds a new NotificationBlocker that listens for screen share events and stops notifications when a full screen is currently being recorded. Implemented behind a mute-notifications-during-screen-share flag. Bug: 1131375 Change-Id: Icebcb9223614e07134ce038aef2ec2e45190c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421665 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810238}
-
Anton Bikineev authored
This is a prerequisite for quarantine bitmap in PCScan. Bug: 11297512 Change-Id: I4d99e348140fe8b4826be46c4bc0a0e88afed4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421894 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810237}
-
Ken Rockot authored
On devices and Android versions which support 5G, this allows the NetworkChangeNotifier to update the ConnectionType to 5G when observing use of a network of type NETWORK_TYPE_NR, which corresponds exclusively to 5G standalone networks. The NCN Java code is also updated to treat TYPE_MOBILE_DUN and TYPE_MOBILE_HIPRI networks the same as TYPE_MOBILE. Currently they are ignored and treated as "unknown" network types, but they are legitimate values when on a cellular network, up to and including 5G. Bug: 1127134 Change-Id: I5b054635a633970d26f4cfcc34b5a58376ed2fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427104Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#810236}
-
Toby Huang authored
FamilyUserMetricsProvider causes an OOBE crash from dereferencing a null sign-in profile. Revert this code temporarily while working on a fix. Bug: 1128281 Change-Id: If13d6fc4a0c222053e8beae3d306e9aa9fae2340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427426 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#810235}
-
Minoru Chikamune authored
[Target problem] - The current code uses g_current_agent_group_scheduler_impl global variable. [What this CL does] - Get rid of the g_current_agent_group_scheduler_impl global variable, and keep this pointer in MainThreadSchedulerImpl as a field. - Make it possible to access current AGS from arbitrary places with `ThreadScheduler::Current()->GetCurrentAgentGroupScheduler()`. [Related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: Iac332a9400bc20537e5d64ce700d0e5866e7f406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427945 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810234}
-
Becca Hughes authored
Change-Id: Id8d677caba6f2353d969efb210f01a4e831acacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427432Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810233}
-
Zentaro Kavanagh authored
- Making usage consistent in file Bug: None Test: None Change-Id: If88abfc0a7fe424f5d6da7f623e321cee72b3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427042Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810232}
-
Dan H authored
This reverts commit 3742fb2f. Reason for revert: builder failure crbug.com/1131947 Original change's description: > chromeos: Set is_linux to false. > > Bug: 1110266 > Test: Built locally. > Change-Id: I291f594060beed19d8497c5d6b7689effbe3dc9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413458 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810162} TBR=thakis@chromium.org,hidehiko@chromium.org Change-Id: I710cbf3c96f26a1e5e9f22617443348ea249984c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429364Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#810231}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a952a34..2f1c8428 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I748185aaeb34c94ab36bef63e41c50b939d1731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810230}
-
Felipe Erias authored
For consistency, rename the ScrollbarGutterIs* methods in ComputedStyle to IsScrollbarGutter*. Bug: 710214 Change-Id: I0f63528112fe00ce91aa7f3877b370e7bfe7d8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416434Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#810229}
-
Prashant Nevase authored
As dark mode image classification logic works on integral values, making APIs accept SkIRect will help callers decide how to round the SkRects. This patch rounds |src| and |dst| by calling SkRect::roundOut() in DarkModeFilterHelper::ApplyToImageIfNeeded(). Bug: 1094005 Change-Id: I86dead7936932e207d0e1a3540de1741c27587d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389862 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810228}
-
Garrett Beaty authored
This is a reland of 229a7c61 Configs for the mojo builders were copied to thew new builder group in mb_config.pyl and waterfalls.pyl. Original change's description: > Switch the builder group for mojo builders. > > The recipe-side config for the mojo builders has already been copied to > the new builder group. > > Bug: 1131163 > Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#809869} Bug: 1131163 Change-Id: I1e1db95eec3513ec1fc85f2ace2cffddc5567a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427286 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810227}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the export and import sub directories of //components/password_manager/core/browser/. Bug: 1067347 Change-Id: Ic8059ed095401354323efc7e8f9b295d30bb7773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428240 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810226}
-
Olivier Tilloy authored
- Use $SNAP_USER_COMMON to store profile directories, to avoid data loss when the snap is refreshed while running. - Add the bluez plug to enable Web Bluetooth. - Use 'snapctl is-connected password-manager-service' instead of D-Bus calls. Change-Id: Iee24e689a9bbd678875d206fe00c7cbb28af38d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398521Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Olivier Tilloy <olivier.tilloy@canonical.com> Cr-Commit-Position: refs/heads/master@{#810225}
-
Aaron Leventhal authored
Bug: 1129111 Change-Id: I5c5db22feb752e42d0620f03c3e765c6319517ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422719 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810224}
-