- 08 Jul, 2020 40 commits
-
-
Kenneth Russell authored
Previously the last one in the list would win; now the first one wins, which is the order in which the code is read. Improves performance for some WebGL content using the validating command decoder on Intel GPUs on macOS. Bug: 1045643 Change-Id: I99c1c874b4d323362f70a11aa6c7971cbdfdd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288503Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786538}
-
Dale Curtis authored
Adds support for parsing color information from vpcc box as well as the colr box if available. Previously we only supported colr, mdcv, and clli for av1. These are standardized boxes, so they may be available on any codec. The VP9 in MP4 spec (https://www.webmproject.org/vp9/mp4/) uses slightly different fourcc codes for the mdvc and clli boxes: SmDm and CoLL respectively - these are now supported as well. R=cassew Fixed: 1102200 Test: Updated unittests Change-Id: I44db608f0439778a9ac4085efc2c1c138432a78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284084 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786537}
-
shrekshao authored
Fixing several BPTC and RGTC texture validation logic according to recent WebGL spec and test updates: https://github.com/KhronosGroup/WebGL/pull/3105 https://github.com/KhronosGroup/WebGL/pull/3111 https://github.com/KhronosGroup/WebGL/pull/3112 Bug: 1100834, 1102924 Change-Id: I82938a642821308a08e6f73175553f312c1c0e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285179 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786536}
-
Devlin Cronin authored
The TODO called for testing for action.onClicked, which exists in the form of MultiActionAPITest.OnClickedDispatching. Bug: 893373 Change-Id: Id33a00340aebcbc11be1d8f15b98663a662bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288496Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786535}
-
Lei Zhang authored
- Remove the public_deps entry for //gin. It can just be a regular deps. - Remove a duplicate entry for pdf_features.h. It is already in the public section. - Give //pdf:pdf_test_utils the minimal required visibility. - Remove a comment about a dependency that is no longer necessary. GN checks and knows the dependency must be there. - Add a dummy group for //pdf:features, since it is public facing just like //pdf:pdf. Change-Id: Ibfe5b6970ad55d65e073f96b42e57228a89a14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288431Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786534}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/babba97ae63a..eb7703565a86 2020-07-08 johnstiles@google.com Update SkXfermodeImageFilter to consolidate color processors. 2020-07-08 herb@google.com Combine MakeOp and insertSubRunOpsIntoTarget 2020-07-08 jlavrova@google.com TextStyle::matchOneAttribute compares backgrounds even if they don’t exist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I2b25c290916fd1f517b1a33f201f68cac6daefa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786533}
-
Christopher Cameron authored
This is causing the test GPUTestConfigTest.LoadCurrentConfig to fail. Bug: 1101436 Change-Id: I3b3c80de68e222f19d7aa7fc7b9eaf1aac8a4437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285339 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Ted Choc authored
Criteria.checkThat/CriteriaNotSatisfiedException is the only allowed path in CriteriaHelper going forward. BUG=1071247 Change-Id: Idde0bd13ce78689b57422e0fc8bdadde57cc2276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288091Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786531}
-
rbpotter authored
Change-Id: Ie930f1064826913243648ccf125d204b946af82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285181Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786530}
-
Emily Stark authored
This CL adds in fading to/from transparent alongside the existing elision animation to/from simplified domain. It's similar to the previous PathFadeAnimation that faded out the path except that it (a) happens concurrently with changing the URL's display bounds, and (b) it can apply to subdomains as well as the path. Bug: 1090393 Change-Id: I8f9348dc47dce3260969577feb5517b14483d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285074 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786529}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: Ica13baa307a947362957060551d0984f591b7e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283636Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#786528}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594209491-ef5df3b74524e456f9efc0fd239921f6b10d9a40.profdata to chrome-win64-master-1594231179-e92968c7f7a7f3e72dcd314b17d160c794b4cf4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I19c294c3336e75350a4f4b38923b015c4f7c599e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288573Reviewed-by:
-
Matthew Porter authored
Previous PR was reviewed and merged (https://chromium-review.googlesource.com/c/chromium/src/+/2141215) then reverted here (https://chromium-review.googlesource.com/c/chromium/src/+/2166465) due to this failure (https://bugs.chromium.org/p/chromium/issues/detail?id=1074508). Added the tryjob to validate the fix in assistant_timers_browsertest Modified Notification View to take out hardcoded colors. Moved them to NativeTheme::ColorId and used the GetSystemColor call at the different references to it. Replaced NotificationButtonMD with MDTextButton. Changed accent_color to base::Optional<SkColor>, updated associated calls to account for that Bug: 1056948, 1074508 Change-Id: I17d786b2e2311bfb7c52472aed2bb02c8593ae0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220474 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786526}
-
Samuel Attard authored
symbols require a underscore prefix Bug: 1098899 Change-Id: I21f9cafcc7eb071b8cdb2dca383608598ac45df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288475Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#786525}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594220267-9b42ec61f1a87a14500dff1ab9da4a37b8c79053.profdata to chrome-win32-master-1594223967-fb5c79f9944c5a268366596411e8494ec34413b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I69e6ae0248def8c4e647795a677a0c7e6e27a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288482Reviewed-by:
-
George Steel authored
This causes no behavioural change. Change-Id: Ieef9d0138cd0f1bc2d647f2b3b5a782d88ac4287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268582 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786523}
-
Xianzhu Wang authored
These tests inherited the [ Skip ] expectation of the base tests. crrev.com/c/2231550 missed to add [ Pass ] for them. Bug: 1103349 Change-Id: I44b9a23c08b87e1c0b569012db7094b559943139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288639Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786522}
-
Stephen Martinis authored
The fetching script currently fetches about 2 GB (on my linux workstation) from cloud storage serially. This can (and is) trivially parallelizable, and should speed up the fetching script significantly. This script has been taking 20 minutes on mac machines for a long time. This will hopefully significantly speed the mac builders up. Bug: 1102597 Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786521}
-
Steve Kobes authored
Also update comment in disk_cache::SimpleBackendImpl, and remove some things that are not used. Bug: 1007815 Change-Id: I5e239877a52a9906a8e42b62a00a40506e98f89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288273 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#786520}
-
Daniel Classon authored
Added helper function GetModifiedUrlWithSettingId that returns the modified url with settingId appended. Also added a testing file for that function. Change-Id: Ic140bc81c334b89b43a332b66251cfff199f5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283653 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786519}
-
Erik Staab authored
Change-Id: I806dab8cea22aa3cd429b3c54727a4c5cb66fc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288493Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786518}
-
Matt Reynolds authored
BindRepeating is correct because SetTracksWatcher expects a media::MediaTracksUpdatedCB which is a base::RepeatingCallback. The callback is called whenever the media track configuration has been updated, which is expected to occur more than once. BUG=1102651 Change-Id: Ibc60aec4cbd7692dfd94a74429d718d38171bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284226 Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This change introduces test batching to ContextualSearchManagerTest. This means that the browser process (and Instrumentation instance) is not restarted between each of the tests in the suite. However, it is restarted before and after this suite, as the batching type is PER_CLASS. For ContextualSearchManagerTest, this means the tests run >5x faster. I had to modify a few tests to clean up persistent state changes, and I got rid of the 1 second delay added to each test, replacing it with retries when panel interactions fail. I also had to make the EmbeddedTestServerRule reusable so that the server can be restarted for each test. In the future this should be further improved to allow the test server to be reused across tests. Finally, I had to remove a maximizePanelThenPromoteToTab animation from ContextualSearchManager that wasn't visible anyways (as it is used when launching an external app), as when run in the test it wasn't being set up correctly and ended up being too invasive to tear down. Bug: 989569 Change-Id: I5aff1667c01ac3dceb33704c6853299cab1cd541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270713 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#786516}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a376518817f9..563d497e009f 2020-07-08 handellm@webrtc.org SimulatedTaskQueue: release lock before destroying tasks. 2020-07-08 mbonadei@webrtc.org Fix 'Perf Android32 (M Nexus5)' config in MB. 2020-07-08 mbonadei@webrtc.org Reland "Add possibility to expand strings in the autoroller." 2020-07-08 danilchap@webrtc.org Delete RtcpDemuxer as unused 2020-07-08 handellm@webrtc.org Partly migrate test/ to webrtc::Mutex. 2020-07-08 danilchap@webrtc.org Cleanup setting VideoQualityTestFixtureInterface::Param struct 2020-07-08 mbonadei@webrtc.org Revert "Add possibility to expand strings in the autoroller." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a93f5349dfa38d87b0bedac084be4ef0bfa5f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288550Reviewed-by:
-
Zhongyi Shi authored
Data for Net.QuicStreamFactory.NumDegradingSessions is missing while Net.QuicSession.PlatformNotification contains effective data. This is to validate the hypothesis that there are no more than one session when network change is detected (which is a bit surprising). Bug: 1090532 Change-Id: I8abe74ce87c2fe63ce5fcaa0edb019f8e8bc8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284445 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786514}
-
Liquan (Max) Gu authored
Change-Id: I36ca73f222600f47b55298202354eb66279c00b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288830Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786513}
-
Ali Juma authored
This CL disables kRealTimeLookupEnabled on iOS so that real-time lookups on iOS can be guarded by this flag rather than being hard-coded to disabled. Bug: 1103218 Change-Id: Icbf4b48c1283786810c7437fa00f1418f44066f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288373 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#786512}
-
Matt Menke authored
This CL removes the Link Doctor click tracking network requests and UMA code. It also removes the code promote the Google cache suggestion and record when the cache suggestions are interacted with. This CL also renames the variable "src" to "source" in the Javascript files, as otherwise, removing the trackClick method in the JS file results in funky build failures on Android, likely due to a buggy regexp when trying to inline files. Bug: 1030281 Change-Id: Ia2a9f56397f1014baf65ac0374c446a062b2007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284973 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#786511}
-
Taylor Bergquist authored
Bug: 1093972 Change-Id: I1d952d79885eccd1a1a011231ea3e2daf038ed75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278650Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#786510}
-
Lei Zhang authored
Consistently write it the same way as most of the code base. Then include build/build_config.h as required to guarantee OS_FOO is properly defined. Change-Id: I30c9e5c96808469b8e6b6a92ecfaa9239e63568c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277742 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786509}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: If36164e2de06f7590e3c619b1d4a78bc55b3a366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284369 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786508}
-
Erik Chen authored
This CL creates a new mojo interface: ScreenManager. This interface has a single method TakeScreenSnapshot which returns a bitmap of the screen's contents. Lacros-chrome uses this interface to implement a rudimentary version of screen-sharing. This in turn allows meet.google.com screen sharing to function properly. This interface will eventually be supplemented with methods to allow window-sharing as well. The whole interface will likely be overhauled in the future to create a more performant and fully-featured version of screen/window sharing. Change-Id: I821c59464ea4d2ff57665381038837f29645750d Bug: 1094460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261430Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786507}
-
evliu authored
This CL resets the Cloud recognition stream if audio has been paused for more than 28 seconds. The Open Speech API will not return recognition events if more than 30 seconds has elapsed since the last audio upload. Bug: 1101566 Change-Id: I9a667358fc8d5b98faaee3922d1d9778ab7a40f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278533 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
-
Andrew Xu authored
This CL ensures that hotseat only has vertical movement during transition between home launcher and hidden state. Bug: 1088182 Change-Id: I680735ec68b60080eaa920a4341d5a59db7dc2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285358 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786505}
-
John Williams authored
This patch as a number of changes to streamline unit tests; the main on is that it names ActivityRecord::SetOrUpdateSession() a nonvirtual method and delegates subclass-specific functionality to the new OnSessionSet() and OnSessionUpdated() methods. Change-Id: I3ce0c0ced968d3e3945ecd215dfe9a25959a49a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278138 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#786504}
-
Himanshu Jaju authored
- Removes existing protos copied from securemessage and ukey2 libraries - Adds dependency on open sourced libraries for the above protos. Change-Id: If2bb26e5c2e02f741f203bc699ef98dbf5edf581 Bug: 1037793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214535 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#786503}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: If2c3352048cdfefa616667b2dbe53e0f853f036e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283652Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#786502}
-
Lukasz Anforowicz authored
This CL takes GetOriginForURLLoaderFactory (and supporing helpers) from an anonymous namespace inside render_frame_host_impl.cc and makes it an instance method of NavigationRequest. This should help with the following long-term tasks: 1. Calculating the origin to commit in the browser process (https://crbug.com/888079). 2. Always setting request_initiator_site_lock (https://crbug.com/1098938). (Being able to access GetOriginForURLLoaderFactory via NavigationRequest might help populate |request_initiator_site_lock| and provide a URLLoaderFactory when creating any RenderFrameImpl in a renderer process (including speculative/provisional frames.) This CL should have no functional or test impact (it is pure refactoring - it just moves code around). Bug: 888079, 1098938 Change-Id: If464a49990d77bbf68b8e70f2a253e44e8c26f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285396Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#786501}
-
Himanshu Jaju authored
in chromium. Design doc - go/nearby-chrome The overall import is split into 3 CLs for easier reviews: - Securemessage and ukey2 import - Nearby connections import - Platform implementation for nearby in chrome Bug: 1037793 Change-Id: I59a58c01c877dd5fb4c7e647c122b633b592fa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274625 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie583045dfa8f5b24eb43dbf1b7c71fc52ebf7778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288086Reviewed-by:
-
