- 04 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c07cb95ffe25..db551cbc8b4b Created with: gclient setdep -r src-internal@db551cbc8b4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC adithyas@google.com,estade@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1038145 Tbr: adithyas@google.com,estade@google.com Change-Id: I0e0b9aba5f052d222dccf707442ca09ed54fc723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181486Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765335}
-
Renjie Tang authored
This change introduces no API changes. But API documents need to be updated. Change-Id: Ibc347df79066de704c5be0683c5b658ba6e1896a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168553 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#765334}
-
deepak1556 authored
Bug: none Change-Id: Iace766c61a64987fa4c25a12b0a74b3ec09d2c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173416 Auto-Submit: Deepak Mohan <hop2deep@gmail.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#765333}
-
Dale Curtis authored
The way this is implemented will lead to overlays being enabled on paths where a blacklist may be applied. The variable names are changed to make it clear that this affects all overlay support, not just hardware ones. R=sunnyps, zmo Bug: 906722, 1056267 Change-Id: I25ae0e465376f1cb9d19b279b7498802021a23fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176269Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#765332}
-
Vincent Boisselle authored
Change-Id: Idff5e54d9219d036b08cdaea2c0b53e0692c392f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180873Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#765331}
-
Carlos IL authored
After the committed interstitials refactor InterstitialPageDelegate has a lot of dead code, and only one subclass (SecurityInterstiitalPage). This CL moves all still used code to SecurityInterstitialPage and removes InterstitialPageDelegate in preparation for removing InterstitialPage. This CL leaves behind more dead code on InterstitialPage, which is cleaned up in the follow up CLs: -crrev.com/c/2146137 -crrev.com/c/2147921 -crrev.com/c/2149954 Change-Id: I35c3248c4b243722729a491063f4e70aaf2aa794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144739Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#765330}
-
Xing Liu authored
Replace the recursive implementation with TileItartor. Also test is polished to cover the empty return case. Bug: NONE Change-Id: Ifd86c560a89f639d4920cff88df5cca044fa83cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177297 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#765329}
-
Becca Hughes authored
If we start fetching a feed, then reset and then return the fetch we might store stale data. This adds the concept of a reset token which is reset everytime the feed is reset. When we store the fetch results we check the reset token and if it does not match we do not save the results. BUG=1076058 Change-Id: I92cfbbdf114c2c8522d76f2fc7dde9f7f153a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173313 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#765328}
-
Gabriel Charette authored
R=fdoray@chromium.org Bug: 1077305 Change-Id: I6e63d8bbbbd83377163ea981f83505a37a5e5ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175750 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#765327}
-
Esmael El-Moslimany authored
ogbinline: forces the OneGoogleBar to be inlined. ogbiframe: forces the OneGoogleBar to be iframed. ogdeb: forwards ogdeb query parameter to the endpoint that serves the OneGoogleBar parts. Bug: 1039913 Change-Id: I6814bbdee741a48f1fe83e5af0e513e9f5f058c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157589 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#765326}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/70ee9bcd3c1c..6e17074ba23d $ git log 70ee9bcd3..6e17074ba --date=short --no-merges --format='%ad %ae %s' 2020-05-04 dschinazi Send two QUIC alternate addresses from GFE for proxied sessions 2020-05-04 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_ignore_one_write_error_after_mtu_probe. 2020-05-04 bnc Remove SPDY_CODE_COUNT_N(decompress_failure*). 2020-05-04 fayang gfe-relnote: In QUIC with TLS, do not proceed in SetWriteSecret if connection has been closed. Protected by gfe2_reloadable_flag_quic_notify_handshaker_on_connection_close. 2020-05-04 fayang Add missing flag counts for gfe2_reloadable_flag_quic_record_frontend_service_vip_mapping and gfe2_reloadable_flag_quic_stream_id_manager_handles_accounting 2020-05-04 fayang Reenable some disabled e2e test for TLS. 2020-05-04 wub gfe-relnote: Allow connection option LRTT to be set for BBRv1 and BBQ2 to be set set for BBRv1 and BBRv2. Refactor only, not protected. 2020-05-01 danzh gfe-relnote: n/a, fix some compiler errors in QUICHE. 2020-05-01 danzh gfe-relnote: add client address into Quic proof source/verifier interface. No behavior change as the client address remains unused in GFE. Not protected. 2020-05-01 dschinazi Remove kDefaultIdleTimeoutSecs 2020-05-01 dschinazi Further clean up QuicConfig idle timeout API 2020-05-01 bnc Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I5a2c07b8db45458c54a2c9014088652f502c569f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181562 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#765325}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c5fba676f66..c6e57b7fb88b git log 0c5fba676f66..c6e57b7fb88b --date=short --first-parent --format='%ad %ae %s' 2020-05-04 treehugger-gerrit@google.com Merge "UI: Add trace title to sidebar and tab title" Created with: gclient setdep -r src/third_party/perfetto@c6e57b7fb88b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7ca7db626b3343696612fca9bd99e75f38e3fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765324}
-
Elly Fong-Jones authored
This override prevents any subclass of BubbleDialogDelegateView from using WidgetDelegate::SetShowCloseButton(), which is annoying. Replacing it with a use of the new setter lets subclasses use either approach. Bug: 1077366 Change-Id: Idf08cfd6fc5b359f1c97340d1e736142e2f650b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179929 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#765323}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a6d7f56cf84f..07328ba0bbce git log a6d7f56cf84f..07328ba0bbce --date=short --first-parent --format='%ad %ae %s' 2020-05-04 yunchao.he@intel.com Add validation tests for texture resource tracking - 2 2020-05-04 yunchao.he@intel.com Add validation code for texture subresource usage tracking Created with: gclient setdep -r src/third_party/dawn@07328ba0bbce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I58e49e295adf909f2190ae1accae29a060dbd1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765322}
-
Vladimir Levin authored
This patch ensures that when we unlock the element in the beforematch event, we still update style and layout. The activate function is only used for bookkeeping and I will be removing it, so we should not be relying on its return value in order to decide whether we need an up-to-date layout. R=jarhar@chromium.org, chrishtr@chromium.org Change-Id: Iffbaae5229bddc78e41b4d0aa1cc15c4a3ad6429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180115Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#765321}
-
Mike Dougherty authored
TBR=sczs@chromium.org Bug: 1078165 Change-Id: I946f4a85ff35980776f81086bc32071514198254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181469Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#765320}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/701ccf97c959..dad6a940e108 git log 701ccf97c959..dad6a940e108 --date=short --first-parent --format='%ad %ae %s' 2020-05-04 landrey@webrtc.org Add helper frame generator factories for the pc framework tests. 2020-05-04 tommi@webrtc.org Add support for PendingTaskSafetyFlag to ToQueuedTask. 2020-05-04 tommi@webrtc.org Introduce a RunLoop class that supports the TaskQueue interface 2020-05-04 marinaciocea@webrtc.org Add unit tests for audio channel send frame transformer delegate. 2020-05-04 philipel@webrtc.org Removed unused function EncodedFrame::SetEncodedSize. Created with: gclient setdep -r src/third_party/webrtc@dad6a940e108 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I83f4aef3cc0842dd5c45cde4ac07facbe6686aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765319}
-
Clark DuVall authored
This changes the hardcoded package ID from 0x02 to 0x05, which allows for other shared libraries to be loaded before WebLayer. This change calls addAssetPath on the AssetManager to increment the package ID until we hit our magic 0x05. Each call needs to use a different path and the path has to be a valid asset path, so we prepend a string of "/." to the WebView package's source dir. This also fixes crbug.com/1075704 by hardcoding the package IDs of the locale resources to 0x05, which will load them at the same ID the main APK will be loaded. This also prevents each split from taking a new dynamic ID. Bug: 1075704, 1075789 Change-Id: I671d0ad64a3025409a62ecebbdbc584819d68ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174964Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#765318}
-
Peter Kasting authored
Now that Notify() is not in a subclass, there's no need for a distinct Iterator class; all its functionality can be done inside Notify(). Bug: none Change-Id: I962182306b09ad4fe4138179a033f7b8d2d9a1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174159 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#765317}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ec46670..1363c04b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3693371a2eabf4a7886789ef80698850b369dbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765316}
-
John Delaney authored
This change routes the initiator_routing_id for the frame that initiates a navigation to the NavigationRequest. This is only set on a subset of navigations as some renderer initiated navigations are not associated with an initiating frame, such as drag-and-drop navs. The initiator RenderFrameHost is not guaranteed to exist by the time the navigation is processed by the browser process because the frame's deletion may have been scheduled prior to the navigation. For this reason, the initiator_frame does not replace |CommonNavigationParams.initiator_origin|. This routing id is used to verify the top-level origin that an impression occurred on for the Conversion Measurement API, rather than relying on sending the origin from the renderer. This usage is also implemented in this change. BUg: 1059959 Change-Id: I8ab6d443a864cd72447d50a7d5a0588b68a19c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090095 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#765315}
-
Peng Huang authored
Change-Id: I2b04b0afccfd4a5d6416a454ef531404deab0b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181493 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#765314}
-
Peter Kasting authored
Removes ability to re-entrantly Notify() inside Notify(). No one used this, it made the code more complex, and it's not clear what the caller would expect the ordering to be. Also, minor changes that shouldn't have a visible functional effect: * Expose "CallbackType" template arg as an alias for user convenience * Replace DISALLOW_COPY_AND_ASSIGN with explicit deletions * Attempt to improve variable/method names * Remove Subscription::IsCancelled(), which was only used in one test (and not very critically there) * Make CallbackList::Iterator non-copyable; then, * Replace |active_iterator_count_| with a simple bool * Replace CallbackList subclass with a type alias * Use in-declaration initializers and =default more * Use preincrement where possible (this is not a style rule, willing to revert if you hate this) * Eliminate some unnecessary explicit unique_ptr::reset() calls at scope ends * Use "CallbackListTest" as the test name for all CallbackList tests Bug: none Change-Id: I11d3a5ef975d4618acc9c883d27fd1da422b5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174158 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#765313}
-
Rachel Carpenter authored
At the moment child accounts do not see the help app open after OOBE, which is not the desired behaviour. Bug: b/155444436 Change-Id: Ia73ff0f301b6bb7a6f25f7d710dd0aab28abe8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172734Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#765312}
-
Rachel Carpenter authored
Change-Id: I2f6b078917b7008cab8f88731258de00ad179ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172235Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#765311}
-
Felipe Cerqueira authored
Bug: 1077860 Change-Id: Ia6d5baded8a15b8ba8458576f6dc8c71a822f4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180802Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Cr-Commit-Position: refs/heads/master@{#765310}
-
Raymond Toy authored
Support k-rate input to the AudioParms for a DynamicsCompressorNode. The node only has k-rate AudioParams so we just need to make sure the input is used. Manually ran this test on Chrome stable, and all tests fail as expected since k-rate inputs are not working there. Bug: 1015760 Test: k-rate-dynamics-compressor-connections.html Change-Id: I9ddaf27be5f2fef65f394f3d63f1fa8998c0ed82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145814Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#765309}
-
Anastasia Helfinstein authored
Currently has only one method, contentsAreEqual, which compares arrays based on whether they have equal elements in the same order. This is not currently used, but will be used by Switch Access in a follow-up change. AX-Relnotes: n/a. Bug: None Change-Id: Ib80a33ab4ac400d07794c5a1355b460f6b070a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#765308}
-
Stephen Chenney authored
When converting the source rect for canvas drawImage with an oriented image we must supply the uncropped image size as the reference size for the correction method. The test fails due to a lack of fuzzy matching in WPT. The result is basically correct. TBR: fserb@chromium.org Bug: 1074354 Change-Id: If9acd8c6ab7473cfa93018856aad059426584c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180863 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#765307}
-
Brandon Wylie authored
New tab pages skip reparenting logic, as a result they're left in memory and cause crashes. Additional logic introduced into TabModelImpl#destroy checks each tab to see if it's in the process of being reparented. Any tab that's not being reparented is destroyed instead. Bug: 1076799 Change-Id: I7919902c768d0d823e1ba463690acb9136ecbcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174904Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#765306}
-
haozhe authored
This patch added the transition generation which described in the spec: https://drafts.csswg.org/css-transitions-2/#current-transition-generation-section For two transitions with the same owning element (including the pseudo-element selector), this patch will sort animation1 and animation2 first by their transition generations, then in ascending order by the Unicode codepoints that make up the expanded transition property name of each transition The spec: https://drafts.csswg.org/css-transitions-2/#animation-composite-order Bug: 1072480, 1068740 Change-Id: I0f54f676befd250082b2323723ba2b71e2931b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157682 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#765305}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c2d329cabe8..4271443d7e44 git log 3c2d329cabe8..4271443d7e44 --date=short --first-parent --format='%ad %ae %s' 2020-05-04 spang@chromium.org Fix VulkanExternalImageTest on SwiftShader 2020-05-04 jonahr@google.com Fix issue with missing step info in generate_stats.py 2020-05-04 spang@chromium.org Vulkan: Move ICD overrides to a common place Created with: gclient setdep -r src/third_party/angle@4271443d7e44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I22969eda7600e2bdf243983b3f08d7c484813198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765304}
-
Omer Katz authored
If an object is reached by the concurrent marker while it is in construction, there is no sync between the threads resulting in a race. Bug: 986235 Change-Id: I235d292b30ad737e04e563de3120ade04dc84a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179546 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#765303}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I01ef99521cfb83bf547e170cb68044a6efede6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181072Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765302}
-
Stephen McGruer authored
This just causes large unnecessary exponential back-offs when a ChangeId doesn't exist. Bug: None Change-Id: Iae16e8da24871f53bb1bba7793a929beb0d7ebae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180911Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#765301}
-
Jeevan Shikaram authored
This CL moves the digital_asset_links folder from chrome/browser/android to chrome/browser/installable as it will now be used on Chrome OS as well. Bug: 1026469 Change-Id: I31941fa2dc4cf97e33d27d6784a1571ffc9300e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162402Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#765300}
-
Thomas Lukaszewicz authored
Updated a several views_examples to use string constants. Cleaned up some unnecessary code. Bug: None Change-Id: Ic793e5cb05902eba4ec19b4f66cc8c7f98cd97ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173830 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#765299}
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 1078140 Change-Id: I95b24261916ca5158bbc00f106ef489a9615e592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180870Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#765298}
-
George Steel authored
Add new CSSAnimationUtils class with a static method KeyframeValueFromComputedStyle() which returns the true computed value for all properties. This mostly calls CSSValueForComputedStyle() without a LayoutObject, but the cases where this does not return the computed value (line-height and transform) are handles separately, similarly to the implementation of ComputedStyleMap. This method does take a LayoutObject, but it is only used to resolve matrix interpolation of box-size-dependent transform values, which produces a deferred compilation which cannot be serialized directly in the current spec. Make Animation.commitStyles() use this new function instead of committing the resolved value using CSSValueFromComputedStyle(). Add additional WPT tests for commitStyles() adding tests for special-case properties and splitting the logical properties case. Bug: 1056197, 1057307 Change-Id: Ic823f96f257d4c6b010dfee758d4ac0b5cd4148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118765 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#765297}
-
Hongchan Choi authored
Per rtoy@ on the issue: There are two unrelated promises here and we got confused on when they resolve. The fix for the test is to call task.done when resolving the promise from decodeAudioData, not from loadFileFromUrl. Bug: 839126 Test: web_tests/webaudio/AudioBufferSource/audiobuffersource-loop-points.html Change-Id: I2882b4e735692ce4227ea7ce2241dcd33a81800e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180110Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#765296}
-