- 19 Jul, 2017 40 commits
-
-
Tien-Ren Chen authored
This reverts commit a207e0dd. Reason for revert: Lint error in downstream code. Original change's description: > Android: Re-enable lint > > Android lint has been failing due to API level mismatch between lint and > platform-tools (26 vs 25). This is causing new lint errors to be > introduced. Ignore the API mismatch for now and re-enable lint so it at > least catches all other issues. > > API warning will be re-enabled after platform-tools is rolled. > > Bug: 739746,746409 > Change-Id: I339560498544462732300c5030381a0c67f25f1b > Reviewed-on: https://chromium-review.googlesource.com/577593 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487918} TBR=mthiesse@chromium.org,wnwen@chromium.org,agrieve@chromium.org Change-Id: I4857cf1ba5f10b009155693a803df922036f1878 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739746, 746409 Reviewed-on: https://chromium-review.googlesource.com/578059Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487983}
-
Mike Reed authored
In preparation for https://skia-review.googlesource.com/c/24644/8 NOTRY=True Bug: 746578 Change-Id: Ia5a59056598e6db62ca2417eaddc2a783d4625b4 Reviewed-on: https://chromium-review.googlesource.com/578487 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#487982}
-
Steven Bennetts authored
Bug: Change-Id: I5f05a943778b6a56abf5535cd0d2b43389ef733f Reviewed-on: https://chromium-review.googlesource.com/577723 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#487981}
-
Sunny Sachanandani authored
This is responsible for a major video playback regression on android webview. Revert "gpu: Allow empty sync tokens in mailboxes." This reverts commit d698cc2f. Revert "cc: Explicitly set sync tokens for mailbox resources." This reverts commit 61b4a9e4. TBR=piman,sandersd Bug: 745941 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8609150bf4b2069010e2f7c8cb5fd6f75f95acf8 Reviewed-on: https://chromium-review.googlesource.com/577990 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#487980}
-
rbpotter authored
Move all chrome.send calls to the native layer Rename native layer functions to match names of messages being sent. Bug: 717296 Change-Id: Ie69391d107183c4fd0e97339d4014ea89f1181e3 Reviewed-on: https://chromium-review.googlesource.com/575374Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#487979}
-
Dominic Mazzoni authored
In change r484950 (https://codereview.chromium.org/2967193003), AXNodeObject::ComputeAriaOwnsChildren was modified to handle both ARIA attributes and AOM properties. The change resulted in calling AxObjectCache().UpdateAriaOwns() with an empty vector in a case where it wasn't called before, and when calling it on an element with no Node (like on an anonymous block, for example), that led to a crash. Fix that by only calling it when GetNode() is valid. Bug: 740375 Change-Id: I058c9760e600e3e582778788a12950cbbeeb77a9 Reviewed-on: https://chromium-review.googlesource.com/574765Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#487978}
-
Will Chen authored
Bug: none Change-Id: I38806a0f1bd878e9e7e51c7dc95b833488ac7754 Reviewed-on: https://chromium-review.googlesource.com/578310Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#487977}
-
Istiaque Ahmed authored
BookmarksIOFunction used to retrieve default path in FILE thread. Use a task with traits: 1. MayBlock: Since this requires IO 2. USER_VISIBLE: As this is part of importing/exporting bookmarks. 3. SKIP_ON_SHUTDOWN: There's no point to continue on or block shutdown because additional operations are required (e.g. showing a file select dialog) for this to complete. Bug: 689520 Change-Id: Ibed8ea5213ca71f07a47cbb4e2c45cadeb9da429 Reviewed-on: https://chromium-review.googlesource.com/577112 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487976}
-
lesliewatkins authored
Renamed TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks. BUG=672263,735642 Review-Url: https://codereview.chromium.org/2957043002 Cr-Commit-Position: refs/heads/master@{#487975}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0c15ae82f0d5..edfe4a5ca018 $ git log 0c15ae82f..edfe4a5ca --date=short --no-merges --format='%ad %ae %s' 2017-07-19 borenet [infra] Add protoc asset 2017-07-19 ethannicholas run skslc output through clang-format 2017-07-19 bsalomon Remove GrLegacyMeshDrawOp and GrPipelineBuilder 2017-07-19 fmalita Revert "Use raster pipeline for repeat/mirror radial gradients" 2017-07-19 bsalomon Fix Google3 Roller? 2017-07-19 bsalomon Move GrTypesPriv.h to include/private 2017-07-19 fmalita Use raster pipeline for repeat/mirror radial gradients Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I2c56cc2aeb11acba1586fb643118f244c2a849b5 Reviewed-on: https://chromium-review.googlesource.com/578322Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487974}
-
Ryan Hansberry authored
Bug: 738540 Change-Id: If0782f8983263d500285de3c986de180c268f2b3 Reviewed-on: https://chromium-review.googlesource.com/575762Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487973}
-
Mike Reed authored
Bug:skia:6828 Change-Id: I8456ac491ce4f140349545ba086cc0a1ba0d1f4c TBR= removing unused param (null) Change-Id: I8456ac491ce4f140349545ba086cc0a1ba0d1f4c Reviewed-on: https://chromium-review.googlesource.com/577668 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#487972}
-
Weidong Guo authored
Changes: 1. Makes the launcher go back to PEEKING state when you click close button in HALF mode. 2. Modifies the corresponding unit test. BUG=745156 TEST=SearchBoxViewFullscreenTest.CloseButtonTest Change-Id: I12b6743cdf49ddbac254004d053d60db2df602e5 Reviewed-on: https://chromium-review.googlesource.com/576115 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487971}
-
Bill Orr authored
The WebVR 1.1 spec was updated to clarify the behavior of getFrameData. Now, GetFrameData should return false unless called within a VRDisplay.requestAnimationFrame callback. BUG=736023 Change-Id: I14d9442a016817a78232ed7b1e71956c8dac614a Reviewed-on: https://chromium-review.googlesource.com/578188Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487970}
-
Sergio Collazos authored
Revert "[Payment Request] Adds tests for accessibility on main pages of Paymnet Request - Second Relanding" This reverts commit c7c107f1. Reason for revert: payments_accessibility_egtest Tests are failing on various devices: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/12117/steps/steps/logs/stdio https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/5818/steps/ios_chrome_ui_egtests%20%28iPad%20Air%20iOS%2010.0.1%29%20on%20iOS-10.0.1/logs/stdio I tried to run the test locally and they are failing as well Original change's description: > [Payment Request] Adds tests for accessibility on main pages of Paymnet Request - Second Relanding > > > The previous reland of this CL did not include the command line arguments for one of the build bots. > This reland adds the command line argument for that build bot. > > TBR=lpromero@chromium.org,michaeldo@google.com > > Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 734571 > > Change-Id: If9fd7b6d2741178b307c3c51763cc89fdcb44073 > Reviewed-on: https://chromium-review.googlesource.com/574690 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: mahmadi <mahmadi@chromium.org> > Commit-Queue: Randall Raymond <rayraymond@google.com> > Cr-Commit-Position: refs/heads/master@{#487861} TBR=eugenebut@chromium.org,rayraymond@google.com,mahmadi@chromium.org Change-Id: Icaea64b4801e9240c4daa25933c65149b3e051d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Reviewed-on: https://chromium-review.googlesource.com/578135Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#487969}
-
Matthew Halpern authored
This CL enables GlobalResourceCoordinator (e.g. resource_coordinator service, GRC) by default. Several projects depend on the GRC service. Features using GRC should be guarded by their own feature flag and run their own finch trials. Several fixes needed to occur to make this happen: - Remove buggy GRC process CPU profiling infrastructure. An updated version will be added in: https://chromium-review.googlesource.com/c/565906/ - Improve MockRenderProcessHost to allow GetProcessResourceCoordinator to be called with connections to the test ServiceManager - ResourceCoordinatorWebContentsObserver::IsEnabled checks to make sure ServiceManagerConnection is available to connect to. - Disable FrameResourceCoordinator because WebFrameClient subclasses do not implement GetInterfaceProvider and crash when being called. This CL has been extended and migrated from CodeReview: https://codereview.chromium.org/2958133003 which was originally being landed on behalf of zhenw@: https://codereview.chromium.org/2943563002 R=oysteine@chromium.org, zhenw@chromium.org,lpy@chromium.org,rockot@chromium.org,nasko@chromium.org BUG=691886 patch from issue 2958133003 at patchset 710001 (http://crrev.com/2958133003#ps710001) Change-Id: Ie6b61e93666ba9e753a218a79e2cff64646e7644 Reviewed-on: https://chromium-review.googlesource.com/572429 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#487968}
-
Paul Jensen authored
When disconnecting the main HttpURLConnection, close the OutputStream if it has not yet been closed (e.g. when enterUploadErrorState() is called). BUG=745870 Change-Id: I16930d0b3dd17d8d17c36e90cd5c1fe8d6f86964 Reviewed-on: https://chromium-review.googlesource.com/575275 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#487967}
-
Lucas Furukawa Gadani authored
Bug: 655753 Change-Id: I756aada2893846878657fe33b405bdb70b23df54 Reviewed-on: https://chromium-review.googlesource.com/576207 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#487966}
-
chrome://net-exportEric Roman authored
There is an option to configure the maximum size of the NetLog. The default is 100MiB. This is a re-land of https://chromium-review.googlesource.com/c/571514/ Bug: 679030 Change-Id: I79eb7e6012deb0979b94a1c0f487068e7800105b Reviewed-on: https://chromium-review.googlesource.com/578048 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487965}
-
Shakti Sahu authored
This CL fixes an issue where the controller converts the required task start time to seconds which causes the OS to sometimes schedule the task a fraction of second before the entry is expired. In that case the file monitor won't remove the file as the entry is still not expired. Also once the cleanup is done, we should check if we have more COMPLETE entries for which we have to schedule cleanup. Bug: Change-Id: Id2f1a6a236dfd3a60f460d463419974d79e73d38 Reviewed-on: https://chromium-review.googlesource.com/576890 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#487964}
-
John Bauman authored
This seems to fix the black flashing that was happening with the extension popup UI. WS_EX_COMPOSITED was originally hiding this issue in most cases (except possibly http://crbug.com/586454 ), possibly because it didn't allow GDI painting outside of WM_PAINT (like is happening here). Bug: 739724 Change-Id: I897deedb3bf7f2c2ff799cb24a98e0f94f835ea9 Reviewed-on: https://chromium-review.googlesource.com/564147Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ananta Iyengar <ananta@chromium.org> Commit-Queue: John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487963}
-
Steven Valdez authored
Bug: Change-Id: I398b76a5424d3a4fb66ec78a58855a87cf914ba7 Reviewed-on: https://chromium-review.googlesource.com/575269Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487962}
-
Matt Mueller authored
Bug: 90277 Change-Id: If7168191fc8c80acc45831731f016494ba4352ba Reviewed-on: https://chromium-review.googlesource.com/576767Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#487961}
-
wutao authored
Skia Blur image filter has a new mode to clamp pixels outside image to image edge. This can resolve the bleeding black issue at the bounds of texture. BUG=622128 TEST=manual tested with lock screen and new app launcher. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id13383910327882d61bd908bff51d2c3fdc36bb9 Reviewed-on: https://chromium-review.googlesource.com/559935 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487960}
-
Hayley Ferr authored
So we don't lose data in the debugging visualization in DebugRectHistory::SaveTouchEventHandlerRectsCallback, we now iterate through the rects independently from each touch action as opposed to using the union of these values. DebugRect stores a TouchAction bit that is populated within SaveTouchEventHandlerRectsCallback. In HeadsUpDisplayLayerImpl::DrawDebugRects, the |debug_rects|'s touch action is added to the HeadsUpDisplayLayerImpl::DrawDebugRect's label in the case |debug_rects|'s type is TOUCH_EVENT_HANDLER_RECT_TYPE. Bug: Change-Id: I7af79e490481b485b11601f7c44cf290d5707e46 Reviewed-on: https://chromium-review.googlesource.com/571032 Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487959}
-
Chris Harrelson authored
for low-end Android devices. TBR=piman@chromium.org Bug: 746018 Change-Id: I40f0dbddd1efc8a751fc3d48c97446e1f04bbeeb Reviewed-on: https://chromium-review.googlesource.com/576607 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#487958}
-
Hayley Ferr authored
Added an UMA_HISTOGRAM_ENUMERATION to report how often we hit each touch action. Bug: 745718 Change-Id: I21d48c48a30f5b7699b078212ae105d34506c156 Reviewed-on: https://chromium-review.googlesource.com/571270Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487957}
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClinet, as preparation to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I2c326050e48dae5671a796f152c7e723ccba601d Reviewed-on: https://chromium-review.googlesource.com/570119 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487956}
-
Tom Anderson authored
BUG=575778 TBR=dpranke@chromium.org NOTRY=true Change-Id: I7fd31e3bd0b2d35e3a26b49a1a85c45b3efd7315 Reviewed-on: https://chromium-review.googlesource.com/578442Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487955}
-
Scott Little authored
These two tests are flaky on the Linux ChromiumOS bot: https://uberchromegw.corp.google.com/i/chromium.chromiumos/waterfall?show=Linux%20ChromiumOS%20Tests%20(1) TBR=zork@chromium.org Bug: 746526 Change-Id: Id2bcf3b9ece0fb25efeff129569d8e96e598ba52 Reviewed-on: https://chromium-review.googlesource.com/578319Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#487954}
-
Fernando Serboncini authored
Also, disabes HarfBuzz's atomic refptr TSan warning Bug: 730692 Change-Id: I69c7fd5ab20896b6abd864506ae394732f8aa6e1 Reviewed-on: https://chromium-review.googlesource.com/544625 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#487953}
-
Jian Li authored
Move the downloaded archive file from download directory into the offline pages archive directory and create the metadata record for it in offline pages metadata database such that it can be opened as an offline page. BUG=738199 TEST=new tests Change-Id: I548e3cfe93f962f8533918384e5205e94a55e5bf Reviewed-on: https://chromium-review.googlesource.com/557159 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#487952}
-
Scott Chen authored
Bug: 741897 Change-Id: I7577fb447f90f83db283b5712bdf3e9fca390889 Reviewed-on: https://chromium-review.googlesource.com/574684 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487951}
-
Christopher Grant authored
BUG=739999 Change-Id: Id184dec6bee3723435ecab66048b071cb8a6b127 Reviewed-on: https://chromium-review.googlesource.com/577954Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#487950}
-
Scott Violet authored
WindowTreeHostManager has a special code path when the primary display changes to an existing display. This gets that code path working for mus. BUG=none TEST=covered by tests Change-Id: I5558a93303eeb9ca6a8f3c6769661d71d92d97fe Reviewed-on: https://chromium-review.googlesource.com/576399Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487949}
-
Eric Roman authored
Bug: 679030 Change-Id: If8794e2432994b88deb28e0edc2b38a986f07cbb Reviewed-on: https://chromium-review.googlesource.com/576747 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#487948}
-
Kyle Horimoto authored
This notification is not actually shown by the Tether component yet; this functionality will be part of a follow-up CL. Bug: 672263, 740635 Change-Id: Ic9b40af6a90631fbc0624b39375224e8d2f6221a Reviewed-on: https://chromium-review.googlesource.com/577063 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487947}
-
Elly Fong-Jones authored
During browser startup or shutdown, there may be no tabs on the TabStripModel while the browser's menu has already been created. In this case, it isn't safe to ask the model about its active tab, so don't. Bug: 730002 Change-Id: I18dfa17228dc061685dd62ba000d1607c6995290 Reviewed-on: https://chromium-review.googlesource.com/575876 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487946}
-
Toni Barzic authored
Enables lock scree apps for dev channel, and adds a flag that can be used to enable the feature to chrome://flags: * enable-lock-screen-apps enables lock screen apps BUG=715781 Change-Id: I3a4638d16af1585b6c18445ee7f405e55b0c2db5 Reviewed-on: https://chromium-review.googlesource.com/576658Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#487945}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=tommi@chromium.org Review-Url: https://codereview.chromium.org/2977633004 Cr-Commit-Position: refs/heads/master@{#487944}
-