- 13 Aug, 2020 40 commits
-
-
Naomi Musgrave authored
chrome/services/sharing/nearby/decoder/nearby_decoder_unittest.cc chrome/browser/nearby_sharing/nearby_sharing_service_impl.cc - Update usage of advertisement field to new name chrome/services/sharing/public/* - Rename advertisement field to be more accurate - Update comments to be more detailed This is a follow-on to feedback raised on Ia384e12083a590f52beb1f98d50b192ab20f31cd Bug: 1084582 Change-Id: If5a3c40ee0ad33de01bd5c4322078c4fa9b206c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352893Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Cr-Commit-Position: refs/heads/master@{#797687}
-
Joe DeBlasio authored
This CL adds a learn more link to the Safety Tip infobar on Android that matches the one used on Desktop. It broadly mirrors what was done previously with the PermissionInfoBar. Fixed: 1096550 Change-Id: I0581be14695fec9793183489b4aae4e9e08c2bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353424Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#797686}
-
Dan Harrington authored
Bug: 1115137 Change-Id: I4c17c8c50ef19b84cf7af8b7e19879a890670e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348700Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797685}
-
Amr Aboelkher authored
EXPECT_DEATH isnt supported in Chromium. Thus the tests associated with it, needs to be removed. Especially, in the mentioned tests, its no need to rewrite them. Bug: chromium:1100129 Change-Id: I0aae13e83c6b4bbc0b7112e523148712e2ff432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270549Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#797684}
-
Miyoung Shin authored
This CL adds |useMojo| parameter to JavascriptInjector that would default to false and using RemoteObjectInjector method in JavascriptInjectorImpl#addPossiblyUnsafeInterface() if useMojo is true. We will add useMojo for the rest of the code when RemoteObjectInjector#removeInterface is implemented and it is available for JavascriptInjectorImpl. This change adds usage of mojom interfaces and methods, and the binary size increase is caused by generated Java bindings. Java bindings improvements (including size optimizations) are captured in https://bugs.chromium.org/u/2764092486/hotlists/java-bindings. Bug: 1105927 Binary-Size: Size increase is unavoidable (see above). Change-Id: I5d9c6d83084b3a72812382e5cbe8011a37e938e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331988Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#797683}
-
Alex Turner authored
This will improve performance when the identifiability study is not enabled. Bug: 1102934 Change-Id: Icbbd72ff0b470ebcf762bcf04754919f568ec1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337254Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbee93ac203d..e1360ddcec9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icea628be2aaf0dde7aa59e8b1c02857332db5b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797681}
-
Nohemi Fernandez authored
This method is no longer used, clean up sign-in utilities. Bug: 1103274 Change-Id: I2b5a68c869d723e2216ab41fdf984948ce5b1eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352804 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797680}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fec8e60ea3e4..df9ed89229db 2020-08-13 johnstiles@google.com Fix logic error in GrProcessorSet::dumpProcessors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ia8f7136457cc9d0efdb2d4416187876a929db6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797679}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1360ddcec9e..b19e07ebf92c 2020-08-13 taylori@google.com Merge "Add WebUSB error" 2020-08-13 fmayer@google.com Move PackageFromLocation to freestanding function. 2020-08-13 fmayer@google.com Add messaging to APK list. 2020-08-13 fmayer@google.com Merge "Introduce GlobalStackProfileTracker." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:159987908 Tbr: perfetto-bugs@google.com Change-Id: Id505925a99ede35650e0f91b8b05876ecaf04beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797678}
-
Yann Dago authored
Bug: 1115696 Change-Id: I75b402d78827a415243c3c11946f1ca17baf7605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353362Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#797677}
-
Stephen Sigwart authored
Some web pages will have a login page that adds an MFA input after the initial username and password submission. When doing so, they set the submitted POST values as the username and password values. If autofill had a different password, but same username, it would overwrite the password field. This causes the password to be invalid when submitted with the MFA unless the user manually enters the original password again. Bug: 1101599 Change-Id: I316283ed09b7f7a9cb754a5246aff8a322ebbe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280603 Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#797676}
-
Monica Basta authored
This CL adds support for device policies and adjusts UI accordingly. Bug: 1063856 Change-Id: Ibccfc34f6fdf588f704e8a7fe8c5818dfb2c0f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352190 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797675}
-
Varun Khaneja authored
When a user who can turn on Enhanced Protection runs Safety Check, they'll be informed that Enhanced Protection is available to them. Before: http://screen/NL1GrepiSiq After : http://screen/YkD3EQy7OS8 Fixed: 1103016 Change-Id: I364b9c47e79c1a4f7f501078f9dd670166fdc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343569 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797674}
-
Richard Knoll authored
This makes the conversions from Mojo Metadata Types available to be used by the NearbySharingService to avoid code duplication. Bug: 1085067 Change-Id: I42457e358fff3b02f7045d2788544c8bb636e066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349628Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797673}
-
Chris Lu authored
Bug: 1071914 Change-Id: I27d71af8635d3c232a4f1562a7da5c61431efee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324884Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#797672}
-
Robbie Gibson authored
The basic idea here is to factor out the match creation methods. On iOS 14, if the clipboard contains content, we create a blank match of the correct type (one without any destination_url). Then, when the match is selected for opening, we can ask the clipboard_provider for a new match using the proper text, and open that one instead. For other platforms, we can keep using the old method, where we access the clipboard immediately and construct the destination_url at match creation time. iOS 14 also uses this behavior if there is cached clipboard content. Bug: 1105869 Change-Id: I70d26f4bcc485e4dc9073db2257161355adc8a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346290 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797671}
-
Mohamed Heikal authored
This reverts commit b7d6ada4. Reason for revert: broke internal CQ because the internal repo wasnt actually "fixed" Original change's description: > Make android_deps material design private > > Usages in internal repo have been fixed, so we should make the real > material design target private and only allow access to the public > alias. > > Bug: 1110346 > Change-Id: Id9bf2b705d51ef95eac6b2154c1d796369e4ec7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347957 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797656} TBR=wnwen@chromium.org,mheikal@chromium.org Change-Id: I7fd1d36dc5b432d49ed7d5305676cb35f924e192 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354275Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797670}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4a486be696b4..2b1c0b0e92e7 2020-08-13 jiawei.shao@intel.com Clean up BufferZeroInitTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I739f3b608b86fdedac4591a702465e85ebffbbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797669}
-
Bret Sepulveda authored
TBR=estark@chromium.org Bug: 1115551 Change-Id: Ic5351b9eef808df37718b1a8581414db9c270070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353335Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797668}
-
Aaron Leventhal authored
Fixes regression from CL:2142611 where a menuitem inside of a group no longer gets an accessible name. This was due to moving kMenuButton inside the NameFromContents() switch, such that it would no longer get a name from contents. Currently, a role=menuitem inside a role=group gets remapped to kMenuButton via AXObject::RemapAriaRoleDueToParent(). The purpose of remapping menuitem inside of a group to kMenuButton is to expose it as AXMenuButton instead of AXMenuItem on OS, per CORE-AAM. This remapping may be removed in the future, and is an open issue in CORE-AAM. See https://github.com/w3c/core-aam/issues/78 Bug: 1114712 Change-Id: Iae23b2351e72486e1cf3bf4b96ce1ff283e4ad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353019Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797667}
-
Miguel Casas authored
VaapiWrapper has two lists to store the VABufferIDs waiting to be sent to vaRenderPicture(): |pending_slice_bufs_| and |pending_va_bufs_|. Both are created and manipulated at the same time and in the same ways, so this CL merges them into a single vector. Bug: b:162962069 Change-Id: I6403be0b55e746a829b90fa79a9c922eef68832c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353014Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797666}
-
Miguel Casas authored
To help finding performance hotspots. (This is mostly for tracing the vaCreateBuffer() call -- since it allocates a BO, it needs to clear it and takes a bit of time; the question is how much, compared to video decoding in vaEndPicture()). Bug: b:162962069 Change-Id: Icde7df8f44c36065c04e5e55e2f9866e73197e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353015 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#797665}
-
Friedrich Horschig authored
This CL ensures all primary change buttons have properly aligned icons. Screenshot in the bug. Bug: 1115117, 1092444 Change-Id: I3c60600f27e209d261fd727d20708a19ffbd5fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353332Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797664}
-
Bret Sepulveda authored
TBR=corising@chromium.org Bug: 1115950 Change-Id: Ib81a1d2937db2783cbd9e65a3f79f4e160ab6b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352917Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797663}
-
Tal Pressman authored
Frames for non-ordinary pages don't report signals (such as FMP or onload). They also have no parent frame, so they are considered main frames, and they use arbitrary agent cluster IDs. This can create situations where we will "affect" queues forever. The solution is to not add such frames to the "waiting for signal" set. This avoids waiting for them indefinitely, while also not throttling them. The CL also changes it so that we don't try affect queues not associated with a frame (i.e.: have no FrameScheduler), as those are "global" queues that are not associated with a single agent. Bug: 1090251,1115389 Change-Id: I8e624626694aa5aded7bce1ab6243c57eb69ebd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352584 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797662}
-
Jérôme Lebel authored
+ Updating SigninSSOIdentityListRequestCacheState enum + NotPopulated in SigninSSOIdentityListRequestDurationCacheState suffix This patch is required for crrev.com/i/3208484 (which uses the cache APIs from SSOService). Bug: 897470 Change-Id: I59794f8838b75bc7f72e26afe1500f8fd176415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346666 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797661}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597298325-7a1b28e7d249f4f2f87ee413bc832fdaab0b39d9.profdata to chrome-mac-master-1597319582-be9645d468b25404b91084b442e1381733e63a51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I4dbc6a5be8c981262d10f14d327df0e62677163e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797660}
-
Arthur Sonzogni authored
This reverts commit 1fb711f6. Reason for revert: https://crbug.com/1115935 Original change's description: > Reland "service worker: Use mojo version of GetUserDataForAllRegistrations" > > This is a reland of 853e0dd9 > > The original CL was reverted due to a data race. The race was fixed > in crrev.com/c/2340297 > > Original change's description: > > service worker: Use mojo version of GetUserDataForAllRegistrations > > > > This CL starts using mojo version of > > GetUserDataForAllRegistrations{,ByKeyPrefix}(). > > > > The type of the return value of these methods is also changed from > > map<registration_id, value> to array<ServiceWorkerUserData>, > > and ServiceWorkerUserData now has registration_id. > > These changes are required to handle a situation where a > > registration_id is associated with multiple values. Some features like > > payments could associate multiple values for a registration_id. > > > > Bug: 1055677 > > Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376 > > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794447} > > Bug: 1055677 > Change-Id: I9f9ea4f6deb9953c4b18af941e6e8b70b66afb66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340417 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795690} TBR=falken@chromium.org,kinuko@chromium.org,bashi@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1055677 Change-Id: I73617bc2236730c6729c8b7af5621594bde5065d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353451Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797659}
-
Anatoliy Potapchuk authored
This test was flaky because sometimes it was going to the network confingure screen(because there was no network), now we are always online. Bug: 964333 Change-Id: I397a873e7a0393a5646993475b934f226661e9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352889Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797658}
-
Rouslan Solomakhin authored
This patch adds a Mojo IPC method to invoke the TWA payment app in ARC. Bug: 1061503 Change-Id: I617460dc1313de5c9968c215eac7022f64d6108d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245644 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#797657}
-
Mohamed Heikal authored
Usages in internal repo have been fixed, so we should make the real material design target private and only allow access to the public alias. Bug: 1110346 Change-Id: Id9bf2b705d51ef95eac6b2154c1d796369e4ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347957 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797656}
-
Bret Sepulveda authored
Failing on Chrome OS. TBR=avi@chromium.org Bug: 1115886 Change-Id: Ia9d3e8861e6ee7685d21a2a8a324b7328756c979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352816Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797655}
-
Dominic Battre authored
Passwords can be keyed by multiple subdomains and it is important to support all of them. Bug: 1095627 Change-Id: I952bd06cb5a7f7123d149787613c4335ccdeff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352933 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797654}
-
Omar Morsi authored
This CL separates non service-related definitions from platform_keys_service.h Bug: 1115581 Change-Id: Ic9912960009968b9d348c72217b3523d531dafc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352793Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#797653}
-
Florent Castelli authored
The parameter is not optional and has never really been optional as calls would fail with empty values. Bug: 803494 Change-Id: I44a2f25b9368f9759f296a95d9ad878de1292faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351836Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797652}
-
Rouslan Solomakhin authored
This reverts https://crrev.com/c/2351959, https://crrev.com/c/2345928, https://crrev.com/c/2302970, and https://crrev.com/c/2257090 because they are causing hard-to-diagnose crashes in production for a feature that is supposed to be still turned off. The patches should be relanded with more test coverage. TBR=jdragon.bae@gmail.com, manukh@chromium.org, maxlg@chromium.org Bug: 1114556, 1052493 Change-Id: Ic221c99e28246676d24bcd2185773657abef4781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354149 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86c9a7134948..522a635391bd 2020-08-13 szuend@chromium.org [ts] Type-check ui/ProgressIndiciator.js with TypeScript 2020-08-13 szuend@chromium.org Revert "Reland "eliminate initial timeout in waitForFunction"" 2020-08-13 szuend@chromium.org [ts] Type-check ui/FilterSuggestionBuilder.js with TypeScript 2020-08-13 szuend@chromium.org [ts] Type-check ui/DropTarget.js with TypeScript 2020-08-13 patrick.brosset@microsoft.com Copy formatted HTML when the console selection contains a table 2020-08-13 jobay@google.com Reland "eliminate initial timeout in waitForFunction" 2020-08-13 kimanh@chromium.org Gate dwarf extension api behind wasmDWARFDebugging experiment flag 2020-08-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1112346,chromium:1112692,chromium:1115011 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6d61142415b9561157dd1456e19b443d4250c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797650}
-
Francois Beaufort authored
This CL makes sure initialized callback from the MediaStream constructor is called asynchronously as it was causing a JavaScript crash potentially caused by the fact that the MediaStream was not completely registered with oilpan. Bug: 1114398 Change-Id: If6058b183bdd07fa747d810efe0f6abed4914e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352800Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#797649}
-
Rainhard Findling authored
* The current translation screenshot presubmit check flags messages which got modified but for which no new translation screenshot got uploaded. It thereby also flags messages that got modified, but of which the message content itself did not change. This is the case, for example, if only the message description for translators got changed. * This CL restricts the translation screenshot presubmit flagging modified messages. It will trigger 1) if the message did not have a screenshot at all so far, or 2) if the message content itself changed. Only changing the non-visible part of a message that already has a translation screenshot does not trigger it anymore. Bug: 1103844 Change-Id: I254ce2a7267a7d2308b606b16d080c74188d582b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328669 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797648}
-