GitLab

Add baked-in Domain Reliability configs for {drive,mail}.google.com.

BUG=356791

Review URL: https://codereview.chromium.org/278773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269609 0039d316-1c4b-4281-b951-d872f2087c98

Trying to get rid of more globals in ui/compositor.

BUG=None

Review URL: https://codereview.chromium.org/277713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269608 0039d316-1c4b-4281-b951-d872f2087c98

This test was writing to the user's downloads directory instead of a
temporary path.

BUG=372017
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/274193008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371655

Review URL: https://codereview.chromium.org/271573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269606 0039d316-1c4b-4281-b951-d872f2087c98

Also includes a few small cleanup changes I noticed while I was in there.

BUG=108012

Review URL: https://codereview.chromium.org/261843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269605 0039d316-1c4b-4281-b951-d872f2087c98

If wrong notification is received, NOTREACHED() is called.

BUG=None
R=benwells@chromium.org

Review URL: https://codereview.chromium.org/263833019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269604 0039d316-1c4b-4281-b951-d872f2087c98

During Chrome shutdown, DeviceMonitorMac deallocs
CrAVFoundationDeviceObserver, which is registered as an
observer of suspended and connected events on the
CrAVCaptureDevice. Every so seldom (see bugs), the
removal of these observers causes a crash. Observers
removal seems to be a long standing problem with
Cocoa and Objective-C++.

This CL speculates with a solution for this trouble
via testing if the protocol method -observationInfo [1]
is not |nil| before removing the observers. This is
based on the observation that:
a) There might be an AVFoundation-internal race
between observer removal and AVCaptureDevice destruction.
b) A previous, unrelated Chrome crash might have
left the AVFoundation into some unstable meta state.
(This is based on xians@ hitting this bug during
browser_tests).

Tested locally and seems to work fine.

BUG=288562, 371271


[1] https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Protocols/NSKeyValueObserving_Protocol/Reference/Reference.html#jumpTo_10

Review URL: https://codereview.chromium.org/274073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269603 0039d316-1c4b-4281-b951-d872f2087c98

When StartupTimebomb goes off, collect the duration stats (difference
between when the timebomb went off and when it is started). We collect
this duration in terms of clock time, montonic clock time and thread CPU
time.

BUG=366699
R=jar@chromium.org

Review URL: https://codereview.chromium.org/273963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269602 0039d316-1c4b-4281-b951-d872f2087c98

ChromeStringCanonicalizer does case and diacritic insensitive string
comparison through an ICU Collator. To get general Unicode character
rules, the root locale should be used. The system default locale is
different from system to system, and using that will cause the code to
break when executed on a system where it doesn't have the properties
that this code assumes.

This change also adds #include statemens for all ICU header files from
which the code in this file uses declarations.

R=rouslan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/275913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269601 0039d316-1c4b-4281-b951-d872f2087c98

Check for NULL |activation_client| in ExtensionPopup::OnWidgetDestroying.

Add a BrowserActionInteractiveTest that crashes without this fix.
Add a BrowserActionTestUtil::InspectPopup helper on Views.

BUG=327776
TEST=Inspecting an extension popup bubble and closing the underlying browser window does not crash.
R=sky@chromium.org,finnur@chromium.org

Review URL: https://codereview.chromium.org/275783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269600 0039d316-1c4b-4281-b951-d872f2087c98

URLFixerUpper may potentially mishandle "about:blank".
The suspicion arose from crbug.com/371030 investigations.
(this unit test case doesn't seem to trigger that, though)

BUG=NONE
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/279593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318769

Review URL: https://codereview.chromium.org/207743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269598 0039d316-1c4b-4281-b951-d872f2087c98

The task manager is a CustomFrameView. This had the logic for its button
placement hardcoded. The view now adds itself as a listener for button
configuration changes on linux. For other systems it falls back on a
default set that matches the current (minimize, maximize, close) order.

The layout of the buttons has changed to consult this order definition.

Loading the assets for the close button has been moved out of layout.
ResourceBundle only loads the asset once, so this can be done during
initialization.

The top padding for the buttons has been updated to provide more spacing. It now fits the rest of the padding in the class.

TEST=CustomFrameViewTest
BUG=351917

Review URL: https://codereview.chromium.org/240163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269597 0039d316-1c4b-4281-b951-d872f2087c98

This matches the current ChromeOS implementation.

BUG=355788
R=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/279503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269596 0039d316-1c4b-4281-b951-d872f2087c98

using Java conversion functions.  This is part of making it possible
to build net/ without ICU, to get binary size down when building net/
as a library

BUG=362608

Review URL: https://codereview.chromium.org/266053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269595 0039d316-1c4b-4281-b951-d872f2087c98

Main thread animations provide no guarantees that the initial fling timestamp
will be strictly positive.  Consequently, a (valid) timestamp of 0 applied to
Android's fling animation curve will yield a zero-sized scroll delta.  Feeding
this scroll delta through WebViewImpl reports that scrolling is impossible, in
which case the fling will early terminate.  Avoid this case by early returning
on non-positive fling timestamps, aligning with Aura's fling behavior.

BUG=371854

Review URL: https://codereview.chromium.org/275113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269594 0039d316-1c4b-4281-b951-d872f2087c98

This variant relies on checking if a drag input window still has capture before releasing the grab.
A better alternative is in CL https://codereview.chromium.org/262893002/.

BUG=363503
TEST=Follow the exact steps in the bug description.
TEST=interactive_ui_tests --gtest_filter=*TabDragging*

Review URL: https://codereview.chromium.org/265843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269593 0039d316-1c4b-4281-b951-d872f2087c98

Someone noticed that occasionally the uploader sent an empty upload. I
looked into the scheduler and found that it was clearing the "upload
pending" bit early, when the upload was scheduled. This meant that if a
beacon arrived between scheduling and starting the upload, the bit was
still set on its behalf, despite it being included in the upload. Once
the upload finished, the scheduler would see the bit still set and
schedule another.

This patch adds a couple of unittests for interesting interleavings
(beacons that arrive between scheduling and starting the upload, and
between starting and finishing the upload), and clears the upload
pending bit in the right place.

BUG=356791

Review URL: https://codereview.chromium.org/272773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269592 0039d316-1c4b-4281-b951-d872f2087c98

> With ongoing work on fixing bugs and performance in D3D11, as well
> as blacklisting old drviers, we might have more stable results on
> Intel. If possible we can narrow down ranges of crashing configs
> and blacklist those individually.
>
> BUG=363721

BUG=369475

Review URL: https://codereview.chromium.org/273723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269591 0039d316-1c4b-4281-b951-d872f2087c98

Remove API version 1 of the credentials passing API and rename version 2
to version 1. This renumbering is backwards-incompatible and would break
any existing users of API version 1. However, the API is still under
development and thee are no users yet. Thus, we should take the
opportunity to remove the cruft of an obsolete experimental API version
before we release anything to the public.

BUG=367847
TEST=Updated browser test
TBR=nkostylev

Review URL: https://codereview.chromium.org/276903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269590 0039d316-1c4b-4281-b951-d872f2087c98

This logs:
a boolean telling the AudioInputController is getting the recording data after an input stream was started.

This is symmetric to AudioOutputControllerPlaybackStartupSuccess on the output side.

NOTRY=true
BUG=357501

Review URL: https://codereview.chromium.org/271093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269589 0039d316-1c4b-4281-b951-d872f2087c98

Spinoff of patch https://codereview.chromium.org/250143002/

For trivial change in chrome/utility/media_galleries/media_metadata_parser.cc:
TBR=vandebo

BUG=304290

Review URL: https://codereview.chromium.org/270873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359299
TEST=valgrind unittests
TBR=zork@chromium.org

Review URL: https://codereview.chromium.org/273623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269587 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/273303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269586 0039d316-1c4b-4281-b951-d872f2087c98

Managing observer lists is needed by all the tests that end up calling
DownloadItem::AddObserver. This CL adds real observers to
MockDownloadItem so that tests don't need to mock this behavior.

BUG=367311

Review URL: https://codereview.chromium.org/248713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269584 0039d316-1c4b-4281-b951-d872f2087c98

If a user blacklists or unblacklists a site in a separate tab, we need
to correctly update every other tab's state (consider the unlikely case
of logging into the same site 8 times at the same time in separate tabs,
or the slightly less unlikely case of changing status in
chrome://settings/passwords while a login page is visible). This CL updates
the observer logic to account for blacklist entries being added and removed
from the PasswordStore, and updates the UI accordingly.

---------------------------------------------------------------------------
This is a reland of r269244, which was reverted due to LSAN breakage.
Original review at https://codereview.chromium.org/276683003/
---------------------------------------------------------------------------

BUG=261628
TBR=vabr@chromium.org

Review URL: https://codereview.chromium.org/276583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269583 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=72&start=14665
TBR=
BUG=

Review URL: https://codereview.chromium.org/274103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361809

Review URL: https://codereview.chromium.org/278593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269581 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tdresser@chromium.org
BUG=372143
TEST=waterfall

Review URL: https://codereview.chromium.org/278173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269580 0039d316-1c4b-4281-b951-d872f2087c98

The atomic number of rubidium.
The normal human body temperature in degrees Celsius.
A television channel reserved for radioastronomy in the United States.
+37 was the international dialing code of the German Democratic Republic (aka East Germany).

R=kareng@google.com

Review URL: https://codereview.chromium.org/272273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269579 0039d316-1c4b-4281-b951-d872f2087c98

This removes the use of a static initializer and makes it possible
for clients to pass a key without owning the memory where the
key is stored (as would be the case if passed to a static const char*).

BUG=371626, 371204

Review URL: https://codereview.chromium.org/279633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269578 0039d316-1c4b-4281-b951-d872f2087c98

This makes it so the buttons can be seen against the dark background.

TBR=oshima
BUG=339558

Review URL: https://codereview.chromium.org/274013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367198

Review URL: https://codereview.chromium.org/270823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269576 0039d316-1c4b-4281-b951-d872f2087c98

ContentViewCore.java:
Before: real 1m25.705s
After: real 0m0.257s

There was a few overly cautious "non-greedy" terminations, and a few optional
matches outside their respective optional blocks.

BUG=371520

Review URL: https://codereview.chromium.org/277753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269575 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/255713008/

BUG=

Review URL: https://codereview.chromium.org/278453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269574 0039d316-1c4b-4281-b951-d872f2087c98

- Uses ScopedTempDir to remove dependency on TestingProfile.
- Uses test::TestBookmarkClient to remove dependency on MessageLoop,
  BookmarkModelFactory, TestingProfile, TestBrowserThreadBundle

BUG=367836

Review URL: https://codereview.chromium.org/273663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269573 0039d316-1c4b-4281-b951-d872f2087c98

The reason to provide default implementations for these methods
is that so an embedder that wants to use bookmarks and doesn't need/want
favicons or omnibox-related methods doesn't even have to think about what
to provide as implementations for them.

BUG=367707

Review URL: https://codereview.chromium.org/274063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269572 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables WebContentsObserver::OnMessageReceived to receive
a reference to RenderFrameHost that received the message.

This allows passing of JavaBridgeDispatcherHostManager ownership from
WebContentsImpl to ContentViewCore and removing of some redundant
initialization code in JavaBridgeDispatcherHostManager, fixing
a long-standing TODO.

This patch also includes a fix for "Search Google for this image"
discovered shorly after the original patch has been landed.

BUG=371296
TBR=jam@chromium.org,benm@chromium.org,yoz@chromium.org,bauerb@chromium.org,fsamuel@chromium.org

Review URL: https://codereview.chromium.org/275873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269571 0039d316-1c4b-4281-b951-d872f2087c98

Instead of bundling up the ozone stuff into the larger gfx.gyp:gfx target,
split up the ozone-related code into a smaller gfx_ozone target with a
small dependency (base, skia). This allows ozone-platforms to implement
the ozone interface without bringing along the rest of gfx.

BUG=361137
R=rjkroege@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/271303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269570 0039d316-1c4b-4281-b951-d872f2087c98