- 16 Feb, 2019 21 commits
-
-
Sidney San Martín authored
Bug: 932667 Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48 Reviewed-on: https://chromium-review.googlesource.com/c/1476105 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#632846}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 714018 Change-Id: Ie683d238342805faad81db7a54899f8955828eef Reviewed-on: https://chromium-review.googlesource.com/c/1475643 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#632845}
-
Sigurd Schneider authored
Exposing v8.h in blink headers increases coupling in chromium and requires defines from V8 to be present in all includers of those blink headers. This CL removes "v8/include/v8.h from three headers and moves it into .cc files instead. Bug: v8:8788 Change-Id: I1f3e172e414d53cc01493f4ca36ad5a3bad00987 Reviewed-on: https://chromium-review.googlesource.com/c/1475176 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632844}
-
Andres Calderon Jaramillo authored
This CL expands the GpuInfo structure to be able to convey information about what image profiles the hardware supports for the purpose of image decode acceleration. The eventual plan is to fill-in this information in GpuServiceImpl::UpdateGPUInfo(). On the client side, ImageDecodeAcceleratorProxy will be able to use it through GpuChannelHost::gpu_info() to determine what images can be sent to the service for decoding. Bug: 868400 Change-Id: I790a438c6c64ed418d0ac3bb9cfedd14286fe78f Reviewed-on: https://chromium-review.googlesource.com/c/1471913 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#632843}
-
Jinsuk Kim authored
In-product help system was determined not to be launched. This CL reverts https://crrev.com/2943983003 which added the functionality for media download. Bug: 715185, 889682 Change-Id: I7478eb2438023febd894560b18b6c380f81577e2 Reviewed-on: https://chromium-review.googlesource.com/c/1367065Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#632842}
-
Mike Dougherty authored
Tapping a universal link while in off the record mode should not open a native application because it shares the private state with the launched app. Bug: 861752 Change-Id: I578caf10e6ea0cf3978d1d7177ec01c71631e5ce Reviewed-on: https://chromium-review.googlesource.com/c/1436489 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#632841}
-
Scott Violet authored
This is only necessary when running in tests. BUG=none TEST=covered by tests Change-Id: Ifa5aeace0ee9623e9392b2fb0912e1c2be7d6005 Reviewed-on: https://chromium-review.googlesource.com/c/1476032 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#632840}
-
Khushal authored
We currently disable using GrContextOptions::PersistentCache if program binary caching needs to be disabled for a workaround. Since skia can now be configured to enable caching the SKSL -> GLSL conversion while disabling program binary caching, allow the persistent cache to be used for that. R=ericrk@chromium.org Bug: 924572 Change-Id: Iad1f60ae7c59809e20b3a5c9c54afd54aa825c63 Reviewed-on: https://chromium-review.googlesource.com/c/1476061 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#632839}
-
Mostyn Bramley-Moore authored
I assume that the pre-existing ldflags setting is a simple translation of linkopts = ["-lz"] from the source bazel BUILD file- which has a comment saying it should be replaced because it's non-hermetic. We have a hermetic zlib in chromium, so let's use it. Change-Id: I3b794b910be88ef34a8d5d13f4e06fb46f30e7c0 Reviewed-on: https://chromium-review.googlesource.com/c/1475188Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#632838}
-
Scott Violet authored
BUG=929914 TEST=none Change-Id: I9174b13bd634ac2e69e5478e5acfe91262c9679a Reviewed-on: https://chromium-review.googlesource.com/c/1475938 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c77e0e0. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." c3f69282 "New wpt tests for absolute position" 969e37ec "Revert "New wpt tests for absolute position"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ibd553075083cb9f66a717e6352923c06511b147e Reviewed-on: https://chromium-review.googlesource.com/c/1474988Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632836}
-
Takuto Ikuta authored
Change-Id: I2c39dbbd2a48cb2ce91333e03d876eae3342abdd Reviewed-on: https://chromium-review.googlesource.com/c/1475145Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af2885953ccf..6fb3f3d8f171 Created with: gclient setdep -r src-internal@6fb3f3d8f171 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I82d772a9bf3ca14bc8588b124d84ad6ef7cd9d95 Reviewed-on: https://chromium-review.googlesource.com/c/1475657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632834}
-
Ian Kilpatrick authored
This was hiding a bug where we'd always hit the cache even if a min-inline-size changed. E.g. min-width: 30% -> min-width: 40%. Subsequently the InlineLengthMayChange() function called with MinLogicalWidth() was incorrect as an "min-width: auto" shouldn't return true if the available size changes. Bug: 635619 Change-Id: If28d8f70874331c02762bb66c0891a7aa60517e6 Reviewed-on: https://chromium-review.googlesource.com/c/1474548 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#632833}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/34fb6244cfec..27e1a74fc2aa git log 34fb6244cfec..27e1a74fc2aa --date=short --no-merges --format='%ad %ae %s' 2019-02-15 tsepez@chromium.org Do not initialize V8 in pdfium_test if --disable-javascript. 2019-02-15 tsepez@chromium.org Fix assertion !pValue.IsEmpty() in cfxjse_value.cpp. Created with: gclient setdep -r src/third_party/pdfium@27e1a74fc2aa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0514caf5cc28a041a88171776c2f9ce6236d980b Reviewed-on: https://chromium-review.googlesource.com/c/1475658Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632832}
-
Boris Sazonov authored
This CL removes 'Preload pages…' toggle from SyncAndServicesPreferences, moving it back to Privacy preferences page. It also reorders preference rows in PrivacyPreferences if UnifiedConsent is enabled, putting 'Preload pages…' below 'Access payment methods' row. Title and summary of 'Preload pages…' in PrivacyPreferences are also updated. Bug: 925884 Change-Id: Ifcc58d71ecc6e22781ff5319a442e6293e086a22 Reviewed-on: https://chromium-review.googlesource.com/c/1472697Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#632831}
-
chrome://ntp-tiles-internalsKristi Park authored
Fix chrome://ntp-tiles-internals so that the tile source will be shown a CUSTOM_LINKS instead of WHITELIST. Also add a section to indicate that the current tiles are custom links. Screenshot: https://screenshot.googleplex.com/jXqpZMvJjgH.png Change-Id: I41e3f5b5f4b0bf72ee8c75cee6e06b0193f78480 Reviewed-on: https://chromium-review.googlesource.com/c/1469068 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#632830}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efc7e91fa764..6344e8c6379b git log efc7e91fa764..6344e8c6379b --date=short --no-merges --format='%ad %ae %s' 2019-02-15 iannucci@chromium.org [recipes] Manual roll Created with: gclient setdep -r src/third_party/depot_tools@6344e8c6379b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:932738,chromium:914992 TBR=agable@chromium.org Change-Id: I03236f6a95ab58077b208e31985c92945a979989 Reviewed-on: https://chromium-review.googlesource.com/c/1475663Reviewed-by:
-
Joel Hockey authored
Crostini shared folders are enabled by default in M73. Flag removed in 74. Bug: 878324 Change-Id: I300f5c13c46a4df23ae5f08be5746fc79a20f07a Reviewed-on: https://chromium-review.googlesource.com/c/1475010Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#632828}
-
Lei Zhang authored
This is part of the process to help migrate base::JSONReader::ReadToValue() to return base::Optional<base::Value>. BUG=925165 Change-Id: I7754b1631a14bd3a30782fbbbb542e5cec897f0e Reviewed-on: https://chromium-review.googlesource.com/c/1474515 Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#632827}
-
Hiroshige Hayashizaki authored
Bug: none Change-Id: I815b94ca78d8ea2cc1648fb571f10b9428d9f603 Reviewed-on: https://chromium-review.googlesource.com/c/1406179Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632826}
-
- 15 Feb, 2019 19 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I246ac0c08f177e3a47610d2b363b1e149db3c378 Reviewed-on: https://chromium-review.googlesource.com/c/1475656Reviewed-by:
-
Aleks Totic authored
Only behavioral change is keeping track of placed elements. This will be important in future CL. This CL is part 3/X of placing Legacy contained OOF Elements by NG. Bug: 907911 Change-Id: I5fb2c1e777bee3310239d7673211c6c6e08b3200 Reviewed-on: https://chromium-review.googlesource.com/c/1474538Reviewed-by:
-
Bill Orr authored
This change allows getting position and orientation data through Windows Mixed Reality APIs. It also adds optional fields to the XRFrameData mojo struct for updating per-frame eye offsets and eye parameters. Bug: 928812 Change-Id: Ic38271348ae5ee8472952da342837b5f8a25432b Reviewed-on: https://chromium-review.googlesource.com/c/1457724 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#632823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd091589..8d1908ec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f500cd3af370b7a5806210ae6a27bf85a0df8c5 Reviewed-on: https://chromium-review.googlesource.com/c/1474987Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632822}
-
khmel@chromium.org authored
TEST=Unit test BUG=915316 Change-Id: I19637f8a6266f99ecbc04dff01a53e149f6aa94e Reviewed-on: https://chromium-review.googlesource.com/c/1475887Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#632821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/685ea8d6f03c..2b0f8cfb7440 git log 685ea8d6f03c..2b0f8cfb7440 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 dhanyaganesh@chromium.org Revert "repository: FetchAll -> RepairMissingRemotes." Created with: gclient setdep -r src/third_party/chromite@2b0f8cfb7440 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I85bdcf6b0d43743d5cf6ede4eb916e343e8a658c Reviewed-on: https://chromium-review.googlesource.com/c/1475749Reviewed-by:
-
Alexei Filippov authored
The C++ thread_local is slightly faster while making the code clear. Besides that calls to TlsGetValue on Windows may alter the result of GetLastError, thus changing behavior of the underlying code. BUG=920440 Change-Id: Ic89632f4a54f35d58b93cdecfffc68fc1a94dac1 Reviewed-on: https://chromium-review.googlesource.com/c/1461681Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#632819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aead8edf8c46..b6c1c66d2547 git log aead8edf8c46..b6c1c66d2547 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 courtneygo@google.com Vulkan: Discard scissor if either dimension is 0 2019-02-15 jonahr@google.com Refactor ANGLE's extensions struct to more easily represent multiple 2019-02-15 enrico.galli@intel.com ES31: Add atomic counter buffer support to D3D11 renderer Created with: gclient setdep -r src/third_party/angle@b6c1c66d2547 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2ebcae5e84035ed8472d69d72857486e838db1c1 Reviewed-on: https://chromium-review.googlesource.com/c/1475197Reviewed-by:
-
John Abd-El-Malek authored
Add a test to verify the renderer doesn't hang if it's making a sync XHR and the network process crashes. Bug: 932305 Change-Id: I8fb8b0bb0f1fdf36583f75b70112c60ab9669174 Reviewed-on: https://chromium-review.googlesource.com/c/1474265Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632817}
-
Hiroshige Hayashizaki authored
Previously, if the encoding returned by XMLHttpRequest::FinalResponseCharset() is invalid, Latin-1 encoding was used due to the logic in TextResourceDecoder::DefaultEncoding(). After this CL, the encoding determined by the latter half of XMLHttpRequest::CreateDecoder() is used in such cases, which is UTF-8 for text. Bug: 905968 Change-Id: I04e6ae524b8e1d3abd21e4a7a10279eb5638a58c Reviewed-on: https://chromium-review.googlesource.com/c/1342813 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#632816}
-
Ian Kilpatrick authored
This also makes the function accept a LayoutBlock instead as well. Unittests which call NGConstraintSpace::CreateFromLayoutObject on a LayoutObject are updated to ensure that the LayoutObject is a new formatting context. Should have no behaviour change. Change-Id: Ibaeffaecd47b37474fc426f80b006592a3257de8 Reviewed-on: https://chromium-review.googlesource.com/c/1473393 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This saves 448 (of 2928) bytes per in-flow layout recursion [*]. This part of the code uses a lot of stack, because of quite a few local variables, but also due to a CHECK(), which alone costs 272 bytes [*]. It's the "child_bfc_block_offset.value()" line that contains the CHECK(has_value()). Fun fact: The compiler would have optimized away the CHECK if our code had called has_value() on its own first. [*] Linux 64bit release. Bug: 930637 Change-Id: I3afe43e8d72e5432b3ff9c3c113ce4f8067b873f Reviewed-on: https://chromium-review.googlesource.com/c/1472619 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632814}
-
manuk authored
When the clipboard contains large text, certain user interactions with the omnibox (e.g. right click) exhibit a significant delay. Previously, when the clipboard contained more than 32*1024 characters, we skipped classifying the text and disabled the 'Paste and Go / Search' context menu item as those were the largest sources of delay. However, at around 130 million characters, sanitizing the text begins to contribute significant delay (3-4 seconds) as well. Additionally, certain user actions fetch and sanitize the clipboard text multiple times; e.g., right clicking the omnibox fetches the clipboard 5 times; then selecting 'paste' fetches the clipboard 2 additional times; these calls accumulate an ~18 second delay. This CL: (1) removes the earlier truncations and (2) instead truncates the clipboard text when it is fetched, and therefore before it is sanitized. Additionally, (3) it increased the truncation length to url::kMaxURLChars (2*1024*1024) characters. This is sufficient to keep the right click delay under 9 seconds while also leaving greater safe room for potentially long URLs (google images serves data URLs up to at least 30k characters). Bug: 543675 Change-Id: I8c3df3dc262747d57e37cd766d84efa12d8d94ee Reviewed-on: https://chromium-review.googlesource.com/c/1474192 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632813}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/f8925d027884..e4dfc9f1b583 $ git log f8925d027..e4dfc9f1b --date=short --no-merges --format='%ad %ae %s' 2019-02-14 pwnall Remove MSBuild section from AppVeyor config. 2019-02-14 costan Replace TEST_CASE with TEST_SUITE. (#29) 2019-01-15 costan Update Travis CI config and dependencies. (#27) 2018-11-15 costan Add shared library mode to Travis CI. (#24) 2018-11-14 coryan Support shared libraries. (#23) 2018-10-23 costan Fix Travis CI for Mac. (#22) 2018-07-23 costan Update dependencies and bump GCC to 8. (#20) Created with: roll-dep src/third_party/crc32c/src Bug: 925652 Change-Id: Ie5a2309b4b81134fa68e1d393fbec6796c84e6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1475748 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632812}
-
Aga Wronska authored
ConfigSource is responsible for delivering access code configuration and ParentAccessService does not depend directly on the source. PolicyConfigSource implements getting configuration from the user policy. Bug: 911326, 921147 Change-Id: I186e6e3c58b0692558907b91185fffb78188e5c3 Reviewed-on: https://chromium-review.googlesource.com/c/1469424Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#632811}
-
Adam Langley authored
Seems like we're going to want to make this more generic to cope with PIN support. Change-Id: I230f317e364a8072b02ffe577b33232c5b9b9786 Reviewed-on: https://chromium-review.googlesource.com/c/1475008 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#632810}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 714018 Change-Id: I6b26b0eb43cb5167e8c115781c956bfe13d6bdfc Reviewed-on: https://chromium-review.googlesource.com/c/1475637 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#632809}
-
Harley Li authored
The specification [1] states that each object store may have a key generator [2]. This is essentially a counter that works exactly like the counters used by SQL's auto-incremented primary keys. [1] https://w3c.github.io/IndexedDB [2] https://w3c.github.io/IndexedDB/#key-generator In the test: the key generator's value is only bumped if it is used, so the first "key generator value" is 1, and the second is not 1. Bug: 929817 Change-Id: Iaf8d0dbf65e7de3de3163726d9791f4aad7048fd Reviewed-on: https://chromium-review.googlesource.com/c/1464968 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Siddhartha S authored
The shared database is implemented and new databases should directly use the shared version instead of using the unique, to avoid migration in the near future. Also, use enum instead of namespace and prefix strings. The actual prefix for identifying a database is also changed to numbers. The only string the api takes in is for UMA. The field trial will still use strings, but these will go away soon. BUG=870813 Change-Id: Id8b506424c66e3a744539838da8b565ca3ddb20d Reviewed-on: https://chromium-review.googlesource.com/c/1472070 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#632807}
-
