- 29 Aug, 2019 40 commits
-
-
Robert Sesek authored
This will replace //base/third_party/dmg_fp. dmg_fp takes at least one mutex for every conversion, which is sub-optimal for performance. The new double-conversion library comes from V8, and it is also used in Blink. A future CL will move Blink onto this copy in //base. Compatibility risk is high because things may rely on specific output output behaviors of the old implementation. Bug: 95729 Change-Id: I6b08093ff4e38e257629f1fcf1d4f095e170c24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698345 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#691618}
-
Yutaka Hirano authored
To resolve OOR-CORS blocking enterprise issues, this CL defines kExtraSafelistedHeaderNames. This is a very short term fix and violates layer in order to make it mergeable. We'll use it only for M77. This affects only the OOR-CORS enabled path. Bug: 999052 Change-Id: I66ab8f298ed761aa3d78d02fa521d1c08f492fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774010 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691617}
-
Robbie Gibson authored
The root cause was that the contentView of the grid cell was getting set to black, instead of the same as the top bar background color, causing a brief flicker to black as different views faded in and out. Also removes a now-unnecessary iOS 13 SDK compiler guard. Bug: 997165 Change-Id: I56ed43b35aa3f61a22df5b0abf9c1398a8e513f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771905Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#691616}
-
Max Moroz authored
This reverts commit 0d648721. Reason for revert: this didn't help, the iOS bots should either use the Chromium bundled Clang or don't build fuzzers Original change's description: > Revert "[base] Use FuzzedDataProvider included in LLVM package." > > This reverts commit 20d2671d. > > Reason for revert: Causes build failures on iOS bots, see: https://crbug.com/999096 > > Original change's description: > > [base] Use FuzzedDataProvider included in LLVM package. > > > > Bug: 991200 > > Change-Id: Iee88e3a81057d509e18a2875a3070c5abc17c959 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774303 > > Auto-Submit: Max Moroz <mmoroz@chromium.org> > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691207} > > TBR=thestig@chromium.org,mmoroz@chromium.org > > Change-Id: I044f8863f8fa7e2bb9e70b0f33e73fdd8bfa2a29 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 991200, 999096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776043 > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Commit-Queue: Oskar Sundbom <ossu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691575} TBR=thestig@chromium.org,mmoroz@chromium.org,ossu@chromium.org Change-Id: Ic811649e40c0932146f8fc275e142f47adc3f5f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991200, 999096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776203Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691615}
-
Christian Dullweber authored
Bug: 967668 Change-Id: I7c87919cc901d0e7253a49df510fe4cfc930ce30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776044 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#691614}
-
Peter Wen authored
This adds a guard rail metric for how long module installer framework code runs during startup. It allows us to measure the current state in the wild as well as improvements down the line. Also clean up references to the backend, moving static methods to instance methods. We end up initializing SplitInstallManagerFactory in recordModuleAvailability and also calling ModuleInstaller#init, so there was no benefit to keeping it a static method. Bug: 994030 Change-Id: I711d257fed83324202082a9947e4391da859e6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774100 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691613}
-
Nicolas Ouellet-Payeur authored
The `check_network_annotations' step on CQ now uses the `python_script' backend instead of the `clang_tool' backend, making it much faster and (hopefully) less flaky. Also changes the default backend to `python_script', when running traffic_annotation_auditor.exe locally. Bug: 966883 Change-Id: Icc608a15608418328774019d3ef25994201e3104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762747Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01615892494a..6dc3546ccbe4 git log 01615892494a..6dc3546ccbe4 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 lalitm@google.com trace_processor: add macro for generating zero boilerplate tables Created with: gclient setdep -r src/third_party/perfetto@6dc3546ccbe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I90acd29e29a52419a2350f8cb610a49e8cfc3241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691611}
-
Xida Chen authored
Most of the test cases in webkit-transform-interpolation-005.html are already covered in transform-interpolation-005.html, except for 2 test cases, and this CL ports those two cases to wpt. Bug: 900581 Change-Id: I4ef5d0322877a6820db686e1c8a54a89fec53bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775662Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691610}
-
Rayan Kanso authored
Bug: 997200 Change-Id: If0de01ac867d143a02870d5856dd97b9f7e4c0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773256Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691609}
-
Oskar Sundbom authored
It triggers MSAN errors. Fix is in progress. Tbr: thestig@chromium.org Bug: 999076 Change-Id: I98786def4ca52ef871a2061981c651a223b12f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776028 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691608}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56ab188a1a0a..fb8b9bf493bb Created with: gclient setdep -r src-internal@fb8b9bf493bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9d9415517f5bb7c1b8a8574c1d97ae2f8fc42b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691607}
-
Antonio Gomes authored
... now that its clients got Onion souped. BUG=787254, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I8092b60a41165d515ade8b1ac6e628c491168ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775004 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#691606}
-
Vadym Doroshenko authored
This CL replaces PasswordFormManager->NewPasswordFormManager. The main difference is that a constructor of form managers are different: PasswordFormManager takes PasswordForm NewPasswordFormManager takes FormData (which is converted to PasswordForm inside NewPasswordFormManager during parsing). Bug: 949519 Change-Id: I0db3bf7bffb8d0bf31bd2f2357b18a7466552f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774287Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#691605}
-
Jan Wilken Dörrie authored
This change implements using strong booleans for the creation of CredentialLeakTypes. These are implemented using util::StrongAlias, which increases type-safety and prevents accidental assignment between separate boolean parameters. Furthermore, this change performs some other small clean-ups. Bug: 986317 Change-Id: I5d08b634921d36abe5a8d1354398fb7a6761b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768353 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6dcd4dc56a9d..b4a6128e28a3 git log 6dcd4dc56a9d..b4a6128e28a3 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 nisse@webrtc.org Delete unneeded dependencies on libjingle_peerconnection_api 2019-08-29 philipel@webrtc.org Increased event log visualizer RTP clock estimation tolerance. 2019-08-29 srte@webrtc.org Fix for tsan failue in real time scenario tests. Created with: gclient setdep -r src/third_party/webrtc@b4a6128e28a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7c473df9af9d810a7f9551dc3977afee2a1e54da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775617Reviewed-by:
-
Ivana Zuzic authored
Since we're planning to launch the same editing activity in two different cases, a new generic interface for launching the editing activity and saving the changes on passwords has been added. It's called password_change_delegate. Two different delegates will implement it in two possible use cases. In the first use case the editing activity is launched from the password viewing activity or from the password list displayed in the saved password preferences. In that case the password entry already exists in the store and needs to be changed. In the second use case the editing activity is launched from the InfoBar when a new password was detected and still hasn't been saved in the store. In that case, another delegate will implement the interface and it will have to create new password records in the store. Because we can't rely on PasswordManagerPresenter persisting through the process, the delegate and the PasswordEntryBridge need to stay alive while the password editing activity exists. They need to be destroyed when the password editing activity is destroyed. Bug: 377410 Change-Id: I53be371375a590c9b928e98800b0be24a36f333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768524Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#691602}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e737ddc..2acf62ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36a1d5847c30339e3c9febaa3dbb46d196f8409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773413Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691601}
-
Antonio Gomes authored
This is phase 1.7 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Files were move to renderer/platform/peerconnection directly, and a factory header was added (namely [2]), so that content/ continue to access RTCVideoEncoder's functionality. [2] //t_p/blink/public/platform/modules/peerconnection/web_rtc_video_encoder_factory.h As part of the move to Blink, this CL also embeds the declaration of base::Feature "kWebRtcScreenshareSwEncoding" into rtc_video_encoder.cc|h, and remove the respective content declaration from [3]. [3] //content/public/common/content_features.cc|h BUG=787254 R=guidou@chromium.org, haraken@chromium.org TBR=kinuko@chromium.org Change-Id: Ibf3bc012443afd9d2112ab88133b41b844f00fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775002 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#691600}
-
Kent Tamura authored
This removes script_forbidden_scope.h dependency from platform/heap/handle.h. This CL reduces estimated pre-processed size of platform/heap/handle.h by 0.5MB. Bug: 242216 Change-Id: I901d582599ac0a5c581efb4fbe9faa76772bf0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775643Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#691599}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d20c5a52d62..fdfb44eeed33 git log 9d20c5a52d62..fdfb44eeed33 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 vapier@chromium.org cros_collections: workaround <=Python-2.7.8 bug Created with: gclient setdep -r src/third_party/chromite@fdfb44eeed33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2a364ce76f665ab7f8980766f48d550bae9c4f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775610Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ieedccdce0a024c6e985a3890d7a46c60adf17a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775612Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts LockHandleAssociatedPtr and LockHandleAssociatedPtrInfo to new Mojo types. It also updates Granted from lock_manager.mojom. Bug: 955171, 978694 Change-Id: I02ba0cdbe52f8f04b3e4514a1f335917db368559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771365 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691596}
-
Julie Jeongeun Kim authored
This CL converts BlobURLTokenRequest to new Mojo types. It updates ResolveForNavigation and Clone from blob_url_store.mojom and methods and members with new Mojo types. Bug: 955171, 978694 Change-Id: Ib18e1c3834e6b0c6129cd2c9b1f13930a06a909d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772791Reviewed-by:
-
Mohamed Abdelhalim authored
NavigationHandleImpl::GetDelegate usages are replaced by NavigationRequest::GetDelegate, and state_for_testing() is removed. Bug: 916537 Change-Id: Ib772f416453a471ce0cac8c917563060f57a3d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773148Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691594}
-
Himanshu Jaju authored
For pre-Q devices, remove the notification when device is unlocked since we are already showing the dialer. No changes made to Q flow. Bug: 995239 Change-Id: I58fb8dc334ad1e0a2f9d109aa225e596b24c0046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760731 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#691593}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7db900e2e78d..6dcd4dc56a9d git log 7db900e2e78d..6dcd4dc56a9d --date=short --no-merges --format='%ad %ae %s' 2019-08-29 nisse@webrtc.org New target for api/rtp_parameters.h and api/media_types.h. Created with: gclient setdep -r src/third_party/webrtc@6dcd4dc56a9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic4ae26fd88c5661fb7cb98a98b84ae7e9cfae8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775613Reviewed-by:
-
Pâris MEULEMAN authored
Sign-outs from native are triggered by profile updates: signin.allowed when set to false, google.services.username_pattern when set to a pattern incompatible with the current user. These policies apply only to managed devices and as such, on signout, the full profile must be cleaned up. Hence, this CL removes the attempt to check if the user is managed during a "Signout from native", as this status might be lost, and instead always forces the cleanup. User triggered SignOut is not impacted. Down the road these preferences, and all signin/signout flows, must be handled by the SigninManager and not internally by the IdentityManager, within |PrimaryAccountPolicyManager|. This will simplify the flow as well as avoid the "hidden" behavior coupling between policy and signin. This CL is created as a pre-cursor to the migration of SigninManager.java to IdentityManager.java as the observer ordering will be impacted. Bug: 934688 Change-Id: I5207e999aadb9a53b8dbdee9c8bc8e17edf6fe57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742153 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#691591}
-
Miyoung Shin authored
This CL converts UsbDevicePtr and UsbDeviceRequest in chrome, extensions, services and blink to the new Mojo types, and uses pending_receiver<UsbDevice> in usb_manager.mojom and web_usb_service.mojom Bug: 955171, 978694 Change-Id: Ib4b997ccbe43389d8e21e608626a057dc5afa925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773008 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/144ee522bc79..56ab188a1a0a Created with: gclient setdep -r src-internal@56ab188a1a0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3044e6dac987508fd478bbdc900f9a4338ea360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775608Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dd9f43487e19..01615892494a git log dd9f43487e19..01615892494a --date=short --no-merges --format='%ad %ae %s' 2019-08-29 treehugger-gerrit@google.com Merge "improve naming of parameterized heapprofd e2e tests" Created with: gclient setdep -r src/third_party/perfetto@01615892494a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I9fbd484552721041cadad027626c16fae173c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775609Reviewed-by:
-
Antonio Gomes authored
... by webrtc::::RTCStatsMemberInterface::Type This is a follow up of haraken@'s remark on [1]. [1] https://crrev.com/c/1772550/3/third_party/blink/renderer/platform/peerconnection/rtc_stats.cc@223 BUG=787254, 919392 R=haraken@chromium.org Change-Id: I32e74b03813ee324263070603c4582e564381ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772215 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Ivan Sandrk authored
After some security discussions, it was decided to wrap the RemoteCommand proto in an additional PolicyData proto layer. Update the code to reflect this. Also, enable secure remote commands again (they were temporarily disabled in crrev.com/c/1771781). Bug: 891222 Change-Id: I6439959cf4b5562b40870df9d9455bc6e5078203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774621 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691586}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58d77ccd..3e737ddc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebf7d74d8b7cb0197a8bd1dc2a1b320bed44f294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773412Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b46042d2a25..9b593a3406f4 git log 4b46042d2a25..9b593a3406f4 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 rmcilroy@chromium.org [Tracing] Add Main-Thread histograms to runtimeStatsTotalMetric. Created with: gclient setdep -r src/third_party/catapult@9b593a3406f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: Ifc2579544d1e60b758bcdb39de112d3886dc6ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775750Reviewed-by:
-
Dominic Farolino authored
This CL centralizes the cross-origin-prefetch-specific logic to PrefetchURLLoaderService, whereas previously it was split between PrefetchURLLoaderService and PrefetchURLLoader. This does not come with any observable change, however simplifies the implementation in a way that will make the preload-header-on-prefetch code cleaner. This CL also eliminates the PrefetchURLLoaderService::CreateLoaderAndStart method that was called from the network::mojom::URLLoaderFactory override, leaving only the URLLoaderFactory override method left. This is much cleaner, as both were not necessary now that the network service has been enabled by default. Bug: 939317 Change-Id: I06b57222ea02a4ac9594eec1f89700a1011655b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775646 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit 55420155. Reason for revert: I have rolled back one suspect change. Enabling the test again to verify it was indeed the culprit. Original change's description: > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan > > The test is disabled due to high flakiness. > > TBR: treib@chromium.org > Bug: 997912 > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690763} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997912 Change-Id: I275345a29e2917d5abe5a402fa03cac0d107703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774630Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#691582}
-
Fergal Daly authored
The fix is to always observe the entire container of elements so that if it comes onscreen, we sync. Also remove ResizeObversers on the elements as the cases it was defending against (suddenly expanding onto the screen) are covered by observing the container. Bug: 998480 Change-Id: I0c253453e0b2f642d686c7213a11d152c1f8330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774008Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691581}
-
Rob Buis authored
Implement the interface mixin between HTML/SVG/etc as specified here: https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement Note that the intention is to rename above HTMLOrSVGElement to HTMLOrForeignElement: https://github.com/whatwg/html/issues/4702 This also removes NoncedElement. Matches WebKit and Firefox. Bug: 835571 Change-Id: I98c7fcf4c081bdee1a861138e03155a77ca37161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655789 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#691580}
-
Findit authored
This reverts commit 06a7200b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 691574 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA2YTcyMDBiMzcwZjM4ZjM5Yzk3YTQ4MTBkMDkzMWFiNTU5NjAxNGUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/51573 Sample Failed Step: compile Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Change-Id: I2dcce548233f9cd12bd144a5a2ed613ec2fe31cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 978694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775676 Cr-Commit-Position: refs/heads/master@{#691579}
-
