- 09 Nov, 2018 40 commits
-
-
Guido Urdaneta authored
This CL adds resizeMode support for MediaStreamTrack.getConstraints() and marks resizeMode as a supported constrainable property. Support for getUserMedia(), applyConstraints() and getCapabilities() will be added in follow-up CLs in this series. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3 Reviewed-on: https://chromium-review.googlesource.com/c/1309749Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#606856}
-
Eugene But authored
Before this CL PageLoaded was called right from didFailProvisionalNavigation:, where URL may still represent the previous page. Bug: 903497 Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a Reviewed-on: https://chromium-review.googlesource.com/c/1327608Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606855}
-
Eugene But authored
SadTabTabHelper now calls sadTabTabHelperDidHide: and sadTabTabHelper:didShowForRepeatedFailure: Bug: 901563 Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5 Reviewed-on: https://chromium-review.googlesource.com/c/1327167Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606854}
-
Pavel Shmakov authored
The code is restructured according to the high-level MVC picture, but low-level details such as view binding mechanism are not used, as it seems to be an overkill at this point. We can easily install those mechanisms in future should the model become more complicated. Verification is extracted to TrustedWebActivityVerifier in the controller layer. Several controllers observe verification and update the model. Several independent Views are observing the changes in the model and updating themselves accordingly. Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113 Reviewed-on: https://chromium-review.googlesource.com/c/1323069Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606853}
-
Tim Volodine authored
The idea of this CTS filter is similar to the filter we have for instrumentation tests, i.e. mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains failing tests and their corresponding issues / root causes. The current filter contains results from a local run for a subset of tests (the actual CTS is not running yet). The CTS filter also augments the instrumentation test filter for test coverage that is missing from instrumentation tests. BUG=903822,902330,841556 Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d Reviewed-on: https://chromium-review.googlesource.com/c/1319677 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#606852}
-
Rayan Kanso authored
Also sets up some useful testing helpers for future upload features. Bug: 774054 Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592 Reviewed-on: https://chromium-review.googlesource.com/c/1329149 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606851}
-
David Jean authored
And a common base class. Bug: 845472 Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb Reviewed-on: https://chromium-review.googlesource.com/c/1318914Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#606850}
-
Aaron Krajeski authored
Current canvas benchmarks only measure CPU time. Using requestAnimationFrame (raf) in javascript we can measure CPU + raster + GPU time. This CL adds a mode to blink_perf.py that runs canvas all canvas test in a way that takes raster and GPU time into account. Roughly doubles the duration of `blink_perf.canvas` benchmark from ~2 minutes to ~4 minutes on a linux desktop. Bug: 894043 Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc Reviewed-on: https://chromium-review.googlesource.com/c/1300038Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606849}
-
Marc Treib authored
Bug: 856179 Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df Reviewed-on: https://chromium-review.googlesource.com/c/1326901 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606848}
-
Anders Hartvoll Ruud authored
Utilizing CSSPropertyName, to make the code much nicer. R=futhark@chromium.org Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3 Reviewed-on: https://chromium-review.googlesource.com/c/1323650 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606847}
-
Hiroshige Hayashizaki authored
Also this CL replaces some of empty-worklet-script.js usage in CSP tests with empty-worklet-script-with-cors-header.js to make sure worklets are rejected due to CSP, not CORS. Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92 Reviewed-on: https://chromium-review.googlesource.com/c/1312146 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606846}
-
Anders Hartvoll Ruud authored
R=chrishtr@chromium.org Bug: 901938 Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7 Reviewed-on: https://chromium-review.googlesource.com/c/1318891 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606845}
-
Dave Tapuska authored
NotificationInlineReplies shipped in M70. BUG=834580 Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a Reviewed-on: https://chromium-review.googlesource.com/c/1323615Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606844}
-
Lukasz Suder authored
Before all details where asked each time. Bug: 806868 Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6 Reviewed-on: https://chromium-review.googlesource.com/c/1329167Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#606843}
-
Greg Thompson authored
A regression was introduced in r581520 that caused the wrong icon and/or the wrong coloring to be used in some circumstances. This CL fixes this in two parts: - AppMenuIconController may decide that the "annoyance level" from a pending update is too low to bother the user. One bug introduced in r581520 was that the controller still notified delegates that the UPGRADE_NOTIFICATION icon type should be used in this case. Now, the VERY_LOW annoyance level is ignore entirely for beta and stable channels. - AppMenuModel no longer bases its decision to include the upgrade menu item directly on the UpgradeDetector. Rather, it now queries the AppMenuIconController. This ensures that the same logic is used for both the badging of the app menu and for the presence of the upgrade item in the menu. BUG=898958 Change-Id: I4b761844365968a24bc69030d711122fcaf16e28 Reviewed-on: https://chromium-review.googlesource.com/c/1312475 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#606842}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 43d0eed3. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5 Reviewed-on: https://chromium-review.googlesource.com/c/1329061 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606841}
-
Corentin Wallez authored
BUG=chromium:901830 Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706 Reviewed-on: https://chromium-review.googlesource.com/c/1326157 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606840}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s' 2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces" Created with: gclient setdep -r src/third_party/perfetto@fd986312652f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I602c7205239349ff0faf4467740388c6cb05725f Reviewed-on: https://chromium-review.googlesource.com/c/1329044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606839}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6 Created with: gclient setdep -r src-internal@6166365225d6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9 Reviewed-on: https://chromium-review.googlesource.com/c/1329043Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606838}
-
Ioana Pandele authored
This CL introduces ManagePasswordsUIProvider, a class which aims to allow for alternative UI surfaces to be shown if available. Bug: 903249 Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76 Reviewed-on: https://chromium-review.googlesource.com/c/1326488Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#606837}
-
Sam Maier authored
Bug: 872904 Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab Reviewed-on: https://chromium-review.googlesource.com/c/1327331Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606836}
-
Hiroshige Hayashizaki authored
Currently WorkerFetchContext has the ownership of some objects originated from WebWorkerFetchContext. To create multiple WorkerFetchContexts for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext, this CL moves these ownership outside WorkerFetchContext. Namely, - url_loader_factory_ and script_loader_factory_ from WorkerFetchContext to WebWorketFetchContext subclasses, and - subresource_filter_ from WorkerFetchContext to WorkerOrWorkletGlobalScope. Still |WorkerFetchContext::subresource_filter_| is kept, but it is created in WorkerOrWorkletGlobalScope and passed to WorkerFetchContext. This CL doesn't change the observable behavior. This CL creates WebURLLoaderFactory a little more eagerly, i.e. when WorkerFetchContext is created, while previously it was created when WorkerFetchContext::CreateURLLoader() is called for the first time. Bug: 880027, 903579 Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68 Reviewed-on: https://chromium-review.googlesource.com/c/1193385 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606835}
-
Rohit Rao authored
BUG=None Change-Id: I3a14f465f152e9b1b514802723093e9702edc001 Reviewed-on: https://chromium-review.googlesource.com/c/1326487Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606834}
-
chrome://discardsSigurdur Asgeirsson authored
I don't know whether to trust these numbers, but this is what I see for my local Windows release 32 bit build. Uncompressed: 3,034,139 browser_resources.pak 233,038,336 mini_installer.exe Compressed: 2,869,382 browser_resources.pak 232,873,472 mini_installer.exe Bug: 891310 Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822 Reviewed-on: https://chromium-review.googlesource.com/c/1327406Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606833}
-
Mike Reed authored
Bug: skia:2664 Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205 Reviewed-on: https://chromium-review.googlesource.com/c/1318416 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606832}
-
Marc Treib authored
The account storage is now used for both server cards and server addresses. Bug: 864519 Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9 Reviewed-on: https://chromium-review.googlesource.com/c/1329241 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606831}
-
Marc Treib authored
Currently, this makes no functional difference: In full Sync mode, the local DB and the server DB are the same thing anyway, and in lightweight/Butter mode, we don't store server addresses at all. However, 1) this change will unlock actually supporting Wallet addresses in Butter mode, and 2) it's just less confusing if "server" things are actually stored in the "server" DB. Bug: 864519 Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8 Reviewed-on: https://chromium-review.googlesource.com/c/1326492Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606830}
-
Anders Hartvoll Ruud authored
Instead of applying custom properties via the static Variable instance, use the new CustomProperty class (which knows about its name and registration) to apply values. This brings the custom property code path closer to the standard property code path. To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the class CSSPropertyName. The idea is that CSSPropertyName can be used instead of CSSPropertyID/AtomicString where both standard and custom properties are expected. My intent is to store a CSSPropertyName in CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big change, as everything that creates property/value pairs must carry the CSSPropertyName. So, for now PropertyReference.Name() is faking it by digging the name out of the associated CSSValue. Note that CSSPropertyName::ToAtomicString intentionally does not return a const AtomicString&. This is because 1) I want to try and reduce the size of CSSPropertyName to one pointer, which means it will contain a StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to be something that can be passed to other threads if needed, which again means StringImpl* (or String, at least) rather than AtomicString. In general, this CL is a step on the path to achieve these things: 1. Removing the useless and dangerous static Variable instance. 2. Not having to piggy-back the custom property name in a CSSValue. 3. Not having to smuggle initial/inherit/unset via the CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues holding these values, like civilized individuals). R=flackr@chromium.org, futhark@chromium.org Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c Reviewed-on: https://chromium-review.googlesource.com/c/1323113 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606829}
-
Leonard Grey authored
This reverts commit 002dfaef. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1 Original change's description: > Mac: Disallow dragging tab into blocked tabstrip > > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam, > though I'm pretty sure the thing that happens right now when you open > a certificate prompt and drag a tab into the parent window is bad. > > This introduces a new method because we're not sure if it matches the > Aura semantics, and this is better than the nothing we were doing previously. > > Bug: 825834 > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d > Reviewed-on: https://chromium-review.googlesource.com/c/1315956 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606619} TBR=ellyjones@chromium.org,lgrey@chromium.org Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825834 Reviewed-on: https://chromium-review.googlesource.com/c/1329341Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#606828}
-
Peter Kotwicz authored
This CL: - Makes the generated AndroidManifest.xml a data dependency of h2o_junit_manifest_target_name - Reenables LaunchTest.* BUG=902325 Change-Id: I47e3c5c2226c78c696716712a4307127493c5903 Reviewed-on: https://chromium-review.googlesource.com/c/1324875Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606827}
-
Stephane Zermatten authored
Before this patch, navigation triggered by clicking on a link or through javascript (renderer-initiated navigation) was considered an end state for Autofill assistant. With this patch, such actions are only considered an end state if the page that's navigated to has no scripts. This is necessary, as such navigation is part of the expected flow of some scripts. Going back a page or refreshing through the UI (non renderer-initiated navigation) are still considered an end state with this patch. Bug: 806868 Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d Reviewed-on: https://chromium-review.googlesource.com/c/1329242Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606826}
-
Mark Cogan authored
This CL decouples the addition of a tab completion block from the other tab opening code in the BVC. This will allow the tab opening logic (which is just tab model manipulation) to be moved out of the BVC. Bug: 903338 Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c Reviewed-on: https://chromium-review.googlesource.com/c/1323558 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606825}
-
gogerald authored
Bug: 806868 Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594 Reviewed-on: https://chromium-review.googlesource.com/c/1324239Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606824}
-
Clemens Arbesser authored
The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available. Bug: 806868 Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c Reviewed-on: https://chromium-review.googlesource.com/c/1317911 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606823}
-
Corentin Wallez authored
This reverts commit 0f0d0b74. Reason for revert: super flaky on win7_chromium_rel_ng BUG=chromium:872776 Original change's description: > Add resource load priority Service Worker tests > > This CL adds resource load priority tests ensuring that the priority of > requests that pass through a Service Worker is preserved. > > R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org > > Bug: 872776 > Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0 > Reviewed-on: https://chromium-review.googlesource.com/c/1316104 > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606689} TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872776 Reviewed-on: https://chromium-review.googlesource.com/c/1329245Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606822}
-
Xianzhu Wang authored
The previous early return shortcut required invalidation of fixed-attachment background etc. Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange(): - always invalidate for fixed-attachment background - correct invalidation of local-attachment background for SPv2 - remove the SetNeedsRepaint() logic for change of existence of ScrollTranslation because now PaintPropertyTreeBuilder will do that whenever a paint property node is created or removed Bug: 529963 Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1308988 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606821}
-
Patrik Höglund authored
This reverts commit 05e6d611. Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. ==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128 READ of size 8 at 0x608000011e50 thread T0 #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28 See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests. Original change's description: > Fix page slip issue after dragging > > Changes: > Update the selected page to be the target page of dragged item at the > end of dragging. > > Bug: 893832 > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df > Reviewed-on: https://chromium-review.googlesource.com/c/1324851 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606585} TBR=newcomer@chromium.org,weidongg@chromium.org Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893832 Reviewed-on: https://chromium-review.googlesource.com/c/1329170Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606820}
-
Yuki Shiino authored
We're planning to not use cross origin ScriptStates everywhere, especially in IDL callback function and callback interface. Given that, we'd like to minimize use of ScriptState of callbacks, which will be nullptr in case of cross origin, so that the call sites of callbacks do not need to handle a SecurityError. This patch is a preparation of https://crrev.com/c/1314023 and removes the use of the ScriptState from custom elements. Bug: 886588, 892755 Change-Id: I52068920b659efe119496ec092448cdc107e0631 Reviewed-on: https://chromium-review.googlesource.com/c/1325585Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606819}
-
Patrik Höglund authored
It is flaky. See for instance https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816. Bug: 903658, 903657 Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b Tbr: mdjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1329161 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606818}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6130e69e..31b2546b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a2852bb93f2c67cb5e6a1f0ed39315bab81006f Reviewed-on: https://chromium-review.googlesource.com/c/1329062Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606817}
-