- 31 Aug, 2020 4 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..79257bae3c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I52ada3e1abcfa1efd29f925fb27d2a61ece46523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802985}
-
Wenbin Zhang authored
This reverts commit 8700df8a. Reason for revert: Android builders started failing since this commit: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957 Traceback (most recent call last): File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main ret = self.args.func() File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen return self.RunGNGen(vals) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates command, extra_files = self.GetIsolateCommand(target, vals) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand 'generated_scripts can no longer customize the script path') AssertionError: generated_scripts can no longer customize the script path Original change's description: > Rename wrapper_scripts for generated_script tests in MB. > > A few tests (some Android resource_sizes tests, and one Perfetto > test), were using generated_script tests that were generating > wrappers that weren't named 'bin/run_$target_name'. > > We want all generated_script tests to be using consistent names, so > this CL changes those targets. > > Bug: 816629 > Change-Id: If447fbee6b33637de4c9711e87379128272285af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802694} TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816629 Change-Id: I11ec06405105860f01f3b7752df2024615f7badc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802984}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af2dca5c5320..79257bae3c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3faeb9a98c46cd94e2d9ee01b1e72c17726e90b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382619Reviewed-by:
-
My Nguyen authored
Also add description for the dialog. Will update search field look later. Keeping search field's onKeyDown behavior similar to AddLanguagesDialog Current view: http://screen/89QAGJxXX5Yh2nB Spec: http://go/cros-lang-settings-ux-slide#slide=15 String is being finalised so translateable=false and no screenshots required Bug: 1113439 Change-Id: I8b7e428d42754eaaf91252aa4f23664cdd3690bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379031 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802982}
-
- 30 Aug, 2020 36 commits
-
-
John Chen authored
Several stories have been deleted by crrev.com/c/2380497. Remove them from expectations.config and timing_data to avoid presubmit errors. TBR=wenbinzhang@google.com NOTRY=true Change-Id: I82c206ffe37e4f9583bc33713b56fef806eea89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384334 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802981}
-
Peter Kasting authored
Bug: none Change-Id: Iaf29f57b6085d96fd5cf0dc890e57500bfc0bfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384333 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#802980}
-
Sara Kato authored
Address remaining comments from crrev/c/2336000 Test: none Bug: none Change-Id: I7b153dddc977701289f813cafecef018a4902ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379421Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#802979}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7adc49071b1bbaa7c37e3839e10395114e0ff7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384266Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598787629-5050e58a06f338b550c38a558c54620e2382ffcd.profdata to chrome-win32-master-1598806680-ea8cbf643223574fcb349af48fd14418e961fcb1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If57a487c563e75372f713e409f17484fabfbce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384252Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/646050ef7bc9..4e662367b179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I5371b9bc170e58267d91ae3b6dd4c0a351721336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384261Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802976}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.13-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ideb698be37330c8f3cad5fa636984e85b04a6c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384260Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, invoking PaymentRequest API with secure payment confirmation method in a cross-origin iframe would display the secure payment confirmation dialog UI, but proceeding to verify the payment with WebAuthn would return NOT_ALLOWED_ERROR. This patch creates autofill::InternalAuthenticator on the top-level RenderFrameHost of the WebContents instead of the RenderFrameHost of the exact iframe that invoked PaymentRequest API. After this patch, it is possible to use secure payment confirmation method in a cross-origin iframe. Bug: 1123217 Change-Id: Ifc3ec58a5bb57a2544c51d15aaa1035b15da6190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383452Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802974}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.13-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I559485dced07f6b6059a0ae02085b8ebfcca2bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384259Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598787629-2ff292917785ccea26fc0bcea2fb51ffdd7b8de4.profdata to chrome-mac-master-1598806680-bf4202c36f1e343eed4671b6753fc4351a3e6e6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I96335e80afa3e428c7669d780f357167619d7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384254Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.13-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I129b9162559b92e510042f75f52bca9ce186f9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384257Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008300800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/5fzLHnuNlPqh_-QJ0yoOS0fc9rVLwLXKf_arigkwZrgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I52f0ada9e317c0c12233b62eae3a7b17082bb40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384249Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3872c989512c..85f51b2a409c 2020-08-30 reed@google.com Simplify firstdirection If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ie59f04c04417c0b2135ef345843cb166e5d57aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384147Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0630a1e7f4a0427b5a236f8694f99acdddddad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384148Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598775158-da08b78b3bc27e20acc6914ae878c390cc193924.profdata to chrome-win32-master-1598787629-5050e58a06f338b550c38a558c54620e2382ffcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id3031fee942031eaba381c8db29a438646972efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384145Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bcc24253c8b..646050ef7bc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6ed32c4185a7be188a84c476abd71bef46370ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384146Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d5961b33e87f..3872c989512c 2020-08-30 reed@google.com Move convexity enum out of public If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ibc9b5a7741774be79588258093f2f1c4f5ab988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384213Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598769008-1f6fb59dbead98af6a3f6082b2d0ac34d925ef32.profdata to chrome-win32-master-1598775158-da08b78b3bc27e20acc6914ae878c390cc193924.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I58cbc04a65e29717c38b200c277966fb3f2f47b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384209Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598764957-579002e6a76f5560b11ec6e2a28ec9eef139de77.profdata to chrome-mac-master-1598787629-2ff292917785ccea26fc0bcea2fb51ffdd7b8de4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieeab0c240d2ae1e15a5b7f28d6c3a9bc7001b0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384212Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/39f016ab802e..809a6d42384e 2020-08-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3e2b3c8c695d220c4238082eb26fa9839dec9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384211Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598764957-5a770d69b5bcb78eee1093900663c67b4c4c4cf4.profdata to chrome-win32-master-1598769008-1f6fb59dbead98af6a3f6082b2d0ac34d925ef32.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I2b16fb89edad0591c58ed99d36f3ba69a7765ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384141Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I90e6f894a9d80a909e81751169aa4928603dc962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382755Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3479e999694c..4bcc24253c8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib2806236d7e4d23e8ec44dda4b604e16a6a8ad05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384139Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I6859b6c96a35f6f9c06e7d8d73db5251379531ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382076Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802958}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I77f9140c2c573a0f969c09f9eb5adc46e2b1d503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384029Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802957}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598754079-67fc4d590254f5ab7174427f2cc7e0ef0963cb7e.profdata to chrome-win32-master-1598764957-5a770d69b5bcb78eee1093900663c67b4c4c4cf4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1cea1cbe01f48105973f90b6c7ace1bad965dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384136Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, invoking PaymentRequest.show() for secure payment confirmation on a device without credentials would reject with "User closed PaymentRequest UI" error message instead of the more correct "Payment method not supported", if show() was called after PaymentRequest.canMakePayment() returned. This is detrimental to measuring the success of the secure payment confirmation dialog. This patch changes the secure payment confirmation UI controller to not invoke PaymentRequest::UserCancelled() when PaymentRequestState has finished looking for credentials and found none. This allows payment_request.cc to correctly the no-apps state by rejecting PaymentRequest.show() with the correct error message. After this patch, a device without credentials always rejects PaymentRequest.show() with "Payment method not supported" without implying that the user interacted with the UI dialog and cancelled it. Bug: 1123082 Change-Id: Idba82354f413c926c1f835ec34e50d3c29080bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383812 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Monica Basta authored
Fixed: 1123093 Change-Id: I09935ef9c9ff0bb4104d887c0314653327faced2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382590 Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id612719ebdeadce1f9c3b6d17ae17bb81dd11a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384137Reviewed-by:
-
kdillon authored
When the frame is detached, the receivers are reset. This makes it possible for BindToReceiver and its variants to be called while the frame is detached. This is an issue because the frame scheduler also gets reset on detach so when we try to call 'GetTaskRunner' (which invokes a method on the frame scheduler) it can crash. To prevent bindings from occurring when there is no execution context, this CL checks whether the frame is detached before binding a pending receiver. Bug: 1103594 Change-Id: I8179ee81b5ca992f88dbb627be1fec5eeeb0a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303777Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802952}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8702b8f4444f..d5961b33e87f 2020-08-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I4cdc6cf033202ca32265f4fdaf8f3357df7ed687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384129Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.12-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0d1ffdea3314c9db397d8749d5bd3793a6e323a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384138Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598680344-aa469a0f04e08491eb84b2521bf3eecf90475733.profdata to chrome-mac-master-1598764957-579002e6a76f5560b11ec6e2a28ec9eef139de77.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4bd7a072982d73bc43413f145fd913990767dbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384134Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10bfd34d3ceb..39f016ab802e 2020-08-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6338404430582136b4679b1383bf39effdfe4949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384130Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598751363-29d99da61a85f02ed5804a976cf96426ad8a9d5e.profdata to chrome-win32-master-1598754079-67fc4d590254f5ab7174427f2cc7e0ef0963cb7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I103ed6a9e63cc25b318ef460619e89b90c81d4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383999Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/48b9a3aff08a..10bfd34d3ceb 2020-08-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b285e81ef0d480d4c9c8130e4cb1e11c713f1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383998Reviewed-by:
-
