GitLab

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
Cr-Commit-Position: refs/heads/master@{#437724}

Previously, the various editors would return |null| to the caller
(PaymentRequestImpl) in the case of a cancel. We are now returning the
original item that was passed in for edit.

BUG=672996
TEST=PaymentRequest*Test*

Review-Url: https://codereview.chromium.org/2561373002
Cr-Commit-Position: refs/heads/master@{#437723}

Two types of sync metadata, once stored in the sync directory, are now being
migrated to the web database. These two types are the per-entry EntityMetadata
and the ModelTypeState, which is globalstate for the autofill model type. This
change adds a migration to add the tables and functions on AutofillTable to
read/write/delete it, with associated tests.

BUG=671832

R=shess@chromium.org,mathp@chromium.org,pavely@chromium.org

Review-Url: https://codereview.chromium.org/2550293002
Cr-Commit-Position: refs/heads/master@{#437722}

Another refactoring aimed at slimming down the TraceLog monster-class
and isolating dependencies of the tracing codebase.
This CL is a pure refactor with no intended behavioral changes.
It moves all the trace filters classes outside of the TraceLog.
This is required to make the next CLs which will change the lifetime
management of filters easier to review.

BUG=659689

Review-Url: https://codereview.chromium.org/2549103003
Cr-Commit-Position: refs/heads/master@{#437721}

and net/quic/core/congestion_control to sync with internal.

Review-Url: https://codereview.chromium.org/2566703002
Cr-Commit-Position: refs/heads/master@{#437720}

BUG=620813

Review-Url: https://codereview.chromium.org/2556813002
Cr-Commit-Position: refs/heads/master@{#437719}

Make use of the PpdCache from PrintPreview.  Setup downloading ppds from
the quirks server.

BUG=662755
TEST=Setup a printer.  Log out.  Rename ppd file.  Open printer from print
preview.

Review-Url: https://codereview.chromium.org/2542363002
Cr-Commit-Position: refs/heads/master@{#437718}

Typed arrays in blink (e.g. DOMFloat32Array) are typedef of DOMTypedArray<T, U>
so using forward declarations causes conflicts. Stop using forward
declarations for typed arrays in union containers. Instead, include
headers directly.

BUG=671755

Review-Url: https://codereview.chromium.org/2559323004
Cr-Commit-Position: refs/heads/master@{#437717}

This patch is a subtask of "Decoupling Gamepad from //content".

In this patch the GamepadService, GamepadServiceUnittest, GamepadMonitor and
GamepadSharedBuffer are moved out of content/browser/gamepad or render_host,
and into device/gamepad/.

The file //content/common/gamepad_hardware_buffer.h is removed, we move the
definition of GamepadHardwareBuffer into gamepad_shared_memory.h, and change
its definition by using generic SharedMemorySeqLockBuffer<blink::WebGamepads>.

In the unittest of GamepadProvider, we don't pass a MockSharedMemoryBuffer
(which has no seqlock controls) anymore. GamepadProvider will create a
SharedMemoryBuffer by default in its constructor, so we add the seqlock-read
accordingly in its unittest.

Based on a patch by bajones@chromium.org.

BUG = 612330

Review-Url: https://codereview.chromium.org/2563483006
Cr-Commit-Position: refs/heads/master@{#437716}

The end goal is to trigger purge from DataTypeManagerImpl at the very beginning
of configuration based on information available in DataTypeManager and
DataTypeControllers.

In this change I moved PurgeDisabledTypes call from
SyncManagerImpl::ConfigureSyncer and called it separately from
SyncBackendHost{Impl/Core}.

R=maxbogue@chromium.org
BUG=647505

Review-Url: https://codereview.chromium.org/2563883006
Cr-Commit-Position: refs/heads/master@{#437715}

This change removes the CopyToWebGLTexture fallback reason, which
was no longer capturing the right thing, and replaces it with
more granular fallback reasons for the different variants of texImage.
This CL also adds more specific fallback reasons to track cases where
a canvas is copied to the clipboard and createImageBItmap.

BUG=671637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2557783002
Cr-Commit-Position: refs/heads/master@{#437714}

This is merely a sanity check. Technically you could show the host
without initializing it, but chances are you didn't meant to do that (or
you can easily change your code to Init before Show).

BUG=NONE

Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac
Review-Url: https://codereview.chromium.org/2552003002
Cr-Original-Commit-Position: refs/heads/master@{#437285}
Cr-Commit-Position: refs/heads/master@{#437713}

Previously RateCounter was using base::Time instead of base::TimeTicks,
which may cause it to generate incorrect values in some cases. Fxed it
to use TimeTicks. Also updated it to use TickClock interface for tests.

Review-Url: https://codereview.chromium.org/2561173004
Cr-Commit-Position: refs/heads/master@{#437712}

PeerConnection creates new threads internally and shuts them down when
connection is closed. This is a blocking operation, so Debug builds were
DCHECK'ing every time connection is terminated. Added ScopedAllowIO to
work around this issue.

BUG=660081

Review-Url: https://codereview.chromium.org/2567533002
Cr-Commit-Position: refs/heads/master@{#437711}

BUG=668584

Review-Url: https://codereview.chromium.org/2560993003
Cr-Commit-Position: refs/heads/master@{#437710}

This re-adds POSIX shared memory support on Mac. This
is for use in the sharing of field trials using shared memory. You
can see the design doc for this project at:
https://docs.google.com/document/d/1mTjD99PchmCGYtLvpxaXFObVnid1zmXIsWBI7GjuJgo/
and the motivation for this change under "Port to other platforms".

NOTE: turning on NOPRESUBMIT because this re-adds some banned calls to AllowIO.

BUG=671228
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2555483002
Cr-Commit-Position: refs/heads/master@{#437709}

BUG=504347

Review-Url: https://codereview.chromium.org/2567723003
Cr-Commit-Position: refs/heads/master@{#437708}

From discussion at
https://crrev.com/2555033003/#msg21

BUG=

Review-Url: https://codereview.chromium.org/2565813002
Cr-Commit-Position: refs/heads/master@{#437707}

BUG=chromedriver:1506

Review-Url: https://codereview.chromium.org/2387353004
Cr-Commit-Position: refs/heads/master@{#437706}

CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink.

CompositorFrameSink is no longer a friend class of exo::Surface.

Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient.

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493223002
Cr-Commit-Position: refs/heads/master@{#437705}

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970

Review-Url: https://codereview.chromium.org/2559323008
Cr-Commit-Position: refs/heads/master@{#437704}

BUG=

Review-Url: https://codereview.chromium.org/2563133002
Cr-Commit-Position: refs/heads/master@{#437703}

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2558933003
Cr-Commit-Position: refs/heads/master@{#437702}

Remove vertical separator between subpage header and first section on the
Custom Spelling subpage of chrome://md-settings/languages.

R=stevenjb@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2557193002
Cr-Commit-Position: refs/heads/master@{#437701}

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641

Review-Url: https://codereview.chromium.org/2537063002
Cr-Commit-Position: refs/heads/master@{#437700}

This change makes PresentationServiceDelegateImpl cancel requests to join
session if they have the "auto-join" presentation ID and the user pref is set to
tab mirroring for the origin. This way, when a page requests to auto-switch from
tab mirroring to Cast SDK on a site where the user has chosen to use tab
mirroring, the auto-switching gets cancelled.

This CL relies on a profile pref introduced by
https://codereview.chromium.org/2487673003/.

BUG=664671

Review-Url: https://codereview.chromium.org/2517833004
Cr-Commit-Position: refs/heads/master@{#437699}

Audio only devices have no way to display a URL, so unittest is irrelevant.

BUG= internal b/32972133
TEST= content_unittests

Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157
Review-Url: https://codereview.chromium.org/2563833002
Cr-Commit-Position: refs/heads/master@{#437698}

This reverts commit 658a3dc1, which did
not work-as-intended because the Chrome feature flags are not available
at the time of zygote initialization.

BUG=670421
TBR=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2567773002
Cr-Commit-Position: refs/heads/master@{#437697}

/verbose linking of chrome.dll creates over one GB of output. This
causes ExecLinkWrapper to consume over two GB of memory which leads to
an OOM failure in the 32-bit depot_tools python, and the loss of all
of the valuable output. This change modifies ExecLinkWrapper to
process the output one line at a time, thus avoiding the OOM.

I've tested that this handles the 1.1 GB of output which the previous
version of this function failed on and I've visually confirmed that the
output looks the same - no extraneous blank lines, for instance, when
displaying warnings, errors, or 1.9 million lines of verbose output.

I also verified that the script stays idle when waiting for output -
blocking on .readline().

This fixes the previous attempt which omitted the vital link.wait() call
which meant that error codes were not propagated.

R=scottmg@chromium.org
BUG=672182,672841

Review-Url: https://codereview.chromium.org/2568563002
Cr-Commit-Position: refs/heads/master@{#437696}

This CL adds logic for resetting all User Controls to its default
value upon closing the device file descriptor; otherwise, as the
bug proves, they persist across camera uses, e.g. the zoom level
is unchanged.

This would be relatively simple except for the fact that controls
come in two types: user controls and camera controls, and
that some controls need another one to be set or cleared
beforehand (e.g. white_balance_auto must be set to off
before white_balance can be set, etc).

See [1] for Spec
[1]  https://www.linuxtv.org/downloads/legacy/video4linux/API/V4L2_API/spec-single/v4l2.html#control

BUG=662616

Review-Url: https://codereview.chromium.org/2479413002
Cr-Commit-Position: refs/heads/master@{#437695}

* Fix/add header guards in header files in //net except for in //net/third_party
  and in header files that are meant to be included only with some special macro
  defined (these are typically *_list.h):
  + #ifndef FILE_NAME in line 5,
  + #define FILE_NAME in line 6,
  + #endif  // FILE_NAME in the last line.
* Add newline to the end of files that do not already end in a newline.
* Remove empty line from the end of files that end in an empty line
  (that is, remove newline characters down to exactly one newline).
* Add empty line between Copyright notice and header guard in
  net/proxy/dhcpcsvc_init_win.h

Review-Url: https://codereview.chromium.org/2562113002
Cr-Commit-Position: refs/heads/master@{#437694}

BUG=

Review-Url: https://codereview.chromium.org/2558993004
Cr-Commit-Position: refs/heads/master@{#437693}

BUG=640506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566493005
Cr-Commit-Position: refs/heads/master@{#437692}

https://skia.googlesource.com/skia.git/+log/e29ce641d378..0e8fc8b9e6a1

$ git log e29ce641d..0e8fc8b9e --date=short --no-merges --format='%ad %ae %s'
2016-12-09 bsalomon Relandx2 "Remove antialiasing control from GrPaint."
2016-12-09 mtklein remove Building with Skia Tutorial
2016-12-09 brianosman Plumb dst color space in many places, rather than "mode"
2016-12-09 bsalomon Revert "Reland "Remove antialiasing control from GrPaint.""
2016-12-09 bsalomon Reland "Remove antialiasing control from GrPaint."
2016-12-05 brianosman Remove SkImage::makeTextureImage
2016-12-09 robertphillips Different approach to fixing gpu blurs on platforms that "useDrawInsteadOfClear"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2569463002
Cr-Commit-Position: refs/heads/master@{#437691}

Previously the fake server used to update all of the progress markers
to the highest single version of an entity being returned in a
GetUpdates response. This caused odd behaviors when clients asked for
different sets of model types. This in turn resulted in tests failing
when they never agreed on some progress marker's version that wasn't
actually being actively updated.

This change separates all model types version/progress markers in the
fake server code. This should help clients that are being enabled
mid-test to get match progress markers when priority and non-priority
types are requested across separate GetUpdates messages.

Also removed some special case logic around filtering deleted items. It
is unclear what purpose that logic was serving.

BUG=672596

Review-Url: https://codereview.chromium.org/2564663003
Cr-Commit-Position: refs/heads/master@{#437690}

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567733002
Cr-Commit-Position: refs/heads/master@{#437689}

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Review-Url: https://codereview.chromium.org/2558223002
Cr-Commit-Position: refs/heads/master@{#437688}

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706

Review-Url: https://codereview.chromium.org/2558973003
Cr-Commit-Position: refs/heads/master@{#437687}

The TRACE_EVENT_CATEGORY_GROUP_ENABLED sets enabled to true even when
filtering mode was turned on. This should be set only for recording and
etw modes.

BUG=669611, 670013

Review-Url: https://codereview.chromium.org/2547193002
Cr-Commit-Position: refs/heads/master@{#437686}

Change message to show that clicking on a trash can actually
deletes items instead of just removes them, even though the
operation is "remove" by the DownloadHistory backend.

BUG=666292

Review-Url: https://codereview.chromium.org/2564053003
Cr-Commit-Position: refs/heads/master@{#437685}