- 24 Jul, 2013 40 commits
-
-
yhirano@chromium.org authored
This CL fixes the problem. BUG=None Review URL: https://chromiumcodereview.appspot.com/19790011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213386 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
Uploading may fail due to confliction. In such a case, response may contain valid JSON data in the content of the response. However, here we expect only valid JSON data representing an uploaded file entry's metadata. This CL skips parsing JSON file, if an error is found. BUG=263330 TEST=Ran unit_tests. Review URL: https://chromiumcodereview.appspot.com/19771024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213385 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
The band-aid was r143761. Now that crbug.com/138152 is fixed, we can hopefully do without. Note: It is possible that this commit causes renderer crashes, if we still didn't get the SessionStorage association right. Please see crbug.com/134003. BUG=134003 Review URL: https://chromiumcodereview.appspot.com/19756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213384 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
I don't see the same issue of crbug.com/244323 on Windows so far, but theoretically this CL fixes the same possible issue on Windows. By the way, this CL is effective for the case that some of fonts are unexpectedly smaller than the default font. Not effective for the case that some of fonts are unexpectedly larger than the default font. So, this CL doesn't fix crbug.com/146236 . BUG=244323 TEST=none Review URL: https://chromiumcodereview.appspot.com/19734003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213383 0039d316-1c4b-4281-b951-d872f2087c98
-
nhiroki@chromium.org authored
This is a preliminary change for adding SyncFileSystemBackend. At first, we planed to do initializing process for SyncFileSystemBackend in InitializeFileSystem(), but it revealed that there are some hassles on that way (see [*]), so we decieded to introduce a separate initialze function and to rename InitializeFileSystem() to its original name (i.e. OpenFileSystem()). [*] https://codereview.chromium.org/18668003/ BUG=242422 TEST=should pass all existing tests NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213382 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@chromium.org authored
Since there are no Windows or Mac pairing registry delegates yet, the host plugin currently crashes when the web-app starts up on those platforms. Review URL: https://chromiumcodereview.appspot.com/19460020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213381 0039d316-1c4b-4281-b951-d872f2087c98
-
varkha@chromium.org authored
BUG=233334 Review URL: https://chromiumcodereview.appspot.com/19054013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213380 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=248424 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/18948004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213379 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213378 0039d316-1c4b-4281-b951-d872f2087c98
-
haraken@chromium.org authored
TBR=haraken Review URL: https://codereview.chromium.org/19620008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213377 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://translate-internals/hajimehoshi@chromium.org authored
This CL enable to jump a tab directly by URL hash in chrome://translate-internals/. For example, chrome://translate-internals/#detection-logs jumps to the detection-logs tab. Likewise, when a user switch a tab, the URL's hash in the Omnibox will be changed to fit the current tab. BUG=262870 TEST=manual Review URL: https://chromiumcodereview.appspot.com/19724006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213375 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
BUG=262918 TEST=FileAPIMessageFilter.{CloseChannelWithInflightRequest,MultipleFilters} Review URL: https://chromiumcodereview.appspot.com/19705017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213374 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
BUG=179830 TEST=Fixes StartupBrowserCreatorTest.OpenURLsPopup for Ash browser tests. Review URL: https://chromiumcodereview.appspot.com/19702003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213373 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
in the current MessageLoop rather than re-entrantly, to avoid executing any JS in an unexpected state. BUG=258526 Review URL: https://chromiumcodereview.appspot.com/19670020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213372 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213371 0039d316-1c4b-4281-b951-d872f2087c98
-
haraken@chromium.org authored
TBR=haraken Review URL: https://codereview.chromium.org/19579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213370 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
This CL implements a JavaScript Dialog API for <webview>. This API allows the embedder to intercept requests for alert/confirm/prompt dialogs, giving the embedder an opportunity to asynchronously display UI to respond to these requests. Note: This API blocks the guest until one of three things happens: 1. The default is not prevented, and so the default action is equivalent to canceling the dialog. 2. The default is prevented and the event.dialog object becomes unreachable in JS and is garbage collected. 3. An action is taken: event.dialog.ok(...) or event.dialog.cancel(); BUG=260745 Test=WebViewTest.Dialog_* Review URL: https://chromiumcodereview.appspot.com/19679002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213369 0039d316-1c4b-4281-b951-d872f2087c98
-
Hokein.Wu@gmail.com authored
Remove |available_capacity| field. BUG=252994 TEST=browser_tests --gtest_fitler=SystemInfoStorageApiTest.* TEST=unit_tests --gtest_filter=StorageInfoProviderTest.* Review URL: https://chromiumcodereview.appspot.com/19672022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213368 0039d316-1c4b-4281-b951-d872f2087c98
-
wuchengli@chromium.org authored
GpuVideoDecoder::Factories is used by GpuVideoDecoder and RTCVideoDecoder. Move it to a new file. BUG=170345 TEST=Run http://apprtc.appspot.com/?debug=loopback on chromebook daisy. Play hardware-accelerated videos. Review URL: https://chromiumcodereview.appspot.com/19638008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213367 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
CloseFile has a potential issue, which may close a file different from opened one. To avoid such a case, by this CL, OpenFile starts to return a closure, which should be called on the file closing. This is the same technique used in fileapi implementation. BUG=259184 TEST=Ran unit_tests and tested manually. Review URL: https://chromiumcodereview.appspot.com/19596003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213366 0039d316-1c4b-4281-b951-d872f2087c98
-
primiano@chromium.org authored
This change introduces a new switch (-x) which causes memdump to add, to each mapping printed out, a bitmap containing resident bit information for the mapping. This extended report can be processed by the memsymbols.py script, part of this CL. The aim of memsymbols.py is to extract the list of symbols, for a given library mapped in the analyzed process, which was resident in memory at a given point in time (when the memdump snapshot was taken). NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19466005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213363 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
It's not looking like we can fix all the regressions in M29, so this disables it for beta. We can re-enable if we get all the relevant patches into the branch. BUG=256474 Review URL: https://chromiumcodereview.appspot.com/19460019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213362 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
Now that CLD is used on all platforms, let's remove ENABLE_LANGUAGE_DETECTION. BUG=248454 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/18820002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213361 0039d316-1c4b-4281-b951-d872f2087c98
-
edmundyan@chromium.org authored
--page-repeat and --pageset-repeat can now be set to repeat for an amount of time by appending an 's' after the integer WillRunPageSet has been renamed to WillRunTest DidRunPageSet has been renamed to DidRunTest BUG=260008 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213184 Review URL: https://chromiumcodereview.appspot.com/18261009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213360 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213359 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213358 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
r213354 - Only depend on libgabi++ for the target toolset. TBR=marja@chromium.org Review URL: https://codereview.chromium.org/20079002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213357 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
I suspect this broke WorkspaceManagerTest on Win8 Aura http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/8306 > Use GetDisplayNearestWindow instead of GetDislpaymatching where appropriate > This is correct way to tell on which display > the window is on as a window doesn't overlap two > displays on ash. > > BUG=none > > Review URL: https://chromiumcodereview.appspot.com/19593008 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/19668011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213356 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Broke WebViewInteractiveTest.EditCommandsNoMenu on Mac [1288:27139:0723/221703:FATAL:layer_impl.cc(286)] Check failed: TotalScrollOffset().y() <= max_scroll_offset_.y() (62 vs. 47) > cc: Allow the main thread to cancel commits > > Add a new SetNeedsUpdateLayers that triggers the commit flow, but is > abortable if update layers doesn't actually make any changes. This > allows the main thread to abort a begin frame. This happens in the case > of scroll updates from the compositor thread or invalidations. > > There was previously an abort begin frame call for when a visibility > message and a begin frame message were posted simultaneously, but it > incorrectly applied the scrolls and scales without informing the > compositor thread that these had already been consumed. To fix this, > the abort message passes back a boolean about whether or not the > commit was aborted (and needed to be sent again) or was handled > (and the scrolls and scales processed). > > To avoid a deluge of begin frames (in the commit sense) from the > scheduler, the scheduler has been adjusted to wait until the next begin > frame (in the vsync signal sense) so that these calls can be throttled. > Otherwise, the scheduler will just keep trying to begin frame. > > R=brianderson@chromium.org, danakj@chromium.org > BUG=256381 > > Review URL: https://chromiumcodereview.appspot.com/19106007 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/19519019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213355 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
There is a lot of setup code duplicated between TESTs. Factor out a test fixture to reduce duplication. BUG= Review URL: https://chromiumcodereview.appspot.com/19603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213353 0039d316-1c4b-4281-b951-d872f2087c98
-
dtu@chromium.org authored
If you ran run_benchmark from different directories, it would be unable to find the page set. BUG=263511 TEST=None. R=tonyg@chromium.org Review URL: https://chromiumcodereview.appspot.com/19597010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213352 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
This is a regression by r212474. preventDefault() is called for a click event on the bookmark star, However we manually check the checkbox by entryBox click and ignore the |defaultPrevented| state. We should repect it. BUG=262869 Review URL: https://chromiumcodereview.appspot.com/19771022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213351 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Hide knowledge of webkit::ppapi::Plugin from chrome. This is part of moving ppapi implementation from webkit/plugins/ppapi to content/renderer. BUG=263054 R=bbudge@chromium.org Review URL: https://codereview.chromium.org/19828007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213350 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=242290 R=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/19525007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213349 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
- Code for making URL list was only working for pageset-repeat, but not for page-repeat (breaking out of the loop when the first cycle is found) - Fixed by using a Set in addition to the List to efficiently make URLs unique while preserving order - Added unittest for page-repeat>1 R=tonyg@chromium.org BUG=263600 Review URL: https://chromiumcodereview.appspot.com/19597007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213348 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This is correct way to tell on which display the window is on as a window doesn't overlap two displays on ash. BUG=none Review URL: https://chromiumcodereview.appspot.com/19593008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213347 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/19579010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213346 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Cleanup open-time histograms to use the sparse framework so that extended histograms can be recorded - also add entries to the xml file. Add a histogram to track close-time failures. This should never fail, but if it is it probably leaks memory and file handles, and possibly locks. BUG=none Review URL: https://chromiumcodereview.appspot.com/18978012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213345 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
BUG=259498 TEST=none Review URL: https://chromiumcodereview.appspot.com/19872007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213344 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=unit_tests --gtest_filter="SearchMetadataTest*" Review URL: https://chromiumcodereview.appspot.com/19871004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213343 0039d316-1c4b-4281-b951-d872f2087c98
-