GitLab

This is a follow-up of crrev.com/403093.

- Replace a TODO comment with an explanation, and add a test to reproduce the
  scenario.

- Fix a possible crash by m_listItems.remove(WTF::kNotFound) just in case.
  We don't find a reproduction.

BUG=625050

Review-Url: https://codereview.chromium.org/2103663006
Cr-Commit-Position: refs/heads/master@{#403416}

Added test coverage with device BACK key.

BUG=

Review-Url: https://codereview.chromium.org/2090633002
Cr-Commit-Position: refs/heads/master@{#403415}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/53f132d..ff05380

BUG=
TBR=kbr@chromium.org
TEST=bots
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2116493004
Cr-Commit-Position: refs/heads/master@{#403414}

`Runnable` concept was useful when bind_internal.h was a huge generated
file. However, it's an unneeded layer these days.
This CL removes `Runnable` from bind_internal.h to simplify its impl.
After this CL, BindState holds the bound Functor directly in its internal
storage.

This CL contains:
 * Merge bind_internal_win.h into bind_internal.h
 * Move typechecks in Bind() into MakeBindStateType.
 * Remove no longer used HasIsMethodTag in bind_helper.h.
 * Remove InvokeHelper specialization for IgnoreResult.
 * Merge assertion-only InvokeHelper specialization into another
   specialization.
 * Factor out the type setup in BindState into MakeBindStateType.

BUG=554299

Review-Url: https://codereview.chromium.org/2106773002
Cr-Commit-Position: refs/heads/master@{#403413}

BUG=610757,625038
TBR=megjablon

Review-Url: https://codereview.chromium.org/2116743002
Cr-Commit-Position: refs/heads/master@{#403412}

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2112003002
Cr-Commit-Position: refs/heads/master@{#403411}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fd47e24b0e09..7a603e4b1a71

$ git log fd47e24b0..7a603e4b1 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2117603003
Cr-Commit-Position: refs/heads/master@{#403410}

BUG=594309,553838
TBR=cbiesinger

Review-Url: https://codereview.chromium.org/2115773002
Cr-Commit-Position: refs/heads/master@{#403409}

The special path for doing substring additions only made sense when we
shared StringImpls for substrings, now that we don't there's no reason
to keep it. The code was dead either way with nothing calling it
anymore.

I also removed constructors for AtomicString that no one used and
switched to using lengthOfNullTerminatedString directly in AtomicString
instead of having a separate code path in AtomicStringTable for finding
the length of UChar* strings.

Finally I simplified AtomicStringTable::remove which was using a find
codepath designed to find a string that may not exist in the table
without actually allocating a new string. This doesn't make sense since
remove is only ever called from StringImpl's destructor on a string we
already know to be atomic so it must be in the table and must have a
hash so we can just do m_table.remove on it.

Review-Url: https://codereview.chromium.org/2111653004
Cr-Commit-Position: refs/heads/master@{#403408}

StringBuilder has an optimization to just store the first String object
you append to avoid a copy in cases where you only append one String
and then call toString(), for example if there's onlyone Text child
and you do element.textContent.

When appending the second string we then allocate a Vector buffer and
copy the first string (m_string) into it. We weren't allocating extra
space for the bytes we were about to append in the second string
though, which meant we always did an extra copy immediately following
the the buffer creation:

String first;
String second;

StringBuilder builder;
// No copy, just stores a pointer to first.
builder.append(first);
// 1. Creates a Vector
// 2. Copies first into it.
// 3. Appends second to the Vector which causes a Vector resize.
builder.append(second);

We solve this by calling reserveInitialCapacity with m_length + the
number of bytes we're about to append when we created the buffer. We
also inflate the number of bytes to be at least the inline capacity
size so that doing:

builder.append(first);
builder.append('1');
builder.append('2');

doesn't require an immediate resize for appending '2' by ensuring we
always overallocate the Vector by at least the inline capacity size so
even when appending a String you get 16 chars of extra space to insert
something else.

BUG=624642

Review-Url: https://codereview.chromium.org/2106283004
Cr-Commit-Position: refs/heads/master@{#403407}

https://chromium.googlesource.com/chromium/src/+/0e94f26e8

BUG=621221
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/2112203002 .

Cr-Commit-Position: refs/heads/master@{#403406}

BUG=625020
TBR=wangxianzhu,bokan

Review-Url: https://codereview.chromium.org/2116733002
Cr-Commit-Position: refs/heads/master@{#403405}

  In order to roll GN cadaad43..ac799c2f (r402556:r403392) and pick up
  the following changes:

  4c75ba48 Fix dependencies rules for create_bundle and bundle_data ninja steps.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2113143003
Cr-Commit-Position: refs/heads/master@{#403404}

This CL implements disabling and enabling audio and video streams via
Javascript media tracks API. When a media track is disabled, the
corresponding DemuxerStream generates an EOS notification, thus ending
further decoding/rendering of that stream. When a media track is
enabled, the corresponding DemuxerStream is seeked to the current
playback position and we notify the renderers to resume reading from
the demuxer stream and rendering its contents.

BUG=249427

Review-Url: https://codereview.chromium.org/1935873002
Cr-Commit-Position: refs/heads/master@{#403403}

Only EventWithLatencyInfo uses [Can]Coalesce() from WebInputEventTraits.
WebInputEventTraits gets used for IPC stuff so is kinda sensitive, but
EventWithLatencyInfo isn't involved with IPC. So, coupling these
together also makes refactoring unnecessarily difficult.

E.g. the coupling means that if we want to move EventWithLatencyInfo to
a component, then WebInputEventTraits and a bunch of dependencies that
EventWithLatencyInfo doesn't care about need to come as well.

To decouple, the guts of [Can]Coalesce() moves to a new .cc file for
EventWithLatencyInfo. The types are known, so we get some added type
safety versus WebInputEventTraits which isn't templatized in the .h. The
instantiations in the .cc become a bit simpler and the runtime type
checks and static casts behind in web_input_event_trait.cc's Apply(..)
are not required.

BUG=615948
TBR=jochen@chromium.org (iwyu)

Review-Url: https://codereview.chromium.org/2111593003
Cr-Commit-Position: refs/heads/master@{#403402}

They are unused because they are used by magic.
They are missing translations to save file size
(see http://crbug.com/450548)

BUG=621771

Review-Url: https://codereview.chromium.org/2102183003
Cr-Commit-Position: refs/heads/master@{#403401}

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648

Review-Url: https://codereview.chromium.org/2115453002
Cr-Commit-Position: refs/heads/master@{#403400}

BUG=620178

Review-Url: https://codereview.chromium.org/2118723002
Cr-Commit-Position: refs/heads/master@{#403399}

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Review-Url: https://codereview.chromium.org/2094903002
Cr-Original-Commit-Position: refs/heads/master@{#402313}
Cr-Commit-Position: refs/heads/master@{#403398}

Cr-Commit-Position: refs/heads/master@{#403397}

This patch fixes incorrect handling of <bad-string-token> inside
@namespace/@import rules. Currently a url(<bad-string-token>) is
incorrectly interpreted as url(url).

The added tests pass in Firefox.

BUG=607095,607500

Review-Url: https://codereview.chromium.org/1930823002
Cr-Commit-Position: refs/heads/master@{#403396}

This removes an extra '}' that accidentally got added in
http://crrev.com/20447ead8ba4b9bf3310da0d80a23a199aba1d60

BUG=625014

Review-Url: https://codereview.chromium.org/2111383002
Cr-Commit-Position: refs/heads/master@{#403395}

When a date picker has a suggestion list it's supposed to be the same
width as the input element. With use-zoom-for-dsf on I discovered that
it was too wide because the width that was being passed in was using
"root frame" coords that were not scaled correctly.

BUG=621221

Review-Url: https://codereview.chromium.org/2095113002
Cr-Commit-Position: refs/heads/master@{#403394}

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111043003
Cr-Commit-Position: refs/heads/master@{#403393}

Revert of [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (patchset #2 id:20001 of https://codereview.chromium.org/2092513002/ )

Reason for revert:
After https://crrev.com/42e3c3e7125d the build warns if it detects this incompatibility.

Original issue's description:
> [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.
>
> The 10.11 SDK has an incompatibility with a OS X 10.7 deployment target.
> ApplicationServices re-exports CoreGraphics, but due to a bug, the dylib
> compatibility version from the re-exported framework gets confused with
> the version of the framework doing the re-export.
>
> This only manifests itself in the component build because individual
> components depend on CoreGraphics directly instead of ApplicationServices.
> In the static library build, the transitive collection of libs ensures that
> ApplicationServices gets linked before CoreGraphics when linking the
> Chromium Framework, so this doesn't occur.
>
> To hack around the issue, specify ApplicationServices in libs ahead of
> CoreGraphics so that the correct compatibility version is picked up. After
> the deployment is updated to 10.8+ (https://crbug.com/580152) these hacks
> can be removed.
>
> BUG=620127
> R=mark@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f7bc190c7ffeda2a2c56161b371bc16750fac2c

TBR=mark@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=620127

Review-Url: https://codereview.chromium.org/2118563002
Cr-Commit-Position: refs/heads/master@{#403392}

Network emulation is a desktop-only feature, so Android testing needs to be disabled.

BUG=chromedriver:984

Review-Url: https://codereview.chromium.org/2115723002
Cr-Commit-Position: refs/heads/master@{#403391}

Context is not final so there is no need to create a wrapper for it.
We extend MockContext directly in our fakes.

Adds a new setHasAndroidLocationPermission that sets a new factory
for LocationUtils to return true or false.

Follow up patch of http://crrev.com/2038753004

Review-Url: https://codereview.chromium.org/2100313003
Cr-Commit-Position: refs/heads/master@{#403390}

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/view?usp=sharing

BUG=613465,624129
TEST=manually.

Review-Url: https://codereview.chromium.org/2109563002
Cr-Commit-Position: refs/heads/master@{#403389}

* //ash/system/chromeos/bluetooth
* //ash/system/chromeos/enterprise
* //ash/system/chromeos/supervised
* //ash/system/chromeos/tray_caps_lock.*

Purely mechanical, no functional changes.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2108403004
Cr-Commit-Position: refs/heads/master@{#403388}

This matches the behavior of the existing history page.

BUG=623014
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2106363002
Cr-Commit-Position: refs/heads/master@{#403387}

TBR=jam@chromium.org
BUG=605318, 618468

Review-Url: https://codereview.chromium.org/2113893003
Cr-Commit-Position: refs/heads/master@{#403386}

And also verify draw transform calculations where the destination is
not the root.

BUG=622372
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2112973003
Cr-Commit-Position: refs/heads/master@{#403385}

while borrowing the lab device to do the debugging

BUG=618089

Review-Url: https://codereview.chromium.org/2114813002
Cr-Commit-Position: refs/heads/master@{#403384}

By this CL, Google sites shown in Drive folder have correct icon, file-type description, and file extension.

BUG=597210
TEST=manually confirmed

Review-Url: https://codereview.chromium.org/2113723003
Cr-Commit-Position: refs/heads/master@{#403383}

Users who don't have first setup complete, but are signed in without sync
suppressed, are in an invalid state, likely from previous issues in the
sign in flow. We were purging their sync data over-aggressively on startup
previously, causing a resync of the control types on each restart. Now we
simply leave the data around, and only purge if the user is actually signed
out.

BUG=624915

Review-Url: https://codereview.chromium.org/2113453006
Cr-Commit-Position: refs/heads/master@{#403382}

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2110663007
Cr-Commit-Position: refs/heads/master@{#403381}

There is no reason why the methods should be non-const. More importantly
it allows us to pass the observer as a const reference to lambdas or
callbacks that need to check its properties.

BUG=580406

Review-Url: https://codereview.chromium.org/2096043002
Cr-Commit-Position: refs/heads/master@{#403380}

Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )

Reason for revert:
Breaks aura_demo target

Original issue's description:
> Link to DirectWrite directly, instead of calling LoadLibrary
>
> BUG=
>
> Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> Cr-Commit-Position: refs/heads/master@{#403344}

TBR=scottmg@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2117683002
Cr-Commit-Position: refs/heads/master@{#403379}

The existing 'deadline' heuristic has proven to be very flawed on some
systems, for reasons explained in the bug. This change adds a new
experimental heuristic, activated via a new command-line switch, for lab
testing: --cast-encoder-util-heuristic=backlog<N>

If the new heuristic proves to work well across our lab's gamut of test
systems, a future change will remove the command-line switch and make
the new heuristic the default.

BUG=chrome-os-partner:54806

Review-Url: https://codereview.chromium.org/2108373002
Cr-Commit-Position: refs/heads/master@{#403378}

Review-Url: https://codereview.chromium.org/2113173002
Cr-Commit-Position: refs/heads/master@{#403377}