GitLab

Bug: 
Change-Id: Ica61e6cd7a1932124296f00aea1b8e73400f74d0
Reviewed-on: https://chromium-review.googlesource.com/544451Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481815}

Previous attempt: https://codereview.chromium.org/2891843002

This attempt includes a fix for //chrome/test/data/nacl/BUILD.gn
in official builds.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2957523002
Cr-Commit-Position: refs/heads/master@{#481814}

It will be used from:
https://chromium-review.googlesource.com/c/527016/

BUG=729905
TEST=it builds.

Change-Id: I7344ed4f86705a7f46b7f6b5791f340fabb94157
Reviewed-on: https://chromium-review.googlesource.com/544453Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481813}

Mojo CDM is still in development and some tests are not working. Filed new bugs
and disable those failing tests for now. We'll gradually fix the implementation
and reenable those tests.

BUG=403462

Change-Id: I5af5a1b2a3c64077bc109a51ec019d1f7b6de8ea
Reviewed-on: https://chromium-review.googlesource.com/527654
Commit-Queue: Xiaohan Wang (OOO June 21-22) <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481812}

BUG=520170
TBR=skyostil@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2956573002
Cr-Commit-Position: refs/heads/master@{#481811}

This patch makes |Position::FirstPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.

This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952983002
Cr-Commit-Position: refs/heads/master@{#481810}

For auxillary threads that rarely need to gain access to another
thread's GC heap, we have to ensure that this happens while the
heap-owning thread isn't concurrently GCing the heap. Otherwise there
is the possibility that heap objects might be relocated or mutated
while the auxillary thread tries to access.

A CrossThreadPersistent<T> (CTP) ensures reference liveness across
threads, but isn't sufficient to handle the wanted exclusive access
after a non-attached thread has deref'ed the persistent. So, for
this to happen, keep the global CTP lock while accessing a heap
object during offline audio rendering -- it specifically accessing
heap objects while a GC runs. As all GCs hold the lock on the global
CTP region while they run, this ensures exclusion.

It is clearly desirable to have all heap access be under the control
of the heap-owning thread, and threaded code should try hard to avoid
accessing another thread's heap objects. The CTP global lock is the
mechanism to use when that isn't practically feasible -- feel free to
add a "TODO(foo): avoid using" next to any instances that you end up
introducing.

As regards audio thread cross-thread usage, the code needs auditing to
check if there are other places where setting up this CTP lock is
required.

R=haraken,rtoy,hongchan
BUG=732511

Review-Url: https://codereview.chromium.org/2951903003
Cr-Commit-Position: refs/heads/master@{#481809}

This patch adds an Observer interface to WebFrameScheduler so that
platform/loader can implement Blink scheduler backed throttling scheme.

Observer will be notified when scheduler's throttling state is changed.
Internally, this means the page visibility is changed to which the frame
belongs.

BUG=729953

Change-Id: I851b153fef2e0c6ada748bee997bc1e69292e08d
Reviewed-on: https://chromium-review.googlesource.com/525198Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481808}

These tests are flaky on Mac and likely flaky everywhere.

TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,horo@chromium.org
BUG=595993
NOTRY=true

Review-Url: https://codereview.chromium.org/2950253003
Cr-Commit-Position: refs/heads/master@{#481807}

This is the first of a series of CLs to expose the GetSecurityStyle()
explanations (currently only used in the DevTools Security panel overview,
untranslated) in the Android connection info popup (translated). It does two
things:

- Mention the issuer in the certificate bullet (for feature parity with the old
  Android connection info popup).
- Swap TLS connection settings values with their descriptions to avoid phrase
  substitution within a clause (for straightforward translation).

The relevant strings retain `translateable="false"` until a future CL, due to
non-trivial runtime logic about when to translate the strings.

BUG=587255, 657299
TEST=Open the DevTools Security panel, visit https://google.com, and verify that there is a green bullet stating "The connection to this site is using a valid, trusted server certificate issued by Google Internet Authority G2."

Review-Url: https://codereview.chromium.org/2951043002
Cr-Commit-Position: refs/heads/master@{#481806}

This gets an individual log from debugd.

BUG=733846

Review-Url: https://codereview.chromium.org/2944403002
Cr-Commit-Position: refs/heads/master@{#481805}

Currently, all boolean storage_only fields in ComputedStyle need to
specify field_size: 1. This is kind of redundant, because it will never
be any other value.

This patch removes the need to specifiy field_size for boolean
storage_only fields.

This does not change generated code.

Bug: 628043
Change-Id: Iccba6c299847c35e3a4c2fd19d4d2f9e85e3e62d
Reviewed-on: https://chromium-review.googlesource.com/544475
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481804}

This patch makes all subgroups on ComputedStyle private to ensure that
no function depends on the way grouping happens in ComputedStyle.

Diff: https://gist.github.com/nainar/13876826757ad4d2c99520f99a8ac875/revisions

Bug: 710938
Change-Id: I2d2d7d5cff3fc64361b9bf42c4ea2496f3130f7f
Reviewed-on: https://chromium-review.googlesource.com/544450Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481803}

This CL sync icon used for extension dialog with default one used to
represent extension based app.
This additionally fixes following issues:
  - base class for uninstall dialog and implementation has own
  expectations for icon size. Now use only one source to define icon
  size.
  - Provide correct loading of icons for non-standard device scale
  factors.

For mechanical change in extension_uninstall_dialog_cocoa.mm
TBR=ellyjones@chromium.org

      desktop.

Bug: 730853
Test: Manually on Cave (1.25 scale factor), Linux Chrome OS + Linux
Change-Id: Ib3d1c80d6883a079728b917efc726e9458b6bacb
Reviewed-on: https://chromium-review.googlesource.com/527527
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481802}

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710

Review-Url: https://codereview.chromium.org/2952283002
Cr-Commit-Position: refs/heads/master@{#481801}

To bring in line with spec
https://w3c.github.io/web-animations/#the-animationtimeline-interface

BUG=624639

Review-Url: https://codereview.chromium.org/2952783002
Cr-Commit-Position: refs/heads/master@{#481800}

This patch introduces |VisibleSelection::CreateWithoutValidationDeprecated()|
as replacement of |SetWithoutValidation()| to make |VisibleSelection| as
virtually immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952973002
Cr-Commit-Position: refs/heads/master@{#481799}

This patch updates the documentation for the web-platform-tests suite
in the README file for LayoutTests/external.

Change-Id: I292bf3d077a14ce8132448356275657b2da9614f
Reviewed-on: https://chromium-review.googlesource.com/544416
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481798}

This patch removes references to the following groups and replaces
those accesses with direct getters/setters:
1. TransformData
2. MultiColData
3. GridData
4. ScrollSnapData
5. DeprecatedFlexibleBoxData

Bug: 710938
Change-Id: I7ea899d943beae130f3289f7fba37d6f4e3eb6f2
Reviewed-on: https://chromium-review.googlesource.com/544715
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481797}

transform-function is changed to transform-list.
<transform-list> is already a space separated list,
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-strings
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877

Review-Url: https://codereview.chromium.org/2951763002
Cr-Commit-Position: refs/heads/master@{#481796}

Move AllDownloadItemNotifier to the content layer.  It has no
dependencies on the chrome layer and a component needs it.

BUG=734294

Change-Id: I4edee3c9ce50578e685632a8e47b18ebcb915dcf
Reviewed-on: https://chromium-review.googlesource.com/539060
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481795}

BUG=490942
R=skobes@chromium.org

Change-Id: Iebbc4bb472015c3140b2d9e0ca0dd61dd82c6b65
Reviewed-on: https://chromium-review.googlesource.com/526954
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481794}

Cr-Commit-Position: refs/heads/master@{#481793}

TBR=thomasanderson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=660216

Review-Url: https://codereview.chromium.org/2956553003 .
Cr-Commit-Position: refs/heads/master@{#481792}

//device/generic_sensors already has all the sensors that can be used
to implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from
//device/sensors as its backend, and this is one of the CLs that refactor
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor.

The issue page contains the design doc link for this change.

BUG=721427

Review-Url: https://codereview.chromium.org/2896583005
Cr-Original-Commit-Position: refs/heads/master@{#480934}
Committed: https://chromium.googlesource.com/chromium/src/+/687e6a76c9d634404eb93643ab900596a77958fd
Review-Url: https://codereview.chromium.org/2896583005
Cr-Commit-Position: refs/heads/master@{#481791}

Upstream some rules in blink_idl_parser to idl_parser.

BUG=617899

Change-Id: Ib9c0e68b1e81ab41147e01c5281e3e7f8366999d
Reviewed-on: https://chromium-review.googlesource.com/544724Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481790}

After my context menu refactor (crrev.com/2785853002),
SelectionPopupController.createActionMenu() and the setting of mIsInsertion
happened on two different threads. This lead to a race-condition in
SelectionPopupController.createActionMenu() since it relied on isInsertion().
This CL removes the race-condition by relying on hasSelection() instead of
isInsertion().

BUG=730996

Review-Url: https://codereview.chromium.org/2954023002
Cr-Commit-Position: refs/heads/master@{#481789}

Previously, there was a device ID section which was never actually updated, leading to confusion by dogfooders. With this change, it is actually shown in the WebUI page.

BUG=672263

Review-Url: https://codereview.chromium.org/2953863002
Cr-Commit-Position: refs/heads/master@{#481788}

This is a reland of 1d629632

I had assumed that unregistered crash keys would be a nop but they need
to be registered or else a DCHECK is triggered.

I also made sure gpu/config/gpu_crash_keys is used as the source of
truth for gpu related crash keys.

Original change's description:
> gpu: Add message filter destructor stack traces to crash keys.
> 
> base::debug::Alias values don't show up in minidumps. Using crash keys
> is recommended for use-after-free bugs in the following doc:
> http://dev.chromium.org/developers/debugging-with-crash-keys
> 
> R=jbauman,rsesek,sandersd
> BUG=729483
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I8fd129daf66dc9235307a28fe5cd7a6c23b85a94
> Reviewed-on: https://chromium-review.googlesource.com/538056
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: John Bauman <jbauman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480879}

TBR=jbauman,sandersd

Bug: 729483, 735175
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I05c46bb583135dff05d5bc75dff694a1caa54b32
Reviewed-on: https://chromium-review.googlesource.com/541937Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481787}

When enabling sharding, I forgot to also enabling the merge script.

BUG=717346,524758
TBR=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2958453002
Cr-Commit-Position: refs/heads/master@{#481786}

Couple modifications to errors/warnings in setup pin dialog:
1) Shows min length warning right away
2) On confirming pin step, only show mismatch error when confirm button clicked
3) Min length warning becomes error once user exceeds min length, but goes back under min length threshold.

Bug: 723800
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7fb9dd7f18c8555a3d247b8a2613574abe696b32
Reviewed-on: https://chromium-review.googlesource.com/540744Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481785}

This reverts commit 26834276.

Reason for revert: These tests are still failing on WebKit Android (Nexus4):
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

Example build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/66197


Original change's description:
> Reland of "Moves mojo_js_integration_tests into blink."
> 
> This reverts commit c461e58e.
> 
> Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/
> 
> Original change's description:
> > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
> >
> > Reason for revert:
> > WebKit Android (Nexus4) are still broken with four failing tests:
> >   JsToCppTest.BackPointer
> >   JsToCppTest.BitFlip
> >   JsToCppTest.Ping
> >   JsToCppTest.Echo
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> > Reviewed-on: https://chromium-review.googlesource.com/538520
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#480282}
> 
> TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org
> 
> Bug: 699569
> Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
> Reviewed-on: https://chromium-review.googlesource.com/540664
> Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481712}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Change-Id: I496aba914c51b914ffb8082d9d6cb4c8cf45f590
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699569
Reviewed-on: https://chromium-review.googlesource.com/544452Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481784}

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c24

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2950393002
Cr-Commit-Position: refs/heads/master@{#481783}

Previously, the Advanced, Networks, and Proxy fields were shown, which are not related to Tether networks.

BUG=672263,730246
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2949363002
Cr-Commit-Position: refs/heads/master@{#481782}

This CL adds SuperfishBlockingPage and SuperfishErrorUI classes to display the
Superfish interstitial. SSLErrorHandler checks for the Superfish certificate
fingerprint and uses a SuperfishBlockingPage (a subclass of SSLBlockingPage)
when it's present.

The strings displayed by SuperfishErrorUI are stubs for now; those will be
filled in to match the mocks in a follow-up.

SSLBlockingPage is modified a bit to allow a subclass that uses its own subclass
of SSLErrorUI. And SSLErrorUI is modified a bit to allow a subclass that uses
special strings.

The certificate error report format is updated to report when the Superfish
interstitial is shown (similar to how clock and captive portal interstitials are
reported). Certificate reporting for the Superfish interstitial is missing a
test; see https://crbug.com/735803.

This is all gated behind the SuperfishInterstitial Finch feature.

BUG=734590

Review-Url: https://codereview.chromium.org/2949003003
Cr-Commit-Position: refs/heads/master@{#481781}

These tests were broken by https://codereview.chromium.org/2789723003

NOTRY=true
TBR=scottmg@chromium.org
BUG=729849

Review-Url: https://codereview.chromium.org/2958443002
Cr-Commit-Position: refs/heads/master@{#481780}

Up until now, the documentation for the feature engagement tracker has
been focused around developing it itself. However, going forward it will
be more beneficial to have documentation for how it should be used.

This CL adds documentation around the following topics:
* Objectives for the service.
* Overview of how it works.
* How to develop a new In-Product Help feature.
* How to enable UMA tracking for new In-Product Help features.
* How to use demo-mode.
* How to use Chrome Variations to locally test In-Product Help features.
* Thorough description for how to configure though Chrome Variations.

BUG=None

Change-Id: I2358b872b07dcaa56df2ae831f47240dee799287
Reviewed-on: https://chromium-review.googlesource.com/524532
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481779}

This argument controls whether the WebContents needs to be reloaded
when activated. Not reloading the WebContents as soon as it is
activated will allow TabManager to implement more advanced reload
rules (e.g. browser window is active, tab has been active for x ms).

Note: Today, a WebContents is considered "active" if it is in a
selected tab, even if the browser window is not visible.

TBR=bauerb@chromium.org,chrisha@chromium.org,bengr@chromium.org

Bug: 731145
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I87a16df112752b97bcc369e34a1e1f86d18d9b99
Reviewed-on: https://chromium-review.googlesource.com/531065
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481778}

This CL extracts the struct Geoposition out of geolocation.mojom 
into a file on its own. No new code.


Bug: 
Change-Id: I6350537ccd19d1da0b02f3c8489fa39a06740376
Reviewed-on: https://chromium-review.googlesource.com/543577Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481777}

This both simplifies the code and fixes the selection bug. The original
code relied on multiple inherited Polymer behaviors which stomped on each other
causing what seems like a race condition per findings at
https://bugs.chromium.org/p/chromium/issues/detail?id=734789#c2.

Specifically:
 - Simplify logic within cr-profile-avatar-selector-grid, no more inherited
   behaviors.
 - Update both settings/ and md_user_manager/ client code.
 - Stop relying on bubbling 'iron-activate' event in manage_profile.html.
   Instead use a Polymer binding + observer.

Regarding the race condition: The previous code, was seemingly attempting to
highlight the grid with the currently selected avatar icon on creation, but
unsuccessfully because this was intentionally broken within the C++ side at
crbug.com/710660. As a side-effect, the 'profile-info-changed' event
propagating back from C++ after every user-initiated change, was causing the
selection of the user to be immediately discarded.

It would make little sense to re-implement JS functionality that is already not
working. Instead I am removing such tests, since they are meaningless until/if
the C++ side is fixed.

BUG=734789
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2950943002
Cr-Commit-Position: refs/heads/master@{#481776}