- 17 Jan, 2020 40 commits
-
-
Caleb Rouleau authored
This is necessary for Pinpoint, which still uses these isolates. This is a fix after https://chromium-review.googlesource.com/c/chromium/src/+/2003767 landed. See the bug for details. TBR=bsheedy@chromium.org Bug: 1042778 Change-Id: Iff81712f2e3f6d26171064922056361e9fc7b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006391Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732746}
-
rbpotter authored
This fixes a Polymer timing issue where setting the margins in the margin-control-container was causing the observer in margins-settings that updated the UI to not fire. Also moving the margins setter in pages_per_sheet to margins for consistency. Bug: 1041378 Change-Id: I83bebfefe8fb306bc332844e5a146271a7ac2b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000523Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732745}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1578307131-benchmark-81.0.4019.0-r1 to 81-3987.39-1578912426-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ida8a7bcad16f06d55e8d2ec3eecdd0e258fbc104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732744}
-
Yi Xu authored
Metrics Compositing.Renderer.RasterTask.RasterUs.Software and Gpu are erroneously obsolete. This is because metrics Compositing.Renderer.RasterTask.RasterUs is marked obsolete. Bug: 817041 Change-Id: I6b96758790c33d21b1e6615920f6ce2cd99d4c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006169Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#732743}
-
Hitoshi Yoshida authored
Changes output path of dictionary files from third_party/blink/(core|modules)/xxx/yyy/zzz.{h,cc} to third_party/blink/bindings/(core|modules)/v8/v8_zzz.{h,cc} Bug: 839389, 1034398 Change-Id: I47504d8bd263b07d8ff74c8306bb48e702580f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004363 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#732742}
-
Jiajun Ou authored
Change-Id: Ia1980395380f62708b89fff2f9d5208165d58e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006830Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#732741}
-
Nicolas Ouellet-Payeur authored
Previously, update_annotations_sheet.py would "play nice" with existing rows that were for another platform. For instance, when running the script, it would leave the "chrome_cleaner" annotation (which is Windows-only) in the spreadsheet. This causes issues on waterfall, because running the bot on Windows creates empty rows (placeholders for Linux-only annotations), which cause it to fail on subsequent runs (as the script doesn't expect empty rows). This CL fixes the issue by making update_annotations_sheet.py delete annotations that are for other platforms. So running the script on Linux will delete Windows-only annotations from the sheet, and vice-versa. Change-Id: I8d0d026f7f4eb94e6c482ca70610b5be7224d0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003307 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#732740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b186101c357..d58b643f10f5 git log 7b186101c357..d58b643f10f5 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 reed@google.com undo SkMatrix() cast -- must be done by sksl machine 2020-01-16 egdaniel@google.com Remove GrPixelConfig from validateSurfaceParams 2020-01-16 egdaniel@google.com Pass in a GrColorType into our Copy call. 2020-01-16 mtklein@google.com little debug/profiling tool cleanups 2020-01-16 bungeman@google.com Avoid BOT/EOT setting in HarfBuzz. 2020-01-16 fmalita@chromium.org [skottie] Refactor property animators 2020-01-16 herb@google.com Isolate updating grTextStrike 2020-01-16 csmartdalton@google.com Add a --scale flag to skpbench 2020-01-16 reed@google.com Make converting from 4x4 to 3x3 explicit 2020-01-16 bsalomon@google.com Disallow GrTextureDomain::kIgnore_Mode in SkGpuBlurUtils::GaussianBlur. 2020-01-16 jvanverth@google.com Reland "Reland "Add new method for storing DrawOpAtlas texture index."" 2020-01-16 robertphillips@google.com Add SkImage::CompressionType::kBC1_RGBA8_UNORM support 2020-01-16 csmartdalton@google.com Fix single-pass tessellator wedges 2020-01-16 michaelludwig@google.com Re-enable QCOM_tiled_rendering, but check for gl functions 2020-01-16 mtklein@google.com DCI-P3 -> Display P3 in Skia Created with: gclient setdep -r src/third_party/skia@d58b643f10f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: If527d60d0024946005f6b9bcc4aac3333d4fea31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006486Reviewed-by:
-
Rachel Sugrono authored
Add two non-consecutive files to a check-select (aka a multi- selection). Quick View should open in check-select mode with the first file being displayed. Bug: 1038799 Change-Id: I1fada68b30ae3bd48df69d96669255aa166787ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006892Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732738}
-
Christopher Cameron authored
Bug: 1042781 Change-Id: Iebb86d120aab538517ae6c087f815f2eb89811de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003897Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#732737}
-
Keishi Hattori authored
ColorChooserPopupUIController's prefinalizer closing the popup allocates new objects which is not allowed. ColorChooserPopupUIController's prefinalizer which closes the popup should not exist. In normal use, the popup will be explicitly closed before ColorChooserPopupUIController is destroyed. The only exception is the Internals::endColorChooser() which releases the ColorChooser without closing the popup. This CL fixes Internals::endColorChooser(). Bug: 1040389, 1039092 Change-Id: Ib52c80e5288ac7a115409706c96c3ba226357dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004365 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732736}
-
Xianzhu Wang authored
The tests are constantly passing. TBR=wangxianzhu@chromium.org Bug: 1018273 Change-Id: I1369632b918965f0864a3dba2c6792a2e5ee23ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005548Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732735}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c1086a36ade..3f0bc2c1766a git log 4c1086a36ade..3f0bc2c1766a --date=short --first-parent --format='%ad %ae %s' 2020-01-16 sansid@google.com Revert "Enable using a custom NetEqFactory in simulations" 2020-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7356cb88..112d1736 (732376:732519) 2020-01-16 ivoc@webrtc.org Enable using a custom NetEqFactory in simulations 2020-01-16 srte@webrtc.org Reland "Moves TransportFeedbackAdapter to TaskQueue." 2020-01-16 kron@webrtc.org Distinguish between send and receive codecs 2020-01-16 danilchap@webrtc.org Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Created with: gclient setdep -r src/third_party/webrtc@3f0bc2c1766a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I67c71458afc5f42c15c7b23f33cca469b77ea7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006609Reviewed-by:
-
Patrick Monette authored
The DedicatedWorkerService is a simple interface that can be used to subscribe to the lifetime of dedicated workers. This interface will be used by the Performance Manager to track dedicated workers. Bug: 993029 Change-Id: I9d189d828c7232bb691c2602c7cc99f7dede8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990263 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#732733}
-
Wei Lee authored
Bug: b/147778989 Test: Manually tested with https://crrev.com/c/2004140 Change-Id: I495d4ca19b81a6d0f556e77d08f07f1b866f7266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004430Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#732732}
-
Hajime Hoshi authored
Page in back-forward cache can be hidden too, so rename the methods to avoid confusion. R=csharrisson@chromium.org BUG=1001087 Change-Id: I3e2a00ecbaf64275bc5cb46c8ab7662f5ad661cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004367Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732731}
-
Aaron Colwell authored
Adding a crash key to make it easier to track down what document URLs are triggering renderer kills. Bug: 977169 Change-Id: I3133772d919d1ab5aabd32997a0ddc58e3af14b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006590 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#732730}
-
Charlene Yan authored
Bug: 1041636 Change-Id: Ic36f25c04f117af7695b6c0b00cdca89478ee84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005390Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732729}
-
Alexandre Courbot authored
The Youtube Android app will sometimes send an invalid frame number after seeking, which triggers an error with the H264Decoder. Until this is fixed, this workaround prevents decoding from failing every second seek. BUG=b:146914440 BUG=b:129119729 TEST=Can seek without issue or artefacts in the Android Youtube app on Krane. Change-Id: I8b6ca5f4c53a67e934c918023ab987e7a0009ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000258 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732728}
-
Kuo Jen Wei authored
Rename several view names as follows: camera -> view-camera expertsettings -> view-expert-settings gridsettings -> view-grid-settings message-dialog -> view-message-dialog photoresolutionsettings -> view-photo-resolution-settings resolutionsettings -> view-resolution-settings settings -> view-settings timersettings -> view-timer-settings videoresolutionsettings -> view-video-resolution-settings warning -> view-warning Bug: 1024811 Test: tast run <DUT> 'camera.CCAUI*' Change-Id: I2b1e6dc4b59d1c46e9c1add1363580cd4a992ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999898 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Bug: 1023035 Change-Id: Ie227ad87af4bba0cdb6f864e609b8b4103a2d603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001412 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732726}
-
Demetrios Papadopoulos authored
The Polymer 2 version is not used anymore, therefore no auto-generation is necessary and the v3 version can be directly checked in. Fixed: 1042545 Change-Id: Ia0267cef30dcf1eb08677d369fd3f8ded21c679f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006421 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732725}
-
chrome://sandboxAlex Gough authored
This should be useful as more services with finer grained sandboxing are introduced. Bug: 997273 Change-Id: I2996c8b32fa9f46bd1a32aa7b80d99d094f020a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006129Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732724}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d968972519ba..41f6150edb16 git log d968972519ba..41f6150edb16 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 sugoi@google.com Stubs for new required extensions 2020-01-16 sugoi@google.com Add blendable checks to GL_EXT_color_buffer_float 2020-01-16 rafael.cintron@microsoft.com Fix FL10_0 multisampling Created with: gclient setdep -r src/third_party/angle@41f6150edb16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036367 Tbr: jonahr@google.com Change-Id: I6b0e6ec62522a3bf607cc0c85e0b00a0beb42ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006621Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c86e356c31a9..7891b46fd46e git log c86e356c31a9..7891b46fd46e --date=short --first-parent --format='%ad %ae %s' 2020-01-16 dhoss@chromium.org Add nullptr checks prior to accesses of CPDF_Document::GetDocExtension() 2020-01-16 tsepez@chromium.org Remove unused one-arg form of IsAppearanceValid(). 2020-01-16 tsepez@chromium.org Add test for growing gap in CFDE_TextEditEngine::AdjustGap(). 2020-01-16 tsepez@chromium.org Avoid underflow before calling CFDE_TextEditEngine::AdjustGap(). Created with: gclient setdep -r src/third_party/pdfium@7891b46fd46e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029437 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9219e3f50942bdc59bd2c03d723e85040948ef14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006611Reviewed-by:
-
Simon Que authored
Bug: 1040754 Change-Id: I8dd70f96b3299797721d2f41f1516028d650484b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004348Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#732721}
-
Azeem Arshad authored
This CL adds a comment in settings_ui.cc to clarify usage of MultideivceHandler. Bug: 845706 Change-Id: Ib2d1b34dac11b52ba8374f146400f3a9c5ac8001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006618 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732720}
-
Akihiro Ota authored
This change modifies the behavior of the darken screen feature. Previously, the user could use [Search + Shift + f7] to darken the screen and [Search + f7] to un-darken the screen. Now this feature behaves like a toggle, so users can press [Search + f7] to toggle between the two states. Bug: 949198 Change-Id: I5003de4983b6d8b730b2e5c823fd48981e05d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951965Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mrefaat@chromium.org Bug: 1041419 Change-Id: If6f5add12f826fc758e76b6540736e540b871b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997910 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#732718}
-
Hiroki Sato authored
Bug: None Test: browser_tests --gtest_filter="AccessibilityFeaturesApiTest*" Change-Id: I075f1c3c563ee311e733bf7dea59cbcf1c41cf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994551 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732717}
-
Caleb Rouleau authored
With the work to move gtests onto the shard maps, the overhead should be reduced and we can change this from 5.5 hours to 6 hours. This will reduce the chance of timeouts of these shards. This is an adjustment from the earlier change https://chromium-review.googlesource.com/c/chromium/src/+/1977965 Bug: 1041692, 1041696 Change-Id: I88661366c3f2ed058ed3d3b247c309d0f3e48957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006612 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732716}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Icc68359187a88ce497e8c6df546031e11bffea0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006443Reviewed-by:
-
Luciano Pacheco authored
Follow up of CL:1991038: Renames parameters from windowId to appId and make their documentation consistent. Bug: 778674 Change-Id: Idc7790795f547ad6a2ff054341c4cbee28561dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997005 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Li Lin authored
The feature is guarded by a feature flag that is currently disabled by default. This CL implements a temporarily UI for getting early feedback on product and data quality while we are figuring out the final UI. More detail at: go/quick-answers-cros and go/quick-answers Bug: 1020004 Test: Unit tests Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732713}
-
Bettina authored
There was an extra "and" in between the domains. Bug: 1037953 Change-Id: I6c8c81f7a1bdd27f5891fe3aa86619038efd5543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982702 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732712}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/251c76530213..91096f77a581 git log 251c76530213..91096f77a581 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 dberris@chromium.org Remove cron.yaml from automatic deployment Created with: gclient setdep -r src/third_party/catapult@91096f77a581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040775 Tbr: rmhasan@google.com Change-Id: Ib1bec1381f5618a264bfe1a79e0341fd3ef0b561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006608Reviewed-by:
-
Ben Kelly authored
This CL converts an unsafe base::Unretained() to target the MediaStreamTrackMetricsHost object directly which is deleted on the same thread as the callback. This comes at the cost of pre-allocating the object instead of lazily creating it when the first receiver is bound. This cost does not seem too great since the object consists of an empty std::map and mojo::ReceiverSet. In addition, the CL attempts to document why the remaining base::Unretained() usage is safe. Bug: 1040396 Change-Id: I094091c4672c412086059c56804efb3d743a2c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005291 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732710}
-
chrome://flagsDavid Staessens authored
This CL adds a flag to chrome://flags to manually enable/disable the ChromeosVideoDecoder feature. This Feature enables the new media::VideoDecoder-based video decoders on ChromeOS. TEST=enabled/disabled flag in Chrome on nocture, and verified logs BUG=None Change-Id: I5df33207f7f2081260a66c8406fc0dceed7a0cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997431 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#732709}
-
Kazuki Takise authored
CTS requires a PIP window to stay at the initial position that Android calculates. However, Chrome sometimes adjusts the bounds unexpectedly when always on top is set because setting always on top triggers UpdatePipBounds, and depending on the density, the initial bounds is adjusted by one pixel. With this CL, PIP bounds update is defered while always on top is set. Other possible ways to fix this issue are: - Don't update PIP bounds for WM_EVENT_ADDED_TO_WORKSPACE. - Ignore bounds change for PIP if it's one (or a few) pixel difference. Note, changing bounds calculation logic on either Android or Chrome side so there's no gap between the bounds calculated by them doesn't work because because DP -> pixels is not a surjection and Chrome may be unable to place the PIP window in the place Android wants (and vice versa). BUG=b:147396441 BUG=b:145881485 TEST=atest android.server.am.ActivityManagerPinnedStackTests TEST=#testEnterPictureInPictureSavePosition Change-Id: I60bfef4620459c0d3f604d3c1641864fc589c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969090Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#732708}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5c6a3c247590..2cb1db08e5f1 git log 5c6a3c247590..2cb1db08e5f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bclayton@google.com SpirvShaderDebugger: Implement OpenCL.Debug.100 Created with: gclient setdep -r src/third_party/swiftshader@2cb1db08e5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic212aaf520c20bc6d5158abea208f078e76d87cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006476Reviewed-by:
-
