GitLab

Never expire one key histogram for Contextual Search that indicates how
often something useful is being shown in the Bar.

This is a key metric for usefulness of the feature.

BUG=1089460

Change-Id: Ic973ecfeb7e47d14aaeaf039aed2815ddc57ad2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425423
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810443}

Drops various GetDownloadProgress() APIs from the PDF viewer because:

1. We never call pp::URLRequestInfo::SetRecordDownloadProgress(), so
   calls to pp::URLLoader::GetDownloadProgress() always return false.
2. We only use GetDownloadProgress() in DocumentLoaderImpl, to try to
   get the total content length if we fail to get it from the
   Content-Length header. But the total content length reported by
   GetDownloadProgress() also comes from Content-Length, so this is not
   useful.
3. GetDownloadProgress() won't be useful post-Pepper, as
   blink::WebAssociatedURLLoader does not have a similar API. Instead,
   the client is expected to track this internally.

Bug: 1099022
Change-Id: I6f2f183e84b2d9e4c0dee2c116ac08bce3dc4ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429545Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810442}

Bug: 973801
Change-Id: I001b71e204baaaf5cfd7f8e14b8683a58d1907a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429244Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810441}

TBR=benmason@chromium.org

Change-Id: Id98e0e2c3f27a7077205fd991e6f79cc64a38434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429429Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810440}

These tests have been disabled for a long time, and don't seem to be
testing anything useful.  Remove them completely.

Bug: None
Change-Id: I86126e852498d51d28ba2ded0f42ca61c9ad1798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424725Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810439}

In response to comment on crrev.com/c/2384332.

Per mpearson@: For enums versus sparses, the underlying UMA
data / logs will look the same.  It's only the implementation
in Chromium that would be different.

Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810438}

All of these tests were triggering starting the "real" TTS engine, even
though a mock TTS engine was installed.

I ran all of the ChromeVoxBackground tests before and after this change
on my system with --test-launcher-jobs=20. If the speech engine is
installed, the average test time drops 30%, from 8200 ms to 6200 ms.
Even if the speech engine is not installed, it still drops 25% from
7700 ms to 6200 ms.

Bug: none
Change-Id: Iea23951ce397176cd1fda64d801422f3031a1fba
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422585
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810437}

RendererFrameHost could have been removed (e.g., because the page has
navigating away), when payment_request_factory is trying to create the
desktop PaymentRequest service. So payment_request_factory should
check RendererFrameHost.isCurrent() before the creation of the service.

Bug: 1131214f

Change-Id: Idde6077f1ce559072f7272b52b0d994d93aab805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426252Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810436}

This patch adds a browser-side flag that can be used to disable the
feature regardless of the Blink feature state.

Bug: 1131040
Change-Id: Ie879301e62404c6c73cf7dc39b2c12ad5908e4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430044
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810435}

This CL moves the code checking the SODA paths to before the service
is launched.

Bug: 1121384
Change-Id: I70e1caf6086dce94a25c425a2959381293545bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429745Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#810434}

Bug: 1131842
Change-Id: I0612adf1075e417bcb43cd24b69b19b96be6b7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429785
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810433}

This wasn't carried over when I added the translate-target because
I don't really understand its intention. Update test and comment.

Before: http://screen/3Uh7wzmoFjZVHTN
After: http://screen/BVcaJp66E8CpSvs

Bug: 1113439
Change-Id: I10fc16aa8287a0901ffc41599eba5cda42a0c926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428510
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810432}

This reverts commit 54974f6a.

Reason for revert: After evaluation, staying with green is decided.
BUG=b:167556640

Original change's description:
> [Bluetooth] Use secondary text color for device connectivity status.
>
> As per recommendation in Comment #30 of crbug.com/1114876. This
> is the same grey used in Network Settings secondary text.
>
> Bug: b:167556640
> Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141
> Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
> Reviewed-by: James Vecore <vecore@google.com>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805877}

TBR=khorimoto@chromium.org,hansberry@chromium.org,vecore@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:167556640
Change-Id: Ie4780eb924787986a80cf1dff00a0e48c5fd8207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429971Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810431}

This change gates the ability to use promises with the extensions API on
the calling context being associated with a Manifest V3 extension or
WebUI.

Bug: 978538
Change-Id: I3a1d11fdc128b7ad3728f7e95298ba73d089cde4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380341
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810430}

The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves.

Reland note: StatusBarColorController failed on L due to a difference in how colors should be calculated. I'm not positive why TabbedAppMenuTest failed, but it seemed to be a race condition triggered (or uncovered) by the change in timing caused by making observer notification async. I think I've fixed it by blocking on the call to showAppMenu rather than polling the status via the instrumentation thread.

Bug: 1129783
Change-Id: I88ac8efcc845826f0396cb624450ef1ba8d5b399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427428Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810429}

https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git/+log/439e81f8f484..8942a9ba43d8

$ git log 439e81f8f..8942a9ba4 --date=short --no-merges --format='%ad %ae %s'
2020-08-18 vitalybuka Update probuf revision
2020-07-29 vitalybuka Move cpplint invocation into a separate job
2020-07-29 vitalybuka Avoid parsing of last mutated message
2020-07-29 vitalybuka Use gmock in LibFuzzerTest
2020-07-28 vitalybuka Fix message before every LLVMFuzzerTestOneInput This is needed to make sure that corpus is still compartible.
2020-05-05 vitalybuka Update protobuf lib
2020-05-05 nareddyt Revert "Dissable AllowUnknownField"
2020-05-05 nareddyt Revert "Fix the test"
2020-04-24 vitalybuka Fix the test
2020-04-24 vitalybuka Dissable AllowUnknownField
2020-04-20 nareddyt Review comments
2020-04-17 nareddyt Add test
2020-04-17 nareddyt Allow unknown fields in corpus parser
2020-04-10 vitalybuka Add missing #include <iostream>
2020-04-10 vitalybuka Add missing #include <iostream>
2020-04-09 jorg.brown Add missing #include <iostream>
2020-03-26 vitalybuka Fix std::bitset overflow
2020-02-04 vitalybuka Lint fixes
2020-02-04 vitalybuka Add Clone test
2020-02-04 vitalybuka Improve efficiency of mutator by allowing Copy/Clone only in CrossOver
2020-02-04 vitalybuka Fix compilation issues for Google internal code
2020-01-29 vitalybuka Remove unnececary size_increase_hint adjustment
2020-01-29 vitalybuka Implement Any support Fixes #151
2020-02-04 vitalybuka Deflake FailedMutations test
2020-01-29 vitalybuka Accept arrays of messages in MutateImpl For #151
2020-01-29 vitalybuka Improve field test by preventing copying of top level messages
2020-01-29 vitalybuka Run InsertField for proto3
2020-01-29 vitalybuka Move CrossOver next to Mutate
2020-01-29 vitalybuka Combine post processing and initialization It's going to be useful for Any support
2020-01-27 vitalybuka Add Any tests for #151
2020-01-27 vitalybuka Reduce number of iterations in some tests
2020-01-27 vitalybuka Make test output more verbose
2020-01-27 vitalybuka Add google.protobuf.Any into test messages
2020-01-26 vitalybuka Remove unneded namespaces
2020-01-26 vitalybuka Implement CrossOver using Copy/Clone mutations
2020-01-26 vitalybuka Use bitset to controll allowed mutations
2020-01-26 vitalybuka Extract GetMaxSize function
2020-01-26 vitalybuka Clone implementation
2020-01-25 vitalybuka Use size_increase_hint selecting copy source
2020-01-25 vitalybuka format
2020-01-25 vitalybuka Use signed size_increase_hint
2020-01-25 vitalybuka Use max_size_hint instead of size_increase_hint
2020-01-25 vitalybuka Update README
2020-01-24 vitalybuka Take into account size_increase_hint selecting mutation
2020-01-24 vitalybuka Make post_processors_ private
2020-01-24 vitalybuka Allow to use a different message as "copy" source Preparation for #44
2020-01-15 vitalybuka Log message when IsInitialized assert fail
2020-01-08 vitalybuka Support multiple callbacks per message type Fixed #146
2020-01-07 vitalybuka Fix typo
2020-01-07 vitalybuka Update README.md
2020-01-07 vitalybuka Fix typo
2020-01-07 vitalybuka Fix typo
2020-01-07 vitalybuka Remove const
2020-01-07 vitalybuka Document PostProcessorRegistration
2019-10-08 vitalybuka Check post_processors_.empty() in CrossOver
2019-09-30 pefoley Add global mutator support
2019-09-06 vitalybuka Update googletest and protobuf
2019-09-06 vitalybuka Don't "post process" and InitializeAndTrim from recursive Mutate calls
2019-09-06 pefoley run clang-format
2019-09-06 vitalybuka Move registration in function scope static variable
2019-08-31 vitalybuka Replace Custom mutations with mutation post processing
2019-09-05 vitalybuka Update README.md
2019-08-31 vitalybuka Remove static members from Mutator
2019-08-30 vitalybuka Use Mutator as singleton
2019-08-31 vitalybuka Move random number generator inside of Mutator.
2019-08-12 aaskar Add Travis and oss-fuzz badges to README
2019-04-29 31459023+hctim More dependencies!
2019-07-29 vitalybuka Remove trailing spaces
2019-07-29 vitalybuka Update protobuf
2019-07-29 vitalybuka Move no_mutator_test.cc
2019-07-29 vitalybuka Initialize fields of map entries
2019-07-29 vitalybuka Convert more tests into TYPED_TEST
2019-07-29 vitalybuka Fix no_mutator_test build for "check"
2019-06-08 toshi.piazza Renames SANITIZER_INTERFACE_WEAK_DEF to LIB_PROTO_MUTATOR_WEAK_DEF
2019-06-07 topiazza Introduced SANITIZER_INTERFACE_WEAK_DEF
2019-06-01 topiazza Builds tests with MSVC
2019-05-29 topiazza Updates CMakeLists.txt to build for MSVC
2019-04-29 31459023+hctim Add a line break.
2019-04-29 31459023+hctim Add proto dependencies to prerequisites.
2019-04-17 spq Fix compile error/warning in src/field_instance.h (was comparison with unsigned < 0, which is always false)
2019-02-04 vitalybuka Remove workaround for stack overflow
2019-02-04 vitalybuka Update protocolbuffers
2019-01-31 vitalybuka Add check to avoid stack overflow parsing nested messages
2019-01-30 kcc replace std::mt19937 with a much faster std::minstd_rand
2019-01-31 vitalybuka Speedup unit tests
2019-01-29 konstantin.s.serebryany Update README.md

Created with:
  roll-dep src/third_party/libprotobuf-mutator/src

Change-Id: Ie0169814c587b00fa1a25239fe0f8d338634b7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427157Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810428}

Bug: 779414
Change-Id: I8e7597877f68be4a88595b9b055e26b4c0b25e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422817
Commit-Queue: Elaine Chien <elainec@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810427}

- Display: none objects should not get an accessible name.
- EnsureComputedStyle() should not be called during a potentially unsafe
  time. This is fixed by calling it during Init(), in cases where it
  will likely be needed (inside a display:none subtree).
- Remove unnecessary and often incorrect heuristic for determining when
  inside an aria-labelledby or aria-describedy calculation. This flag is
  already passed in via recursion when following that kind of relation.
- Do not recurse into children that are explicitly hidden
- Improve explicitly hidden computation for CSS visibility. Explicitly
  hidden means that the element was specifically hidden, and that it
  didn't just inherit the fact that it's hidden.
- Improve results in name-calc-visibility, where an element explicitly
  referenced by aria-labelledby wasn't included in the name because it
  was visibility:hidden element. Elements that are explicitly referenced
  must be included in a name or description even if they are hidden.

Bug: 1130436
Change-Id: I58b7b70b53c5c1d37ec1407bc2ecb35de3d17d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212795Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810426}

New language settings for Chrome OS is looking at removing this option
because it seems confusing to users. Adding metrics to measure usage.

Mock: http://go/cros-lang-settings-ux-slide#slide=11

Bug: 1113439
Change-Id: I206212e5f09e90893bb40a41adcb6b3e8f0a8ea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423656Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810425}

This is a reland of 821323c7

This reland disables BFCache for the previously failing task so that
the test always gets a spare renderer. See
http://shortn/_gKtHBOaX5w

Original change's description:
> Add Render Process for Site Instance Assignment to content API
>
> This CL adds an enum, SiteInstanceProcessAssignment, which
> describes all the ways a SiteInstance may be assigned a render
> process. This is exposed in the content API to allow embedders to
> record this usage.
>
> See design doc in bug and/or chained CL for more info.
>
> Bug: 1129505
> Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809620}

Bug: 1129505
Change-Id: I9d78c7afd6219499fedf84094954aa6308435f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426253
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810424}

This class will own pinned_files_container and recent_files_container.
It will also be responsible for setting the max size for the pinned
files container based on available screen space and update it when
screen space changes.

Bug: 1131268
Change-Id: If09810570e59f7beeac0667e84d4cd558ee67bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427081
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810423}

The layout test
third_party/blink/web_tests/http/tests/devtools/sources/
debugger-breakpoints/
restore-locations-for-breakpoint-with-broken-source-map.js

Uses a source map URL and expects to intercept the source map load
to arrive at ResourceLoader.load, which it intercepts. This CL changes
the source map URL to a data URL, as an upcoming devtools front-end
CL will handle http and https scheme source maps differently and
bypass ResourceLoader.load.

TBR=caseq@chromium.org

Bug: chromium:1069378
Change-Id: I5c90d9f8ce8be98b774e5fd4795d37b05fa3fcad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429345Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810422}

Delayed expiration and updated owner for:

- Platform.Thermal.Temperature.Cpu.0
- Platform.Thermal.Zone.Cpu.States

Marked as obsolete:

- Platform.Thermal.Temperature.Wifi0
- Platform.Thermal.Temperature.Wifi1
- Platform.Thermal.Temperature.Wifi2
- Platform.Thermal.Zone.Wifi0.States
- Platform.Thermal.Zone.Wifi1.States
- Platform.Thermal.Zone.Wifi2.States

Bug: 1089286, 1089287, 1089288, 1089289, 1089290

Change-Id: I24a015554dc37217a7d6cc9c14b0b541895d1e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422469Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810421}

Bug: 1128669
Change-Id: Iacf9b66c1966bceaaa585a5ae4d69adb5a4dfe00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427039Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810420}

There's an ongoing effort to reduce the number of dependencies on
ChromeActivity. As part of this effort, clients that use ChromeActivity
as a dependency provider are being transitioned to taking their
dependencies directly through the constructor.

Bug: 1123209
Change-Id: Ic6e55b46917e624e716c4bc1248a540a9076d6e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411275Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810419}

The Histogram for SurfaceEmbeddingTime is being marked obsolete. It has
been supplanted by Graphics.Smoothness.* metrics for on going monitoring.

The trace events which were added to supplement the metric are still
very useful for debugging and will remain.

LocalSurfaceIdAllocation was used to pipe the allocation time along with
the LocalSurfaceId that was needed for the actual Surface Sync. This
change also removes that, leading to a mechanical refactor of classes to
use just LocalSurfaceId directly.

TBR=boliu@chromium.org
TBR=dalecurtis@chromium.org
TBR=dcheng@chromium.org
TBR=dgozman@chromium.org
TBR=guidou@chromium.org
TBR=mbarbella@chromium.org
TBR=oshima@chromium.org
TBR=seantopping@chromium.org
TBR=sky@chromium.org
TBR=yfriedman@chromium.org

Bug: 1000081
Change-Id: Ibe9a85d63b534c55548a109ea746764d8c66f2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415128Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810418}

Roll Chrome Linux PGO profile from chrome-linux-master-1600948720-175990bf7d350cbec3f87177d4fba26f3b99d541.profdata to chrome-linux-master-1600970122-55543164fcb4253994646347c53b84b49193c16a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: Ib1006dc8179944ae698e3ea7f02e73b885161532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429654Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810417}

Roll Chrome Win64 PGO profile from chrome-win64-master-1600861496-1af5dbbac81d989efc59c83c56068ac6e2862c09.profdata to chrome-win64-master-1600981042-72ca27b946abaa6539d1e0700f216205b0fe946d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org
Change-Id: I197a2960847f608ba056e16240b25a0ce883a9fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810416}

BUG=1120713

Change-Id: I92355ee0dc736581262de2fb0352a69c4ad73d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380933Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810415}

Change-Id: I719d6545f0ed2fc9bae19fa36cf99c1dd4308562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429932
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#810414}

This CL creates a core/ directory for observers that capture top-level
page load metrics, including CoreWebVitals metrics, in both
chrome/browser as well as components/. The OWNERs of these files are now
a subset of the previous owners. CorePageLoadMetricsObserver is renamed
to UmaPageLoadMetricsObserver.

Bug: None
Change-Id: Ieb5f1156bf48f8f1527ca0c8719af1de0865d5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419125
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810413}

Change-Id: I6a4047aa1bfc15c96970b8c868c42f4ce4ecf30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429250
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810412}

This effectively reverts https://crrev.com/799772 by removing all page
pausing code from PrintRenderFrameHelper, and restores the deleted
pausing code in blink::ChromeClient. It is not a straight revert to
preserve some of the code that will be useful in the next attempt to
properly implement pausing.

While this revert is obviously incorrect from the web spec perspective,
it improves the overall browser behavior. As is, there are limitations
to the granularity at which Blink can perform pauses. In a renderer
process, when one page pauses, the entire process pauses. This means if
one tab is performing a print preview, then a second tab that shares the
same renderer process is paused. In the paused state, the second tab
cannot navigate, and users, especially power users that multi-task, will
find this behavior to be buggy.

Bug: 956832,1122964
Change-Id: Ia71fa218aa07625ca530e154256ca5a92381a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428623Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810411}

We originally gathered these to decide how to prioritize some a11y
work, but since that work is now done, they are no longer needed.

Bug: 1130629
Change-Id: I52eb229504bdfb988d9fc6f5866de60d06c1f048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424765
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810410}

Signed-off-by: Shannon Chen <shannc@chromium.org>
Change-Id: I9fa066750a8e1e632eee4395d859aef4898319c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424627Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Shannon Chen <shannc@google.com>
Cr-Commit-Position: refs/heads/master@{#810409}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I270216ca36fc83d59b80daea62c7739671789a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810408}

This change refactors this test by:
1) Splitting out the library & bytecode-snarfing logic to a helper
   function
2) Deduplicating some code that existed on each platform, via use of
   a couple of typedefs
3) Has the test not hang onto the shared library if one of the gtest
   asserts fail - I don't think this is a problem in practice, but.

Bug: None
Change-Id: Iea33973b141de7cb5fe1aaeae5eb1d6773d31c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414684Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810407}

After a crash info bar will be presented on all foreground scenes
if the user choose to restore all foreground windows will be restored.
if not all windows tabs for all windows which were opened on the last
run will be added to the recent closed tabs.

Bug: 1126311, 1114179
Change-Id: I80623012dc132e2702004d2dbc0bbcb410a7d91c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415929
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810406}

Add a finalized string for the scanner dropdown label and implement i18n
for strings.

Bug: 1059779
Change-Id: Ia216da7e9c9fc5a6b8928aa02e0889ade65acdad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429227Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810405}

This was an oversight in
https://chromium-review.googlesource.com/c/chromium/src/+/2425459

Bug: 1127055
Change-Id: If3fb89f024972f338cd81b16a1885af053aa594e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429523Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810404}