GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aa133ed09624..9708a7d8f867

git log aa133ed09624..9708a7d8f867 --date=short --no-merges --format='%ad %ae %s'
2019-11-18 vidorteg@microsoft.com Verifying that the tab exists in TabbedEditorcontainer tab map before consuming it.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@9708a7d8f867

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=v8-waterfall-sheriff@grotations.appspotmail.com

Bug: None
Change-Id: Ib526fea05f8cd2a814c09eecb405ee324572ecaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922344Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716396}

After resizing screen, clicking bookmarks do not move to the target
site. It is caused by that application misregards the device as a
tablet while the view is still in mobile mode.

Bug: 1013516
Change-Id: I40dfc49ede96a9f38f4e6b453cf97f3ac5561602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919350Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#716395}

Now in ShelfContainerView::ChildPreferredSizeChanged, layout is
updated implicitly by calling PreferredSizeChanged(). However, due
to the CL (https://crrev.com/c/1876128), when the parent view calls
ChildPreferredSizeChanged(), the child view is not labeled as
|needs_layout_|. As a result, ShelfContainerView's layout may fail to
update after calling PreferredSizeChanged(). To solve this issue,
ShelfContainerView's layout is invalidated explicitly.

Bug: 1025567
Change-Id: Iee6c8cbebd038b78ae229a0f28d1f08924a68fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921340Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716394}

R=zmo@chromium.org

Bug: 10253933
Change-Id: I5f69fe6240c9b5b4d91827822bb81466a316f20d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922434
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716393}

base::Hash() is deprecated and is being replaced by base::FastHash().
Existing uses are replaced with base::FastHash(), if appropriate, or
base::PersistentHash() if output stability is required.

Bug: 1025358
Change-Id: Id1f8b8c4dbbeb248c5c9725a0107506e35fbd771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919820Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716392}

This is just to reflect the spec update.

TEST=See matching strings on screen
BUG=chromium:893332

Change-Id: Ibb4ec0f3d398cf8e1e0cf841c5045139a2e0a975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922747Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716391}

The transient input source for canvas input only supports a single
input source, but was reacting to pointer events for non-primary
inputs such as additional fingers on a multitouch screen.

While this was mostly harmless due to separate logic in XRInputSource
ensuring that the selectstart/selectend events don't overlap
unexpectedly, it could still result in the resulting touch points
jumping arbitrarily between the finger positions.

Fix this by ignoring pointer events if they aren't marked isPrimary.

Change-Id: I289af2040b3614937161193766bef7ca4b91e209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922332Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716390}

This reverts commit bd07dee9.

Reason for revert: Fails color-layer test on Mac10.10:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48789

Original change's description:
> [CompositeAfterPaint] Remove internals.elementLayerTreeAsText()
> 
> The layer tree mode is not supported in CompositedAfterPaint.
> Remove it and rewrite the tests so that the tests will pass in
> CompositeAfterPaint.
> 
> Change-Id: Ided24dc50b6804397777fec8fbce45d8d6cb3174
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918295
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716300}

TBR=kenrb@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I5a8667762698a7879975510df28578558c29295e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923208Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716389}

WebAppInstallTask::web_contents_ didn't have InstallableManager attached.

Full installation (InstallWebAppFromManifestWithFallback) was DCHECKing on
this. Let's unify all WebContents creation for all cases in
CreateWebContents static factory method.

Drive-by: Implement MaybeInstallAppsInSyncInstall to retry installation
attempts on Chrome restart (after crash, for example).

This code is disabled by default behind kDesktopPWAsWithoutExtensions and
kDesktopPWAsUSS base features.

Bug: 860583
Change-Id: Ieaa5426a8acaacfe9c6775bf669e022955892d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918912Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716388}

While the stack trace in the crash report says
ShelfController::OnDisplayConfigurationChanged, the crash is actually in
ShelfController::OnWindowTreeHostsSwappedDisplays. The inaccuracy of the
stack trace is because of Identical COMDAT Folding, as explained in [1]
under the heading "I Comprehend Further." The present CL fixes the crash
by removing ShelfController::OnWindowTreeHostsSwappedDisplays, along
with ShelfController::OnWindowTreeHostReusedForDisplay, as they are both
redundant with ShelfController::OnDisplayConfigurationChanged anyway.

[1] https://randomascii.wordpress.com/2017/12/10/analyzing-a-confusing-crash/

Test: ash_unittests ShelfControllerPrefsTest.ShelfSettingsValidAfterDisplaySwapWhileLoggedIn
Fixed: 1022852
Change-Id: I95d9a0bdd24db4c462983043466d70caefa223d3
Bug: 1022852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922596
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716387}

D3D11VideoDecoder::DoDecode checks |current_buffer_| to see if
there's a buffer being decoded.  If so, it assumes that there is
a callback for it.  Unfortunately, in some cases, this is wrong,
and it crashes.

NotifyError clears the callback without clearing |current_buffer_|,
and nothing else seems to.

This CL clears |current_buffer_| in NotifyError, to see if that's
the path by which the callback and the buffer are out of sync.

Bug: 1012464
Change-Id: I5d62ce07490de81bb1bfec7fa68a515efc416c11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922459
Commit-Queue: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Auto-Submit: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716386}

Bug: 1007657
Change-Id: I63e151cc22ca2db63e44329cce78eebce769f082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917755
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716385}

https://chromium.googlesource.com/catapult.git/+log/991721505aa9..437131108da3

git log 991721505aa9..437131108da3 --date=short --no-merges --format='%ad %ae %s'
2019-11-18 eroman@chromium.org Switch NetLog Viewer's appengine runtime from Go 1.9 to Python3.

Created with:
  gclient setdep -r src/third_party/catapult@437131108da3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:1006879
Change-Id: Ic8f1eb891e29e15446c352b1330bed616c06c14c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922343Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716384}

Bug:978745, b/142269595

Change-Id: Ife7bad8616f39d2eec1d9ca97a7992197a9abe49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918086Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716383}

This hook is mostly used by the bots, and since all of our bots are now
recycled continuously, there should be no need to clobber the cache at
every build. This will save a couple min per build, as well as a couple
GB of bandwidth per build.

R=dpranke, jbudorick

Bug: None
Change-Id: I9c46184566de3defb2456b6261ff9505b6a4872c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920476Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716382}

Replace remaining instances of "erase" with "delete" for consistency
throughout the security key settings UI.

Also add a general IDS_SETTINGS_DELETE string and replace other
equivalent definitions.

Fixed: 1008903
Change-Id: I38412ee865a9ad547be5d4bf9e5d18935fd2c616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918165
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#716381}

Previously, showing saved passwords domains in password
protection modal warning dialog was a feature
flag but because they will be in two different releases, it
will be more clearcut having two experiments. This is also
the recommendation from the metrics team. Also, create
field trial tests for saved password and saved password
with domains for password protection.

Bug: 1026006
Change-Id: Iec740c0140e3ad94a68b268407305ef84e4b21f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915181
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716380}

This is a reland of fc5589ac

Race conditions and flakes in the tests have been fixed.
AccessibilityBridge.TestNavigation has been added.

Original change's description:
> [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager
>
> This change adds functionality to the Accessibility Bridge:
> * Listens for change in AccessibilityMode from Fuchsia
> * Gets the semantic tree from Chrome accessibility and sends it to the
> SemanticsManager
> * Sends live updates when nodes are added, updated or removed
>
> To send updates, this change includes the following:
> * Creates a ViewRefPair and registers it with the SemanticsManager
> * Initialize an AccessibilityBridge
> * Listen for changes in the Chrome Accessibility tree, serializes them
> to Fuchsia data structures and sends that data to the Fuchsia
> SemanticsManager
>
> Testing: Added AccessibilityBridge browsertests.
>
> Bug: 973095
> Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171
> Commit-Queue: Sharon Yang <yangsharon@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714588}

Bug: 973095
Change-Id: I920435c123b66dbe2172ce7fe164d64ba679321b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916961
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716379}

This extends the expiration date of several flags still relevant to
sandbox and scheduler configurations.

Bug: 1025993
Change-Id: I43866b5424d326fef1487e0881f1a4f0c77f1477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922547
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716378}

Test: see the warning indicator at login screen
Bug: chromium:893332
Change-Id: Ia34fb90163efc22015255473e468e52a50ac42e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919788
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716377}

These seem to be leftovers from recent code movings among DWTHX11 =>
DWTH{Linux,Platform}.

Bug: None
Change-Id: I02ed92616b92ffea1b5cb14333b3e012d3f73534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919600
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716376}

Update ETW manifest usage so chrome.dll can be used to register the ETW
provider. Prior to this a DummyChrome.dll was needed which registered
the ETW provider used by Chrome. The chrome_events_win.man file was
updated to be a general application manifest containing a
instrumentation section.  The chrome_events_winTEMP.BIN and
MSG00001.bin files are auto-generated by the manifest compiler.

chrome.dll size (release x64)
Before: 122,627,584
After:  122,629,120
Total Increase: 1536 bytes

BUG: 1024949

Change-Id: Ibb3783da20a35a5caeabab93bd2da10a2cf67faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896040Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716375}

The separate observer has a couple of advantages.

Firstly, it allows waiting and access to occur after the
content::Portal (and its interceptor) may have been destroyed.
Instead, it's valid as long as the Portal is valid when the
observer is created.

Secondly, it allows examination of the activate result.

Since there are existing tests which rely on the ability to
observe activation immediately after a portal is created or
adopted (ideally we would more explicitly sequence these events
in the test, but this is not always possible), the created
observer is augmented with the ability to run a callback
immediately (rather than after the run loop quits, which is
subtle due to other work in the same task and nested run loops).
This is used to create a PortalActivatedObserver immediately
when the Portal is created, before the browser UI thread can
process any task which might either activate or destroy the Portal.

This mostly makes PortalInterceptorForTesting an implementation
detail of the more specific observers.

Change-Id: I6ee3bd8e847235654cc4a063659818e2e970c2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900258
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716374}

- compositing/3d-cube.html is modified to a pixel test instead of a
  ref test because there seems no way to make the ref test pass. The
  new pixel result is platform independent.

- compositing/video/video-controls-layer-creation-squashing.html is
  modified from a ref test to a text test because what we care about
  is how we composite the layers.

- paint/invalidation/compositing/*-float-under-*-inline.html are updated to
  expect the new LayoutNG result. They are now expected to fail with
  LayoutNG disabled.

- Other rebaselines.

Change-Id: Ieeb195dfeea6b8478cf90b77f03a0a84984f6281
Bug: 726075, 591099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915459Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716373}

Implements browser tests to verify that startup profiles taken in the
browser and child processes are received by the metrics provider.

To work within the test timeouts and to avoid non-determinism this
requires a couple adaptations to be made to the code when run under
these tests. The profiling period is reduced from 30 seconds to one
second, and profiles are taken in all renderer processes. The behavior
is enabled by providing a 'browser-test' argument to the existing
'start-stack-profiler' switch.

The main thread profiler for browser tests is moved later, after the
command line is set up, to be able to observe the added switch
argument. StackSamplingConfiguration is made responsible for the
sampling parameters, reusing the GetSamplingParamsForCurrentProcess()
function which was previously unused.



Bug: 1011877
Change-Id: Ibad55178ebd3ff5ea497971868c9619210c2c8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900262
Commit-Queue: Mike Wittman <wittman@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716372}

AppServiceAppModelBuilder is used to replace InternalAppModelBuilder.
AppService integration to ui/app_list has been enabled for a couple
of months, so it should be safe to remove InternalAppModelBuilder.

Unit tests are updated to use AppServiceAppModelBuilder. I will use a
separate CL to move the internal_app_model_builder_unittest.cc to
src/chrome/browser/ui/app_list/app_service/, and convert it to
AppService unit tests. This CL still uses
internal_app_model_builder_unittest.cc, as it is more clear to show
the change.

BUG=1016159

Change-Id: I2d537aa940eae29201dd64bb7b345d3ae820d777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919534Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716371}

Flaky timeout occurs on linux and mac10.10 for
testIFrameWithExtensionsSource, and on mac10.10 for
testNoSuchElementExceptionMessage.

BUG=1026018
TBR=jbudorick@chromium.org

Change-Id: Ib91536f5ab2f81262a9ae913ceaf6944b0b98283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922647Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716370}

Previously, we filtered out low reputation sites from
the modal warnings shown for phished svaed passwords.
However, low reputation and phished sites should be both
shown as warnings.

Bug: 1026000
Change-Id: I425198650c387bdccbb72769c45d054f91075e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921654Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716369}

https://skia.googlesource.com/skia.git/+log/39da10b5563f..ff2f380fd37a

git log 39da10b5563f..ff2f380fd37a --date=short --no-merges --format='%ad %ae %s'
2019-11-18 robertphillips@google.com Only access the scissorState's rect when it is valid
2019-11-18 brianosman@google.com Remove some SK_API from src/
2019-11-18 halcanary@google.com DEPS: add third_party/externals/libgifcodec
2019-11-18 halcanary@google.com GN tool: copy_git_directory.py script
2019-11-18 michaelludwig@google.com Make TessellationHelper resettable

Created with:
  gclient setdep -r src/third_party/skia@ff2f380fd37a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@google.com

Bug: None
Change-Id: I0e5733b3bd23c21874e02dcb3af03fef9f21e602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716368}

Fixes a highlight bug in the narrow panel of the expanded old
Bar layout.

Now we adjust the x touchpoint offset by the position of the
narrow panel in the tab.

BUG=1025905

Change-Id: I2adf0ddf72283454bc711ae4cfb4d3975fc92351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921346
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716367}

Change-Id: I813d1797761da3d52369484f211695bc22af0dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914589
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716366}

1. Update related comments.
2. Rename the local variable which may assign to this Vector.

Bug: 1006173
Change-Id: I5ff5c6b3c9e6b10504fe988480df879209be5f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921927Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716365}

This CL adds
1 - Fixes default favicon to show the globe icon
2 - Fixes vertical alignment of favicon
3 - Adds the close button back
4 - Makes open_in_new_tab button visible only when in full state

Bug: 1025085, 1025084, 1025088, 1023659
Change-Id: I2dff5b9949fb33dba4c0b6f009ca5ee92503d8d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918646
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716364}

Terminal System App is not able to access chrome.storage.sync
so we will provide terminalPrivate functions to store
settings as a syncable pref.

Bug: 1019021
Bug: 1022250
Change-Id: I54e089f1a07f520eaf3747ac405a56e883ba1908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921016Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716363}

This patch aligns the following methods with the spec:
    playbackRate
    setPlaybackRate
    updatePlaybackRate
    EffectivePlaybackRate
    reverse

https://drafts.csswg.org/web-animations/#reversing-an-animation-section

Per spec, we no longer reset the start time when a new pending time is
required. The variable playback_rate_ now reflects the rate currently
in effect, rather than the rate that will be in effect once the animation
is ready.

Bug: 960944
Change-Id: I65dd99515462e0041b43ff208bc523f6b2920563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895372
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716362}

Bug: 978745, b/142269595
Change-Id: I6b16514985602f3e8463d2934ae5bb767a0f9af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922590Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716361}

This is a reland of 71d76ec9 with two changes:

* Disable the unit test on Windows 7, which does not support nested jobs.
* Remove a bogus NOTREACHED that was causing the child process to die too
  early. On the CQ bots it happened to die just before we called TerminateProcess
  anyway so this didn't cause failures there.

Original change's description:
> Kill the software_reporter_tool process if the browser exits early
>
> Assign the software_reporter_tool process to a job object with the
> KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed
> if it's still running when the browser exits.
>
> R=proberge
>
> Bug: 1016939
> Change-Id: I87dfc907cc853add1721f80c589051896ed4e857
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106
> Commit-Queue: Joe Mason <joenotcharles@chromium.org>
> Reviewed-by: proberge <proberge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715997}

R=proberge

Bug: 1016939
Change-Id: I633ebe5f87ab694e4c48a3097bda7c13d0ad4ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922474Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716360}

ExtraRequestCompleteInfo relies only on origin-related parts of the url.
This means that we can replace the |GURL url| field with
|url::Origin origin_of_final_url|.  This helps sanitize the URL in the
future (possibly removing the path and/or query parts in some cases).

Bug: 973885
Change-Id: Iac54c27a5f8d3b1d80463f0092d31324cc928fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894153
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716359}

Bug: 
Change-Id: Ic4c8a01624c33202feccc4c24932ebf449dcd488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922411
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716358}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f6ea6efa9de..665be402b23d


Created with:
  gclient setdep -r src-internal@665be402b23d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ia17c50b70829865608c8420e83ef70ca59b578ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922409Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716357}